From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 13 Oct 2015 07:08:18 +0000 (+0300)
Subject: ASoC: wm8904: harmless underflow in wm8904_put_deemph()
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=931dfa6931448ccfd12d4ccd8d1d9289ceb92439;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git

ASoC: wm8904: harmless underflow in wm8904_put_deemph()

We try to check that "deemph" is zero or one, but because of an
underflow bug, it can also be negative.  It's fine, negative values are
handled as non-zero.  But it's messy and static checkers complain so
let's fix it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index b783743dc97e..2aa23f1b9e3c 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -534,7 +534,7 @@ static int wm8904_put_deemph(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
-	int deemph = ucontrol->value.integer.value[0];
+	unsigned int deemph = ucontrol->value.integer.value[0];
 
 	if (deemph > 1)
 		return -EINVAL;