From: Simon Pilgrim <llvm-dev@redking.me.uk>
Date: Thu, 4 Jul 2019 09:46:06 +0000 (+0000)
Subject: Fix MSVC "not all control paths return a value" warnings. NFCI.
X-Git-Tag: android-x86-9.0-r1~840
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=948545f15ea4e730b3dcfe31dc865634d760c608;p=android-x86%2Fexternal-llvm.git

Fix MSVC "not all control paths return a value" warnings. NFCI.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@365119 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Remarks/RemarkParser.cpp b/lib/Remarks/RemarkParser.cpp
index 3af293a98b9..bd83ba488d8 100644
--- a/lib/Remarks/RemarkParser.cpp
+++ b/lib/Remarks/RemarkParser.cpp
@@ -25,9 +25,8 @@ static std::unique_ptr<ParserImpl> formatToParserImpl(ParserFormat Format,
   switch (Format) {
   case ParserFormat::YAML:
     return llvm::make_unique<YAMLParserImpl>(Buf);
-  default:
-    llvm_unreachable("Unknown format encountered!");
   };
+  llvm_unreachable("Unhandled llvm::remarks::ParserFormat enum");
 }
 
 static std::unique_ptr<ParserImpl>
@@ -36,9 +35,8 @@ formatToParserImpl(ParserFormat Format, StringRef Buf,
   switch (Format) {
   case ParserFormat::YAML:
     return llvm::make_unique<YAMLParserImpl>(Buf, &StrTab);
-  default:
-    llvm_unreachable("Unknown format encountered!");
   };
+  llvm_unreachable("Unhandled llvm::remarks::ParserFormat enum");
 }
 
 Parser::Parser(ParserFormat Format, StringRef Buf)