From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 22 Nov 2011 08:46:03 +0000 (+0100)
Subject: vl: Tighten parsing of -m argument
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=961b42b9dc858936f32effc3f47c76b1c4e7de56;p=qmiga%2Fqemu.git

vl: Tighten parsing of -m argument

strtosz_suffix() fails unless the size is followed by 0, whitespace or
','.  Useless here, because we need to fail for any junk following the
size, even if it starts with whitespace or ','.  Check manually.
Things like "-m 1024," are now caught.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/vl.c b/vl.c
index b9146cfdea..a50842bb76 100644
--- a/vl.c
+++ b/vl.c
@@ -2535,9 +2535,10 @@ int main(int argc, char **argv, char **envp)
                 break;
             case QEMU_OPTION_m: {
                 int64_t value;
+                char *end;
 
-                value = strtosz(optarg, NULL);
-                if (value < 0) {
+                value = strtosz(optarg, &end);
+                if (value < 0 || *end) {
                     fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
                     exit(1);
                 }