From: sdottaka Date: Sun, 21 Apr 2013 13:27:30 +0000 (+0900) Subject: Cppcheck: Member variable * is not initialized in the constructor. X-Git-Tag: 2.16.4+-jp-10~1100 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=a89981729474aac5a33bd111397fa48781146062;p=winmerge-jp%2Fwinmerge-jp.git Cppcheck: Member variable * is not initialized in the constructor. --- diff --git a/Src/Common/Picture.cpp b/Src/Common/Picture.cpp index fadc5f767..81bedc78b 100644 --- a/Src/Common/Picture.cpp +++ b/Src/Common/Picture.cpp @@ -19,7 +19,7 @@ static char THIS_FILE[] = __FILE__; // CPicture implementation // -CPicture::CPicture() +CPicture::CPicture() : m_hr(S_OK) { } diff --git a/Src/CompareEngines/DiffUtils.cpp b/Src/CompareEngines/DiffUtils.cpp index 09fce5060..70d31aed1 100644 --- a/Src/CompareEngines/DiffUtils.cpp +++ b/Src/CompareEngines/DiffUtils.cpp @@ -36,6 +36,9 @@ DiffUtils::DiffUtils() , m_inf(NULL) , m_FilterCommentsManager(new ::FilterCommentsManager) , m_pDiffWrapper(new ::CDiffWrapper) + , m_ndiffs(0) + , m_ntrivialdiffs(0) + , m_codepage(0) { } diff --git a/Src/Merge.cpp b/Src/Merge.cpp index db001c49d..e19efc604 100644 --- a/Src/Merge.cpp +++ b/Src/Merge.cpp @@ -181,6 +181,7 @@ struct ArgSetting CMergeApp::CMergeApp() : m_bNeedIdleTimer(FALSE) +, m_pOpenTemplate(0) , m_pDiffTemplate(0) , m_pHexMergeTemplate(0) , m_pDirTemplate(0) diff --git a/Src/OpenView.cpp b/Src/OpenView.cpp index db48413f9..96e39c4b4 100644 --- a/Src/OpenView.cpp +++ b/Src/OpenView.cpp @@ -102,7 +102,7 @@ COpenView::COpenView() , m_pUpdateButtonStatusThread(NULL) , m_bRecurse(FALSE) { - // TODO: add construction code here + memset(m_dwFlags, 0, sizeof(m_dwFlags)); } COpenView::~COpenView() diff --git a/Src/OpenView.h b/Src/OpenView.h index 6b1bf0c73..e22b3ceaf 100644 --- a/Src/OpenView.h +++ b/Src/OpenView.h @@ -73,7 +73,6 @@ public: /// unpacker info DWORD m_dwFlags[3]; PackingInfo m_infoHandler; - BOOL m_bOverwriteRecursive; /**< If TRUE overwrite last used value of recursive */ // Attributes public: diff --git a/Src/PatchTool.cpp b/Src/PatchTool.cpp index e591ecb7a..7f0ad97f9 100644 --- a/Src/PatchTool.cpp +++ b/Src/PatchTool.cpp @@ -39,7 +39,7 @@ static char THIS_FILE[] = __FILE__; /** * @brief Default constructor. */ -CPatchTool::CPatchTool() +CPatchTool::CPatchTool() : m_bOpenToEditor(FALSE) { } diff --git a/Src/Plugins.h b/Src/Plugins.h index e88393b43..f9f7795fc 100644 --- a/Src/Plugins.h +++ b/Src/Plugins.h @@ -44,7 +44,7 @@ class PluginInfo { public: PluginInfo() - : m_lpDispatch(NULL), m_filters(NULL) + : m_lpDispatch(NULL), m_filters(NULL), m_bAutomatic(FALSE), m_nFreeFunctions(0) { }; /// Parse the filter string (only for files), and create the filters diff --git a/Src/ProjectFilePathsDlg.cpp b/Src/ProjectFilePathsDlg.cpp index 94cec5864..21b04617d 100644 --- a/Src/ProjectFilePathsDlg.cpp +++ b/Src/ProjectFilePathsDlg.cpp @@ -30,6 +30,7 @@ IMPLEMENT_DYNCREATE(ProjectFilePathsDlg, CPropertyPage) ProjectFilePathsDlg::ProjectFilePathsDlg() : CPropertyPage(ProjectFilePathsDlg::IDD) , m_bLeftPathReadOnly(FALSE) , m_bRightPathReadOnly(FALSE) +, m_bIncludeSubfolders(FALSE) { //{{AFX_DATA_INIT(ProjectFilePathsDlg) //}}AFX_DATA_INIT