From: Axel Lin Date: Mon, 22 Feb 2016 07:24:54 +0000 (+0800) Subject: gpio: mpc8xxx: Slightly update the code for better readability X-Git-Tag: android-x86-7.1-r1~1881^2~11 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=adf32eaa05323449b74b36f25b918583e2bdb6f1;p=android-x86%2Fkernel.git gpio: mpc8xxx: Slightly update the code for better readability Setting gc->direction_output to gc->direction_output looks strange. I think this change makes the intention more clear. Signed-off-by: Axel Lin Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index bc042ad62cfb..425501c39527 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -339,8 +339,11 @@ static int mpc8xxx_probe(struct platform_device *pdev) */ mpc8xxx_irq_chip.irq_set_type = devtype->irq_set_type; - gc->direction_output = devtype->gpio_dir_out ?: gc->direction_output; - gc->get = devtype->gpio_get ?: gc->get; + if (devtype->gpio_dir_out) + gc->direction_output = devtype->gpio_dir_out; + if (devtype->gpio_get) + gc->get = devtype->gpio_get; + gc->to_irq = mpc8xxx_gpio_to_irq; ret = gpiochip_add_data(gc, mpc8xxx_gc);