From: Samuel Pitoiset Date: Mon, 25 Feb 2019 14:28:25 +0000 (+0100) Subject: radv: don't copy buffer descriptors list for samplers X-Git-Tag: android-x86-8.1-r2^2~67 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=b79bac03c4926fc155752f50febeb60c5b668f60;p=android-x86%2Fexternal-mesa.git radv: don't copy buffer descriptors list for samplers Sampler descriptors don't have a buffer list. This fixes some crashes with new CTS dEQP-VK.binding_model.descriptor_copy.*.sampler_*. Cc: 18.3 19.0 Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen (cherry picked from commit 4924dfc851e52c383380ae56be4d8606684ead7c) --- diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index bc0ff5c7e16..7f7d6827ed3 100644 --- a/src/amd/vulkan/radv_descriptor_set.c +++ b/src/amd/vulkan/radv_descriptor_set.c @@ -965,7 +965,11 @@ void radv_update_descriptor_sets( } src_ptr += src_binding_layout->size / 4; dst_ptr += dst_binding_layout->size / 4; - dst_buffer_list[j] = src_buffer_list[j]; + + if (src_binding_layout->type != VK_DESCRIPTOR_TYPE_SAMPLER) { + /* Sampler descriptors don't have a buffer list. */ + dst_buffer_list[j] = src_buffer_list[j]; + } } } }