From: Johannes Doerfert <jdoerfert@anl.gov>
Date: Fri, 14 Jun 2019 14:53:41 +0000 (+0000)
Subject: [Attributor] Disable the Attributor by default and fix a comment
X-Git-Tag: android-x86-9.0-r1~1908
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=b8b2e16c536fb66ad0fcccbc0fc9684ee5795bc1;p=android-x86%2Fexternal-llvm.git

[Attributor] Disable the Attributor by default and fix a comment

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@363408 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/llvm/Transforms/IPO/Attributor.h b/include/llvm/Transforms/IPO/Attributor.h
index eee224b3a1b..f2d9c3486c7 100644
--- a/include/llvm/Transforms/IPO/Attributor.h
+++ b/include/llvm/Transforms/IPO/Attributor.h
@@ -97,7 +97,6 @@
 #ifndef LLVM_TRANSFORMS_IPO_ATTRIBUTOR_H
 #define LLVM_TRANSFORMS_IPO_ATTRIBUTOR_H
 
-#include "llvm/Analysis/CGSCCPassManager.h"
 #include "llvm/Analysis/LazyCallGraph.h"
 #include "llvm/IR/CallSite.h"
 #include "llvm/IR/PassManager.h"
@@ -483,8 +482,7 @@ struct BooleanState : public IntegerState {
 /// NOTE: If the state obtained via getState() is INVALID, thus if
 ///       AbstractAttribute::getState().isValidState() returns false, no
 ///       information provided by the methods of this class should be used.
-/// NOTE: The Attributor currently runs as a call graph SCC pass. Partially to
-///       this *current* choice there are certain limitations to what we can do.
+/// NOTE: The Attributor currently has certain limitations to what we can do.
 ///       As a general rule of thumb, "concrete" abstract attributes should *for
 ///       now* only perform "backward" information propagation. That means
 ///       optimistic information obtained through abstract attributes should
diff --git a/lib/Transforms/IPO/Attributor.cpp b/lib/Transforms/IPO/Attributor.cpp
index 9adf5e702d8..0915a990499 100644
--- a/lib/Transforms/IPO/Attributor.cpp
+++ b/lib/Transforms/IPO/Attributor.cpp
@@ -59,7 +59,7 @@ static cl::opt<unsigned>
 static cl::opt<bool> DisableAttributor(
     "attributor-disable", cl::Hidden,
     cl::desc("Disable the attributor inter-procedural deduction pass."),
-    cl::init(false));
+    cl::init(true));
 
 static cl::opt<bool> VerifyAttributor(
     "attributor-verify", cl::Hidden,