From: Markus Elfring Date: Fri, 21 Nov 2014 14:50:44 +0000 (+0100) Subject: USB-SIS: Deletion of an unnecessary check before the function call "usb_put_dev" X-Git-Tag: android-x86-4.4-r3~682^2~35 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=bb2d43e0919ad89077dc756167c2bcc3e4cc97ab;p=android-x86%2Fkernel.git USB-SIS: Deletion of an unnecessary check before the function call "usb_put_dev" The usb_put_dev() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c index 633caf643122..022dc0008f2a 100644 --- a/drivers/usb/misc/sisusbvga/sisusb.c +++ b/drivers/usb/misc/sisusbvga/sisusb.c @@ -2472,8 +2472,7 @@ sisusb_delete(struct kref *kref) if (!sisusb) return; - if (sisusb->sisusb_dev) - usb_put_dev(sisusb->sisusb_dev); + usb_put_dev(sisusb->sisusb_dev); sisusb->sisusb_dev = NULL; sisusb_free_buffers(sisusb);