From: Rustam Subkhankulov Date: Thu, 14 Jul 2022 13:48:31 +0000 (+0300) Subject: wifi: p54: add missing parentheses in p54_flush() X-Git-Tag: v6.0-rc1~141^2~64^2~48 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=bcfd9d7f6840b06d5988c7141127795cf405805e;p=tomoyo%2Ftomoyo-test1.git wifi: p54: add missing parentheses in p54_flush() The assignment of the value to the variable total in the loop condition must be enclosed in additional parentheses, since otherwise, in accordance with the precedence of the operators, the conjunction will be performed first, and only then the assignment. Due to this error, a warning later in the function after the loop may not occur in the situation when it should. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Rustam Subkhankulov Fixes: 0d4171e2153b ("p54: implement flush callback") Acked-by: Christian Lamparter Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20220714134831.106004-1-subkhankulov@ispras.ru --- diff --git a/drivers/net/wireless/intersil/p54/main.c b/drivers/net/wireless/intersil/p54/main.c index 26b28d4d680f..b925e327e091 100644 --- a/drivers/net/wireless/intersil/p54/main.c +++ b/drivers/net/wireless/intersil/p54/main.c @@ -683,7 +683,7 @@ static void p54_flush(struct ieee80211_hw *dev, struct ieee80211_vif *vif, * queues have already been stopped and no new frames can sneak * up from behind. */ - while ((total = p54_flush_count(priv) && i--)) { + while ((total = p54_flush_count(priv)) && i--) { /* waste time */ msleep(20); }