From: Magnus Hagander <magnus@hagander.net>
Date: Wed, 3 Oct 2007 13:20:40 +0000 (+0000)
Subject: More detailed error msg (with stack trace) if a file copy fails.
X-Git-Tag: REL9_0_0~4892
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=bdf6b888a858a786898a8b649822bd901adac996;p=pg-rex%2Fsyncrep.git

More detailed error msg (with stack trace) if a file copy fails.
---

diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm
index 729f3b641f..7a9acb2442 100644
--- a/src/tools/msvc/Install.pm
+++ b/src/tools/msvc/Install.pm
@@ -3,7 +3,7 @@ package Install;
 #
 # Package that provides 'make install' functionality for msvc builds
 #
-# $PostgreSQL: pgsql/src/tools/msvc/Install.pm,v 1.22 2007/09/27 21:13:11 adunstan Exp $
+# $PostgreSQL: pgsql/src/tools/msvc/Install.pm,v 1.23 2007/10/03 13:20:40 mha Exp $
 #
 use strict;
 use warnings;
@@ -22,9 +22,14 @@ sub lcopy
 	my $src = shift;
 	my $target = shift;
 
-	unlink $target if -f $target;
+        if (-f $target)
+        {
+           unlink $target || confess "Could not delete $target\n";
+        }
+
+	copy($src,$target)
+          || confess "Could not copy $src to $target\n";
 
-	copy($src,$target);
 }
 
 sub Install
@@ -123,8 +128,7 @@ sub CopyFiles
         print ".";
         $f = $basedir . $f;
         die "No file $f\n" if (!-f $f);
-        lcopy($f, $target . basename($f))
-          || croak "Could not copy $f to $target". basename($f). " to $target". basename($f) . "\n";
+        lcopy($f, $target . basename($f));
     }
     print "\n";
 }