From: Elia Pinto <gitter.spiros@gmail.com>
Date: Wed, 23 Apr 2014 13:44:05 +0000 (-0700)
Subject: lib-gpg.sh: use the $( ... ) construct for command substitution
X-Git-Tag: v2.1.0-rc0~184^2~29
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=be194d53c0ce38ab3e040c6be249550fab4e8e1c;p=git-core%2Fgit.git

lib-gpg.sh: use the $( ... ) construct for command substitution

The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
index 05824fa8e..fd499e7c4 100755
--- a/t/lib-gpg.sh
+++ b/t/lib-gpg.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-gpg_version=`gpg --version 2>&1`
+gpg_version=$(gpg --version 2>&1)
 if test $? = 127; then
 	say "You do not seem to have gpg installed"
 else