From: Bjorn Bringert Date: Fri, 13 Sep 2013 12:39:12 +0000 (+0100) Subject: Don't use resource ID in switch X-Git-Tag: android-x86-6.0-r1~958 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=c639f8cdab11c603e25b5ae38282dddcb939d401;p=android-x86%2Fpackages-apps-Launcher3.git Don't use resource ID in switch This makes Eclipse unhappy when the code is used as a library project. Change-Id: I75949ebd36fabcdc88914150dc3a21aecc3357d8 --- diff --git a/src/com/android/launcher3/WallpaperPickerActivity.java b/src/com/android/launcher3/WallpaperPickerActivity.java index a0b9e6e7d..fe7525a00 100644 --- a/src/com/android/launcher3/WallpaperPickerActivity.java +++ b/src/com/android/launcher3/WallpaperPickerActivity.java @@ -306,27 +306,27 @@ public class WallpaperPickerActivity extends WallpaperCropActivity { // Called when the user selects a contextual menu item @Override public boolean onActionItemClicked(ActionMode mode, MenuItem item) { - switch (item.getItemId()) { - case R.id.menu_delete: - int childCount = mWallpapersView.getChildCount(); - ArrayList viewsToRemove = new ArrayList(); - for (int i = 0; i < childCount; i++) { - CheckableFrameLayout c = - (CheckableFrameLayout) mWallpapersView.getChildAt(i); - if (c.isChecked()) { - ThumbnailMetaData meta = (ThumbnailMetaData) c.getTag(); - mSavedImages.deleteImage(meta.mSavedWallpaperDbId); - viewsToRemove.add(c); - } - } - for (View v : viewsToRemove) { - mWallpapersView.removeView(v); + int itemId = item.getItemId(); + if (itemId == R.id.menu_delete) { + int childCount = mWallpapersView.getChildCount(); + ArrayList viewsToRemove = new ArrayList(); + for (int i = 0; i < childCount; i++) { + CheckableFrameLayout c = + (CheckableFrameLayout) mWallpapersView.getChildAt(i); + if (c.isChecked()) { + ThumbnailMetaData meta = (ThumbnailMetaData) c.getTag(); + mSavedImages.deleteImage(meta.mSavedWallpaperDbId); + viewsToRemove.add(c); } - ///xxxxx DESTROYING - mode.finish(); // Action picked, so close the CAB - return true; - default: - return false; + } + for (View v : viewsToRemove) { + mWallpapersView.removeView(v); + } + ///xxxxx DESTROYING + mode.finish(); // Action picked, so close the CAB + return true; + } else { + return false; } }