From: Markus Elfring Date: Sat, 27 Jan 2018 20:48:01 +0000 (+0100) Subject: RDMA/iwpm: Delete an error message for a failed memory allocation in iwpm_create_nlmsg() X-Git-Tag: v4.17-rc1~94^2~170 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=c7ec83772a08d84e5e6a774a7c49ec1d6dc2dd88;p=uclinux-h8%2Flinux.git RDMA/iwpm: Delete an error message for a failed memory allocation in iwpm_create_nlmsg() Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c index 81528f64061a..9821ae900f6d 100644 --- a/drivers/infiniband/core/iwpm_util.c +++ b/drivers/infiniband/core/iwpm_util.c @@ -439,10 +439,9 @@ struct sk_buff *iwpm_create_nlmsg(u32 nl_op, struct nlmsghdr **nlh, struct sk_buff *skb = NULL; skb = dev_alloc_skb(IWPM_MSG_SIZE); - if (!skb) { - pr_err("%s Unable to allocate skb\n", __func__); + if (!skb) goto create_nlmsg_exit; - } + if (!(ibnl_put_msg(skb, nlh, 0, 0, nl_client, nl_op, NLM_F_REQUEST))) { pr_warn("%s: Unable to put the nlmsg header\n", __func__);