From: Charles McGarvey Date: Wed, 5 Jun 2013 04:44:28 +0000 (-0600) Subject: gitweb: fix problem causing erroneous project list X-Git-Tag: v1.8.3.3~19^2 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=ca7a5dcfd39bdeb26d74074e78e6966df5e63a6b;p=git-core%2Fgit.git gitweb: fix problem causing erroneous project list The bug is manifest when running gitweb in a persistent process (e.g. FastCGI, PSGI), and it's easy to reproduce. If a gitweb request includes the searchtext parameter (i.e. s), subsequent requests using the project_list action--which is the default action--and without a searchtext parameter will be filtered by the searchtext value of the first request. This is because the value of the $search_regexp global (the value of which is based on the searchtext parameter) is currently being persisted between requests. Instead, clear $search_regexp before dispatching each request. Signed-off-by: Charles McGarvey Signed-off-by: Junio C Hamano --- diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 80950c018..8d69ada04 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1086,7 +1086,7 @@ sub evaluate_and_validate_params { our $search_use_regexp = $input_params{'search_use_regexp'}; our $searchtext = $input_params{'searchtext'}; - our $search_regexp; + our $search_regexp = undef; if (defined $searchtext) { if (length($searchtext) < 2) { die_error(403, "At least two characters are required for search parameter");