From: Thomas Huth Date: Wed, 21 Apr 2021 15:48:48 +0000 (+0200) Subject: pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=d08a64940452060ab7ad5eb49cd5801131c2b9ec;p=qmiga%2Fqemu.git pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang When compiling the s390-ccw bios with Clang, the compiler complains: pc-bios/s390-ccw/bootmap.c:302:9: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses] if (!mbr->dev_type == DEV_TYPE_ECKD) { ^ ~~ The code works (more or less by accident), since dev_type can only be 0 or 1, but it's better of course to use the intended != operator here instead. Fixes: 5dc739f343 ("Allow booting in case the first virtio-blk disk is bad") Message-Id: <20210421163331.358178-1-thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Christian Borntraeger Signed-off-by: Thomas Huth --- diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c index b46997c0b7..56411ab3b6 100644 --- a/pc-bios/s390-ccw/bootmap.c +++ b/pc-bios/s390-ccw/bootmap.c @@ -299,7 +299,7 @@ static void ipl_eckd_cdl(void) sclp_print("Bad block size in zIPL section of IPL2 record.\n"); return; } - if (!mbr->dev_type == DEV_TYPE_ECKD) { + if (mbr->dev_type != DEV_TYPE_ECKD) { sclp_print("Non-ECKD device type in zIPL section of IPL2 record.\n"); return; }