From: Philippe Mathieu-Daudé <philmd@redhat.com>
Date: Fri, 19 Aug 2022 15:39:23 +0000 (+0100)
Subject: chardev/baum: Avoid dynamic stack allocation
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=d34977d682e382fb2af83e6e6508e3b06d1a3cf2;p=qmiga%2Fqemu.git

chardev/baum: Avoid dynamic stack allocation

Use autofree heap allocation instead of variable-length
array on the stack.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-4-peter.maydell@linaro.org
---

diff --git a/chardev/baum.c b/chardev/baum.c
index 6a210ffd81..0a0d12661a 100644
--- a/chardev/baum.c
+++ b/chardev/baum.c
@@ -299,7 +299,8 @@ static void baum_chr_accept_input(struct Chardev *chr)
 static void baum_write_packet(BaumChardev *baum, const uint8_t *buf, int len)
 {
     Chardev *chr = CHARDEV(baum);
-    uint8_t io_buf[1 + 2 * len], *cur = io_buf;
+    g_autofree uint8_t *io_buf = g_malloc(1 + 2 * len);
+    uint8_t *cur = io_buf;
     int room;
     *cur++ = ESC;
     while (len--)