From: Greg Kroah-Hartman Date: Tue, 24 Mar 2015 19:10:58 +0000 (+0100) Subject: greybus: es1: decimal modes are not what are wanted for debugfs X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~1651^2~4 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=d52f9973e2de01e6da7beb2e91ece009ffd880a2;p=uclinux-h8%2Flinux.git greybus: es1: decimal modes are not what are wanted for debugfs decimal is not octal, so use the proper mode settings for the debugfs files. Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/es1.c b/drivers/staging/greybus/es1.c index 7e612cbd813e..796c2ab5dafd 100644 --- a/drivers/staging/greybus/es1.c +++ b/drivers/staging/greybus/es1.c @@ -554,7 +554,7 @@ static void usb_log_enable(struct es1_ap_dev *es1, int enable) apb1_log_task = kthread_run(apb1_log_poll, es1, "apb1_log"); if (apb1_log_task == ERR_PTR(-ENOMEM)) return; - apb1_log_dentry = debugfs_create_file("apb1_log", 444, + apb1_log_dentry = debugfs_create_file("apb1_log", S_IRUGO, gb_debugfs_get(), NULL, &apb1_log_fops); } else { @@ -730,7 +730,8 @@ static int ap_probe(struct usb_interface *interface, if (retval) goto error; - apb1_log_enable_dentry = debugfs_create_file("apb1_log_enable", 666, + apb1_log_enable_dentry = debugfs_create_file("apb1_log_enable", + (S_IWUSR | S_IRUGO), gb_debugfs_get(), es1, &apb1_log_enable_fops);