From: Baowen Zheng Date: Wed, 2 Mar 2022 03:29:29 +0000 (+0800) Subject: flow_offload: improve extack msg for user when adding invalid filter X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=d922a99b96d0030f2e7e8128e98f29123172bd03;p=uclinux-h8%2Flinux.git flow_offload: improve extack msg for user when adding invalid filter Add extack message to return exact message to user when adding invalid filter with conflict flags for TC action. In previous implement we just return EINVAL which is confusing for user. Signed-off-by: Baowen Zheng Reviewed-by: Roi Dayan Link: https://lore.kernel.org/r/1646191769-17761-1-git-send-email-baowen.zheng@corigine.com Signed-off-by: Jakub Kicinski --- diff --git a/net/sched/act_api.c b/net/sched/act_api.c index ca03e7284254..4f51094da9da 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -1446,6 +1446,8 @@ int tcf_action_init(struct net *net, struct tcf_proto *tp, struct nlattr *nla, continue; if (skip_sw != tc_act_skip_sw(act->tcfa_flags) || skip_hw != tc_act_skip_hw(act->tcfa_flags)) { + NL_SET_ERR_MSG(extack, + "Mismatch between action and filter offload flags"); err = -EINVAL; goto err; }