From: Jia-Ju Bai Date: Fri, 27 Jul 2018 03:38:23 +0000 (-0400) Subject: media: pci: cx88: Replace mdelay() with msleep() in cx88_card_setup_pre_i2c() X-Git-Tag: android-x86-8.1-r1~474^2~139 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=dddaf754cb3af9fe779be1f6e117dc76e36cfdc2;p=android-x86%2Fkernel.git media: pci: cx88: Replace mdelay() with msleep() in cx88_card_setup_pre_i2c() cx88_card_setup_pre_i2c() is never called in atomic context. It calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/pci/cx88/cx88-cards.c b/drivers/media/pci/cx88/cx88-cards.c index 4c92d2388c26..07e1483e987d 100644 --- a/drivers/media/pci/cx88/cx88-cards.c +++ b/drivers/media/pci/cx88/cx88-cards.c @@ -3307,9 +3307,9 @@ static void cx88_card_setup_pre_i2c(struct cx88_core *core) case CX88_BOARD_PROLINK_PV_GLOBAL_XTREME: case CX88_BOARD_PROLINK_PV_8000GT: cx_write(MO_GP2_IO, 0xcf7); - mdelay(50); + msleep(50); cx_write(MO_GP2_IO, 0xef5); - mdelay(50); + msleep(50); cx_write(MO_GP2_IO, 0xcf7); usleep_range(10000, 20000); break;