From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 6 Oct 2009 23:16:00 +0000 (+0200)
Subject: Warn if value of qdev_init() isn't checked
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=dde8bbb44de41ea68f9bede0a6a778ce046b2bcf;p=qmiga%2Fqemu.git

Warn if value of qdev_init() isn't checked

After qdev_init() fails, the device is gone.  Failure to check runs a
high risk of use-after-free.

Patchworks-ID: 35166
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/hw/qdev.h b/hw/qdev.h
index b385b25b46..8cd843e763 100644
--- a/hw/qdev.h
+++ b/hw/qdev.h
@@ -100,7 +100,7 @@ struct CompatProperty {
 
 DeviceState *qdev_create(BusState *bus, const char *name);
 DeviceState *qdev_device_add(QemuOpts *opts);
-int qdev_init(DeviceState *dev);
+int qdev_init(DeviceState *dev) __attribute__((warn_unused_result));
 void qdev_init_nofail(DeviceState *dev);
 int qdev_unplug(DeviceState *dev);
 void qdev_free(DeviceState *dev);