From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 17 Jun 2021 14:15:10 +0000 (+0300)
Subject: clk: renesas: rzg2l: Avoid mixing error pointers and NULL
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=e37868f14416bc5f22235dce073c496381d349c3;p=uclinux-h8%2Flinux.git

clk: renesas: rzg2l: Avoid mixing error pointers and NULL

These functions accidentally return both error pointers and NULL when
there is an error.  It doesn't cause a problem but it is confusing and
seems unintentional.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/YMtY7nOtqEvTokh7@mwanda
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---

diff --git a/drivers/clk/renesas/renesas-rzg2l-cpg.c b/drivers/clk/renesas/renesas-rzg2l-cpg.c
index 6808390f8ee0..34e90ee46290 100644
--- a/drivers/clk/renesas/renesas-rzg2l-cpg.c
+++ b/drivers/clk/renesas/renesas-rzg2l-cpg.c
@@ -125,7 +125,7 @@ rzg2l_cpg_div_clk_register(const struct cpg_core_clk *core,
 						 core->flag, &priv->rmw_lock);
 
 	if (IS_ERR(clk_hw))
-		return NULL;
+		return ERR_CAST(clk_hw);
 
 	return clk_hw->clk;
 }