From: Dan Carpenter Date: Mon, 28 Sep 2015 10:06:20 +0000 (+0300) Subject: ALSA: usb-audio: harmless underflow in snd_audigy2nx_led_put() X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=e87359efcaf45efc41dbaa6ec25eb26705300cee;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git ALSA: usb-audio: harmless underflow in snd_audigy2nx_led_put() We want to verify that "value" is either zero or one, so we test if it is greater than one. Unfortunately, this is a signed int so it could also be negative. I think this is harmless but it introduces a static checker warning. Let's make "value" unsigned. Signed-off-by: Dan Carpenter Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index d3608c0a29f3..fe91184ce832 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -338,7 +338,7 @@ static int snd_audigy2nx_led_put(struct snd_kcontrol *kcontrol, struct usb_mixer_elem_list *list = snd_kcontrol_chip(kcontrol); struct usb_mixer_interface *mixer = list->mixer; int index = kcontrol->private_value & 0xff; - int value = ucontrol->value.integer.value[0]; + unsigned int value = ucontrol->value.integer.value[0]; int old_value = kcontrol->private_value >> 8; int err;