From: Zhengchao Shao Date: Mon, 24 Jul 2023 02:37:35 +0000 (+0800) Subject: net: remove redundant NULL check in remove_xps_queue() X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=f080864a9d906678e050f10f0e81add711b86fbc;p=tomoyo%2Ftomoyo-test1.git net: remove redundant NULL check in remove_xps_queue() There are currently two paths that call remove_xps_queue(): 1. __netif_set_xps_queue -> remove_xps_queue 2. clean_xps_maps -> remove_xps_queue_cpu -> remove_xps_queue There is no need to check dev_maps in remove_xps_queue() because dev_maps has been checked on these two paths. Signed-off-by: Zhengchao Shao Link: https://lore.kernel.org/r/20230724023735.2751602-1-shaozhengchao@huawei.com Signed-off-by: Jakub Kicinski --- diff --git a/net/core/dev.c b/net/core/dev.c index 8e7d0cb540cd..e7ffcfa037f7 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2384,8 +2384,7 @@ static bool remove_xps_queue(struct xps_dev_maps *dev_maps, struct xps_map *map = NULL; int pos; - if (dev_maps) - map = xmap_dereference(dev_maps->attr_map[tci]); + map = xmap_dereference(dev_maps->attr_map[tci]); if (!map) return false;