From: Robert Haas <rhaas@postgresql.org>
Date: Thu, 17 Feb 2011 15:29:42 +0000 (-0500)
Subject: Add some words of caution to elog.c.
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=f196738534baa95badd9d8f1debb5822240ebc6b;p=pg-rex%2Fsyncrep.git

Add some words of caution to elog.c.

Stephen Frost, somewhat rewritten by me
---

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index a1a449f2dd..5679d5b9c1 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -3,6 +3,12 @@
  * elog.c
  *	  error logging and reporting
  *
+ * Because of the extremely high rate at which log messages can be generated,
+ * we need to be mindful of the performance cost of obtaining any information
+ * that may be logged.  Also, it's important to keep in mind that this code may
+ * get called from within an aborted transaction, in which case operations
+ * such as syscache lookups are unsafe.
+ *
  * Some notes about recursion and errors during error processing:
  *
  * We need to be robust about recursive-error scenarios --- for example,