From: Jeremiah Mahler Date: Tue, 12 Aug 2014 07:03:44 +0000 (-0700) Subject: staging: rtl8192u/ieee80211: Fix sparse ieee80211_debug_init/_exit not declared warning X-Git-Tag: android-x86-4.4-r2~359^2~1263 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=f2ea5ff8a7cde20542d47d1398d3fc710d357f6f;p=android-x86%2Fkernel.git staging: rtl8192u/ieee80211: Fix sparse ieee80211_debug_init/_exit not declared warning A sparse warning is generated about 'ieee80211_debug_init' and 'ieee80211_debug_exit' not being declared. drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning: symbol 'ieee80211_debug_init' was not declared. Should it be static? drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:297:13: warning: symbol 'ieee80211_debug_exit' was not declared. Should it be static? These functions are used outside of this file so using static will not work. The prototypes are given in r8192U_core.c but sparse nonetheless still gives a warning. Fix the sparse warning by moving these prototypes from r8192U_core.c to ieee80211.h. Signed-off-by: Jeremiah Mahler Cc: Joel Pelaez Jorge Cc: Andrea Merello Cc: "John W. Linville" Cc: Joe Perches Cc: Himangi Saraogi Cc: Arnd Bergmann Cc: Peter P Waskiewicz Jr Cc: Ana Rey Cc: Chaitanya Hazarey Cc: Rickard Strandqvist Cc: Teodora Baluta Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h index 1040bab9702a..c118551066c8 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h @@ -2485,6 +2485,10 @@ extern int ieee80211_wx_set_freq(struct ieee80211_device *ieee, struct iw_reques extern int ieee80211_wx_get_freq(struct ieee80211_device *ieee, struct iw_request_info *a, union iwreq_data *wrqu, char *b); +/* ieee80211_module.c */ +extern int ieee80211_debug_init(void); +extern void ieee80211_debug_exit(void); + //extern void ieee80211_wx_sync_scan_wq(struct ieee80211_device *ieee); extern void ieee80211_wx_sync_scan_wq(struct work_struct *work); diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index bd8a497af06e..eb96bedb1c53 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -4805,8 +4805,6 @@ static void rtl8192_usb_disconnect(struct usb_interface *intf) } /* fun with the built-in ieee80211 stack... */ -extern int ieee80211_debug_init(void); -extern void ieee80211_debug_exit(void); extern int ieee80211_crypto_init(void); extern void ieee80211_crypto_deinit(void); extern int ieee80211_crypto_tkip_init(void);