From: Jaegeuk Kim <jaegeuk@kernel.org>
Date: Wed, 19 Sep 2018 22:45:19 +0000 (-0700)
Subject: f2fs: avoid infinite loop in f2fs_alloc_nid
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=fa0b9799279721b5e8db54ef334fb6dda62563ce;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git

f2fs: avoid infinite loop in f2fs_alloc_nid

If we have an error in f2fs_build_free_nids, we're able to fall into a loop
to find free nids.

Suggested-by: Chao Yu <chao@kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 7d11854028e8..4dc98f5f2e84 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -2353,8 +2353,9 @@ retry:
 	spin_unlock(&nm_i->nid_list_lock);
 
 	/* Let's scan nat pages and its caches to get free nids */
-	f2fs_build_free_nids(sbi, true, false);
-	goto retry;
+	if (!f2fs_build_free_nids(sbi, true, false))
+		goto retry;
+	return false;
 }
 
 /*