From: Geert Uytterhoeven Date: Fri, 23 Feb 2018 13:38:30 +0000 (+0100) Subject: serial: fsl_lpuart: Fix out-of-bounds access through DT alias X-Git-Tag: v4.17-rc1~125^2~45 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=ffab87fdecc655cc676f8be8dd1a2c5e22bd6d47;p=uclinux-h8%2Flinux.git serial: fsl_lpuart: Fix out-of-bounds access through DT alias The lpuart_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: c9e2e946fb0ba5d2 ("tty: serial: add Freescale lpuart driver support") Signed-off-by: Geert Uytterhoeven Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 8cf112f2efc3..51e47a63d61a 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -2145,6 +2145,10 @@ static int lpuart_probe(struct platform_device *pdev) dev_err(&pdev->dev, "failed to get alias id, errno %d\n", ret); return ret; } + if (ret >= ARRAY_SIZE(lpuart_ports)) { + dev_err(&pdev->dev, "serial%d out of range\n", ret); + return -EINVAL; + } sport->port.line = ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); sport->port.membase = devm_ioremap_resource(&pdev->dev, res);