OSDN Git Service
jsh [Fri, 18 Sep 2009 22:22:48 +0000 (15:22 -0700)]
Fix potential ArrayIndexOutOfBoundsException.
When parsing an SMS message as email, extractEmailAddressFromMessageBody()
checks parts.length >= 1, but then proceeds to access parts[1] (which
may not exist). Instead, check for parts.length >= 2, and treat
parts.length = 1 as non-email.
b/
2122698
Android (Google) Code Review [Fri, 18 Sep 2009 22:05:50 +0000 (18:05 -0400)]
Merge change 25829 into eclair
* changes:
Revert "ContactsContract: Adding joined columns to the Data class definition."
Dmitri Plotnikov [Fri, 18 Sep 2009 22:04:58 +0000 (15:04 -0700)]
Revert "ContactsContract: Adding joined columns to the Data class definition."
This reverts commit
dd768a6a736bc202b62aa20f3282b3cfb285dc7f.
Android (Google) Code Review [Fri, 18 Sep 2009 21:25:21 +0000 (17:25 -0400)]
Merge change 25818 into eclair
* changes:
Clean up some debugging and add 2 math lib routines.
Jason Sams [Fri, 18 Sep 2009 21:24:24 +0000 (14:24 -0700)]
Clean up some debugging and add 2 math lib routines.
Android (Google) Code Review [Fri, 18 Sep 2009 21:02:56 +0000 (17:02 -0400)]
Merge change 25810 into eclair
* changes:
Fix pause-wait dial string conversion error
Android (Google) Code Review [Fri, 18 Sep 2009 20:54:34 +0000 (16:54 -0400)]
Merge change 25800 into eclair
* changes:
ContactsContract: Adding joined columns to the Data class definition.
Dmitri Plotnikov [Fri, 18 Sep 2009 20:24:25 +0000 (13:24 -0700)]
ContactsContract: Adding joined columns to the Data class definition.
The rationale is this. Since all these joined columns are currently on
different classes, we routinely see code like this:
private static final String[] PROJECTION_PHONE = {
Data._ID, // 0
RawContacts.CONTACT_ID, // 1
Phone.TYPE, // 2
Phone.NUMBER, // 3
Phone.LABEL, // 4
Contacts.DISPLAY_NAME, // 5
};
The most noxious line is RawContacts.CONTACT_ID
After this change, the above declaration changes to:
private static final String[] PROJECTION_PHONE = {
Data._ID, // 0
Data.CONTACT_ID, // 1
Phone.TYPE, // 2
Phone.NUMBER, // 3
Phone.LABEL, // 4
Data.DISPLAY_NAME, // 5
};
Change-Id: I820e68efd6c1364241596f826c4da1b9c2defe11
Android (Google) Code Review [Fri, 18 Sep 2009 20:51:36 +0000 (16:51 -0400)]
Merge change 25780 into eclair
* changes:
Reject lowercase characters in checkBluetoothAddress().
Evan Millar [Fri, 18 Sep 2009 20:18:59 +0000 (13:18 -0700)]
More hi-res assets, and darken background color to donut level.
Includes hi-res divider and header assets.
Change-Id: I8fbeb619509886f707fe604a8057c6beda1e03a7
Android (Google) Code Review [Fri, 18 Sep 2009 19:23:40 +0000 (15:23 -0400)]
Merge change 25785 into eclair
* changes:
Fix http://b/
2126318 (density test fails due to wrong-size asset stripping)
Android (Google) Code Review [Fri, 18 Sep 2009 19:18:27 +0000 (15:18 -0400)]
Merge change 25786 into eclair
* changes:
Fix http://b/
2086471 (list view headers too dark in mdpi).
Daniel Sandler [Fri, 18 Sep 2009 19:17:33 +0000 (15:17 -0400)]
Fix b/
2086471 (list view headers too dark in mdpi).
Daniel Sandler [Fri, 18 Sep 2009 18:06:07 +0000 (14:06 -0400)]
Fix b/
2126318 (density test fails due to wrong-size asset stripping)
The density test expects all resources of all densities to be included, but specifying a density for a particular device build kills that. We therefore add all the required densities explicitly to the Makefile to compensate.
Android (Google) Code Review [Fri, 18 Sep 2009 19:07:28 +0000 (15:07 -0400)]
Merge change 25752 into eclair
* changes:
Add a Gservices setting to controll the app error reporting feature.
Android (Google) Code Review [Fri, 18 Sep 2009 18:53:46 +0000 (14:53 -0400)]
Merge change 25775 into eclair
* changes:
Fix typo in SECONDARY_DATA_RETRY_CONFIG
Android (Google) Code Review [Fri, 18 Sep 2009 18:38:38 +0000 (14:38 -0400)]
Merge change 25464 into eclair
* changes:
Improve ExifInterface API.
Nick Pelly [Fri, 18 Sep 2009 18:37:06 +0000 (11:37 -0700)]
Reject lowercase characters in checkBluetoothAddress().
This keeps consistency with Bluez which uses upper case string address. It's
important to keep the case the same so that .equals() in BluetoothService.java
work.
Change-Id: I6404ca137d0aec3cc2e6e7cb79763d5305a03547
Chih-Chung Chang [Thu, 17 Sep 2009 09:58:32 +0000 (17:58 +0800)]
Improve ExifInterface API.
Change-Id: Ic6c4df8244b51b9a0d1c73c3797847220d86604d
Libin Tang [Wed, 16 Sep 2009 21:46:09 +0000 (16:46 -0500)]
Fix pause-wait dial string conversion error
Resolves these specific cases:
-
8475766800;,1234
-
8475766800,;1234
Both of these should be converted to
8475766800;1234
Change-Id: Ic329007a3a6e99b1dd55cd8cdec7239dd734c3ca
Robert Greenwalt [Fri, 18 Sep 2009 18:23:58 +0000 (11:23 -0700)]
Fix typo in SECONDARY_DATA_RETRY_CONFIG
The parser doesn't like ';'.
bug:
2130639
Android (Google) Code Review [Fri, 18 Sep 2009 18:22:01 +0000 (14:22 -0400)]
Merge change 25772 into eclair
* changes:
Add progress view and default poster for the <video> implementation
Andrei Popescu [Fri, 18 Sep 2009 17:59:52 +0000 (18:59 +0100)]
Add progress view and default poster for the <video> implementation
Android (Google) Code Review [Fri, 18 Sep 2009 17:29:34 +0000 (13:29 -0400)]
Merge change 25768 into eclair
* changes:
Add one line of logging when SCO SOCKET connect starts.
Nick Pelly [Fri, 18 Sep 2009 17:17:41 +0000 (10:17 -0700)]
Add one line of logging when SCO SOCKET connect starts.
This is to help collect information from Moto QA about delays connecting BT
audio.
Change-Id: I790c65f5b64c85aaffc0e68ebe8b6202f476b39f
http://b/
2129464
Android (Google) Code Review [Fri, 18 Sep 2009 17:16:30 +0000 (13:16 -0400)]
Merge change 25734 into eclair
* changes:
Show the live wallpaper on the lock screen.
Android (Google) Code Review [Fri, 18 Sep 2009 17:01:05 +0000 (13:01 -0400)]
Merge change 25644 into eclair
* changes:
add Eclair to the droiddoc 'since' options so that we can see API Level diffs in the docs.
Leon Scroggins [Thu, 17 Sep 2009 21:27:13 +0000 (17:27 -0400)]
Do not attempt to retry a scrollTo with a negative position.
Fixes http://b/issue?id=
2093435
Change-Id: If938c8f6e5d74b91e39a06a5736967663c9800b7
Dianne Hackborn [Fri, 18 Sep 2009 08:53:49 +0000 (01:53 -0700)]
Show the live wallpaper on the lock screen.
This also takes care of the problem of system dialogs like the
crash dialog causing the status bar to dim behind the lock screen.
On the down side, the fade transition from the lock screen is
now gone, and I'm not sure how likely it is for it to return.
Change-Id: I7f9e6d0f3510a1fdbbe6ad252d986bd85a16475d
Grace Kloba [Thu, 17 Sep 2009 22:31:12 +0000 (15:31 -0700)]
When a WebView starts, we may get first layout before viewSizeChanged()
ever get called. Call WebView's getViewWidth() to get the current UI
width. If it is still 0, log a warning.
Fix http://b/issue?id=
2128645
Android (Google) Code Review [Fri, 18 Sep 2009 16:11:28 +0000 (12:11 -0400)]
Merge change 25666 into eclair
* changes:
Save message size
Leon Scroggins [Thu, 17 Sep 2009 19:55:31 +0000 (15:55 -0400)]
Draw shadow below title, or at top if title is off screen.
Fixes http://b/issue?id=
2118813 for the "real" title bar.
Also fix http://b/issue?id=
2125444 by moving the save after
the check for mNativeClass.
Change-Id: I8f85f0a76eb7e1d186485ef65c50ae8d4bc10932
Jacek Surazski [Fri, 18 Sep 2009 13:01:26 +0000 (15:01 +0200)]
Add a Gservices setting to controll the app error reporting feature.
Bryan Mawhinney [Thu, 17 Sep 2009 20:31:16 +0000 (21:31 +0100)]
Reserve space for the searchbox spinner, even when stopped.
Make the searchbox spinner invisible (transparent) when it's not active. This prevents the size of the text field from varying depending on whether the spinner is spinning or not, which can cause an annoying flicker.
Bug:
2084293
Change-Id: Idd63a296d1f07c5bd47884040f21e4880038f424
Jeff Sharkey [Thu, 17 Sep 2009 23:11:32 +0000 (16:11 -0700)]
Adopt new FastTrack API for internal widget, fix bugs.
Change internal widget to use new FastTrack API instead of
using SHOW_OR_CREATE. Also reset the internal Uri when
reused in lists. Fixes http://b/
2087222
Android (Google) Code Review [Fri, 18 Sep 2009 06:55:53 +0000 (02:55 -0400)]
Merge change 25722 into eclair
* changes:
Modified the validation to use singal media player instance.
Android (Google) Code Review [Fri, 18 Sep 2009 06:55:00 +0000 (02:55 -0400)]
Merge change 25496 into eclair
* changes:
Fix issue
2127371: Possible race condition in AudioFlinger::openRecord() when a Track is being destroyed.
Yu Shan Emily Lau [Fri, 18 Sep 2009 06:40:59 +0000 (23:40 -0700)]
Modified the validation to use singal media player instance.
Android (Google) Code Review [Fri, 18 Sep 2009 06:20:43 +0000 (02:20 -0400)]
Merge change 25452 into eclair
* changes:
Modified the new stream video url.
Android (Google) Code Review [Fri, 18 Sep 2009 05:57:38 +0000 (01:57 -0400)]
Merge change 25717 into eclair
* changes:
CertTool: avoid using final static array.
Chia-chi Yeh [Fri, 18 Sep 2009 05:55:43 +0000 (13:55 +0800)]
CertTool: avoid using final static array.
Android (Google) Code Review [Fri, 18 Sep 2009 04:45:09 +0000 (00:45 -0400)]
Merge change 25706 into eclair
* changes:
WebKit: switch to java-based CertTool.
Android (Google) Code Review [Fri, 18 Sep 2009 04:44:48 +0000 (00:44 -0400)]
Merge change 25705 into eclair
* changes:
Add a helper class to send out credentials.
Android (Google) Code Review [Fri, 18 Sep 2009 04:44:00 +0000 (00:44 -0400)]
Merge change 25684 into eclair
* changes:
keystore: add multi-user support.
Chia-chi Yeh [Fri, 18 Sep 2009 04:11:20 +0000 (12:11 +0800)]
WebKit: switch to java-based CertTool.
Change-Id: Ica6d491ede2bf2a311cacb7a7d64a249191fbecf
Chia-chi Yeh [Fri, 18 Sep 2009 04:00:12 +0000 (12:00 +0800)]
Add a helper class to send out credentials.
Change-Id: I9a550c6edc55d5c2c601223c011922b183cb4d30
Chia-chi Yeh [Fri, 18 Sep 2009 02:15:37 +0000 (10:15 +0800)]
keystore: add multi-user support.
Change-Id: I60268261110934a1d60efa341ff530f94415724f
Mathias Agopian [Fri, 18 Sep 2009 02:19:08 +0000 (19:19 -0700)]
fix [
2129080] Soft reboot after clicking around and then rubbing the screen
Android (Google) Code Review [Fri, 18 Sep 2009 01:51:26 +0000 (21:51 -0400)]
Merge change 25636 into eclair
* changes:
Add each contact in vCard into "My Groups" if account is for Google's and it has such a group. This fix should be temporal. Should be fixed in the near future.
Dianne Hackborn [Fri, 18 Sep 2009 01:46:22 +0000 (18:46 -0700)]
Try to fix docs build.
Change-Id: I331e128fa95c3bc0b8bc4ab2537cc2ea92e310e7
Daisuke Miyakawa [Thu, 17 Sep 2009 23:39:11 +0000 (16:39 -0700)]
Add each contact in vCard into "My Groups" if account is for Google's and it has such a group.
This fix should be temporal. Should be fixed in the near future.
Internal issue id:
2126265
Dianne Hackborn [Thu, 17 Sep 2009 22:14:12 +0000 (15:14 -0700)]
Fix issue #
2093608: Calendar widget takes a few seconds to launch
Avert your eyes!
The key change here is that RemoteViews can now call a Context API to
start its pending intent, which inside of the activity manager we can
use to determine to cancel the timeout delay for external entities
to disrupt the home screen.
Change-Id: If097cf7478cbed7a3c04a304050bd7fd5703d197
Android (Google) Code Review [Fri, 18 Sep 2009 00:43:53 +0000 (20:43 -0400)]
Merge change 25647 into eclair
* changes:
Some tweaks to the rotary lock widget.
Android (Google) Code Review [Fri, 18 Sep 2009 00:36:24 +0000 (20:36 -0400)]
Merge change 25629 into eclair
* changes:
Android side of the fix for [
2121211] Sholes has stutter during animations
Karl Rosaen [Fri, 18 Sep 2009 00:21:18 +0000 (17:21 -0700)]
Some tweaks to the rotary lock widget.
- don't show arrows above widget when in resting state
- don't show other icon once you press one (e.g don't show silent mode icon when you are pressing the lock icon)
- wider target for triggering action
Android (Google) Code Review [Fri, 18 Sep 2009 00:20:14 +0000 (20:20 -0400)]
Merge change 25639 into eclair
* changes:
do not use transactions for calls that just read the DB
Scott Main [Fri, 18 Sep 2009 00:16:09 +0000 (17:16 -0700)]
add Eclair to the droiddoc 'since' options so that we
can see API Level diffs in the docs.
Android (Google) Code Review [Fri, 18 Sep 2009 00:14:37 +0000 (20:14 -0400)]
Merge change 25640 into eclair
* changes:
Make the EditText error popup correctly resize when the view resizes.
Android (Google) Code Review [Fri, 18 Sep 2009 00:12:22 +0000 (20:12 -0400)]
Merge change 25634 into eclair
* changes:
Report NO_CONNECTIVITY when failover net unavail
Android (Google) Code Review [Fri, 18 Sep 2009 00:07:45 +0000 (20:07 -0400)]
Merge change 25554 into eclair
* changes:
telephony: Add CdmaCellLocation class to the public API.
Eric Fischer [Fri, 18 Sep 2009 00:01:59 +0000 (17:01 -0700)]
Make the EditText error popup correctly resize when the view resizes.
It was calling PopupWindow.update() with -1 arguments for the width
and height under the impression that that would cause it to use the
new values that had already been set with setWidth() and setHeight().
But in fact this caused it not to change at all.
Fred Quintana [Fri, 18 Sep 2009 00:00:01 +0000 (17:00 -0700)]
do not use transactions for calls that just read the DB
Tom Taylor [Thu, 17 Sep 2009 23:39:27 +0000 (16:39 -0700)]
Save message size
Save the message size in the pdu.
Robert Greenwalt [Thu, 17 Sep 2009 21:58:16 +0000 (14:58 -0700)]
Report NO_CONNECTIVITY when failover net unavail
Fix ConnectivityService so that it reports connection status correctly.
bug:
2128595
Android (Google) Code Review [Thu, 17 Sep 2009 23:32:34 +0000 (19:32 -0400)]
Merge change 25626 into eclair
* changes:
Check if rename of current settings file was successful before persisting new changes to settings.
Suchi Amalapurapu [Thu, 17 Sep 2009 22:38:20 +0000 (15:38 -0700)]
Check if rename of current settings file was successful before persisting
new changes to settings.
Mike Lockwood [Thu, 17 Sep 2009 20:42:09 +0000 (16:42 -0400)]
telephony: Add CdmaCellLocation class to the public API.
Its twin sister GsmCellLocation is public, so this really should be in the SDK too.
Change-Id: If6f5899047546a7398f1e4191c67acf15555c21b
Signed-off-by: Mike Lockwood <lockwood@android.com>
Mathias Agopian [Thu, 17 Sep 2009 23:18:16 +0000 (16:18 -0700)]
Android side of the fix for [
2121211] Sholes has stutter during animations
a new method, compostionComplete() is added to the framebuffer hal, it is used by surfaceflinger to signal the driver that the composition is complete, BEFORE it releases its client. This gives a chance to the driver to
Android (Google) Code Review [Thu, 17 Sep 2009 23:07:05 +0000 (19:07 -0400)]
Merge change 25550 into eclair
* changes:
add system property to disable gzip, to help with debugging.
Android (Google) Code Review [Thu, 17 Sep 2009 22:49:51 +0000 (18:49 -0400)]
Merge change 25601 into eclair
* changes:
Fix possible race condition when switching keyboards while there are pending messages.
Fred Quintana [Thu, 17 Sep 2009 19:42:35 +0000 (12:42 -0700)]
- Make the AccountManagerService delete accounts that
have no Authenticator, both when the package is removed
and when the phone is booted.
- add the ability to register with the RegisteredServicesCache
to be notified when the set of Authenticators changes.
Debajit Ghosh [Thu, 17 Sep 2009 20:33:54 +0000 (13:33 -0700)]
add system property to disable gzip, to help with debugging.
Amith Yamasani [Thu, 17 Sep 2009 18:27:14 +0000 (11:27 -0700)]
Fix possible race condition when switching keyboards while there are pending messages.
Android (Google) Code Review [Thu, 17 Sep 2009 22:03:26 +0000 (18:03 -0400)]
Merge change 25571 into eclair
* changes:
Import revised translations. DO NOT MERGE
Android (Google) Code Review [Thu, 17 Sep 2009 21:56:31 +0000 (17:56 -0400)]
Merge change 25561 into eclair
* changes:
Add Gservices settings required for carrier billing.
Android (Google) Code Review [Thu, 17 Sep 2009 21:54:11 +0000 (17:54 -0400)]
Merge change 25567 into eclair
* changes:
The starting progress for WebView should be 100 as it is not in the loading state.
Sanjay Jeyakumar [Thu, 17 Sep 2009 20:50:30 +0000 (13:50 -0700)]
Add Gservices settings required for carrier billing.
Eric Fischer [Thu, 17 Sep 2009 21:28:06 +0000 (14:28 -0700)]
Import revised translations. DO NOT MERGE
Grace Kloba [Thu, 17 Sep 2009 21:20:28 +0000 (14:20 -0700)]
The starting progress for WebView should be 100 as it is
not in the loading state.
Jeff Sharkey [Thu, 17 Sep 2009 04:41:51 +0000 (21:41 -0700)]
Added API for triggering FastTrack.
I added a new API to help us move away from launching
FastTrack through SHOW_OR_CREATE. For now it's going to
still pass through as an Intent with extras, but in the
future this could be used to launch a Window from a system
service.
Partially fixes http://b/
2087222
Leon Scroggins [Thu, 17 Sep 2009 18:19:49 +0000 (14:19 -0400)]
Don't scroll the title bar off screen while loading.
Though the user can still manually scroll the title bar
off screen, we do not want it to happen automatically.
When we load a new page, its scroll position can be
set to (0,0). Make sure that we simply set it to the
top without adding in the title bar's height. Also,
prevent javascript which attempts to scroll the page
to (0,0) or (0,1) from removing the title bar.
Fixes http://b/issue?id=
2113398 and http://b/issue?id=
2123079
Change-Id: Ida64d8c94be6744c7b0b4d60af1c229b2cc83673
Android (Google) Code Review [Thu, 17 Sep 2009 19:25:52 +0000 (15:25 -0400)]
Merge change 25338 into eclair
* changes:
Remove the network connection logic from RequestQueue.
Android (Google) Code Review [Thu, 17 Sep 2009 19:11:22 +0000 (15:11 -0400)]
Merge change 25526 into eclair
* changes:
Add API to retrieve memory used by running processes.
Patrick Scott [Wed, 16 Sep 2009 13:59:12 +0000 (09:59 -0400)]
Remove the network connection logic from RequestQueue.
This doesn't always work right and is causing some problems if the network comes
back up without sending the broadcast.
Android (Google) Code Review [Thu, 17 Sep 2009 19:03:27 +0000 (15:03 -0400)]
Merge change 25534 into eclair
* changes:
Message Reject notification shouldn't be shown in Emergency Calling Mode
Android (Google) Code Review [Thu, 17 Sep 2009 19:02:16 +0000 (15:02 -0400)]
Merge change 25524 into eclair
* changes:
Fix the zoom center. Now there is a titlebar, the zoom center needs to be adjusted for it as the user really cares the spot in the document. We need to pin zoom around that spot.
Satish Roddom [Wed, 16 Sep 2009 10:52:58 +0000 (05:52 -0500)]
Message Reject notification shouldn't be shown in Emergency Calling Mode
Issue: While in emergency mode, if we receive a message, there is a notification
being shown as "Text Message rejected".
Fix: In CdmaSMSDispatcher.java, send RESULT_OK response instead of RESULT_SMS_GENERIC_ERROR
for messages during Emergency mode. So, that SMS_REJECTED action is not broadcasted.
If the result is RESULT_OK from CdmaSMSDispatcher, the function notifyAndAcknowledgeLastIncomingSms()
is not called from SMSDispatcher.java and hence SMS_REJECTED_ACTION intent is not broadcast.
Consequently SMSRejectReceiver.java will not receive the broadcast and will not show reject
notification.
Change-Id: I2aa8f239393b3e6eeac6b0c2bb69799018e9ae9d
Grace Kloba [Thu, 17 Sep 2009 18:01:44 +0000 (11:01 -0700)]
Fix the zoom center. Now there is a titlebar, the zoom center
needs to be adjusted for it as the user really cares the spot
in the document. We need to pin zoom around that spot.
Fix http://b/issue?id=
2126300
Android (Google) Code Review [Thu, 17 Sep 2009 18:53:45 +0000 (14:53 -0400)]
Merge change 25535 into eclair
* changes:
CDMA Check for network duplicate sms
Android (Google) Code Review [Thu, 17 Sep 2009 18:46:45 +0000 (14:46 -0400)]
Merge change 25528 into eclair
* changes:
Another stagefright test-case and ignore end-of-stream notifications while we're flushing.
Android (Google) Code Review [Thu, 17 Sep 2009 18:39:43 +0000 (14:39 -0400)]
Merge change 25490 into eclair
* changes:
Revert "Don't activate keyguard if screen is turned off while proximity sensor is active."
Grace Kloba [Thu, 17 Sep 2009 14:56:48 +0000 (07:56 -0700)]
Don't change the zoom filter during the zoom animation.
Call another invalidate() to draw with the final filters.
This fixed the problem where the end of the zoom animation
is slow and jagged.
Fix http://b/issue?id=
2126523
Andreas Huber [Thu, 17 Sep 2009 18:16:52 +0000 (11:16 -0700)]
Another stagefright test-case and ignore end-of-stream notifications while we're flushing.
Dianne Hackborn [Thu, 17 Sep 2009 17:24:05 +0000 (10:24 -0700)]
Add API to retrieve memory used by running processes.
Change-Id: I9c1935c2ef3c78bd67ec4dfd811a1caaab4514c3
Android (Google) Code Review [Thu, 17 Sep 2009 18:02:06 +0000 (14:02 -0400)]
Merge change 25523 into eclair
* changes:
Add additional error checking, exit early if errors occur.
Jack Palevich [Thu, 17 Sep 2009 17:59:23 +0000 (10:59 -0700)]
Add additional error checking, exit early if errors occur.
Android (Google) Code Review [Thu, 17 Sep 2009 17:58:20 +0000 (13:58 -0400)]
Merge change 25519 into eclair
* changes:
LocationManagerService: Take fix accuracy into account in proximity zone logic.
Yusuf T. Mobile [Tue, 14 Jul 2009 22:46:26 +0000 (15:46 -0700)]
LocationManagerService: Take fix accuracy into account in proximity zone logic.
Fixes http://code.google.com/p/android/issues/detail?id=2002
Change-Id: If2b0665c556269279c5813f2254f9624a556bd92
Signed-off-by: Mike Lockwood <lockwood@android.com>
Android (Google) Code Review [Thu, 17 Sep 2009 17:53:37 +0000 (13:53 -0400)]
Merge change 25414 into eclair
* changes:
refactor copy-and-paste email address filtering code. add a column to Calendar.Events contract class.
Christian Gustafsson [Wed, 16 Sep 2009 00:09:13 +0000 (19:09 -0500)]
CDMA Check for network duplicate sms
In some cases a sms acknowledgement might be lost. The network will then resend
the same sms. These duplicate sms should be acknowledged but not shown to the
user.
C.S0015-B 4.3.1.6 Unique Message Identification.
The fields used to identify a message are:
* Message Identifier,
* Originating Address,
* Originating Subaddress, and
* Message Center Time Stamp.
Since some of the fields are optional, the Teleservice Layer shall use as
many of the fields as are present in the SMS message to determine message
uniqueness. Mobile stations should discard repeated messages.
1. Add a fingerprint function to SmsMessage.java. This returns a byte array
to be used as a unique identifier. Parts that make up the identifier are
the originating address, teleservice id and the bearerdata. Using all of
the bearerdata saves parsing time. There are no random bits allowed in
the standard. This makes binary comparison possible. Using all of the
bearerdata accounts for the message id, smsc timestamp and "... shall
use as many of the fields as are present in the SMS message".
2. Have CdmaSMSDispatcher.dispatchMessage() pull a fingerprint and check if
it matches the last acknowledged fingerprint. When it matches return and
signal that message was handled.
3. Have CdmaSMSDispatcher.acknowledgeLastIncomingSms() take the last
dispatched fingerprint move it to the last acknowledged fingerprint.
Only do this if processing of the sms was successful.
Change-Id: If79f8fe40896cd290940b7ccd5a17531ab937b60