OSDN Git Service

android-x86/frameworks-native.git
5 years agoMerge "libbinder: keep ashmem size >= 0"
Tri Vo [Tue, 5 Feb 2019 21:45:11 +0000 (13:45 -0800)]
Merge "libbinder: keep ashmem size >= 0"
am: 5805df43c8

Change-Id: Id46cf33b6e0d48a1173d39301ffdcde15caff343

5 years agoMerge "libbinder: keep ashmem size >= 0"
Tri Vo [Tue, 5 Feb 2019 21:38:50 +0000 (21:38 +0000)]
Merge "libbinder: keep ashmem size >= 0"

5 years agoMerge "installd_service_test: fix ServiceTest.CreateAppDataSnapshot_ClearsCache"
Nikita Ioffe [Tue, 5 Feb 2019 17:24:10 +0000 (09:24 -0800)]
Merge "installd_service_test: fix ServiceTest.CreateAppDataSnapshot_ClearsCache"
am: 4febfd6da7

Change-Id: I1134649531c898a20d524d26a8d40e63aeec9132

5 years agoMerge "installd_service_test: fix ServiceTest.CreateAppDataSnapshot_ClearsCache"
Treehugger Robot [Tue, 5 Feb 2019 17:00:28 +0000 (17:00 +0000)]
Merge "installd_service_test: fix ServiceTest.CreateAppDataSnapshot_ClearsCache"

5 years agoinstalld_service_test: fix ServiceTest.CreateAppDataSnapshot_ClearsCache
Nikita Ioffe [Sat, 2 Feb 2019 17:26:18 +0000 (17:26 +0000)]
installd_service_test: fix ServiceTest.CreateAppDataSnapshot_ClearsCache

This test is failing on cf_x86_phone-userdebug target, with an error:
Failed copying /data/local/tmp/user_de/0/com.foo to /data/local/tmp/misc_de/0/rollback'

Logs shows that cp fails with "No such file or directory error":
02-05 08:37:49.444 12746 12746 I cp      : cp: /data/local/tmp/misc_de/0/rollback: No such file or directory
02-05 08:37:49.445 12746 12746 I cp      : cp terminated by exit(1)

Testcase is failing, because it doesn't create
/data/local/tmp/misc_de/0/rollback directory. It is hard to spot, because
other testcases in installd_service_test also create that directory, meaning
that depending on the order in which testcases are run,
CreateAppDataSnapshot_ClearsCache will either fail or succeed.

Verified that this is the case by running only
CreateAppDataSnapshot_ClearsCache testcase:
./data/nativetest/installd_service_test/installd_service_test --gtest_filter=*CreateAppDataSnapshot_ClearsCache*

Bug: 123631551
Fixes: 123631551
Test: ./data/nativetest/installd_service_test/installd_service_test --gtest_filter=*CreateAppDataSnapshot_ClearsCache*
Change-Id: I8277efe6076bac28fd07ea3705a21aae6b8cab14

5 years agoMerge "Use sh_binary instead of cc_prebuilt_binary for shell scripts"
Alexander Smundak [Tue, 5 Feb 2019 02:14:38 +0000 (18:14 -0800)]
Merge "Use sh_binary instead of cc_prebuilt_binary for shell scripts"
am: 5a3804f0cb

Change-Id: I1fed184f753e77b04bd2df05fcad6649dcbbc5eb

5 years agoMerge "Use sh_binary instead of cc_prebuilt_binary for shell scripts"
Alexander Smundak [Tue, 5 Feb 2019 02:04:18 +0000 (02:04 +0000)]
Merge "Use sh_binary instead of cc_prebuilt_binary for shell scripts"

5 years agoUse sh_binary instead of cc_prebuilt_binary for shell scripts
Sasha Smundak [Mon, 4 Feb 2019 19:20:58 +0000 (11:20 -0800)]
Use sh_binary instead of cc_prebuilt_binary for shell scripts

Bug: 123829926
Test: treehugger
Change-Id: If9d2da84b30aebf8881c6da12efbe99549f5e0cc

5 years agoMerge "Have `otapreopt_chroot` bind-mount Bionic artifacts from the Runtime APEX."
Roland Levillain [Mon, 4 Feb 2019 13:47:45 +0000 (05:47 -0800)]
Merge "Have `otapreopt_chroot` bind-mount Bionic artifacts from the Runtime APEX."
am: 58ec999387

Change-Id: I8ffdce4c545d838489cf8818ad75a3c9d8e076f2

5 years agoMerge "Have `otapreopt_chroot` bind-mount Bionic artifacts from the Runtime APEX."
Roland Levillain [Mon, 4 Feb 2019 13:40:17 +0000 (13:40 +0000)]
Merge "Have `otapreopt_chroot` bind-mount Bionic artifacts from the Runtime APEX."

5 years agoMerge "Add handling for PH property dex2oat_resolve_startup_strings"
Mathieu Chartier [Sat, 2 Feb 2019 01:24:21 +0000 (17:24 -0800)]
Merge "Add handling for PH property dex2oat_resolve_startup_strings"
am: 25d4688e91

Change-Id: I0a2ec9718664ce5c7664694656e0b6c434589927

5 years agoMerge "Add handling for PH property dex2oat_resolve_startup_strings"
Mathieu Chartier [Sat, 2 Feb 2019 01:14:50 +0000 (01:14 +0000)]
Merge "Add handling for PH property dex2oat_resolve_startup_strings"

5 years agoMerge "Add "ls -l /data/anr" output to bugreport"
Makoto Onuki [Fri, 1 Feb 2019 21:42:34 +0000 (13:42 -0800)]
Merge "Add "ls -l /data/anr" output to bugreport"
am: ec22502dc5

Change-Id: I1299d9f2843a5fe34f038f023b600e61e0142a94

5 years agoMerge "Add "ls -l /data/anr" output to bugreport"
Treehugger Robot [Fri, 1 Feb 2019 21:29:39 +0000 (21:29 +0000)]
Merge "Add "ls -l /data/anr" output to bugreport"

5 years agoAdd handling for PH property dex2oat_resolve_startup_strings
Mathieu Chartier [Thu, 31 Jan 2019 20:59:39 +0000 (12:59 -0800)]
Add handling for PH property dex2oat_resolve_startup_strings

Added unit test to verify the property is passed to the oat file.

Test: adb shell /data/nativetest64/installd_dexopt_test/installd_dexopt_test
Bug: 116059983
Bug: 123524494

Change-Id: Ib4fe5401d58c6ac05ef3011bef04e38d1b6d4ba9

5 years agoMerge "Refactor the APEX package activation/deactivation logic in `otapreopt_chroot`."
Roland Levillain [Fri, 1 Feb 2019 19:29:31 +0000 (11:29 -0800)]
Merge "Refactor the APEX package activation/deactivation logic in `otapreopt_chroot`."
am: fafe4a0ec0

Change-Id: Ied38a0653016a252f42788c6c71c24c0475a21b1

5 years agoAdd "ls -l /data/anr" output to bugreport
Makoto Onuki [Fri, 1 Feb 2019 01:08:59 +0000 (17:08 -0800)]
Add "ls -l /data/anr" output to bugreport

Bug: 123720446
Test: with adb bugreport
Change-Id: I2a00d370b8e61b4f0059cdf2d8d67136968a9f20

5 years agoMerge "Refactor the APEX package activation/deactivation logic in `otapreopt_chroot`."
Roland Levillain [Fri, 1 Feb 2019 16:29:22 +0000 (16:29 +0000)]
Merge "Refactor the APEX package activation/deactivation logic in `otapreopt_chroot`."

5 years agoHave `otapreopt_chroot` bind-mount Bionic artifacts from the Runtime APEX.
Roland Levillain [Thu, 31 Jan 2019 18:30:17 +0000 (18:30 +0000)]
Have `otapreopt_chroot` bind-mount Bionic artifacts from the Runtime APEX.

Have `otapreopt_chroot` bind-mount Bionic artifacts (`linker(64)`,
`libc.so`, `libm.so`, `libdl.so`) from the Runtime APEX
(`/postinstall/apex/com.android.runtime`) into `/postinstall/bionic/`,
much the same way `init` sets up Bionic bind-mounts in the default
mount namespace.

Test: m otapreopt_chroot
Test: A/B OTA update test (asit/dexoptota/self_full).
Bug: 113373927
Bug: 120266448
Change-Id: Ie254a94ae35e62f88375bc89380456f15796566a

5 years agoRefactor the APEX package activation/deactivation logic in `otapreopt_chroot`.
Roland Levillain [Fri, 1 Feb 2019 13:15:58 +0000 (13:15 +0000)]
Refactor the APEX package activation/deactivation logic in `otapreopt_chroot`.

This is in prevision of reusing the package deactivation logic as a
clean-up step upon Bionic bind-mounting failure.

Test: m otapreopt_chroot
Test: A/B OTA update test (asit/dexoptota/self_full).
Bug: 113373927
Bug: 120266448
Change-Id: I17b2d57252af7aca1fc27b4c051d6cc9d373c223

5 years agoMerge "installd: remove restored ce_data if de_data rollback failed"
Nikita Ioffe [Fri, 1 Feb 2019 13:09:34 +0000 (05:09 -0800)]
Merge "installd: remove restored ce_data if de_data rollback failed"
am: 580ae9ca0c

Change-Id: Ibfdb902495de3470e916828572b8712c6b4e016f

5 years agoMerge "installd: remove restored ce_data if de_data rollback failed"
Nikita Ioffe [Fri, 1 Feb 2019 12:59:55 +0000 (12:59 +0000)]
Merge "installd: remove restored ce_data if de_data rollback failed"

5 years agoMerge "installd: Add destroyAppDataSnapshot and corresponding binder API"
Nikita Ioffe [Fri, 1 Feb 2019 12:07:27 +0000 (04:07 -0800)]
Merge "installd: Add destroyAppDataSnapshot and corresponding binder API"
am: 1b3315a657

Change-Id: I3342b12dcabb10795440e95d31f80c237d29e6a7

5 years agoMerge "installd: Add destroyAppDataSnapshot and corresponding binder API"
Nikita Ioffe [Fri, 1 Feb 2019 11:50:12 +0000 (11:50 +0000)]
Merge "installd: Add destroyAppDataSnapshot and corresponding binder API"

5 years agoinstalld: Add destroyAppDataSnapshot and corresponding binder API
Nikita Ioffe [Fri, 25 Jan 2019 13:54:43 +0000 (13:54 +0000)]
installd: Add destroyAppDataSnapshot and corresponding binder API

- destroyAppDataSnapshot: deletes both ce and de snapshots (controlled
  via storageFlags), for ce snapshot fallbacks to deleting it by it's
  inode in case snapshot is not accessible (user hasn't unlocked the
  phone yet).
- snapshotAppData: in case ce snapshot was requested, it will now return
  inode if a folder with the snapshot. Otherwise it will return 0.

Passing ceSnapshotInode to destroyAppDataSnapshot should make logic
inside RollbackManagerService a bit easier. Since it will be able to
delete ce snapshot regardless of user unlocking their phone.

Bug: 112431924
Test: installd_service_test installd_utils_test
Change-Id: I015de12593b87f3000f004cc0a901a9208d0b693
Merged-In: I015de12593b87f3000f004cc0a901a9208d0b693

5 years agoMerge "Installd: Refactor binder tests"
Andreas Gampe [Thu, 31 Jan 2019 22:26:13 +0000 (14:26 -0800)]
Merge "Installd: Refactor binder tests"
am: a60ff681ff

Change-Id: I7ba4b5d8a168ff0b3fa72c9de805bbfc00dce64d

5 years agoMerge "Installd: Refactor binder tests"
Treehugger Robot [Thu, 31 Jan 2019 22:14:21 +0000 (22:14 +0000)]
Merge "Installd: Refactor binder tests"

5 years agoMerge "libbinder_ndk: ScopedAResource into impl namespace"
Steven Moreland [Thu, 31 Jan 2019 19:54:23 +0000 (11:54 -0800)]
Merge "libbinder_ndk: ScopedAResource into impl namespace"
am: 4cf7bb91de

Change-Id: Ic6d7940fc96d8fceb1a083548cbe0f328659d89c

5 years agoMerge "libbinder_ndk: ScopedAResource into impl namespace"
Steven Moreland [Thu, 31 Jan 2019 19:35:33 +0000 (19:35 +0000)]
Merge "libbinder_ndk: ScopedAResource into impl namespace"

5 years agoInstalld: Refactor binder tests
Andreas Gampe [Thu, 31 Jan 2019 17:22:27 +0000 (09:22 -0800)]
Installd: Refactor binder tests

Add helper macros to automatically print return status errors.

Bug: 123631551
Test: atest --test-mapping frameworks/native/cmds/installd
Merged-In: I4ab448fabbab91cc608c318a07f9bf95547062fc
Change-Id: I4ab448fabbab91cc608c318a07f9bf95547062fc

5 years agoMerge "Fix regression in startBugreport flow"
Nandana Dutt [Thu, 31 Jan 2019 13:02:37 +0000 (05:02 -0800)]
Merge "Fix regression in startBugreport flow"
am: 2db5865065

Change-Id: Ib1cddf40717e8888c14d7450874f7395af87a484

5 years agoMerge "Fix regression in startBugreport flow"
Treehugger Robot [Thu, 31 Jan 2019 12:48:36 +0000 (12:48 +0000)]
Merge "Fix regression in startBugreport flow"

5 years agoMerge "Ensure only one bugreport is in progress in dumpstate"
Nandana Dutt [Thu, 31 Jan 2019 10:40:38 +0000 (02:40 -0800)]
Merge "Ensure only one bugreport is in progress in dumpstate"
am: 57928b4fa0

Change-Id: I891e65c16001fa04be3bfd35159da9635120d676

5 years agoMerge "installd: Create "lib" symlink with the correct label."
Nick Kralevich [Thu, 31 Jan 2019 10:33:39 +0000 (02:33 -0800)]
Merge "installd: Create "lib" symlink with the correct label."
am: 1120b649f6

Change-Id: I4fda03a9c6d3d49b314c42ef62ce3e96e6ae3b81

5 years agoMerge "Ensure only one bugreport is in progress in dumpstate"
Nandana Dutt [Thu, 31 Jan 2019 10:31:43 +0000 (10:31 +0000)]
Merge "Ensure only one bugreport is in progress in dumpstate"

5 years agoMerge "installd: Create "lib" symlink with the correct label."
Treehugger Robot [Thu, 31 Jan 2019 10:22:02 +0000 (10:22 +0000)]
Merge "installd: Create "lib" symlink with the correct label."

5 years agoMerge "Add OWNERS to inputflinger"
Michael Wright [Thu, 31 Jan 2019 03:56:14 +0000 (19:56 -0800)]
Merge "Add OWNERS to inputflinger"
am: b4dca46279

Change-Id: Ie442ddfa51c0474036cc864abe454b1bf4404272

5 years agoMerge "Add OWNERS to inputflinger"
Treehugger Robot [Thu, 31 Jan 2019 03:44:38 +0000 (03:44 +0000)]
Merge "Add OWNERS to inputflinger"

5 years agoMerge "libbinder_ndk: remove draft status"
Steven Moreland [Thu, 31 Jan 2019 01:09:31 +0000 (17:09 -0800)]
Merge "libbinder_ndk: remove draft status"
am: d0cc655ec1

Change-Id: Ib49d1778258b550539c000911e86f9e71e3f5bef

5 years agoMerge "libbinder_ndk: remove draft status"
Steven Moreland [Thu, 31 Jan 2019 00:51:57 +0000 (00:51 +0000)]
Merge "libbinder_ndk: remove draft status"

5 years agoAdd OWNERS to inputflinger
Michael Wright [Wed, 30 Jan 2019 22:00:04 +0000 (22:00 +0000)]
Add OWNERS to inputflinger

Test: N/A
Change-Id: If16fbe675557cb01770bdc2d6cbc55c46c384d9c

5 years agoinstalld: Create "lib" symlink with the correct label.
Nick Kralevich [Wed, 30 Jan 2019 20:32:21 +0000 (12:32 -0800)]
installd: Create "lib" symlink with the correct label.

When installing an application which has a 32 bit ABI, system_server
(via installd) creates a compatibility "lib" symlink in the application
home directory. See:

https://android.googlesource.com/platform/frameworks/base/+/d5d7492040c1730899cccef9916541176004635c/services/core/java/com/android/server/pm/PackageManagerService.java#22876
and
https://android.googlesource.com/platform/frameworks/native/+/6b8e52c805f124f8b1d7e511ae68d01d0769c32b/cmds/installd/InstalldNativeService.cpp#2077

When a process creates a filesystem object within a directory, in
inherits the directory type, but DOES NOT inherit the directory MLS
categories. See

* https://www.spinics.net/lists/selinux/msg21893.html
* https://www.spinics.net/lists/selinux/msg21897.html

for more details on this behavior.

Without subsequent fixup, an installd created symlink in an
application home directory will have incorrect SELinux MLS categories,
and as a result, may be unreadable to the application.

Modify installd to assign the "lib" label the same MLS categories as
the enclosing parent directory.

Steps to reproduce:

  1) adb shell
  2) su
  3) ls -laZ /data/data/*/lib

Expected:

  crosshatch:/ # ls -laZ /data/data/*/lib
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0:c177,c256,c512,c768 46 2019-01-30 12:46 /data/data/com.android.chrome/lib -> /system/product_services/app/Chrome/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0:c512,c768           38 2019-01-30 12:46 /data/data/com.android.omadm.service/lib -> /system/priv-app/DMService/lib/arm
  lrwxrwxrwx 1 root root u:object_r:privapp_data_file:s0:c512,c768       54 2019-01-30 12:46 /data/data/com.android.vending/lib -> /system/product_services/priv-app/Phonesky/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0:c141,c256,c512,c768 30 2019-01-30 12:46 /data/data/com.google.android.apps.tycho/lib -> /product/app/Tycho/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0:c512,c768           46 2019-01-30 12:46 /data/data/com.google.android.videos/lib -> /system/product_services/app/Videos/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0:c180,c256,c512,c768 58 2019-01-30 12:46 /data/data/com.google.android.webview/lib -> /system/product_services/app/TrichromeWebView/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0:c512,c768           34 2019-01-30 12:46 /data/data/com.qti.ltebc/lib -> /system/app/QAS_DVC_MSP/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0:c512,c768           38 2019-01-30 12:46 /data/data/com.qualcomm.ltebc_vzw/lib -> /system/app/QAS_DVC_MSP_VZW/lib/arm

Actual:

  crosshatch:/ # ls -laZ /data/data/*/lib
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0     46 2019-01-30 12:36 /data/data/com.android.chrome/lib -> /system/product_services/app/Chrome/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0     38 2019-01-30 12:36 /data/data/com.android.omadm.service/lib -> /system/priv-app/DMService/lib/arm
  lrwxrwxrwx 1 root root u:object_r:privapp_data_file:s0 54 2019-01-30 12:36 /data/data/com.android.vending/lib -> /system/product_services/priv-app/Phonesky/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0     30 2019-01-30 12:36 /data/data/com.google.android.apps.tycho/lib -> /product/app/Tycho/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0     46 2019-01-30 12:36 /data/data/com.google.android.videos/lib -> /system/product_services/app/Videos/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0     58 2019-01-30 12:36 /data/data/com.google.android.webview/lib -> /system/product_services/app/TrichromeWebView/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0     34 2019-01-30 12:36 /data/data/com.qti.ltebc/lib -> /system/app/QAS_DVC_MSP/lib/arm
  lrwxrwxrwx 1 root root u:object_r:app_data_file:s0     38 2019-01-30 12:36 /data/data/com.qualcomm.ltebc_vzw/lib -> /system/app/QAS_DVC_MSP_VZW/lib/arm

Bug: 123350324
Test: manual
Change-Id: Id09846556cb0ba7e39fbc57f9039f072d6a752a1

5 years agolibbinder_ndk: ScopedAResource into impl namespace
Steven Moreland [Wed, 30 Jan 2019 20:29:53 +0000 (12:29 -0800)]
libbinder_ndk: ScopedAResource into impl namespace

This is an implementation detail that may change in the future.

Fixes: 123601615
Test: atest android.binder.cts
Change-Id: I006d8bf8b64228a2cc27bee671b6a9838e8df492

5 years agoFix regression in startBugreport flow
Nandana Dutt [Wed, 30 Jan 2019 13:13:52 +0000 (13:13 +0000)]
Fix regression in startBugreport flow

Ensure what's passed to the background thread is around.

BUG: 123617758
Test: adb shell /data/nativetest64/dumpstate_test/dumpstate_test
Test: manual test of API via a test client
Change-Id: I161c0d378c04cf925778fdb8712b1bd68901fb91

5 years agoMerge "Use screenshot file descriptor if available"
Nandana Dutt [Wed, 30 Jan 2019 11:12:46 +0000 (03:12 -0800)]
Merge "Use screenshot file descriptor if available"
am: 6b8e52c805

Change-Id: Ia7f9f5d192dbbb8409e52a29cb73f9cac532f301

5 years agoMerge "Use screenshot file descriptor if available"
Nandana Dutt [Wed, 30 Jan 2019 10:55:37 +0000 (10:55 +0000)]
Merge "Use screenshot file descriptor if available"

5 years agolibbinder: keep ashmem size >= 0
Tri Vo [Tue, 29 Jan 2019 21:23:46 +0000 (13:23 -0800)]
libbinder: keep ashmem size >= 0

Avoid integer overflow.

Bug: 123590642
Test: device boots
Change-Id: I9f25827842da00c4e69efca849c6a94721964007

5 years agoMerge "Fix/suppress google-explicit-constructor warnings"
Chih-Hung Hsieh [Wed, 30 Jan 2019 02:15:19 +0000 (18:15 -0800)]
Merge "Fix/suppress google-explicit-constructor warnings"
am: c4f5492a93

Change-Id: I83d4cd5f62103b74f3dcf007b80fd8162e4727f7

5 years agoMerge "Fix/suppress google-explicit-constructor warnings"
Treehugger Robot [Wed, 30 Jan 2019 01:58:55 +0000 (01:58 +0000)]
Merge "Fix/suppress google-explicit-constructor warnings"

5 years agoFix/suppress google-explicit-constructor warnings
Chih-Hung Hsieh [Thu, 20 Dec 2018 23:54:30 +0000 (15:54 -0800)]
Fix/suppress google-explicit-constructor warnings

* Use NOLINT or NOLINTNEXTLINE to suppress warnings on intended converters

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: I5c73437ecee0d672863664cc8c2970b099597f77

5 years agoMerge "installd: clear app's cache before doing a snapshot"
Nikita Ioffe [Tue, 29 Jan 2019 21:24:08 +0000 (13:24 -0800)]
Merge "installd: clear app's cache before doing a snapshot"
am: 3163e53e92

Change-Id: Id15e016045b9c7204c9865ee168e7c938aac7056

5 years agoMerge "installd: clear app's cache before doing a snapshot"
Treehugger Robot [Tue, 29 Jan 2019 21:11:50 +0000 (21:11 +0000)]
Merge "installd: clear app's cache before doing a snapshot"

5 years agolibbinder_ndk: remove draft status
Steven Moreland [Tue, 29 Jan 2019 19:51:13 +0000 (11:51 -0800)]
libbinder_ndk: remove draft status

So that it is included in future NDK releases.

Fixes: 123299014
Test: N/A
Change-Id: I118b3190ce01147af84a33156ac01cdcde54a20d

5 years agoMerge "Restore security context of `/postinstall/apex` earlier in otapreopt_chroot."
Roland Levillain [Tue, 29 Jan 2019 18:20:50 +0000 (10:20 -0800)]
Merge "Restore security context of `/postinstall/apex` earlier in otapreopt_chroot."
am: d1569ad004

Change-Id: If70d3c2e3b2e51aa4e41f88c4623692a40fa052a

5 years agoMerge "Restore security context of `/postinstall/apex` earlier in otapreopt_chroot."
Roland Levillain [Tue, 29 Jan 2019 18:07:59 +0000 (18:07 +0000)]
Merge "Restore security context of `/postinstall/apex` earlier in otapreopt_chroot."

5 years agoUse screenshot file descriptor if available
Nandana Dutt [Tue, 29 Jan 2019 16:10:45 +0000 (16:10 +0000)]
Use screenshot file descriptor if available

Test: adb shell /data/nativetest64/dumpstate_test/dumpstate_test
BUG: 123576130
Fixes: 123576130

Change-Id: I2ac2dc3bfc7920a00e4148ca29169c171558de3a

5 years agoEnsure only one bugreport is in progress in dumpstate
Nandana Dutt [Tue, 29 Jan 2019 15:59:38 +0000 (15:59 +0000)]
Ensure only one bugreport is in progress in dumpstate

BUG: 123571915
Test: current bugreport flows work
Test: interactive bugreport
Test: adb shell /data/nativetest64/dumpstate_test/dumpstate_test
Test: adb shell /data/nativetest64/dumpstate_smoke_test/dumpstate_smoke_test
Change-Id: I1145a27ed6dde43142789d876902e32d1a286bb2

5 years agoMerge "Convert Android.mk file to Android.bp"
Sasha Smundak [Tue, 29 Jan 2019 16:12:31 +0000 (08:12 -0800)]
Merge "Convert Android.mk file to Android.bp"
am: 058cb93644

Change-Id: I65c74c81e932b3fcb08f80f4c6454d960943811d

5 years agoMerge "Convert Android.mk file to Android.bp"
Treehugger Robot [Tue, 29 Jan 2019 15:56:47 +0000 (15:56 +0000)]
Merge "Convert Android.mk file to Android.bp"

5 years agoinstalld: clear app's cache before doing a snapshot
Nikita Ioffe [Wed, 23 Jan 2019 14:32:48 +0000 (14:32 +0000)]
installd: clear app's cache before doing a snapshot

Bug: 112431924
Test: installd_service_test
Change-Id: I4a6c3bbf071dcee007e48ece40e5009c1a43ecca

5 years agoMerge "installd: Validate volumeUuid in snapshotAppData and restoreAppDataSnapshot"
Nikita Ioffe [Tue, 29 Jan 2019 11:30:13 +0000 (03:30 -0800)]
Merge "installd: Validate volumeUuid in snapshotAppData and restoreAppDataSnapshot"
am: 2470dd34e8

Change-Id: I469e9d9353b0c74483ba2665d69db257177f0c5f

5 years agoMerge "installd: Validate volumeUuid in snapshotAppData and restoreAppDataSnapshot"
Treehugger Robot [Tue, 29 Jan 2019 11:13:16 +0000 (11:13 +0000)]
Merge "installd: Validate volumeUuid in snapshotAppData and restoreAppDataSnapshot"

5 years agoMerge "Add vendor dumpsys."
Steven Moreland [Tue, 29 Jan 2019 05:09:24 +0000 (21:09 -0800)]
Merge "Add vendor dumpsys."
am: f9a1f695d3

Change-Id: Iedff3f7710b26aa6853a5e06b371ad91ade8ab3c

5 years agoMerge "Update filesystem permissions for task tracepoints."
Carmen Jackson [Tue, 29 Jan 2019 04:56:08 +0000 (20:56 -0800)]
Merge "Update filesystem permissions for task tracepoints."
am: 50ef7e0df8

Change-Id: I85478faa82eb78b96d1a5b7e3615fa4addd3a936

5 years agoMerge "Remove unused DumpstateOptions parcel"
Nandana Dutt [Tue, 29 Jan 2019 03:52:24 +0000 (19:52 -0800)]
Merge "Remove unused DumpstateOptions parcel"
am: 73bc78fe43

Change-Id: I43c6252c88fa954e9be08bff4989e04737570e2c

5 years agoMerge "Add vendor dumpsys."
Treehugger Robot [Tue, 29 Jan 2019 01:46:08 +0000 (01:46 +0000)]
Merge "Add vendor dumpsys."

5 years agoRestore security context of `/postinstall/apex` earlier in otapreopt_chroot.
Roland Levillain [Thu, 24 Jan 2019 10:51:30 +0000 (10:51 +0000)]
Restore security context of `/postinstall/apex` earlier in otapreopt_chroot.

Invoke `selinux_android_restorecon` on `/postinstall/apex` just after
mounting a tmpfs filesystem in it, so that this directory is correctly
labeled (with type `postinstall_apex_mnt_dir`) and may be manipulated
in following operations (`chmod`, `chown`, etc.) following updated
policies restricted to `postinstall_apex_mnt_dir` (instead of
`tmpfs`).

Test: m otapreopt_chroot
Test: A/B OTA update test (asit/dexoptota/self_full).
Bug: 113373927
Bug: 120796514
Change-Id: I0b243a00e0443e439afda055d3b12aa9eefe0503

5 years agoMerge "Update filesystem permissions for task tracepoints."
Treehugger Robot [Mon, 28 Jan 2019 22:04:58 +0000 (22:04 +0000)]
Merge "Update filesystem permissions for task tracepoints."

5 years agoinstalld: Validate volumeUuid in snapshotAppData and restoreAppDataSnapshot
Nikita Ioffe [Mon, 21 Jan 2019 17:56:03 +0000 (17:56 +0000)]
installd: Validate volumeUuid in snapshotAppData and restoreAppDataSnapshot

Only supported values are nullptr and "TEST".

Bug: 112431924
Test: installd_service_test
Change-Id: I27260a3554d009053206d8e3d1e213306ff3d7d5

5 years agoUpdate filesystem permissions for task tracepoints.
Carmen Jackson [Fri, 25 Jan 2019 01:31:25 +0000 (17:31 -0800)]
Update filesystem permissions for task tracepoints.

These tracepoints are used for memory debugging, and should be enabled
for user builds.

Bug: 123367055
Test: manual: took a trace with Traceur and verified that these
tracepoints appear.

Change-Id: I31fafc11d60a96f2a4c58f2670decb2480c0ec78
Merged-In: I31fafc11d60a96f2a4c58f2670decb2480c0ec78

5 years agoMerge "Remove unused DumpstateOptions parcel"
Nandana Dutt [Mon, 28 Jan 2019 17:20:45 +0000 (17:20 +0000)]
Merge "Remove unused DumpstateOptions parcel"

5 years agoMerge "installd: clear existing snapshots before performing a new one"
Nikita Ioffe [Mon, 28 Jan 2019 12:20:53 +0000 (04:20 -0800)]
Merge "installd: clear existing snapshots before performing a new one"
am: 0b643d5117

Change-Id: I8a481ad56250acaf90150ec3e1392fda40c8e0ba

5 years agoMerge "installd: clear existing snapshots before performing a new one"
Nikita Ioffe [Mon, 28 Jan 2019 12:09:47 +0000 (12:09 +0000)]
Merge "installd: clear existing snapshots before performing a new one"

5 years agoRemove unused DumpstateOptions parcel
Nandana Dutt [Fri, 16 Nov 2018 17:28:25 +0000 (17:28 +0000)]
Remove unused DumpstateOptions parcel

Now using bugreport mode to indicate runtime options.

BUG: 111441001
Test: adb shell /data/nativetest64/dumpstate_test/dumpstate_test
Change-Id: I1890323394a5f146a8e0e971914b8b7437e75547

5 years agoMerge "Load libandroid_runtime lazily."
Steven Moreland [Sat, 26 Jan 2019 03:43:24 +0000 (19:43 -0800)]
Merge "Load libandroid_runtime lazily."
am: 5a8d6ccb0f

Change-Id: I31fe8e26e6c24d77b5119f3ce976d21cd7118ecf

5 years agoMerge "Load libandroid_runtime lazily."
Steven Moreland [Sat, 26 Jan 2019 03:28:52 +0000 (03:28 +0000)]
Merge "Load libandroid_runtime lazily."

5 years agoAdd vendor dumpsys.
Steven Moreland [Sat, 26 Jan 2019 03:14:27 +0000 (19:14 -0800)]
Add vendor dumpsys.

$ adb shell /vendor/bin/dumpsys -l
<hangs>
$ adb shell /vendor/bin/sh -c "/vendor/bin/dumpsys -l"
Currently running services:
...
$ adb root
$ adb shell /vendor/bin/dumpsys -l
Currently running services:
...

Bug: 123433249
Test: manual (see above)
Change-Id: I4d74be3ef43e7d65154be27c4cf85ab32e09dfef

5 years agoLoad libandroid_runtime lazily.
Steven Moreland [Wed, 23 Jan 2019 00:02:02 +0000 (16:02 -0800)]
Load libandroid_runtime lazily.

Memory/performance for low-level processes that do not need this.

Bug: 118783779 # follow-up to cleanup
Bug: 123284997
Test: atest android.binder.cts
Change-Id: Ie8de0a082dfb75786a45a448185fedb317daa94e

5 years agoConvert Android.mk file to Android.bp
Sasha Smundak [Fri, 25 Jan 2019 07:20:47 +0000 (23:20 -0800)]
Convert Android.mk file to Android.bp

See build/soong/README.md for more information.

Bug: 122332691
Test: treehugger
Change-Id: I2146596aad99baa128511d07ab73470885319d49

5 years agoMerge "Add jwcai and tianyuj to the owner's file of libs/ui"
Jiwen Cai [Fri, 25 Jan 2019 18:57:05 +0000 (10:57 -0800)]
Merge "Add jwcai and tianyuj to the owner's file of libs/ui"
am: c7756aa898

Change-Id: Ic7e86ff07d95f8242b894e22e695425837070311

5 years agoMerge "Add jwcai and tianyuj to the owner's file of libs/ui"
Jiwen Cai [Fri, 25 Jan 2019 18:42:22 +0000 (18:42 +0000)]
Merge "Add jwcai and tianyuj to the owner's file of libs/ui"

5 years ago[automerger skipped] Merge "DO NOT MERGE: Revert "Revert "Add libprocessgroup depende...
Suren Baghdasaryan [Fri, 25 Jan 2019 17:20:12 +0000 (09:20 -0800)]
[automerger skipped] Merge "DO NOT MERGE: Revert "Revert "Add libprocessgroup dependency and fix sched_policy include"""
am: bb60500006 -s ours
am skip reason: subject contains skip directive

Change-Id: I4d5aa9919338b99dec2bf4696e3559461748cf70

5 years agoMerge "DO NOT MERGE: Revert "Revert "Add libprocessgroup dependency and fix sched_pol...
Suren Baghdasaryan [Fri, 25 Jan 2019 17:09:02 +0000 (17:09 +0000)]
Merge "DO NOT MERGE: Revert "Revert "Add libprocessgroup dependency and fix sched_policy include"""

5 years agoDO NOT MERGE: Revert "Revert "Add libprocessgroup dependency and fix sched_policy...
Suren Baghdasaryan [Fri, 25 Jan 2019 05:29:23 +0000 (05:29 +0000)]
DO NOT MERGE: Revert "Revert "Add libprocessgroup dependency and fix sched_policy include""

This reverts commit f145309d9c1549b06029bb00a3d5fe2bf459ed02.

Reason for revert: AOSP is fixed with new vendor image

Change-Id: If522adf1ea36e7792b1ae26234ec2bdb2756bdfd
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
5 years agoinstalld: remove restored ce_data if de_data rollback failed
Nikita Ioffe [Fri, 25 Jan 2019 11:44:36 +0000 (11:44 +0000)]
installd: remove restored ce_data if de_data rollback failed

I think it's clearer (and safer) if failed rollback leaves app devoid of
any data rather that with only ce_data.
LMK if you disagree, I will just abandon this change then. :)

I tried adding a test to make de_rollback fail (while keeping
ce_rollback successful), but failed to.
Only idea I have in mind is to intercept calls to /system/bin/cp, which
doesn't look like a unit test anymore (and also I'm not sure how
feasible it is).

Test: existing tests in installd_service_test pass
Bug: 112431924

Change-Id: I3c6214d70bac682874ea846a01294b5361470f93

5 years agoinstalld: clear existing snapshots before performing a new one
Nikita Ioffe [Wed, 23 Jan 2019 16:32:13 +0000 (16:32 +0000)]
installd: clear existing snapshots before performing a new one

Bug: 112431924
Test: installd_service_test
Change-Id: I23a97f113e8a7423a7c509ee06d1436a2c2c961f

5 years agoMerge "Refactor paths to Android Runtime binaries in directory `cmds/installd/`."
Roland Levillain [Fri, 25 Jan 2019 12:36:35 +0000 (04:36 -0800)]
Merge "Refactor paths to Android Runtime binaries in directory `cmds/installd/`."
am: 415bf00873

Change-Id: I8fb4d4114fea2ea1ba2814cc1830b350e0c30c1b

5 years agoMerge "Refactor paths to Android Runtime binaries in directory `cmds/installd/`."
Roland Levillain [Fri, 25 Jan 2019 12:23:17 +0000 (12:23 +0000)]
Merge "Refactor paths to Android Runtime binaries in directory `cmds/installd/`."

5 years agoMerge changes from topics "runtime-apex-otapreopt_chroot-tear-down", "runtime-apex...
Roland Levillain [Fri, 25 Jan 2019 12:07:57 +0000 (04:07 -0800)]
Merge changes from topics "runtime-apex-otapreopt_chroot-tear-down", "runtime-apex-installd-support", "runtime-apex-otapreopt_chroot-support"
am: 9e346da01b

Change-Id: I946d33be30c9bfb1ebd738cc936c9c0fbaa61199

5 years agoMerge changes from topics "runtime-apex-otapreopt_chroot-tear-down", "runtime-apex...
Roland Levillain [Fri, 25 Jan 2019 11:56:30 +0000 (11:56 +0000)]
Merge changes from topics "runtime-apex-otapreopt_chroot-tear-down", "runtime-apex-installd-support", "runtime-apex-otapreopt_chroot-support"

* changes:
  Implement a tear-down phase in otapreopt_chroot.
  Revert^2 "Have installd use ART binaries from the Android Runtime APEX."
  Revert^2 "Have `otapreopt_chroot` mount APEX packages in the chroot dir."

5 years agoMerge "Use the consent service to check if user has consented to taking a bugreport"
Nandana Dutt [Thu, 24 Jan 2019 15:29:02 +0000 (07:29 -0800)]
Merge "Use the consent service to check if user has consented to taking a bugreport"
am: 7f2f2f20ca

Change-Id: Ia6901274f3ecf9516795b76de1f30abf58c6ea20

5 years agoMerge "Use the consent service to check if user has consented to taking a bugreport"
Treehugger Robot [Thu, 24 Jan 2019 15:14:05 +0000 (15:14 +0000)]
Merge "Use the consent service to check if user has consented to taking a bugreport"

5 years agoMerge "Add IIncidentCompanion binder API."
Joe Onorato [Thu, 24 Jan 2019 12:28:59 +0000 (04:28 -0800)]
Merge "Add IIncidentCompanion binder API."
am: b5fd6ace3e

Change-Id: I13b8b2c2e60d56635ad66c376f68a0a016eff2b1

5 years agoUse the consent service to check if user has consented to taking a
Nandana Dutt [Fri, 18 Jan 2019 17:13:52 +0000 (17:13 +0000)]
Use the consent service to check if user has consented to taking a
bugreport

Test: verified current flows of bugreport generation still work
Test: TBD test the new flow
Change-Id: I5fc154905515db664f76d1453c9d79364dc2f01e

5 years agoMerge "Add IIncidentCompanion binder API."
Treehugger Robot [Thu, 24 Jan 2019 12:16:35 +0000 (12:16 +0000)]
Merge "Add IIncidentCompanion binder API."

5 years agoMerge "installd: Implement support for userdata snapshot and restore."
Narayan Kamath [Thu, 24 Jan 2019 10:32:53 +0000 (02:32 -0800)]
Merge "installd: Implement support for userdata snapshot and restore."
am: 1f34244f97

Change-Id: If67275c2d9034ceae70219404a5716d7360f5f4d

5 years agoMerge "installd: Implement support for userdata snapshot and restore."
Narayan Kamath [Thu, 24 Jan 2019 10:25:00 +0000 (10:25 +0000)]
Merge "installd: Implement support for userdata snapshot and restore."

5 years ago[automerger skipped] Merge "DO NOT MERGE: Revert "Add libprocessgroup dependency...
Suren Baghdasaryan [Thu, 24 Jan 2019 07:07:57 +0000 (23:07 -0800)]
[automerger skipped] Merge "DO NOT MERGE: Revert "Add libprocessgroup dependency and fix sched_policy include""
am: 9c57f3bf98 -s ours
am skip reason: subject contains skip directive

Change-Id: I3d84ee2904faf8a8d6e12ad7bde97d85a2f7d686

5 years agoMerge "DO NOT MERGE: Revert "Add libprocessgroup dependency and fix sched_policy...
Suren Baghdasaryan [Thu, 24 Jan 2019 06:57:55 +0000 (06:57 +0000)]
Merge "DO NOT MERGE: Revert "Add libprocessgroup dependency and fix sched_policy include""

5 years agoMerge "Add FEATURE_TELEPHONY_IMS feature definition"
Brad Ebinger [Thu, 24 Jan 2019 05:02:43 +0000 (21:02 -0800)]
Merge "Add FEATURE_TELEPHONY_IMS feature definition"
am: be07f77163

Change-Id: Ie460f8f61cd5474f8a4cedc88b1bffb2af9ad30a