OSDN Git Service
Elliott Hughes [Mon, 25 Jan 2016 18:31:35 +0000 (18:31 +0000)]
Merge "Add another stdio test."
Elliott Hughes [Sat, 23 Jan 2016 04:50:40 +0000 (04:50 +0000)]
Merge "Put struct FILE back how NDK-built apps expect it."
Elliott Hughes [Sat, 23 Jan 2016 03:18:48 +0000 (19:18 -0800)]
Put struct FILE back how NDK-built apps expect it.
The first rule of stdio is you never change struct FILE. This broke all
NDK-built apps that used stdin/stdout/stderr. (Which is more than you
might think, given that those streams don't go anywhere useful. Svelte!)
I've added a big code comment because I knew when I removed the field that
doing so was a mistake, but I couldn't think why.
Bug: http://b/
24807045
Bug: http://b/
26747402
Change-Id: Ie1233586b223bb1cdf8e354c66d5ff23487a833a
Elliott Hughes [Sat, 23 Jan 2016 03:22:44 +0000 (19:22 -0800)]
Add another stdio test.
This test didn't catch anything, but it does ensure that we exercise
the "lots of files" case.
Bug: http://b/
26747402
Change-Id: I6c51c6436029572a49190d509f131eb93b808652
Dimitry Ivanov [Fri, 22 Jan 2016 18:38:08 +0000 (18:38 +0000)]
Merge "Revert "Temporary apply LIBC version to __pthread_gettid""
Elliott Hughes [Fri, 22 Jan 2016 03:19:20 +0000 (03:19 +0000)]
Merge "Loosen up sys_time.gettimeofday."
Dimitry Ivanov [Thu, 21 Jan 2016 22:25:32 +0000 (22:25 +0000)]
Revert "Temporary apply LIBC version to __pthread_gettid"
This reverts commit
0ef1d121b5e4845f4ef3b59ae9a1f99ceb531186.
Bug: http://b/
26392296
Bug: http://b/
26391427
Change-Id: I7bbb555de3a43813e7623ff6ad4e17874d283eca
Dimitry Ivanov [Fri, 22 Jan 2016 01:41:27 +0000 (01:41 +0000)]
Merge "libc: hide __signalfd4 symbol"
Dimitry Ivanov [Fri, 22 Jan 2016 01:40:45 +0000 (01:40 +0000)]
Merge "libc: hide fake_gmtime_r and fake_localtime_r"
Elliott Hughes [Fri, 22 Jan 2016 00:43:43 +0000 (16:43 -0800)]
Loosen up sys_time.gettimeofday.
We've seen it take 1146us on Nexus 9 (which did have exceptionally slow
system calls).
Bug: http://b/
26724042
Change-Id: I263b7e1267d58fe4a6528403d03e5b245fdcd528
Dimitry Ivanov [Fri, 22 Jan 2016 00:05:23 +0000 (16:05 -0800)]
libc: hide fake_gmtime_r and fake_localtime_r
Bug: http://b/
26274444
Change-Id: Icf96a00142a287d8d3466d2545e213e605601b42
Dimitry Ivanov [Thu, 21 Jan 2016 23:23:49 +0000 (23:23 +0000)]
Merge "linker: align allocated blocks to 16 bytes"
Dimitry Ivanov [Thu, 21 Jan 2016 23:19:52 +0000 (15:19 -0800)]
libc: hide __signalfd4 symbol
Bug: http://b/
26274444
Change-Id: Iaa2df640cac07e2e407ca11b9701ee9e11729146
Dimitry Ivanov [Thu, 21 Jan 2016 18:55:40 +0000 (10:55 -0800)]
linker: align allocated blocks to 16 bytes
C/C++ requires the result of malloc/new to be
aligned for any primitive type.
Change-Id: I715b7679e738f34b3b409993fb3ef242e1321b7f
Elliott Hughes [Thu, 21 Jan 2016 18:35:18 +0000 (18:35 +0000)]
Merge "Simplify fseek/ftell."
Elliott Hughes [Thu, 21 Jan 2016 01:14:53 +0000 (17:14 -0800)]
Simplify fseek/ftell.
Another step towards _FILE_OFFSET_BITS=64 support.
Bug: http://b/
24807045
Change-Id: I00b83c81a7b108176c4d9437bc32611f73b7e967
Christopher Ferris [Thu, 21 Jan 2016 18:31:12 +0000 (18:31 +0000)]
Merge "Remove dependency on zipalign."
Dimitry Ivanov [Thu, 21 Jan 2016 05:30:31 +0000 (05:30 +0000)]
Merge "Do not unmap reserved region on dlclose"
Dimitry Ivanov [Fri, 15 Jan 2016 19:13:35 +0000 (11:13 -0800)]
Do not unmap reserved region on dlclose
dlclose used to unmap the part of the reserved region
for ANDROID_DLEXT_RESERVED_ADDRESS that was neccessary
to map PT_LOAD segments. With this change dlclose
replaces mapped PT_LOAD segments with a PROT_NONE,
MAP_ANONYMOUS | MAP_NORESERVE.
Previously caller was unmapping the reserved region after
the failed dlclose which led to race condition when someone
else reused the region freed by dlclose but before the unmap
by the chromium code.
Bug: http://code.google.com/p/chromium/issues/detail?id=568880
Change-Id: I0f5eaa2bf6641f83dde469b631c518482acc59a2
Christopher Ferris [Wed, 20 Jan 2016 04:32:37 +0000 (20:32 -0800)]
Remove dependency on zipalign.
Roll our own version of zipalign so that we can break the dependency
on the build tools zipalign. This breaks the transitive dependency
on androidfw so that building bionic unit tests in brillo works again.
Also modify the DlExtTest.ExtInfoUseFdWithOffset test so it dynamically
gets the offset of the shared library inside of the zip instead of
hard-coding the value.
Bug:
25446938
Change-Id: Idfb5d3089960a94eefa2c76e03da1ad2f4d7fb2f
Elliott Hughes [Wed, 20 Jan 2016 23:07:50 +0000 (23:07 +0000)]
Merge "Move stdio implementation details around a little."
Colin Cross [Wed, 20 Jan 2016 21:10:34 +0000 (21:10 +0000)]
Merge "Update Android.bp to match Android.mk"
Colin Cross [Wed, 20 Jan 2016 20:01:19 +0000 (12:01 -0800)]
Update Android.bp to match Android.mk
Change-Id: Ia14a7af94d6220b3078b8d37b76990454b16703c
Colin Cross [Wed, 20 Jan 2016 19:58:16 +0000 (19:58 +0000)]
Merge "Update Android.bp to match Android.mk"
Elliott Hughes [Wed, 20 Jan 2016 00:28:15 +0000 (16:28 -0800)]
Move stdio implementation details around a little.
Change-Id: I24594426d5479bdd55cbef0ab1b7d76c249dbd0c
Elliott Hughes [Wed, 20 Jan 2016 00:13:45 +0000 (00:13 +0000)]
Merge "Make FILE*s less usable after fclose(3)."
Elliott Hughes [Tue, 19 Jan 2016 23:46:05 +0000 (15:46 -0800)]
Make FILE*s less usable after fclose(3).
BSD doesn't invalidate the fd stored in struct FILE, which can make
it possible (via fileno(3), for example), to perform operations on
an fd you didn't intend to (rather than just failing with EBADF).
Fixing this makes the code slightly simpler anyway, and might help
catch bad code before it ships.
Bug: http://stackoverflow.com/questions/
10816837/fclose-works-differently-on-android-and-linux
Change-Id: I9db74584038229499197a2695c70b58ed0372a87
Colin Cross [Tue, 19 Jan 2016 20:50:20 +0000 (12:50 -0800)]
Update Android.bp to match Android.mk
Change-Id: Ib6ab28c5b4569c9537c4647b3661166fdb82544a
Chih-hung Hsieh [Tue, 19 Jan 2016 20:04:47 +0000 (20:04 +0000)]
Merge "Switch libc default to clang."
Chih-Hung Hsieh [Tue, 19 Jan 2016 18:59:34 +0000 (10:59 -0800)]
Switch libc default to clang.
* Default to clang when USE_CLANG_PLATFORM_BUILD is not set
and the target has no clang bug.
BUG:
26102335
Change-Id: Ied6c9dc5593bfbadbb8d8b38e66ea237d649bae5
Elliott Hughes [Tue, 19 Jan 2016 17:48:28 +0000 (17:48 +0000)]
Merge "Fix GCC build breakage."
Elliott Hughes [Tue, 19 Jan 2016 17:47:47 +0000 (09:47 -0800)]
Fix GCC build breakage.
Change-Id: I0339f525c68af942fb97f4bffc771717e67e0e07
Elliott Hughes [Tue, 19 Jan 2016 17:25:01 +0000 (17:25 +0000)]
Merge "Add more fortify symbols to the expected differences from glibc."
Elliott Hughes [Tue, 19 Jan 2016 17:24:16 +0000 (17:24 +0000)]
Merge "Implement if_nameindex(3)/if_freenameindex(3)."
Elliott Hughes [Sat, 16 Jan 2016 05:02:56 +0000 (21:02 -0800)]
Implement if_nameindex(3)/if_freenameindex(3).
This is just a subset of the recently-implemented getifaddrs(3), though if
we want to handle interfaces (such as "rmnet_*") that don't have an address,
we need to either expose ifaddrs_storage and keep track of which interfaces
we've already seen (which is pretty messy), or refactor the netlink code so
we can reuse it and just extract the information we need for if_nameindex(3).
This patch goes the latter route.
Also clean up if_nametoindex(3) and if_indextoname(3).
Change-Id: I5ffc5df0bab62286cdda2e7af06f032c767119a8
Yi Kong [Sun, 17 Jan 2016 22:48:36 +0000 (22:48 +0000)]
Merge "Add more tests for getifaddrs(3)"
Elliott Hughes [Sat, 16 Jan 2016 03:54:31 +0000 (19:54 -0800)]
Add more fortify symbols to the expected differences from glibc.
Change-Id: I6266b2e6cbea3c014b4ea30a7100186965e40cf1
Elliott Hughes [Sat, 16 Jan 2016 03:02:06 +0000 (03:02 +0000)]
Merge "Sync with upstream OpenBSD."
Dan Willemsen [Sat, 16 Jan 2016 00:47:39 +0000 (00:47 +0000)]
Merge "Align Soong builds closer to Make"
Elliott Hughes [Sat, 16 Jan 2016 00:30:18 +0000 (16:30 -0800)]
Sync with upstream OpenBSD.
Also some minor build cleanup.
Change-Id: Ibd20602d7ea45685f0c47fceb00ffd6c7ae35954
Dan Willemsen [Sat, 16 Jan 2016 00:00:57 +0000 (16:00 -0800)]
Align Soong builds closer to Make
This moves the Android.bp file to use wildcards in the same places that
they're using in the Android.mk file. It also fixes a file that was in a
different order.
Make and Soong still produce binaries with object files in different
orders, but that's due to Make reordering the object files based on
compile type. Soong keeps the original specified order. It's not
possible to emulate the reordered files in the Android.bp, since the
arch-specific files won't interleave properly.
Change-Id: I9052b3ed7c523c13df5cbe606f913c32c88c7c5f
Christopher Ferris [Thu, 14 Jan 2016 20:04:29 +0000 (20:04 +0000)]
Merge "Add comment for [p]select_smoke tests STDIN issue."
Christopher Ferris [Thu, 14 Jan 2016 19:12:38 +0000 (11:12 -0800)]
Add comment for [p]select_smoke tests STDIN issue.
Change-Id: I59cde8b5aaac3e27419ca86d16f85e5af568acf9
Yi Kong [Wed, 13 Jan 2016 11:28:14 +0000 (11:28 +0000)]
Add more tests for getifaddrs(3)
This adds the following two checks:
* getifaddrs sees the same list of interfaces as /sys/class/net.
* IPv4 addresses we get from netdevice(7) agrees with results from
getifaddrs.
Change-Id: I2f6d79d0b5cde6d98a0f671d1623b6b2bc75b60f
Dan Willemsen [Thu, 14 Jan 2016 08:16:02 +0000 (08:16 +0000)]
Merge "Fix Soong mips builds"
Dan Willemsen [Thu, 14 Jan 2016 07:22:22 +0000 (23:22 -0800)]
Fix Soong mips builds
Change-Id: I6ae8208e077d831969b08e7abd232deaa20ceca1
Christopher Ferris [Thu, 14 Jan 2016 07:04:53 +0000 (07:04 +0000)]
Merge "Fix select failures when STDIN is ready."
Christopher Ferris [Thu, 14 Jan 2016 06:38:09 +0000 (22:38 -0800)]
Fix select failures when STDIN is ready.
The select_smoke and pselect_smoke test can fail if STDIN has data ready
to be read. The easiest way to see the failure is to type on the command
line while running the tests.
To avoid this, allow the return value to be 2 or 3 and check which fds
are ready to be read.
Change-Id: Iafba332c5f3ed1943e3d34501f123dd45f06a8c4
Dan Albert [Thu, 14 Jan 2016 06:12:32 +0000 (06:12 +0000)]
Merge "Escape failure messages in XML test output."
Dan Albert [Thu, 14 Jan 2016 05:48:56 +0000 (21:48 -0800)]
Escape failure messages in XML test output.
The gtest XML format requires escaped HTML characters in the test
results.
Change-Id: Ieb9519a55cb52093dfb10a88e883b569bc372cdb
Christopher Ferris [Thu, 14 Jan 2016 05:16:33 +0000 (05:16 +0000)]
Merge "Add method to run fortified versions of funcs."
Christopher Ferris [Wed, 13 Jan 2016 21:47:58 +0000 (13:47 -0800)]
Add method to run fortified versions of funcs.
Add a way to turn fortify off for the files that test fortify functions.
This method involves simply compiling the same file with fortify off and
changing the test name slightly.
It's not very pretty, and it assumes that only these few files test
functions that can be fortified.
Bug:
15195631
Change-Id: Iba9db1d508b7d28a1d6968019cb70fe08864827b
Dan Willemsen [Wed, 13 Jan 2016 21:45:14 +0000 (21:45 +0000)]
Merge "Fix Soong x86 builds"
Dan Willemsen [Wed, 13 Jan 2016 21:36:11 +0000 (13:36 -0800)]
Fix Soong x86 builds
Change-Id: Ida3f3584f832d61caf7200557ea57be799eaf38e
Dimitry Ivanov [Wed, 13 Jan 2016 20:35:25 +0000 (20:35 +0000)]
Merge "Revert "Move __system_property* to LIBC_PRIVATE for lp64 libc""
Dimitry Ivanov [Wed, 13 Jan 2016 20:32:12 +0000 (20:32 +0000)]
Revert "Move __system_property* to LIBC_PRIVATE for lp64 libc"
This reverts commit
ff14fb5a1f809d87125fa0d14f08d486b6bf1ea1.
Bug: http://b/
26497521
Change-Id: Id7131b37a31e936db0e72ef9969e1f13d2dd578f
Colin Cross [Wed, 13 Jan 2016 20:32:09 +0000 (20:32 +0000)]
Merge "Rearrange build files to support USE_SOONG=true"
Dan Willemsen [Wed, 13 Jan 2016 20:32:07 +0000 (20:32 +0000)]
Merge "Fix Soong x86 atom builds"
Colin Cross [Wed, 13 Jan 2016 20:31:39 +0000 (20:31 +0000)]
Merge "Update Android.bp for changes to Android.mk"
Dan Willemsen [Wed, 13 Jan 2016 03:35:40 +0000 (19:35 -0800)]
Fix Soong x86 atom builds
Change-Id: Ie92e605c499f128335a8da7cfefa7e6ae367a223
Elliott Hughes [Tue, 12 Jan 2016 23:16:00 +0000 (23:16 +0000)]
Merge "Fix <sys/sysmacros.h>."
Elliott Hughes [Tue, 12 Jan 2016 22:43:27 +0000 (14:43 -0800)]
Fix <sys/sysmacros.h>.
1. The definitions were wrong.
2. The definitions were inline functions.
3. The definitions were polluting the namespace even for code that doesn't
want BSD cruft.
Note that everybody will still get these by default, because you still get
all the BSD stuff by default.
Bug: http://b/
12706131
Change-Id: I062ecd09feef7a6e8ba1922d465b96a9c4bf4f4e
Colin Cross [Mon, 11 Jan 2016 20:28:17 +0000 (12:28 -0800)]
Rearrange build files to support USE_SOONG=true
Building with USE_SOONG=true will build with an Android.bp file if it is
present in the directory, otherwise an Android.mk file. Only a few of
the bionic directories compile with soong, so include all of them from
the top level Android.mk file and remove the top level Android.bp file.
Individual subdirectories with Android.bp files will use soong with
USE_SOONG=true.
Change-Id: Idf8d7977ea4668fa646be25b543bf9d3773de615
Elliott Hughes [Tue, 12 Jan 2016 20:57:48 +0000 (20:57 +0000)]
Merge "Add a getifaddrs(3) debugging tool."
Chih-hung Hsieh [Tue, 12 Jan 2016 19:41:46 +0000 (19:41 +0000)]
Merge "Explicit binary op order for both gcc and clang/llvm."
Chih-Hung Hsieh [Tue, 12 Jan 2016 17:48:09 +0000 (09:48 -0800)]
Explicit binary op order for both gcc and clang/llvm.
* gcc assembler parses (1 << n - 1) as ((1 << n) - 1)
* llvm assembler parses (1 << n - 1) as (1 << (n - 1))
BUG:
26289334
Change-Id: Iaaa3d07f59c0f87cb1b80b9a1c4e765b66846791
Elliott Hughes [Tue, 12 Jan 2016 05:30:07 +0000 (21:30 -0800)]
Add a getifaddrs(3) debugging tool.
...disguised as a test, because that's the easiest way to keep an eye on it.
Change-Id: Iec2531183790d12aec561d27645e5d400f69efbf
Colin Cross [Mon, 11 Jan 2016 21:20:55 +0000 (13:20 -0800)]
Update Android.bp for changes to Android.mk
Change-Id: Ie01e326e2776c699237b156155610d08801c0cd4
Elliott Hughes [Mon, 11 Jan 2016 21:43:58 +0000 (21:43 +0000)]
Merge "Add basic tests for <net/if.h>."
Elliott Hughes [Mon, 11 Jan 2016 21:18:20 +0000 (13:18 -0800)]
Add basic tests for <net/if.h>.
Bug: http://b/
26447711
Change-Id: I9bbcdffc07e99c98e367a63de861ddc7b274d579
Elliott Hughes [Mon, 11 Jan 2016 21:16:42 +0000 (21:16 +0000)]
Merge "Handle AF_PACKET in getifaddr(3)."
Yi Kong [Tue, 22 Dec 2015 17:07:23 +0000 (17:07 +0000)]
Handle AF_PACKET in getifaddr(3).
Also fix a bug where we were mutating the address/broadcast address
of an existing entry rather than the new entry, and use 'const' to
ensure we don't make that mistake again.
Change-Id: I31c127a5d21879b52c85cd0f7ed2e66554a21e39
Elliott Hughes [Fri, 8 Jan 2016 18:54:01 +0000 (18:54 +0000)]
Merge "Defend against -fstack-protector in libc startup."
Dimitry Ivanov [Fri, 8 Jan 2016 18:50:13 +0000 (18:50 +0000)]
Merge "Move __aeabi* symbols to LIBC_N version"
Dimitry Ivanov [Fri, 8 Jan 2016 18:06:44 +0000 (10:06 -0800)]
Move __aeabi* symbols to LIBC_N version
We had these symbols incorrectly versioned as LIBC_PRIVATE
in M release. This change moves __aeabi* symbols from LIBC
to LIBC_N and adds __gnu_Unwind_Find_exidx to the list
Bug: https://github.com/android-ndk/ndk/issues/1
Change-Id: I0b353012adeacb00ae29ea10c63b9d1cf1cadbe7
Elliott Hughes [Thu, 7 Jan 2016 03:51:43 +0000 (19:51 -0800)]
Defend against -fstack-protector in libc startup.
Exactly which functions get a stack protector is up to the compiler, so
let's separate the code that sets up the environment stack protection
requires and explicitly build it with -fno-stack-protector.
Bug: http://b/
26276517
Change-Id: I8719e23ead1f1e81715c32c1335da868f68369b5
Josh Gao [Wed, 6 Jan 2016 22:49:30 +0000 (22:49 +0000)]
Merge "Kill BOARD_MALLOC_ALIGNMENT."
Josh Gao [Wed, 6 Jan 2016 22:06:55 +0000 (14:06 -0800)]
Kill BOARD_MALLOC_ALIGNMENT.
Bug: http://b/
26403338
Change-Id: Iba4006277fdb7c7ca60542c517634ae86c847b4f
Josh Gao [Wed, 6 Jan 2016 20:08:13 +0000 (20:08 +0000)]
Merge "Replace MALLOC_IMPL with MALLOC_SVELTE."
Elliott Hughes [Wed, 6 Jan 2016 19:52:43 +0000 (19:52 +0000)]
Merge "Temporary hack to avoid stack protector crashes."
Tom Cherry [Wed, 6 Jan 2016 19:16:31 +0000 (19:16 +0000)]
Merge "Revert "system_properties.cpp: special case ro.* properties""
Tom Cherry [Wed, 6 Jan 2016 18:52:52 +0000 (18:52 +0000)]
Revert "system_properties.cpp: special case ro.* properties"
This reverts commit
c5fd81ab2524a06be907d9c5234e79346bbbbd7c.
Bug:
26416032
Change-Id: Id2d6761fdf55efa28c0b08b597daaa5cd381d758
Elliott Hughes [Wed, 6 Jan 2016 19:12:06 +0000 (11:12 -0800)]
Temporary hack to avoid stack protector crashes.
It'll take me a while to refactor things cleanly, but if we just want
something that boots for testing...
Bug: http://b/
26276517
Change-Id: I24729d3dc546e36e0eff383f0d1d05c3aa1f2e0b
Elliott Hughes [Wed, 6 Jan 2016 19:02:19 +0000 (19:02 +0000)]
Merge "Remove mktime_tz."
Dimitry Ivanov [Wed, 6 Jan 2016 18:37:19 +0000 (18:37 +0000)]
Merge "Temporary move __udivdi3 back to LIBC for x86"
Dimitry Ivanov [Tue, 5 Jan 2016 19:18:42 +0000 (11:18 -0800)]
Temporary move __udivdi3 back to LIBC for x86
Bug: http://b/
26289334
Bug: http://b/
26413821
Change-Id: Ifb0eb6f16aca54cb4a9184a6394992ee57dd3408
Elliott Hughes [Wed, 6 Jan 2016 17:15:02 +0000 (09:15 -0800)]
Remove mktime_tz.
Bug: http://b/
15765976
Change-Id: Ifc8cd19ae621e611d66173ae927ef9a0445965c1
Dimitry Ivanov [Wed, 6 Jan 2016 04:43:26 +0000 (04:43 +0000)]
Merge "Fix gcc+arm builds"
Dimitry Ivanov [Wed, 6 Jan 2016 04:38:32 +0000 (20:38 -0800)]
Fix gcc+arm builds
gcc requires unique names of symbols for .symver
Bug: http://b/
26391427
Change-Id: I6392e34a45a37245fd4e53fb54243be73f443313
Dimitry Ivanov [Wed, 6 Jan 2016 02:33:41 +0000 (02:33 +0000)]
Merge "Deprecate bzero"
Dimitry Ivanov [Wed, 6 Jan 2016 02:19:27 +0000 (02:19 +0000)]
Merge "Export public __aeabi* symbols as LIBC_PRIVATE"
Dimitry Ivanov [Wed, 6 Jan 2016 00:38:43 +0000 (16:38 -0800)]
Export public __aeabi* symbols as LIBC_PRIVATE
But keep LIBC as default version for them
Bug: http://b/
26391427
Bug: http://b/
26410625
Change-Id: I819e354bbba482d1f983d9be15c23fcce10e5dd9
Elliott Hughes [Wed, 6 Jan 2016 01:27:09 +0000 (01:27 +0000)]
Merge "Fix a broken link in a comment."
Elliott Hughes [Wed, 6 Jan 2016 01:24:37 +0000 (01:24 +0000)]
Merge "Tidy up KernelArgumentBlock::getauxval."
Dimitry Ivanov [Wed, 6 Jan 2016 01:02:56 +0000 (17:02 -0800)]
Deprecate bzero
bzero is hashdefined to memset in strings.h and it
was removed from POSIX 2008.
Bug: http://b/
26407170
Change-Id: Ia6d54f0e314dc7f5f3fbad0e9b00344f49f77d43
Nick Kralevich [Wed, 6 Jan 2016 00:43:48 +0000 (00:43 +0000)]
Merge "system_properties.cpp: special case ro.* properties"
Elliott Hughes [Wed, 6 Jan 2016 00:33:33 +0000 (16:33 -0800)]
Fix a broken link in a comment.
Bug: https://code.google.com/p/android/issues/detail?id=197784
Change-Id: I2f9e5bc2dd2b8a6992c7c55bc856e4a323c7c8a8
Nick Kralevich [Wed, 6 Jan 2016 00:19:24 +0000 (16:19 -0800)]
system_properties.cpp: special case ro.* properties
Currently, reads of ro.* properties are treated differently than
writes of ro.* properties. When writing an ro.* property, we ignore
the "ro." portion of the property, and base the security decision
on the label of the remaining portion.
See https://android.googlesource.com/platform/system/core/+/
e7a9e52740c952c623f7842ffa1d09b58b45e552/init/property_service.cpp
line 120-126
For example, for writing, the label associated with
"ro.build.fingerprint" comes from the /property_contexts file
entry:
# ro.build.fingerprint is either set in /system/build.prop, or is
# set at runtime by system_server.
build.fingerprint u:object_r:fingerprint_prop:s0
However, we fail to follow this same special case when sorting
properties into files. Instead, ro.build.fingerprint is assigned
u:object_r:default_prop:s0 instead of u:object_r:fingerprint_prop:s0
Ignore the "ro." portion when sorting properties into files.
This will make reads and writes of properties use the same label.
Bug:
21852512
Change-Id: Ie88ffc6b78b31fc8ddf370ae27c218546fb25a83
Elliott Hughes [Wed, 6 Jan 2016 00:29:33 +0000 (16:29 -0800)]
Tidy up KernelArgumentBlock::getauxval.
Correct the comment, and remove the unused functionality. getauxval(3) does
now set errno to let you know it failed to find anything, but since none of
this function's callers care anyway it seems safer to leave errno untouched
until we actually have a demonstrated need for it.
Bug: https://code.google.com/p/android/issues/detail?id=198111
Change-Id: I232a42dc5a02c8faab94c7d69bef610408276c23
Dan Willemsen [Tue, 5 Jan 2016 23:14:43 +0000 (23:14 +0000)]
Merge "libc: Update Android.bp with recent changes"