OSDN Git Service
Eder Ruiz Maria [Sun, 21 Jul 2013 00:17:18 +0000 (20:17 -0400)]
emulator: cmd_status() using send_packet() for run hooks easily
Now like cmd_command(), cmd_status() directly uses send_packet() instead
of send_event(), consequently cmd_status() must build the hci packet
without help of send_event(). With this change the events sent by
default_cmd() no more use send_event(), who is a good place to run hooks
for BTDEV_HOOK_POST_EVT. And the functions cmd_command() and
cmd_status() can run hooks for BTDEV_HOOK_POST_CMD.
Eder Ruiz Maria [Sun, 21 Jul 2013 00:17:17 +0000 (20:17 -0400)]
emulator: Split default_cmd() for better command and event handler
Now except for command complete event and command status event, all
other are handled by default_cmd_completion(). With this we can easily
add hooks in some points.
Eder Ruiz Maria [Sun, 21 Jul 2013 00:17:16 +0000 (20:17 -0400)]
emulator: Add support for delete a hook
Eder Ruiz Maria [Sun, 21 Jul 2013 00:17:15 +0000 (20:17 -0400)]
emulator: Export command and event hooks for hciemu user
Eder Ruiz Maria [Sun, 21 Jul 2013 00:17:14 +0000 (20:17 -0400)]
emulator: Add hook only if there aren't other with same type and opcode
Eder Ruiz Maria [Sun, 21 Jul 2013 00:17:13 +0000 (20:17 -0400)]
emulator: Add support for pre/post command/event hooks
Now who use emulator can add hooks to manipulate hci packets before
and after process commands and send events.
Anderson Lizardo [Fri, 19 Jul 2013 17:34:17 +0000 (13:34 -0400)]
attrib: Reduce scope of variable declarations in char_discovered_cb()
This makes it easy to identify where variables are being used.
Anderson Lizardo [Fri, 19 Jul 2013 17:34:16 +0000 (13:34 -0400)]
attrib: Allow dec_read_resp() to just check if PDU is valid
If a NULL "value" parameter is given, only check whether PDU is valid,
without copying attribute value to a buffer.
Alvaro Silva [Fri, 19 Jul 2013 17:34:15 +0000 (13:34 -0400)]
attrib: Add encode/decode execute write support
Add functions for encoding/decoding Execute Write Request PDUs.
Alvaro Silva [Fri, 19 Jul 2013 17:34:14 +0000 (13:34 -0400)]
attrib: Add encode/decode prepare write support
Add functions for encoding/decoding Prepare Write Request PDUs.
Alvaro Silva [Fri, 19 Jul 2013 17:34:13 +0000 (13:34 -0400)]
attrib: Remove unused parameter from enc_write_resp()
Eder Ruiz Maria [Fri, 19 Jul 2013 17:34:12 +0000 (13:34 -0400)]
attrib: Fix coding style for various enc_*/dec_* functions
Fix coding style for enc_read_blob(), enc_read_blob_resp(),
dec_read_resp(), enc_error_resp(), enc_find_info_req(),
enc_find_info_resp() and enc_prep_write().
Anderson Lizardo [Fri, 19 Jul 2013 17:34:11 +0000 (13:34 -0400)]
attrib: Simplify prepare_write()
All parameters can be retrieved from struct write_long_data fields,
therefore there is no need to pass them separately.
Anderson Lizardo [Fri, 19 Jul 2013 17:34:10 +0000 (13:34 -0400)]
attrib: Fix coding style in prepare_write_cb()
Anderson Lizardo [Fri, 19 Jul 2013 17:34:09 +0000 (13:34 -0400)]
attrib: Do not use Write Command in gatt_write_char()
Previously, if no callback was given to gatt_write_char(), it was
assumed that a "Write Without Response" (which uses Write Command)
should be used instead of Write Request.
This "shortcut" is unnecessary (there is gatt_write_cmd() for the
situations where Write Without Response is required) and just duplicates
code.
This commit also fixes the few places where gatt_write_cmd() should be
used.
Anderson Lizardo [Fri, 19 Jul 2013 17:34:08 +0000 (13:34 -0400)]
attrib: Rename gatt_find_info() to gatt_discover_char_desc()
The old name referred to the underlying ATT PDU (Find Information
Request and Find Information Response) and not to the actual GATT
procedure (Discover All Characteristic Descriptors).
Eder Ruiz Maria [Fri, 19 Jul 2013 17:34:07 +0000 (13:34 -0400)]
gatttool: Remove unused code
Since commit
6a3a89774c6738df4d5b77636c4ce747b7497ae9 the code
removed here has no sense.
Luiz Augusto von Dentz [Tue, 23 Jul 2013 12:52:32 +0000 (15:52 +0300)]
audio/player: Fix attempting to set the same setting value
This cause unnecessary commands to be sent over the air so instead the
code should just return success as nothing should be changed.
Luiz Augusto von Dentz [Tue, 23 Jul 2013 12:52:31 +0000 (15:52 +0300)]
audio/media: Fix not updating position
The status may not be 'playing' as MPRIS documents it as 'Playing'
instead, to make this less prone to typos like this the code now
uses strcasecmp.
Luiz Augusto von Dentz [Tue, 23 Jul 2013 12:52:30 +0000 (15:52 +0300)]
audio/AVRCP: Fix registration of VOLUME_CHANGED
First check with GetCapabilities if the event is really support before
registering.
Luiz Augusto von Dentz [Tue, 23 Jul 2013 12:52:29 +0000 (15:52 +0300)]
audio/AVRCP: Rework role detection
This makes AVRCP agnostic to any roles so the same session can be used
both for controller and target role.
Anderson Lizardo [Tue, 23 Jul 2013 01:36:05 +0000 (21:36 -0400)]
cyclingspeed: Fix MultipleLocationsSupported property name usage
MultipleLocationsSupported is the correct property name, as implemented
in profiles/cyclingspeed/cyclingspeed.c.
Johan Hedberg [Sat, 20 Jul 2013 20:33:02 +0000 (23:33 +0300)]
mailmap: Add Martin due to one commit with incomplete name
Sathish Narasimman [Fri, 19 Jul 2013 04:31:52 +0000 (10:01 +0530)]
attrib: Fix interactive gatttool segfault
Passing the special character single quote:
$gatttool -I
[ ][ ][LE]> '
Segmentation fault (core dumped)
Checking g_shell_parse_argv fail status (return FALSE on failure), works
fine.
Marcel Holtmann [Thu, 18 Jul 2013 14:37:19 +0000 (07:37 -0700)]
build: Build a simpler version of libgdbus-internal
Lucas De Marchi [Wed, 3 Jul 2013 12:29:20 +0000 (09:29 -0300)]
build-sys: Don't build gdbus several times
We are currently compiling gdbus 3 times: one for tests, one for
bluetoothd and another for obexd.
$ ls gdbus/*watch.o
gdbus/bluetoothd-watch.o gdbus/obexd-watch.o gdbus/watch.o
Instead of prepending $(gdbus_sources) to several _SOURCES variable, use
a convenience library.
Lucas De Marchi [Wed, 3 Jul 2013 12:29:19 +0000 (09:29 -0300)]
build-sys: Rename lib suffix to -internal
libbluetooth-private -> libbluetooth-internal
Anderson Lizardo [Thu, 18 Jul 2013 02:20:09 +0000 (22:20 -0400)]
lib: Remove duplicated HSP_HS_UUID definition
There is an identical definition on the same header file (next to
HSP_AG_UUID).
Luiz Augusto von Dentz [Wed, 17 Jul 2013 11:27:53 +0000 (14:27 +0300)]
tools/bluetooth-player: Make show-item command print Player property
This makes show-item command to print Player property that indicates
which player the item belongs to.
Luiz Augusto von Dentz [Wed, 17 Jul 2013 11:18:26 +0000 (14:18 +0300)]
doc/media-api: Update documentation of MediaItem1
This adds documentation of property Player
Luiz Augusto von Dentz [Wed, 17 Jul 2013 11:17:11 +0000 (14:17 +0300)]
audio/player: Add Player property to MediaItem1
This proper refer to the player object path which the item belongs to
Luiz Augusto von Dentz [Wed, 17 Jul 2013 10:51:36 +0000 (13:51 +0300)]
doc/media-api: Update documentation of MediaFolder1
This adds missing access types to properties NumberOfItems and Name
Martin Xu [Wed, 17 Jul 2013 02:37:25 +0000 (10:37 +0800)]
core: Fix default authorize value for external profiles
Previously the value of "authorize" was essentially ignored in the
settings table. This wasn't very noticeable since almost all profiles
use the default true value. Since the default value of "authorize" is
true it cannot be left out from the default settings table entries
(leaving it out would set it implicitly to false).
Luiz Augusto von Dentz [Tue, 16 Jul 2013 11:51:36 +0000 (14:51 +0300)]
doc/media-api: Update documentation of MediaPlayer1
This adds documentation of properties Type and Subtype
Johan Hedberg [Tue, 16 Jul 2013 10:59:17 +0000 (13:59 +0300)]
input: Add debug logs for attio connection status in HoG code
Johan Hedberg [Tue, 16 Jul 2013 10:58:37 +0000 (13:58 +0300)]
input: Fix minor coding style issue in HoG code
Johan Hedberg [Tue, 16 Jul 2013 10:53:59 +0000 (13:53 +0300)]
core: Add debug log for attrib disconnection reason
Johan Hedberg [Mon, 15 Jul 2013 11:29:54 +0000 (14:29 +0300)]
core: Remove unnecessary btd_device reference count in browse_req
The browse request is "owned" by the btd_device structure so it doesn't
make sense to have browse_req keeping an extra reference for the
btd_device.
Szymon Janc [Tue, 9 Jul 2013 07:40:00 +0000 (09:40 +0200)]
core: Use proper header for S_IRUSR/S_IWUSR
According to open() manual one should include <sys/stat.h>.
This fix build with bionic library:
target thumb C: libbluetoothd <= external/bluetooth/bluez/src/attrib-server.c
external/bluetooth/bluez/src/attrib-server.c: In function 'write_value':
external/bluetooth/bluez/src/attrib-server.c:922:26: error: 'S_IRUSR'
undeclared (first use in this function)
external/bluetooth/bluez/src/attrib-server.c:922:26: note: each undeclared
identifier is reported only once for each function it appears in
external/bluetooth/bluez/src/attrib-server.c:922:36: error: 'S_IWUSR'
undeclared (first use in this function)
Luiz Augusto von Dentz [Thu, 11 Jul 2013 09:48:19 +0000 (12:48 +0300)]
plugins/policy: Limit the number of retries to sink profile
The policy should only retry a limit number of times.
Luiz Augusto von Dentz [Thu, 11 Jul 2013 09:40:54 +0000 (12:40 +0300)]
plugins/policy: Limit the number of retries to source profile
The policy should only retry a limit number of times.
Luiz Augusto von Dentz [Tue, 9 Jul 2013 11:46:03 +0000 (14:46 +0300)]
audio/control: Enable initiate connection to CT role
Since the policy uses service API to initiate the connections this needs
to be enabled for both CT and TG roles.
Luiz Augusto von Dentz [Fri, 5 Jul 2013 10:38:42 +0000 (13:38 +0300)]
audio/sink: Move stream retry logic to policy plugin
policy plugin is a better place to have such a logic as it is already
handling other connection policies related to such profiles.
Luiz Augusto von Dentz [Fri, 5 Jul 2013 10:29:28 +0000 (13:29 +0300)]
audio/source: Move stream retry logic to policy plugin
policy plugin is a better place to have such a logic as it is already
handling other connection policies related to such profiles.
Luiz Augusto von Dentz [Tue, 2 Jul 2013 15:31:59 +0000 (18:31 +0300)]
plugins/policy: Reword audio policy code in a simple plugin
This moves audio device policy to a plugin and removes any dependency of
audio plugin to it.
Luiz Augusto von Dentz [Tue, 2 Jul 2013 13:47:34 +0000 (16:47 +0300)]
audio/main: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Tue, 2 Jul 2013 13:45:23 +0000 (16:45 +0300)]
audio/manager: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Tue, 2 Jul 2013 13:14:54 +0000 (16:14 +0300)]
audio/transport: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Tue, 2 Jul 2013 13:14:10 +0000 (16:14 +0300)]
audio/media: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Tue, 2 Jul 2013 13:02:45 +0000 (16:02 +0300)]
audio/source: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Tue, 2 Jul 2013 11:33:37 +0000 (14:33 +0300)]
audio/sink: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Tue, 2 Jul 2013 11:16:51 +0000 (14:16 +0300)]
audio/A2DP: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Mon, 1 Jul 2013 13:36:07 +0000 (16:36 +0300)]
audio/control: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Mon, 1 Jul 2013 13:20:46 +0000 (16:20 +0300)]
audio/AVRCP: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Fri, 28 Jun 2013 13:03:14 +0000 (16:03 +0300)]
audio/AVDTP: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Fri, 28 Jun 2013 08:01:00 +0000 (11:01 +0300)]
audio/AVCTP: Remove dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Thu, 27 Jun 2013 12:03:13 +0000 (15:03 +0300)]
audio/control: Reduce dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Thu, 27 Jun 2013 09:32:41 +0000 (12:32 +0300)]
audio/source: Reduce dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Wed, 26 Jun 2013 12:52:27 +0000 (15:52 +0300)]
audio/sink: Reduce dependency on struct audio_device
This is part of the work necessary to completely remove
struct audio_device
Luiz Augusto von Dentz [Tue, 25 Jun 2013 11:47:10 +0000 (14:47 +0300)]
audio/control: Use service user_data for private data
This remove the need of forward declaration of struct control and prepare
for a complete removal of struct audio_device.
Luiz Augusto von Dentz [Tue, 25 Jun 2013 11:21:02 +0000 (14:21 +0300)]
audio/source: Use service user_data for private data
This remove the need of forward declaration of struct source and prepare
for a complete removal of struct audio_device.
Luiz Augusto von Dentz [Tue, 25 Jun 2013 11:02:02 +0000 (14:02 +0300)]
audio/sink: Use service user_data for private data
This remove the need of forward declaration of struct sink and prepare
for a complete removal of struct audio_device.
Johan Hedberg [Fri, 12 Jul 2013 11:04:58 +0000 (14:04 +0300)]
core: Clear temporary flag only when a real profile is connected
Johan Hedberg [Fri, 12 Jul 2013 11:04:05 +0000 (14:04 +0300)]
input: Fix rejecting connections from unknown devices
Johan Hedberg [Fri, 12 Jul 2013 10:18:14 +0000 (13:18 +0300)]
core: Fix incorrect update of dev->svc_refreshed
Johan Hedberg [Fri, 12 Jul 2013 09:50:45 +0000 (12:50 +0300)]
input: Fix service disconnected state transition
Without this patch the input service would remain in connected state
whenever a remotely initiated disconnection happens.
Johan Hedberg [Fri, 12 Jul 2013 09:28:57 +0000 (12:28 +0300)]
core: Remove unnecessary device_resolve_svc function
Johan Hedberg [Fri, 12 Jul 2013 09:25:32 +0000 (12:25 +0300)]
input: Add some extra debug statements to clarify connection flow
Johan Hedberg [Fri, 12 Jul 2013 08:14:44 +0000 (11:14 +0300)]
core: Fix returning correct D-Bus reply when refreshing services
Johan Hedberg [Fri, 12 Jul 2013 07:43:25 +0000 (10:43 +0300)]
core: Clear device->attrib pointer before calling g_attrib_cancel_all
The g_attrib_cancel_all function may call functions such as
find_included_cb that should at this point no longer have access to the
GAttrib instance and try to do operations with it. Therefore it is
safest to ensure that device->attrib is no longer available in these
functions.
Frederic Danis [Thu, 11 Jul 2013 12:37:28 +0000 (14:37 +0200)]
core: Remove redundant includes from sdpd-*.c
Johan Hedberg [Thu, 11 Jul 2013 11:17:27 +0000 (14:17 +0300)]
core: Refresh SDP services if no matching profiles were found
Johan Hedberg [Thu, 11 Jul 2013 08:39:06 +0000 (11:39 +0300)]
core: Simplify code flow in search_cb
Johan Hedberg [Thu, 11 Jul 2013 08:38:44 +0000 (11:38 +0300)]
core: Implement passive SDP discovery after connecting known services
Johan Hedberg [Thu, 11 Jul 2013 08:30:55 +0000 (11:30 +0300)]
core: Remove unnecessary secure paramter from device_browse_primary
Johan Hedberg [Thu, 11 Jul 2013 08:29:03 +0000 (11:29 +0300)]
core: Remove unused reverse parameter from device_browse_sdp
Johan Hedberg [Thu, 11 Jul 2013 08:26:23 +0000 (11:26 +0300)]
core: Set low priority for SDP data
In the case that there are other channels over the same ACL we want SDP
transactions to interfere as little as possible.
Johan Hedberg [Wed, 10 Jul 2013 11:45:34 +0000 (14:45 +0300)]
core: Use g_dbus_send_reply over dbus_message_new_method_return
Johan Hedberg [Wed, 10 Jul 2013 11:37:08 +0000 (14:37 +0300)]
core: Remove profile removal detection
This code has been nonfunctional since 5.0 and it seems no-one cares for
it, so just remove it.
Johan Hedberg [Wed, 10 Jul 2013 10:55:04 +0000 (13:55 +0300)]
core: Fix incorrectly restarting service discovery after pairing
If services are already discovered through a Device1.Connect() call we
should not retry discovering them when Device1.Pair() is called.
Luiz Augusto von Dentz [Tue, 9 Jul 2013 09:54:50 +0000 (12:54 +0300)]
core/device: Don't call btd_service_disconnect on device_remove
device_remove is called to cleanup/free the device objects so the
services should be disconnected before hand.
Luiz Augusto von Dentz [Fri, 5 Jul 2013 12:55:47 +0000 (15:55 +0300)]
core/device: Fix crash while freeing services list
btd_service do alter its state on service_remove which can cause
plugins to attempt to access services list which may have freed some
services already.
To fix this the code now updates the list in place so the services are
first removed from services list before calling service_remove.
Luiz Augusto von Dentz [Fri, 5 Jul 2013 12:47:51 +0000 (15:47 +0300)]
core/service: Rename service_shutdown to service_remove
This rename service_shutdown to service_remove to make it more similar to
other internal APIs such as device_remove which only do object
cleanup/free and do not have any disconnect logic.
Szymon Janc [Wed, 26 Jun 2013 20:26:35 +0000 (22:26 +0200)]
lib: Add range check for SDP_SVC_ATTR_RSP/SDP_SVC_SEARCH_ATTR_RSP
This is an improved version of recently reverted commit
1796f00e8465.
Response size is verified against minimal allowed value only if it is
complete response. If response is partial it is allowed by spec that
it will be split in arbitrary manner.
Verified against Nokia BH217 on which original commit caused
regression.
Martin [Fri, 5 Jul 2013 09:38:26 +0000 (17:38 +0800)]
obexd/client: Add Target property to Session interface
Target property is already documented property but it was not
implemented.
Luiz Augusto von Dentz [Thu, 4 Jul 2013 12:00:45 +0000 (15:00 +0300)]
audio/source: Fix not notifying service about connection state
btd_service_connecting_complete should be called whenever the service
is connected otherwise the service state will not be consistent.
Luiz Augusto von Dentz [Thu, 4 Jul 2013 12:00:44 +0000 (15:00 +0300)]
audio/sink: Fix not notifying service about connection state
btd_service_connecting_complete should be called whenever the service
is connected otherwise the service state will not be consistent.
Jefferson Delfes [Wed, 3 Jul 2013 20:54:56 +0000 (16:54 -0400)]
emulator: Implement LE advertising report
When a virtual device starts a LE advertising, emulator searches for
other virtual devices that are in scan mode, in order to send adv data
to these devices.
Inverse goes when LE scan is enabled. Emulator searches virtual devices
that are in advertising mode and copy adv data to them.
Jefferson Delfes [Wed, 3 Jul 2013 20:54:55 +0000 (16:54 -0400)]
emulator: Dummy LE set advertising parameters
Implement basic LE set adv parameters command.
Jefferson Delfes [Wed, 3 Jul 2013 20:54:54 +0000 (16:54 -0400)]
emulator: Disallow LE set scan params command when scan is enabled
When LE scan is enabled, the command LE set scan parameters should
return a command disallowed in status of command complete event.
Jefferson Delfes [Wed, 3 Jul 2013 20:54:53 +0000 (16:54 -0400)]
emulator: Store LE scan state of virtual controller
The LE command set scan enable can change the scan state of virtual
controller.
Jefferson Delfes [Wed, 3 Jul 2013 20:54:52 +0000 (16:54 -0400)]
emulator: Implement basic LE set adv enable command
Store advertising state of virtual controller in btdev struct.
Jefferson Delfes [Wed, 3 Jul 2013 20:54:51 +0000 (16:54 -0400)]
emulator: Store LE advertising data length in btdev
LE advertising data length will be used for emulating reports in other
virtual devices.
Christian Fetzer [Fri, 28 Jun 2013 10:16:07 +0000 (12:16 +0200)]
obexd: Re-add D-Bus session properties
This got lost when switching to org.freedesktop.DBus.Properties.
Marcel Holtmann [Fri, 28 Jun 2013 19:07:20 +0000 (12:07 -0700)]
monitor: Print UUID-32 and UUID-128 strings
Marcel Holtmann [Fri, 28 Jun 2013 19:06:06 +0000 (12:06 -0700)]
monitor: Add stub for UUID-128 to string conversion
Marcel Holtmann [Wed, 26 Jun 2013 17:10:50 +0000 (10:10 -0700)]
Release 5.7
Marcel Holtmann [Wed, 26 Jun 2013 17:03:17 +0000 (10:03 -0700)]
build: Update library version
Luiz Augusto von Dentz [Wed, 26 Jun 2013 13:08:35 +0000 (16:08 +0300)]
obexd/MAP: Fix assigning pointer not value to 0
The fix introduced by
455fb131f08cddc9759c877e38ebff3b4bd975b2 would
leave err value uninitialized and set the pointer to 0 which doesn't
make any sense.
Johan Hedberg [Wed, 26 Jun 2013 11:30:11 +0000 (14:30 +0300)]
lib: Update company identifiers