OSDN Git Service
Tom Lane [Thu, 6 Apr 2006 20:38:00 +0000 (20:38 +0000)]
Remove the pgstats logic for delaying destruction of stats table entries.
Per recent discussion, this seems to be making the stats less accurate
rather than more so, particularly on Windows where PID values may be
reused very quickly. Patch by Peter Brant.
Peter Eisentraut [Thu, 6 Apr 2006 18:54:37 +0000 (18:54 +0000)]
Build src/test/regress/README during tarball making like the other
generated text files. Fix build of that file, too.
Put the text files in the right place during make dist, so there are no
extra manual steps required anymore.
Bruce Momjian [Wed, 5 Apr 2006 22:55:05 +0000 (22:55 +0000)]
Update AIX FAQ to show readline options more clearly.
Backpatch FAQ's to 8.1.X.
Tom Lane [Wed, 5 Apr 2006 22:11:58 +0000 (22:11 +0000)]
Fix a bunch of problems with domains by making them use special input functions
that apply the necessary domain constraint checks immediately. This fixes
cases where domain constraints went unchecked for statement parameters,
PL function local variables and results, etc. We can also eliminate existing
special cases for domains in places that had gotten it right, eg COPY.
Also, allow domains over domains (base of a domain is another domain type).
This almost worked before, but was disallowed because the original patch
hadn't gotten it quite right.
Peter Eisentraut [Wed, 5 Apr 2006 13:40:15 +0000 (13:40 +0000)]
When merging PO files, take into consideration translations in other PO
files of the same languages. That way, similar or equal translations in
different programs are automatically propagated and the life of translators
becomes a little bit easier.
Tom Lane [Wed, 5 Apr 2006 03:34:05 +0000 (03:34 +0000)]
Add a field to the first page of each WAL file to indicate the
XLOG_BLCKSZ. This ought to help in preventing configuration mismatch
problems if anyone tries to ship PITR files between servers compiled
with different XLOG_BLCKSZ settings. Simon Riggs
Tom Lane [Tue, 4 Apr 2006 22:39:59 +0000 (22:39 +0000)]
Don't use BLCKSZ for the physical length of the pg_control file, but
instead a dedicated symbol. This probably makes no functional difference
for likely values of BLCKSZ, but it makes the intent clearer.
Simon Riggs, minor editorialization by Tom Lane.
Tom Lane [Tue, 4 Apr 2006 19:35:37 +0000 (19:35 +0000)]
Modify all callers of datatype input and receive functions so that if these
functions are not strict, they will be called (passing a NULL first parameter)
during any attempt to input a NULL value of their datatype. Currently, all
our input functions are strict and so this commit does not change any
behavior. However, this will make it possible to build domain input functions
that centralize checking of domain constraints, thereby closing numerous holes
in our domain support, as per previous discussion.
While at it, I took the opportunity to introduce convenience functions
InputFunctionCall, OutputFunctionCall, etc to use in code that calls I/O
functions. This eliminates a lot of grotty-looking casts, but the main
motivation is to make it easier to grep for these places if we ever need
to touch them again.
Tom Lane [Mon, 3 Apr 2006 23:35:05 +0000 (23:35 +0000)]
Define a separately configurable XLOG_BLCKSZ symbol for the page size
used within WAL files. Historically this was the same as the data file
BLCKSZ, but there's no necessary connection, and it's possible that
performance gains might ensue from reducing XLOG_BLCKSZ. In any case
distinguishing two symbols should improve code clarity. This commit
does not actually change the page size, only provide the infrastructure
to make it possible to do so. initdb forced because of addition of a
field to pg_control.
Mark Wong, with some help from Simon Riggs and Tom Lane.
Peter Eisentraut [Mon, 3 Apr 2006 18:47:41 +0000 (18:47 +0000)]
Put flex'ed and bison'ed files in contrib in the distribution tarball, as
is done for the analogous files in the main distribution.
Tom Lane [Mon, 3 Apr 2006 16:45:50 +0000 (16:45 +0000)]
Fix thinko in gistRedoPageUpdateRecord: if XLR_BKP_BLOCK_1 is set, we
don't have anything to do to the page, but we still have to adjust the
incomplete_inserts list that we're maintaining in memory.
Teodor Sigaev [Mon, 3 Apr 2006 13:44:33 +0000 (13:44 +0000)]
Eliminate ajust scan code. Since concurrent GiST it doesn't
do real work. That was missed during concurrence development.
Teodor Sigaev [Mon, 3 Apr 2006 08:37:41 +0000 (08:37 +0000)]
Minor cleanups
Teodor Sigaev [Mon, 3 Apr 2006 08:21:05 +0000 (08:21 +0000)]
Detoast query in g_intbig_consistent and copy query in g_int_consistent
Bruce Momjian [Mon, 3 Apr 2006 03:46:16 +0000 (03:46 +0000)]
Add to qsort TODO.detail.
Bruce Momjian [Mon, 3 Apr 2006 03:40:20 +0000 (03:40 +0000)]
Update for max row size.
Bruce Momjian [Mon, 3 Apr 2006 03:39:23 +0000 (03:39 +0000)]
Update max row size to 400gb, per Tom.
Neil Conway [Sun, 2 Apr 2006 20:08:22 +0000 (20:08 +0000)]
Rewrite much of psql's \connect code, for the sake of code clarity and
to fix regressions introduced in the recent patch adding additional
\connect options. This is based on work by Volkan YAZICI, although
this version of the patch doesn't bear much resemblance to Volkan's
version.
\connect takes 4 optional arguments: database name, user name, host
name, and port number. If any of those parameters are omitted or
specified as "-", the value of that parameter from the previous
connection is used instead; if there is no previous connection,
the libpq default is used. Note that this behavior makes it
impossible to reuse the libpq defaults without quitting psql and
restarting it; I don't really see the use case for needing to do
that.
Tom Lane [Sun, 2 Apr 2006 19:39:54 +0000 (19:39 +0000)]
Adjust interval-addition test so that it won't fail on DST transition days.
Strange that we missed this DST dependence while fixing the others.
Peter Eisentraut [Sun, 2 Apr 2006 17:38:13 +0000 (17:38 +0000)]
Update information schema for SQL:2003 and new PostgreSQL features.
Alvaro Herrera [Sun, 2 Apr 2006 09:02:41 +0000 (09:02 +0000)]
Add tab-completion for REASSIGN OWNED BY and DROP OWNED BY. Also fix some
whitespace issues nearby.
DROP OWNED BY is actually a bit kludgy, but it seems better to do it this way
rather than duplicating the words_after_create list just to add a single
element.
Neil Conway [Sun, 2 Apr 2006 04:02:40 +0000 (04:02 +0000)]
Correct some errors and do some SGML police work on the reference pages
for REASSIGN OWNED and DROP OWNED.
Neil Conway [Sun, 2 Apr 2006 03:56:40 +0000 (03:56 +0000)]
Minor improvement to DROP TABLE reference page.
Bruce Momjian [Sun, 2 Apr 2006 01:27:42 +0000 (01:27 +0000)]
Add recent /port/qsort comparison discussion.
Tom Lane [Sat, 1 Apr 2006 03:03:37 +0000 (03:03 +0000)]
Remove the 'slow' path for btree index build, which built the btree
incrementally by successive inserts rather than by sorting the data.
We were only using the slow path during bootstrap, apparently because
when first written it failed during bootstrap --- but it works fine now
AFAICT. Removing it saves a hundred or so lines of code and produces
noticeably (~10%) smaller initial states of the system catalog indexes.
While that won't make much difference for heavily-modified catalogs,
for the more static ones there may be a useful long-term performance
improvement.
Tom Lane [Fri, 31 Mar 2006 23:32:07 +0000 (23:32 +0000)]
Clean up WAL/buffer interactions as per my recent proposal. Get rid of the
misleadingly-named WriteBuffer routine, and instead require routines that
change buffer pages to call MarkBufferDirty (which does exactly what it says).
We also require that they do so before calling XLogInsert; this takes care of
the synchronization requirement documented in SyncOneBuffer. Note that
because bufmgr takes the buffer content lock (in shared mode) while writing
out any buffer, it doesn't matter whether MarkBufferDirty is executed before
the buffer content change is complete, so long as the content change is
completed before releasing exclusive lock on the buffer. So it's OK to set
the dirtybit before we fill in the LSN.
This eliminates the former kluge of needing to set the dirtybit in LockBuffer.
Aside from making the code more transparent, we can also add some new
debugging assertions, in particular that the caller of MarkBufferDirty must
hold the buffer content lock, not merely a pin.
Tom Lane [Thu, 30 Mar 2006 23:03:10 +0000 (23:03 +0000)]
Improve gist XLOG code to follow the coding rules needed to prevent
torn-page problems. This introduces some issues of its own, mainly
that there are now some critical sections of unreasonably broad scope,
but it's a step forward anyway. Further cleanup will require some
code refactoring that I'd prefer to get Oleg and Teodor involved in.
Tom Lane [Thu, 30 Mar 2006 22:11:55 +0000 (22:11 +0000)]
Suppress attempts to report dropped tables to the stats collector from a
startup or recovery process. Since such a process isn't a real backend,
pgstat.c gets confused. This accounts for recent reports of strange
"invalid server process ID -1" log messages during crash recovery.
There isn't any point in attempting to make the report, since we'll discard
stats in such scenarios anyhow.
Andrew Dunstan [Thu, 30 Mar 2006 01:08:15 +0000 (01:08 +0000)]
Fix bad SQL, per Stefan Kaltenbrunner.
Tom Lane [Wed, 29 Mar 2006 21:17:39 +0000 (21:17 +0000)]
Clean up and document the API for XLogOpenRelation and XLogReadBuffer.
This commit doesn't make much functional change, but it does eliminate some
duplicated code --- for instance, PageIsNew tests are now done inside
XLogReadBuffer rather than by each caller.
The GIST xlog code still needs a lot of love, but I'll worry about that
separately.
Tom Lane [Wed, 29 Mar 2006 15:15:43 +0000 (15:15 +0000)]
TablespaceCreateDbspace should function normally even on platforms that do not
have symlinks (ie, Windows). Although it'll never be called on to do anything
useful during normal operation on such a platform, it's still needed to
re-create dropped directories during WAL replay.
Tom Lane [Tue, 28 Mar 2006 22:01:16 +0000 (22:01 +0000)]
Disable full_page_writes, because turning it off risks causing crash-recovery
failures even when the hardware and OS did nothing wrong. Per recent analysis
of a problem report from Alex Bahdushka.
For the moment I've just diked out the test of the parameter, rather than
removing the GUC infrastructure and documentation, in case we conclude that
there's something salvageable there. There seems no chance of it being
resurrected in the 8.1 branch though.
Tom Lane [Tue, 28 Mar 2006 21:17:23 +0000 (21:17 +0000)]
Repair longstanding error in btree xlog replay: XLogReadBuffer should be
passed extend = true whenever we are reading a page we intend to reinitialize
completely, even if we think the page "should exist". This is because it
might indeed not exist, if the relation got truncated sometime after the
current xlog record was made and before the crash we're trying to recover
from. These two thinkos appear to explain both of the old bug reports
discussed here:
http://archives.postgresql.org/pgsql-hackers/2005-05/msg01369.php
Tom Lane [Fri, 24 Mar 2006 23:02:17 +0000 (23:02 +0000)]
Comments in IndexBuildHeapScan describe the indexing of recently-dead
tuples as needed "to keep VACUUM from complaining", but actually there is
a more compelling reason to do it: failure to do so violates MVCC semantics.
This is because a pre-existing serializable transaction might try to use
the index after we finish (re)building it, and it might fail to find tuples
it should be able to see. We got this mostly right, but not in the case
of partial indexes: the code mistakenly discarded recently-dead tuples for
partial indexes. Fix that, and adjust the comments.
Tom Lane [Fri, 24 Mar 2006 04:32:13 +0000 (04:32 +0000)]
Arrange to emit a description of the current XLOG record as error context
when an error occurs during xlog replay. Also, replace the former risky
'write into a fixed-size buffer with no overflow detection' API for XLOG
record description routines; use an expansible StringInfo instead. (The
latter accounts for most of the patch bulk.)
Qingqing Zhou
Tom Lane [Thu, 23 Mar 2006 04:22:37 +0000 (04:22 +0000)]
Fix plpgsql to pass only one copy of any given plpgsql variable into a SQL
command or expression, rather than one copy for each textual occurrence as
it did before. This might result in some small performance improvement,
but the compelling reason to do it is that not doing so can result in
unexpected grouping failures because the main SQL parser won't see different
parameter numbers as equivalent. Add a regression test for the failure case.
Per report from Robert Davidson.
Tom Lane [Thu, 23 Mar 2006 00:19:30 +0000 (00:19 +0000)]
Add error location info to ResTarget parse nodes. Allows error cursor to be supplied
for various mistakes involving INSERT and UPDATE target columns.
Tom Lane [Tue, 21 Mar 2006 19:49:15 +0000 (19:49 +0000)]
Improve performance of our private version of qsort. Per recent testing,
the logic it contained to switch to insertion sort for near-sorted input was
in fact a big loss, because it could fairly easily be fooled into applying
insertion sort to large subfiles that weren't all that well ordered. Remove
that, and instead add a simple check for already-perfectly-sorted input, as
per suggestion from Dann Corbit. This adds at worst O(N*lgN) overhead, and
usually far less, while sometimes allowing a subfile sort to finish in O(N)
time. Preliminary testing says this is an improvement over the basic
Bentley & McIlroy code for many nonrandom inputs, and it costs almost
nothing when the input is random.
Neil Conway [Tue, 21 Mar 2006 18:18:35 +0000 (18:18 +0000)]
Minor refactoring: initialize_SSL() only returns 0, so it should return
"void" rather than "int".
Alvaro Herrera [Tue, 21 Mar 2006 17:54:28 +0000 (17:54 +0000)]
Merge the loading of shared object descriptions with regular descriptions,
both in code and in the messages emitted to the user.
Bruce Momjian [Tue, 21 Mar 2006 13:38:12 +0000 (13:38 +0000)]
Fix psql history handling:
> 1) Fix the problems with the \s command.
> When the saveHistory is executed by the \s command we must not do the
> conversion \n -> \x01 (per
> http://archives.postgresql.org/pgsql-hackers/2006-03/msg00317.php )
>
> 2) Fix the handling of Ctrl+C
>
> Now when you do
> wsdb=# select 'your long query here '
> wsdb-#
> and press afterwards the CtrlC the line "select 'your long query here
'"
> will be in the history
>
> (partly per
> http://archives.postgresql.org/pgsql-hackers/2006-03/msg00297.php )
>
> 3) Fix the handling of commands with not closed brackets, quotes,
double
> quotes. (now those commands are not splitted in parts...)
>
> 4) Fix the behaviour when SINGLELINE mode is used. (before it was
almost
> broken ;(
Sergey E. Koposov
Bruce Momjian [Mon, 20 Mar 2006 15:07:05 +0000 (15:07 +0000)]
Update comment that pgNotify.be_pid is pid of the notifying server process.
Neil Conway [Sun, 19 Mar 2006 22:22:56 +0000 (22:22 +0000)]
Fix a few places that were checking for the return value of palloc() to be
non-NULL: palloc() ereports on OOM, so we can safely assume it returns a
valid pointer.
Tom Lane [Sun, 19 Mar 2006 01:19:42 +0000 (01:19 +0000)]
Adjust join_1.out to match Windows behavior for new mergejoin regression
test, per Dave Page and buildfarm. Perhaps we will need a join_2 instead,
but for the moment assume that this test tracks the other diffs.
Neil Conway [Sat, 18 Mar 2006 22:09:58 +0000 (22:09 +0000)]
The call to DNSServiceRegistrationCreate in postc does incorrect
byte-swapping on the port number which causes the call to fail on Intel
Macs.
This patch uses htons() instead of htonl() and fixes this bug.
Ashley Clark
Tom Lane [Fri, 17 Mar 2006 19:38:12 +0000 (19:38 +0000)]
Fix bug introduced into mergejoin logic by performance improvement patch of
2005-05-13. When we find that a new inner tuple can't possibly match any
outer tuple (because it contains a NULL), we can't immediately skip the
tuple when we are in NEXTINNER state. Doing so can lead to emitting
multiple copies of the tuple in FillInner mode, because we may rescan the
tuple after returning to a previous marked tuple. Instead, proceed to
NEXTOUTER state the same as we used to do. After we've found that there's
no need to return to the marked position, we can go to SKIPINNER_ADVANCE
state instead of SKIP_TEST when the inner tuple is unmatchable; this
preserves the performance improvement. Per bug report from Bruce.
I also made a couple of cosmetic code rearrangements and added a regression
test for the problem.
Peter Eisentraut [Fri, 17 Mar 2006 16:02:47 +0000 (16:02 +0000)]
Document long names for format options (plain, tar, custom). They already
worked and someone asked about them, so we might as well document them.
Michael Meskes [Fri, 17 Mar 2006 15:46:13 +0000 (15:46 +0000)]
Fixed bug 2330: Wrong error code in case of a duplicate key
Tom Lane [Thu, 16 Mar 2006 18:11:17 +0000 (18:11 +0000)]
Fix invalid use of #if within a macro, per Laurenz Albe. Also try to
make the LDAP code's error messages look like they were written by someone
who had heard of our style guidelines.
Tom Lane [Thu, 16 Mar 2006 00:31:55 +0000 (00:31 +0000)]
Clean up representation of function RTEs for functions returning RECORD.
The original coding stored the raw parser output (ColumnDef and TypeName
nodes) which was ugly, bulky, and wrong because it failed to create any
dependency on the referenced datatype --- and in fact would not track type
renamings and suchlike. Instead store a list of column type OIDs in the
RTE.
Also fix up general failure of recordDependencyOnExpr to do anything sane
about recording dependencies on datatypes. While there are many cases where
there will be an indirect dependency (eg if an operator returns a datatype,
the dependency on the operator is enough), we do have to record the datatype
as a separate dependency in examples like CoerceToDomain.
initdb forced because of change of stored rules.
Bruce Momjian [Wed, 15 Mar 2006 03:24:17 +0000 (03:24 +0000)]
Fix typo in pgcvslog, used == instead of =.
Tom Lane [Tue, 14 Mar 2006 23:03:20 +0000 (23:03 +0000)]
It seems the YYLLOC_DEFAULT macro recommended by the Bison 1.875 manual
just doesn't work with Bison 2.0 ... fix it ...
Tom Lane [Tue, 14 Mar 2006 22:50:46 +0000 (22:50 +0000)]
Missed this file in previous commit :-(
Tom Lane [Tue, 14 Mar 2006 22:48:25 +0000 (22:48 +0000)]
Improve parser so that we can show an error cursor position for errors
during parse analysis, not only errors detected in the flex/bison stages.
This is per my earlier proposal. This commit includes all the basic
infrastructure, but locations are only tracked and reported for errors
involving column references, function calls, and operators. More could
be done later but this seems like a good set to start with. I've also
moved the ReportSyntaxErrorPosition logic out of psql and into libpq,
which should make it available to more people --- even within psql this
is an improvement because warnings weren't handled by ReportSyntaxErrorPosition.
Neil Conway [Mon, 13 Mar 2006 18:04:58 +0000 (18:04 +0000)]
Fix a number of syntax errors in contrib modules' uninstall scripts.
Most of the changes add the mandatory USING clause to DROP OPERATOR
CLASS statements. DROP TYPE is now DROP TYPE CASCADE; without
CASCADE a DROP TYPE fails due to the circular dependency on the
type's I/O functions. The DROP FUNCTION statements for the I/O
functions have been removed, as DROP TYPE CASCADE removes them
automatically. Patch from Michael Fuhr.
Bruce Momjian [Sat, 11 Mar 2006 16:57:44 +0000 (16:57 +0000)]
Remove Christof Petig copyright. He already approved removal from an
include file in the same area,.
Bruce Momjian [Sat, 11 Mar 2006 16:43:22 +0000 (16:43 +0000)]
Remove copyright notices from Jan (per author approval), and those files
derived from Jan's.
Bruce Momjian [Sat, 11 Mar 2006 04:38:42 +0000 (04:38 +0000)]
Add CVS tag lines to files that were lacking them.
Neil Conway [Sat, 11 Mar 2006 01:19:22 +0000 (01:19 +0000)]
Remove a few places that attempted to define INT_MAX, SCHAR_MAX, and
similar constants if they were not previously defined. All these
constants must be defined by limits.h according to C89, so we can
safely assume they are present.
Tom Lane [Fri, 10 Mar 2006 23:19:00 +0000 (23:19 +0000)]
Recent changes in memory management in tuplesort.c had a problem: the
case where we run low on array slots before we run low on memory is much
more probable than I had thought, and so it's important to treat each
tape fairly in that case. To fix this, track per-tape slot allocations
just like we track per-tape space allocation. Also, in the FINALMERGE
code path avoid scanning all the input tapes when we really only need to
read from one. This should fix poor behavior with very large work_mem
as exhibited by Stefan Kaltenbrunner.
I didn't do anything about putting an upper bound on the number of tapes,
but maybe we should still consider that.
Tom Lane [Fri, 10 Mar 2006 20:18:15 +0000 (20:18 +0000)]
Add a CHECK_FOR_INTERRUPTS() in _bt_buildadd(). This fixes problem
with not responding to query cancel during the last stage of btree index
creation.
Neil Conway [Fri, 10 Mar 2006 20:15:28 +0000 (20:15 +0000)]
Implement 4 new aggregate functions from SQL2003. Specifically: var_pop(),
var_samp(), stddev_pop(), and stddev_samp(). var_samp() and stddev_samp()
are just renamings of the historical Postgres aggregates variance() and
stddev() -- the latter names have been kept for backward compatibility.
This patch includes updates for the documentation and regression tests.
The catversion has been bumped.
NB: SQL2003 requires that DISTINCT not be specified for any of these
aggregates. Per discussion on -patches, I have NOT implemented this
restriction: if the user asks for stddev(DISTINCT x), presumably they
know what they are doing.
Bruce Momjian [Fri, 10 Mar 2006 19:12:51 +0000 (19:12 +0000)]
Remove unintened change to pg_proc.h.
Bruce Momjian [Fri, 10 Mar 2006 19:10:50 +0000 (19:10 +0000)]
Make $PostgreSQL CVS tags consistent for SGML files.
Tom Lane [Fri, 10 Mar 2006 15:39:42 +0000 (15:39 +0000)]
Fix order of linking of libxslt and libxml2, per Dave Page.
Tom Lane [Fri, 10 Mar 2006 01:51:23 +0000 (01:51 +0000)]
Add a CHECK_FOR_INTERRUPTS() to the loop in ExecMakeTableFunctionResult.
Otherwise you can't cancel queries like select ... from generate_series(1,
1000000).
Bruce Momjian [Thu, 9 Mar 2006 21:29:38 +0000 (21:29 +0000)]
Remove Jan Wieck's name from copyrights, and put in standard
boilerplate, with approval of author.
Tom Lane [Wed, 8 Mar 2006 22:59:09 +0000 (22:59 +0000)]
Remove somebody's flight of fancy about an UPDATE with ORDER BY and LIMIT.
Bruce Momjian [Wed, 8 Mar 2006 22:00:27 +0000 (22:00 +0000)]
Remove Christof Petig copyright on include file, per author request.
Tom Lane [Wed, 8 Mar 2006 16:59:03 +0000 (16:59 +0000)]
Tweak trace_sort code to show the merge order (number of active input
tapes) for each merge step. This will give us some idea of how effective
the merge distribution algorithm is.
Bruce Momjian [Wed, 8 Mar 2006 08:00:35 +0000 (08:00 +0000)]
Update pltcl expected file for E''.
Bruce Momjian [Wed, 8 Mar 2006 04:01:29 +0000 (04:01 +0000)]
Adjust plpython for escape_string_warning.
Bruce Momjian [Wed, 8 Mar 2006 03:58:53 +0000 (03:58 +0000)]
Adjust PL regression tests for escape_string_warning.
Bruce Momjian [Wed, 8 Mar 2006 03:51:52 +0000 (03:51 +0000)]
Update /contrib regression tests for escape_string_warning.
Tom Lane [Tue, 7 Mar 2006 23:46:24 +0000 (23:46 +0000)]
Further examination of ltsReleaseBlock usage shows that it's got a
performance issue during regular merge passes not only the 'final merge'
case. The original design contemplated that there would never be more
than about one free block per 'tape', hence no need for an efficient
method of keeping the free blocks sorted. But given the later addition
of merge preread behavior in tuplesort.c, there is likely to be about
work_mem worth of free blocks, which is not so small ... and for that
matter the number of tapes isn't necessarily small anymore either. So
we'd better get rid of the assumption entirely. Instead, I'm assuming
that the usage pattern will involve alternation between merge preread
and writing of a new run. This makes it reasonable to just add blocks
to the list without sorting during successive ltsReleaseBlock calls,
and then do a qsort() when we start getting ltsGetFreeBlock() calls.
Experimentation seems to confirm that there aren't many qsort calls
relative to the number of ltsReleaseBlock/ltsGetFreeBlock calls.
Tom Lane [Tue, 7 Mar 2006 19:06:50 +0000 (19:06 +0000)]
Repair old performance bug in tuplesort.c/logtape.c. In the case where
we are doing the final merge pass on-the-fly, and not writing the data
back onto a 'tape', the number of free blocks in the tape set will become
large, leading to a lot of time wasted in ltsReleaseBlock(). There is
really no need to track the free blocks anymore in this state, so add a
simple shutoff switch. Per report from Stefan Kaltenbrunner.
Tom Lane [Tue, 7 Mar 2006 17:32:22 +0000 (17:32 +0000)]
Turn off zero_damaged_pages in the right place (ie, in the autovac
process not in the postmaster) and with the right GucSource (needs to
be a nontransactional source since we've not started an xact yet).
Bruce Momjian [Tue, 7 Mar 2006 03:03:09 +0000 (03:03 +0000)]
Use SetConfigOption() to turn off "zero_damaged_pages" in autovacuum.
Bruce Momjian [Tue, 7 Mar 2006 03:01:22 +0000 (03:01 +0000)]
Back out comment update about sighup, original was accurate.
Bruce Momjian [Tue, 7 Mar 2006 02:54:23 +0000 (02:54 +0000)]
Properly set "escape_string_warning" to default to true.
Tom Lane [Tue, 7 Mar 2006 01:03:12 +0000 (01:03 +0000)]
Make all our flex and bison files use %option prefix or %name-prefix
(respectively) to rename yylex and related symbols. Some were doing
it this way already, while others used not-too-reliable sed hacks in
the Makefiles. It's all nice and consistent now.
Tom Lane [Tue, 7 Mar 2006 01:00:19 +0000 (01:00 +0000)]
Remove the stub support we had for UNION JOIN; per discussion, this is
not likely ever to be implemented seeing it's been removed from SQL2003.
This allows getting rid of the 'filter' version of yylex() that we had in
parser.c, which should save at least a few microseconds in parsing.
Tom Lane [Tue, 7 Mar 2006 00:48:07 +0000 (00:48 +0000)]
'make clean' should NOT remove *~ files.
Bruce Momjian [Mon, 6 Mar 2006 22:54:14 +0000 (22:54 +0000)]
SGML typo fix.
Bruce Momjian [Mon, 6 Mar 2006 22:52:10 +0000 (22:52 +0000)]
Default to ON for 8.2, as announced in the release notes:
escape_string_warning = on
Bruce Momjian [Mon, 6 Mar 2006 22:51:20 +0000 (22:51 +0000)]
Done though the second is default so off in 8.2:
> * -Eventually enable escape_string_warning and standard_conforming_strings
Bruce Momjian [Mon, 6 Mar 2006 22:49:17 +0000 (22:49 +0000)]
Attached is the new patch. To summarize:
- new function justify_interval(interval)
- modified function justify_hours(interval)
- modified function justify_days(interval)
These functions are defined to meet the requirements as discussed in
this thread. Specifically:
- justify_hours makes certain the sign bit on the hours
matches the sign bit on the days. It only checks the
sign bit on the days, and not the months, when
determining if the hours should be positive or negative.
After the call, -24 < hours < 24.
- justify_days makes certain the sign bit on the days
matches the sign bit on the months. It's behavior does
not depend on the hours, nor does it modify the hours.
After the call, -30 < days < 30.
- justify_interval makes sure the sign bits on all three
fields months, days, and hours are all the same. After
the call, -24 < hours < 24 AND -30 < days < 30.
Mark Dilger
Bruce Momjian [Mon, 6 Mar 2006 19:49:20 +0000 (19:49 +0000)]
Enable standard_conforming_strings to be turned on.
Kevin Grittner
Bruce Momjian [Mon, 6 Mar 2006 18:38:11 +0000 (18:38 +0000)]
Update comment on how sighup signal affects postgresql.conf reload.
Markus Bertheau
Bruce Momjian [Mon, 6 Mar 2006 17:59:30 +0000 (17:59 +0000)]
* Stephen Frost (sfrost@snowman.net) wrote:
> I've now tested this patch at home w/ 8.2HEAD and it seems to fix the
> bug. I plan on testing it under 8.1.2 at work tommorow with
> mod_auth_krb5, etc, and expect it'll work there. Assuming all goes
> well and unless someone objects I'll forward the patch to -patches.
> It'd be great to have this fixed as it'll allow us to use Kerberos to
> authenticate to phppgadmin and other web-based tools which use
> Postgres.
While playing with this patch under 8.1.2 at home I discovered a
mistake in how I manually applied one of the hunks to fe-auth.c.
Basically, the base code had changed and so the patch needed to be
modified slightly. This is because the code no longer either has a
freeable pointer under 'name' or has 'name' as NULL.
The attached patch correctly frees the string from pg_krb5_authname
(where it had been strdup'd) if and only if pg_krb5_authname returned
a string (as opposed to falling through and having name be set using
name = pw->name;). Also added a comment to this effect.
Backpatch to 8.1.X.
Stephen Frost
Bruce Momjian [Mon, 6 Mar 2006 17:41:44 +0000 (17:41 +0000)]
This patch adds native LDAP auth, for those platforms that don't have
PAM (such as Win32, but also unixen without PAM). On Unix, uses
OpenLDAP. On win32, uses the builin WinLDAP library.
Magnus Hagander
Bruce Momjian [Mon, 6 Mar 2006 17:10:31 +0000 (17:10 +0000)]
Add:
> o Prevent parent tables from altering or dropping constraints
> like CHECK that are inherited by child tables
>
> Dropping constraints should only be possible with CASCADE.
>
Bruce Momjian [Mon, 6 Mar 2006 15:21:42 +0000 (15:21 +0000)]
Update item.
Bruce Momjian [Mon, 6 Mar 2006 15:19:45 +0000 (15:19 +0000)]
Add for Win32:
> o Check WSACancelBlockingCall() for interrupts (win32intr)
>
Bruce Momjian [Mon, 6 Mar 2006 15:19:19 +0000 (15:19 +0000)]
Add WSACancelBlockingCall TODO.detail item.
Bruce Momjian [Mon, 6 Mar 2006 15:13:38 +0000 (15:13 +0000)]
Add for ecpg:
> o Add COPY TO STDIN / STDOUT handling
Bruce Momjian [Mon, 6 Mar 2006 15:09:04 +0000 (15:09 +0000)]
Fix psql history handling so 'execute' backslash commands (\g)
remain as part of the multi-line query.
Bruce Momjian [Mon, 6 Mar 2006 05:22:31 +0000 (05:22 +0000)]
Update:
< * %Disallow changing sequence characteristics like INCREMENT for SERIAL columns
> * %Disallow ALTER SEQUENCE changes for SERIAL sequences because pg_dump
> does not dump the changes
Bruce Momjian [Mon, 6 Mar 2006 05:16:21 +0000 (05:16 +0000)]
Add:
> * %Disallow changing sequence characteristics like INCREMENT for SERIAL columns
Bruce Momjian [Mon, 6 Mar 2006 05:14:19 +0000 (05:14 +0000)]
Prevent autovacuum from zeroing damaged pages.