OSDN Git Service
Greg Kroah-Hartman [Sat, 12 Jul 2014 01:44:39 +0000 (18:44 -0700)]
staging: lnet: lib-lnet.h: checkpatch cleanup: align arguments to parenthesis
whitespace changes only - git diff -w shows no difference
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 12 Jul 2014 01:40:36 +0000 (18:40 -0700)]
staging: lnet: types.h: checkpatch cleanup: whitespace neatening
whitespace changes only - git diff -w shows no difference
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Utkin [Fri, 11 Jul 2014 14:38:30 +0000 (15:38 +0100)]
staging: comedi: ni_atmio16d.c: remove pointless condition
The issue was discovered with static analysis and has two instances in
this file. The code looks like this
if (x <
65536000) {
...
} else if (x <
655360000) {
...
} else if (x <= 0xffffffff /*
6553600000 */) {
...
} else if (x <= 0xffffffff /*
65536000000 */) {
...
}
The meaning of this block is to select appropriate clock frequency for
interval timer basing on "x", which is amount of time.
Notes:
1. That last condition matches previous one - that's the issue.
2. Decimal numbers in comments don't match hex numbers in expressions.
But in first case the numbers have same order, while in the second case
the hex number is the same, and the decimal one is 10 times bigger.
3. Actually type of "x" is "unsigned int", so its exact upper limit is
not obviously known.
4. There's no "else" block.
So it makes sense to make an "else" block from last "else if" case. The
code inside the block seems correct for such usage.
[ Actually, get rid of the final "else if" case and change the
next-to-last "else if" case to an "else" as the upper limit of "x" _is_
known to be 0xffffffff (UINT_MAX), which is less than
6553600000 -- Ian ]
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=79871
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Fri, 11 Jul 2014 04:02:55 +0000 (23:02 -0500)]
staging: comedi: addi_apci_1564: fix s->maxdata assignment in do subdevice init.
s->maxdata for the do subdevice should be 1, however currently it is
being set to 0xffffffff. Fix this.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Fri, 11 Jul 2014 04:02:27 +0000 (23:02 -0500)]
staging: comedi: addi_apci_1564: remove null check of devpriv in apci1564_detach()
There is no need to test whether devpriv is null in this function. The
check looks left over and we can just remove it.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Fri, 11 Jul 2014 04:02:04 +0000 (23:02 -0500)]
staging: comedi: addi_apci_1564: remove unnecessary dev->board_name initialization
The dev->board_name is now initialized by the comedi core before calling
the(*attach) or (*auto_attach) function in a driver. As long as the driver
does no additional probing, it's no longer necessary initialize the board_name.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Fri, 11 Jul 2014 04:01:26 +0000 (23:01 -0500)]
staging: comedi: addi_apci_1564: remove len_chanlist from di and do subdevices
This value is only needed for subdevices that support async commands.
The comedi core will default the value to 1 when it is not initialized.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 19:02:18 +0000 (20:02 +0100)]
staging: vt6656: Fix pairwise key for non station modes
patch 'vnt_set_keymode don't save pairwise key entry' caused
a slight regression in access point mode
Only don't save in station mode.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 19:02:17 +0000 (20:02 +0100)]
staging: vt6656: vnt_init_bands fix missing default.
The default is that all the channels are enabled for rf types
not mentioned here.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 16:25:42 +0000 (01:25 +0900)]
MAINTAINERS: Adds Daeseok Youn to maintainers list for dgap
Adds "Daeseok Youn" to maintainers list for dgap driver.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:24:34 +0000 (19:24 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetcustombaud()
Null checks in dgap_tty_digisetcustombaud() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:24:14 +0000 (19:24 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digigetcustombaud()
Null checks in dgap_tty_digigetcustombaud() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:23:54 +0000 (19:23 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetedelay()
Null checks in dgap_tty_digisetedelay() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:23:34 +0000 (19:23 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_set_modem_info()
Null checks in dgap_set_modem_info() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd" and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:23:16 +0000 (19:23 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digigeta()
Null checks in dgap_tty_digigeta() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "un".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:22:58 +0000 (19:22 +0900)]
staging: dgap: removes redundant null check and change paramter for dgap_tty_digiseta()
Null checks in dgap_tty_digiseta() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "bd" which are used in dgap_tty_digiseta().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:22:39 +0000 (19:22 +0900)]
staging: dgap: removes redundant null check and change the paramter for dgap_param()
The dgap_param() has a paramter which is tty_struct and
use variables in that struct. That variables which are "ch", "bd", "bs"
and "un" do not need to check NULL so these statements are removed.
And also change the parameter of this function because
it is possible to let someone know what paramters
are needed for this function.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:22:21 +0000 (19:22 +0900)]
staging: dgap: remove unused variable in dgap_param()
The "ts" is not used in dgap_param().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 11 Jul 2014 10:22:04 +0000 (19:22 +0900)]
staging: dgap: redundant NULL and magic check in dgap_get_modem_info()
The "ch" is already checking in caller.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:31 +0000 (01:08 +0100)]
staging: vt6656: rxtx replace debug messages DBG_PRT
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:30 +0000 (01:08 +0100)]
staging: vt6656: rxtx remove unneeded comments
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:29 +0000 (01:08 +0100)]
staging: vt6656: rxtx remove static declarations
all functions are in visibility order.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:28 +0000 (01:08 +0100)]
staging: vt6656: rename s_vGetFreeContext to vnt_get_free_context
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:27 +0000 (01:08 +0100)]
staging: vt6656: clean up and rename wFB_Opt1 to vnt_fb_opt1
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:26 +0000 (01:08 +0100)]
staging: vt6656: clean up and rename wFB_Opt0 to vnt_fb_opt0
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:25 +0000 (01:08 +0100)]
staging: vt6656: rename and cleanup wTimeStampOff
Rename to vnt_time_stampoff
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:24 +0000 (01:08 +0100)]
staging: vt6656: rename s_uGetTxRsvTime to vnt_get_rsvtime
Drop tx from name
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:23 +0000 (01:08 +0100)]
staging: vt6656: rename s_uGetRTSCTSRsvTime to vnt_get_rtscts_rsvtime_le
Function always returns little endian.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:22 +0000 (01:08 +0100)]
staging: vt6656: rename s_uGetDataDuration to vnt_get_duration_le
Drop data and the function always returns little endian
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:21 +0000 (01:08 +0100)]
staging: vt6656: s_uGetDataDuration remove camel case
camel case changes
pDevice -> priv
byPktType -> pkt_type
bNeedAck -> need_ack
uAckTime -> ack_time
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:20 +0000 (01:08 +0100)]
staging: vt6656: rxtx rename s_uGetRTSCTSDuration to vnt_get_rtscts_duration_le
Function always returns little endian value.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 11 Jul 2014 00:08:19 +0000 (01:08 +0100)]
staging: vt6656: s_uGetRTSCTSDuration remove camel case
camel case changes
pDevice -> priv
byDurType -> dur_type
cbFrameLength -> frame_length
byPktType -> pkt_type
wRate -> rate
bNeedAck -> need_ack
uCTSTime -> cts_time
uDurTime -> dur_time
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexey Khoroshilov [Thu, 10 Jul 2014 23:31:41 +0000 (19:31 -0400)]
staging: gdm724x: fix leak at failure path in init_usb()
If an allocation in init_usb() failed, it returns without
deallocation of already allocated resources.
The patch fix it and replaces GFP_ATOMIC by GFP_KERNEL in
alloc_tx_sdu_struct() and alloc_rx_struct() as long as
they are called from probe only.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:53 +0000 (16:56 +0200)]
staging:
ced1401: usb1401.c: join quoted strings
Fix checkpatch warnings "quoted string split across lines" in file usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:52 +0000 (16:56 +0200)]
staging:
ced1401: usb1401.c: split long lines
Fix checkpatch warnings "line over 80 characters" in file usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:51 +0000 (16:56 +0200)]
staging:
ced1401: usb1401.c rename camel case variable
Rename camel case variable dwCount in function ced_writechar_callback
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:50 +0000 (16:56 +0200)]
staging:
ced1401: usb1401.c: fix code indent
Fix checkpatch warning "suspect code indent for conditional statements" in file
usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:49 +0000 (16:56 +0200)]
staging:
ced1401: usb1401.c: add blank line after declarations
Fix checkpatch warnings "Missing a blank line after declarations" in file
usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:48 +0000 (16:56 +0200)]
staging:
ced1401: ced_ioc.c : split long lines
Fix checkpatch warnings "line over 80 characters" in file ced_ioc.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:47 +0000 (16:56 +0200)]
staging:
ced1401: ced_ioc.c: remove else branch in ced_wait_event
Fix checkpatch warning "else is not generally useful after a break or return" in
file ced_ioc.c, function ced_wait_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:46 +0000 (16:56 +0200)]
staging:
ced1401: ced_ioc.c: remove else branch in ced_set_event
Fix checkpatch warning "else is not generally useful after a break or return" in
file ced_ioc.c, function ced_set_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:45 +0000 (16:56 +0200)]
staging:
ced1401: ced_ioc.c: remove space before tabs
Fix checkpatch warning "please, no space before tabs" in file
ced_ioc.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:44 +0000 (16:56 +0200)]
staging:
ced1401: ced_ioc.c: add blank line after declarations
Fix checkpatch warnings "Missing a blank line after declarations" in file
ced_ioc.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:43 +0000 (16:56 +0200)]
staging:
ced1401: usb1401.h: fix "foo * bar"
Fix checkpatch error "foo * bar" should be "foo *bar" in file usb1401.h
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Fri, 11 Jul 2014 14:56:42 +0000 (16:56 +0200)]
staging:
ced1401: usb1401.c: change spaces to tabs
Fix checkpatch errors "code indent should use tabs where possible" in file
usb1401.c
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:17 +0000 (19:56 +0100)]
staging: vt6656: rename s_vFillCTSHead to vnt_fill_cts_head
Removing static declaration.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:16 +0000 (19:56 +0100)]
staging: vt6656: s_vFillCTSHead remove camel case
Camel case changes
byPktType -> pkt_type
cbFrameLength -> frame_len
bNeedAck -> need_ack
pDevice -> priv
uCTSFrameLen -> cts_frame_len
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:15 +0000 (19:56 +0100)]
staging: vt6656: rename s_vGenerateTxParameter to vnt_generate_tx_parameter
Removing static declaration
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:14 +0000 (19:56 +0100)]
staging: vt6656: s_vGenerateTxParameter remove camel case
Camel case changes
byPktType -> pkt_type
wCurrentRate -> current_rate
cbFrameSize -> frame_size
bNeedACK -> need_ack
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:13 +0000 (19:56 +0100)]
staging: vt6656: s_vGenerateTxParameter remove else from if statements
The function returns out at if statements so drop else.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:12 +0000 (19:56 +0100)]
staging: vt6656: merge data positions for packet types a and b into vnt_rxtx_ab
add rts positions from s_vFillRTSHead
add need_mic and remaining union vnt_tx_data_head head positions from
s_vGenerateTxParameter for packet type PK_TYPE_11A and PK_TYPE_11B..
As there are no other possibilities for packet types in s_vGenerateTxParameter
the if becomes else.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:11 +0000 (19:56 +0100)]
staging: vt6656: move s_vFillCTSHead to vnt_rxtx_cts
add need_mic and union vnt_tx_data_head head positions from s_vGenerateTxParameter.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:10 +0000 (19:56 +0100)]
staging: vt6656: merge PK_TYPE_11GB and PK_TYPE_11GA into vnt_rxtx_rts
add to vnt_rxtx_rts calls from s_vFillRTSHead.
add need_mic and union vnt_tx_data_head head positions from s_vGenerateTxParameter.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:09 +0000 (19:56 +0100)]
staging: vt6656: s_vGenerateTxParameter parse out vnt_rrv_time_ab
create new function vnt_rxtx_ab which will eventually carry onward
functions
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:08 +0000 (19:56 +0100)]
staging: vt6656: s_vGenerateTxParameter rxtx.c s_vGenerateTxParameter pBuf->rrv_time always the calling pkt_type
Use byPktType instead of macro.
The pkt_type has already been filtered in this function so its always set
to the correct one.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:07 +0000 (19:56 +0100)]
staging: vt6656: s_vGenerateTxParameter Parse out struct vnt_rrv_time_cts
Create new function vnt_rxtx_cts that will eventually carry onward
function.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:06 +0000 (19:56 +0100)]
staging: vt6656: s_vGenerateTxParameter Parse out struct vnt_rrv_time_rts
Creat new function vnt_rxtx_rts that will eventually carry onward
functions.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:05 +0000 (19:56 +0100)]
staging: vt6656: move current_rate setting out of s_vGenerateTxParameter
Removing unneeded pointers
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:04 +0000 (19:56 +0100)]
staging: vt6656: rxtx remove fb_option from functions.
This is now dead code.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:03 +0000 (19:56 +0100)]
staging: vt6656: rxtx: move tx_context->fb_option into function structure.
Replace fb_option in function calls with tx_context->fb_option.
Namely functions s_vFillCTSHead and s_vFillRTSHead
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 10 Jul 2014 18:56:02 +0000 (19:56 +0100)]
staging: vt6656: rxtx remove struct ethhdr from functions
ethhdr is nolonger used by driver.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sanjeev sharma [Thu, 10 Jul 2014 12:24:56 +0000 (17:54 +0530)]
staging: rtl8192u: Fixed switch and case indentation error
This patch will fix switch and case indentation Error
reported by checkpatch script.
Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sanjeev sharma [Thu, 10 Jul 2014 12:24:54 +0000 (17:54 +0530)]
staging: rtl8192u: Remove useless return statement
This patch will remove unneeded return statements in
code.
Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Thu, 10 Jul 2014 11:45:44 +0000 (12:45 +0100)]
staging: comedi: ni_daq_700: remove MODULE_VERSION() and commentary
We don't module version numbers for in-kernel drivers. The kernel
version number is sufficient information.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Thu, 10 Jul 2014 11:45:43 +0000 (12:45 +0100)]
staging: comedi: vmk80xx: remove MODULE_VERSION() from in-kernel module
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vincent Heuken [Thu, 10 Jul 2014 10:34:28 +0000 (03:34 -0700)]
Staging: panel: fixed frivilous else statement warning
Fixed one instance of the following checkpatch.pl warning in
panel.c:
WARNING: else is not generally useful after a break or return
Signed-off-by: Vincent Heuken <me@vincentheuken.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kees Cook [Thu, 10 Jul 2014 20:16:11 +0000 (13:16 -0700)]
staging: r8821ae: avoid leaking format string
This make sure a format string cannot leak into the work queue name nor
the printk buffer.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:12 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_free_circ_block()
Rename camel case arguments and locals in function ced_free_circ_block()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:11 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_get_circ_block()
Rename camel case arguments and locals in function ced_get_circ_block()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:10 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_set_circular()
Rename camel case arguments and locals in function ced_set_circular()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:09 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_dbg_stop_loop()
Rename camel case arguments and locals in function ced_dbg_stop_loop()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:08 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_dbg_get_data()
Rename camel case arguments and locals in function ced_dbg_get_data()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:07 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_dbg_ramp_data/addr()
Rename camel case arguments and locals in function ced_dbg_ramp_data() and
ced_dbg_ramp_addr()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:06 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_dbg_peek/poke()
Rename camel case arguments and locals in function ced_dbg_peek() and
ced_dbg_poke()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:05 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_dbg_cmd()
Rename camel case arguments and locals in function ced_dbg_cmd()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:04 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_transfer_flags()
Rename camel case arguments and locals in function ced_transfer_flags()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:03 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_type_of_1401()
Rename camel case arguments and locals in function ced_type_of_1401()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:02 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_check_self_test()
Rename camel case arguments and locals in function ced_check_self_test()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:01 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_start_self_test()
Rename camel case arguments and locals in function ced_start_self_test()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:04:00 +0000 (11:04 +0200)]
staging:
ced1401: fix ced_state_of_1401()
Rename camel case arguments and locals in function ced_state_of_1401()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:03:59 +0000 (11:03 +0200)]
staging:
ced1401: fix ced_get_transfer()
Rename camel case arguments and locals in function ced_get_transfer()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:03:58 +0000 (11:03 +0200)]
staging:
ced1401: fix ced_test_event()
Rename camel case arguments and locals in function ced_test_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:03:57 +0000 (11:03 +0200)]
staging:
ced1401: fix ced_wait_event()
Rename camel case arguments and locals in function ced_wait_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:03:56 +0000 (11:03 +0200)]
staging:
ced1401: fix ced_set_event()
Rename camel case arguments and locals in function ced_set_event()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:03:55 +0000 (11:03 +0200)]
staging:
ced1401: fix ced_unset_transfer()
Rename camel case arguments and locals in function ced_unset_transfer()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:03:54 +0000 (11:03 +0200)]
staging:
ced1401: fix ced_set_transfer()
Rename camel case arguments and locals in function ced_set_transfer()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:03:53 +0000 (11:03 +0200)]
staging:
ced1401: fix ced_set_area()
Rename camel case arguments and locals in function ced_set_area()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:20 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_clear_area()
Rename camel case arguments and locals in function ced_clear_area()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:19 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_get_out_buf_space()
Rename camel case arguments and locals in function ced_get_out_buf_space()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:18 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_line_count()
Rename camel case arguments and locals in function ced_line_count()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:17 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_stat_1401()
Rename camel case arguments and locals in function ced_stat_1401()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:16 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_get_string()
Rename camel case arguments and locals in function ced_get_string()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:15 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_get_char()
Rename camel case arguments and locals in function ced_get_char()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:14 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_quick_check()
Rename camel case arguments and locals in function ced_quick_check()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:13 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_is_1401()
Rename camel case arguments and locals in function ced_is_1401()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:12 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_in_self_test()
Rename camel case arguments and locals in function ced_in_self_test()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:11 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_get_state()
Rename camel case arguments and locals in function ced_get_state()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:10 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_send_char()
Rename camel case arguments and locals in function ced_send_char()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:09 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_send_string()
Rename camel case arguments and locals in function ced_send_string()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ellero [Thu, 10 Jul 2014 09:02:08 +0000 (11:02 +0200)]
staging:
ced1401: fix ced_put_chars()
Rename camel case arguments and locals in function ced_put_chars()
Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>