OSDN Git Service
Glenn Kasten [Sat, 3 Dec 2016 00:26:33 +0000 (16:26 -0800)]
fifo: Fix build
Test: builds OK on macOS
Change-Id: Icac55988f07fb4e4960edd218a33963b6908ce33
Glenn Kasten [Fri, 2 Dec 2016 00:12:59 +0000 (16:12 -0800)]
fifo: isolate atomic and futex operations
Now all atomic and futex operations occur in fifo_index.cpp.
This implements these TODOs:
- Abstract out atomic operations to audio_utils_fifo_index
- Replace friend by setter and getter, and abstract the futex
This is one of a series of CLs to isolate the dependencies.
Test: builds OK on Android, host Linux, and host macOS
Change-Id: Ic4ec46d472c583dce8525f11ed8cb1db89928d30
Glenn Kasten [Thu, 1 Dec 2016 16:30:21 +0000 (08:30 -0800)]
fifo: pull out clock_nanosleep and futex to separate files
This is one of a series of CLs to isolate the dependencies.
Test: builds OK on Android, host Linux, and host macOS
Change-Id: I8ffcab7b7c4acab141b09f75f593ebde1ebec31a
Pavlin Radoslavov [Thu, 1 Dec 2016 03:28:17 +0000 (03:28 +0000)]
Merge "Fix a typo in config rate check: 441000 -> 44100" am:
84e3d1d1e2 am:
7f7c9626de am:
819eafd923
am:
2bf4141a10
Change-Id: I7fd229ef487c726ff7f96b0377a7ebec3768af49
Pavlin Radoslavov [Thu, 1 Dec 2016 03:22:46 +0000 (03:22 +0000)]
Merge "Fix a typo in config rate check: 441000 -> 44100" am:
84e3d1d1e2 am:
7f7c9626de
am:
819eafd923
Change-Id: I4a0c07f6cc8ec510747cf499a3b305bb323b1d44
Pavlin Radoslavov [Thu, 1 Dec 2016 03:17:45 +0000 (03:17 +0000)]
Merge "Fix a typo in config rate check: 441000 -> 44100" am:
84e3d1d1e2
am:
7f7c9626de
Change-Id: I76380d4d6685f359c947dff027069414402780df
Pavlin Radoslavov [Thu, 1 Dec 2016 03:12:45 +0000 (03:12 +0000)]
Merge "Fix a typo in config rate check: 441000 -> 44100"
am:
84e3d1d1e2
Change-Id: I3e570ab57af3f836f4224770301631b06e2204ba
Treehugger Robot [Thu, 1 Dec 2016 03:02:33 +0000 (03:02 +0000)]
Merge "Fix a typo in config rate check: 441000 -> 44100"
Glenn Kasten [Wed, 30 Nov 2016 23:39:19 +0000 (23:39 +0000)]
Merge "fifo: add shutdown state"
rago [Wed, 30 Nov 2016 21:02:17 +0000 (13:02 -0800)]
Fix security vulnerability: potential OOB write in audioserver
Bug:
32705438
Bug:
32703959
Test: cts security test
(audio_effect.h moved to a different branch)
Change-Id: I36a2c19373e0a2c7bf90599c0ccbb9e0ad815f65
Pavlin Radoslavov [Wed, 30 Nov 2016 18:45:32 +0000 (10:45 -0800)]
Fix a typo in config rate check: 441000 -> 44100
Test: code compilation
Change-Id: I073e1a46723417259c265720168d90938fd38dd0
Glenn Kasten [Tue, 22 Nov 2016 22:00:23 +0000 (14:00 -0800)]
fifo: add shutdown state
FIFO is marked shutdown after an "impossible" error is detected.
Usually this indicate that memory has become corrupted, or incorrect use
of the API. Once the FIFO is marked shutdown, all APIs that can return
an error code will return -EIO, and all other APIs will become no-ops.
Test: see unit tests in tests/ directory
Change-Id: I559145d613c3783a699a9ced062dd5ff3676769d
Jean-Michel Trivi [Mon, 28 Nov 2016 22:24:36 +0000 (22:24 +0000)]
Merge "Count a11y stream as public stream"
Jean-Michel Trivi [Wed, 23 Nov 2016 23:45:48 +0000 (15:45 -0800)]
Count a11y stream as public stream
Test: see bug
Bug:
30448020
Change-Id: Iad817f47d11e8766fea5d1c083823e2b132b606d
Glenn Kasten [Tue, 22 Nov 2016 22:02:11 +0000 (14:02 -0800)]
fifo: update documentation
Test: builds OK
Change-Id: I5a3d0bdadc8613e8501b020457665135677f7b63
Glenn Kasten [Tue, 22 Nov 2016 22:00:53 +0000 (14:00 -0800)]
fifo: use const more
Test: builds OK
Change-Id: I81c4e656b65e9e50f3affb11aeb3b51b0a36e3f7
Glenn Kasten [Mon, 21 Nov 2016 20:13:03 +0000 (20:13 +0000)]
Merge "Rename hysteresis-related symbols for clarity"
Glenn Kasten [Mon, 21 Nov 2016 20:12:52 +0000 (20:12 +0000)]
Merge "Fix a few clang-tidy warnings"
Glenn Kasten [Fri, 18 Nov 2016 23:28:42 +0000 (15:28 -0800)]
Fix a few clang-tidy warnings
Test: still builds
Change-Id: I6583f4f600a24a0784cdda186f77d5cacffc6cc5
Glenn Kasten [Fri, 18 Nov 2016 21:34:01 +0000 (13:34 -0800)]
Rename hysteresis-related symbols for clarity
Test: builds OK
Change-Id: I47fc5c5b7cbe6354386e143a5f9a5b5f9f3322a6
Glenn Kasten [Wed, 16 Nov 2016 20:53:33 +0000 (20:53 +0000)]
Merge "fifo: add new APIs, and other cleanup"
TreeHugger Robot [Mon, 14 Nov 2016 22:34:54 +0000 (22:34 +0000)]
Merge "audio_route: do not check for null pointer when freeing"
David Lin [Sat, 12 Nov 2016 01:43:16 +0000 (17:43 -0800)]
audio_route: do not check for null pointer when freeing
Remove null pointer checks when doing free()
Test: make
Change-Id: I29c3641aa66b2a56676fa1cc062055bbf16d67d3
Signed-off-by: David Lin <dtwlin@google.com>
Glenn Kasten [Wed, 19 Oct 2016 19:14:46 +0000 (12:14 -0700)]
fifo: add new APIs, and other cleanup
New APIs:
- buffer()
- capacity()
- flush()
- frameSize()
- totalFlushed()
- totalLost()
- totalReleased()
Pull up mFifo from writer and reader into the base provider class.
Update documentation.
Test: see unit tests in tests/ directory
Change-Id: I1957638c69e1c1dc742b6f024156def757736867
Eric Laurent [Fri, 11 Nov 2016 01:41:23 +0000 (17:41 -0800)]
radio metadata: add API to get channel and subchannel
Change-Id: I5a5a3a58b8ec667f9a1d911210efd897fc7713cb
Andy Hung [Thu, 10 Nov 2016 19:15:45 +0000 (19:15 +0000)]
Merge "Add AUDIO_UID_INVALID"
Mikhail Naganov [Tue, 8 Nov 2016 22:11:36 +0000 (14:11 -0800)]
Move AUDIO_DEVICE_*_STUB to system/audio.h.
This is needed so it can be used in TypeConverter.cpp
Bug:
32740394
Change-Id: Ie203df160b808818813c169733641b6ac68b96f5
Test: make & check on the device
Andy Hung [Tue, 8 Nov 2016 01:38:17 +0000 (17:38 -0800)]
Add AUDIO_UID_INVALID
Test: power manager should show correct uids for audio
Bug:
32713790
Change-Id: Ib6993e2f06b3fbf5a96942088fa1bae30c5f781f
Marco Nelissen [Mon, 7 Nov 2016 18:00:33 +0000 (18:00 +0000)]
Merge "IAudioPolicyService is now in libaudioclient instead of libmedia" am:
76f97250ff am:
c58a77360c am:
ff3b15b22e
am:
7a73cf02af
Change-Id: Ib5c3c7d3a527e47051d795be4a26e30f525c989a
Marco Nelissen [Mon, 7 Nov 2016 17:41:49 +0000 (17:41 +0000)]
Merge "IAudioPolicyService is now in libaudioclient instead of libmedia" am:
76f97250ff am:
c58a77360c
am:
ff3b15b22e
Change-Id: I8903ffc0ae1b6422d0e10a12817694f072c9a8c9
Marco Nelissen [Mon, 7 Nov 2016 17:32:14 +0000 (17:32 +0000)]
Merge "IAudioPolicyService is now in libaudioclient instead of libmedia" am:
76f97250ff
am:
c58a77360c
Change-Id: Id3f3ec80c10a4d698e6f38660cfc911337b91e69
Marco Nelissen [Mon, 7 Nov 2016 17:22:52 +0000 (17:22 +0000)]
Merge "IAudioPolicyService is now in libaudioclient instead of libmedia"
am:
76f97250ff
Change-Id: Ie85b93bdb1b0b004c4cfe9cd2f60cc8766781ced
Marco Nelissen [Mon, 7 Nov 2016 17:14:24 +0000 (17:14 +0000)]
Merge "IAudioPolicyService is now in libaudioclient instead of libmedia"
Marco Nelissen [Fri, 4 Nov 2016 16:40:24 +0000 (09:40 -0700)]
IAudioPolicyService is now in libaudioclient instead of libmedia
Test: build
Change-Id: I865f3c4bc3a4823802944501f2b3f86711059356
Marco Nelissen [Fri, 4 Nov 2016 21:53:53 +0000 (21:53 +0000)]
Merge "IAudioPolicyService is now in libaudioclient instead of libmedia"
Marco Nelissen [Fri, 4 Nov 2016 16:40:24 +0000 (09:40 -0700)]
IAudioPolicyService is now in libaudioclient instead of libmedia
Test: build
Change-Id: I865f3c4bc3a4823802944501f2b3f86711059356
Dan Willemsen [Thu, 3 Nov 2016 20:55:28 +0000 (13:55 -0700)]
Fix build with MacOS 10.12 SDK
Test: mmma -j system/media/audio_utils
Change-Id: Iab8270c5f2dc011a984acd78f59a3adca73b7a62
Thierry Strudel [Thu, 27 Oct 2016 17:12:43 +0000 (10:12 -0700)]
audio_route: check if subpath name is valid before trying to add it
Change-Id: I38d38c14d68e0fb25af188661cba750b7cac8f99
Eric Laurent [Thu, 27 Oct 2016 15:23:04 +0000 (15:23 +0000)]
Merge "radio: fix metadata compatibility for 64 bit processes"
Eric Laurent [Tue, 25 Oct 2016 18:01:45 +0000 (11:01 -0700)]
radio: fix metadata compatibility for 64 bit processes
Clarify use of 32 bit quantities in radio metadata APIs and internal
implementation: all "unsigned int" are replaced by uint32_t.
Also use size_t when appropriate.
Add checks and asserts on invalid metadata buffer size.
Change-Id: I1e4a995858467c679b978574c305d82814f8c15c
Glenn Kasten [Wed, 19 Oct 2016 22:46:02 +0000 (15:46 -0700)]
fifo: fix bugs in lost frames calculation
Problems fixed:
- did not set the lost frames parameter to zero when no frames were lost
- under-estimated lost frames by mFrameCount
Also improved the documentation about lost frames.
Test: currently using interactive test only, need an automated version
Change-Id: I8b056c9cf4ead0d197b4c3aeff8482a08710c4cb
Glenn Kasten [Thu, 20 Oct 2016 18:21:52 +0000 (18:21 +0000)]
Merge "fifo: address code review comments"
Glenn Kasten [Wed, 19 Oct 2016 18:13:55 +0000 (11:13 -0700)]
fifo: address code review comments
Test: builds OK
Change-Id: I20f1a2e0cf0d63e4a5c04bf7f3364d0e71d8e929
Mikhail Naganov [Tue, 18 Oct 2016 21:46:05 +0000 (14:46 -0700)]
Move audio hw module names to system/
The names of the modules are also used in audio policy configuration
files and thus need to be consistent between HAL and the framework.
Change-Id: I55510bfe425f9fd8634530ed6db25514da081007
Test: make
Mikhail Naganov [Tue, 18 Oct 2016 16:10:05 +0000 (16:10 +0000)]
Merge "Move audio_effects_conf.h to system/audio_effects"
Mikhail Naganov [Tue, 18 Oct 2016 16:01:15 +0000 (16:01 +0000)]
Merge "Move parameters that are used by framework to system/audio.h"
Glenn Kasten [Fri, 14 Oct 2016 15:51:20 +0000 (08:51 -0700)]
Handle futex status EWOULDBLOCK
Test: very difficult, as it is a race condition that rarely occurs
Change-Id: Ibefe09d1e9d940f57463391ed339325b42b84b73
Glenn Kasten [Tue, 18 Oct 2016 01:08:29 +0000 (01:08 +0000)]
Merge "Address code review comments"
Mikhail Naganov [Tue, 18 Oct 2016 01:03:56 +0000 (18:03 -0700)]
Move audio_effects_conf.h to system/audio_effects
This file is not really related to HAL.
Also removed executable bit from it, thanks to gkasten@
Change-Id: I4f4fb2bb6c3792b06dfad2ecdd5e07428acbc351
Test: make
Glenn Kasten [Tue, 18 Oct 2016 00:51:26 +0000 (00:51 +0000)]
Merge "Change struct timeout * to const struct timeout *"
Mikhail Naganov [Tue, 18 Oct 2016 00:14:23 +0000 (17:14 -0700)]
Move parameters that are used by framework to system/audio.h
Note that it is preferred to use the constants from AudioParameter
instead of directly using preprocessor defines.
Change-Id: I072448d06ec6dbbc760519004576bc4fe1438062
Test: make
Mikhail Naganov [Mon, 17 Oct 2016 22:22:49 +0000 (22:22 +0000)]
Merge "Split audio effects headers"
Glenn Kasten [Sun, 16 Oct 2016 21:51:15 +0000 (14:51 -0700)]
Change struct timeout * to const struct timeout *
Test: builds OK
Change-Id: I8372ab83a50d527dffbfbb5014ac93ee4692f577
Mikhail Naganov [Fri, 14 Oct 2016 22:33:43 +0000 (15:33 -0700)]
Split audio effects headers
There can be different use cases with the code that imports
headers from audio_effects (each subsequent case is a more
specialized version of the previous one):
1. The code only needs access to general structures
like effect_descriptor_t:
==> include system/audio_effect.h
Example: AudioSystem in libmedia
2. The code that needs access to effect UUID and parameter
enums:
==> include system/audio_effects/effect_foo.h
Examples: media framework effects interfaces, libwilhelm
3. The code that needs to call into HAL:
==> include hardware/audio_effect.h
Examples: libaudiohal (implementation part) and libeffects
4. The code that implements a particular effect:
==> include audio_effects/effect_foo.h
Examples: cts/.../CTSTestEffect.cpp
stuff in hardware/, vendor/
Change-Id: Iee601a7a4d485ea35ff5c16ed595b219911585f7
Test: make
Glenn Kasten [Fri, 14 Oct 2016 15:49:02 +0000 (08:49 -0700)]
Address code review comments
Change INT_MAX to INT32_MAX.
Document iovec == NULL.
Strengthen TODO about re-architecting futex code.
Rename getSize() to size().
Simplify error handling for mFifo.diff().
Rename masked to offset.
Test: re-run tests/*
Change-Id: I51f0c457399ac12b282eee726d13c3ca9a58ed1a
Glenn Kasten [Fri, 14 Oct 2016 17:05:26 +0000 (10:05 -0700)]
Fix build
Test: build for sdk_phone_mips-sdk (mac) works
Change-Id: Ifc839975d1fc994beeb1651280e2d94e8b7a3199
Glenn Kasten [Fri, 14 Oct 2016 16:31:25 +0000 (16:31 +0000)]
Merge "fifo: improve blocking and hysteresis"
Mikhail Naganov [Thu, 13 Oct 2016 19:56:00 +0000 (12:56 -0700)]
Remove dependencies on hardware/audio_effects.h
Also remove some outstanding dependencies on hardware/audio.h.
Most of the time, only constants and structs from audio_effects.h
are used, and no actual calls into HAL are made. Move these
definitions into system/audio_effect.h, and generate constants
from TREBLE HAL definition.
Test: make
Change-Id: Ib28eca67f40bf8285d3352407f1ee82b6c77ad54
Eric Laurent [Thu, 13 Oct 2016 00:35:00 +0000 (00:35 +0000)]
audio_route: add check on enum values am:
ff3e6f401e am:
e12085b0c5
am:
95f7f2c505
Change-Id: I09f7d7f0547b2970231fe2e12babcc1f3041cc8c
Eric Laurent [Thu, 13 Oct 2016 00:27:11 +0000 (00:27 +0000)]
audio_route: add check on enum values am:
ff3e6f401e
am:
e12085b0c5
Change-Id: Ib2155fab97702c791c58ad2f27f5f5d6e0f790ba
Eric Laurent [Thu, 13 Oct 2016 00:19:40 +0000 (00:19 +0000)]
audio_route: add check on enum values
am:
ff3e6f401e
Change-Id: I4a9cfe96aac7472dde381cbb8756353d3cd128f2
Glenn Kasten [Sun, 2 Oct 2016 20:00:19 +0000 (13:00 -0700)]
fifo: improve blocking and hysteresis
Work-in-progress to eventually allow the application to independently
specify whether or not each index (both front and rear) is also treated
as a futex, and if so whether it is single-process or multi-process.
This involves replacing mIsPrivate by an enum for futex types.
Still to do:
- provide an API to configure this
- better testing
Continued work on the setHysteresis() API.
Still to do:
- better testing and debugging, especially for the read side.
- do the right thing based on data currently in the buffer
Added available() API to return the number of frames that could
be obtain()ed. For reader, this is the fill level.
Miscellaneous:
- renamed sharedRear to writerRear
- improved Doxygen comments
- address code review comments by explaining why some paramters are
passed by reference and some as pointers
- updated tests
- fixed bug: iovec was not being clear on error
- changed default value of throttlesWriter to true
Test: tests/fifo_*
Change-Id: I0e19052abc90453ca48a0299d2c2de62468de6cb
Eric Laurent [Wed, 12 Oct 2016 17:38:12 +0000 (10:38 -0700)]
audio_route: add check on enum values
Bug:
31906753
Bug:
32064030
Change-Id: Id57ad136b2c314040e6cbf62a3319ecef2c2114b
Mikhail Naganov [Tue, 11 Oct 2016 00:20:51 +0000 (17:20 -0700)]
Remove redundant prefixes from enums in audio common types and effects HAL
Re-generated audio-base.h from updated files. No changes
in effective constant values, only in source mapping comments.
Bug:
31800672
Change-Id: I28ed14a0f5cfa53ada105258cd196fa86b401857
Test: make
Eric Laurent [Fri, 7 Oct 2016 01:36:52 +0000 (18:36 -0700)]
audio: add constants to audio-base.h
move some constants to audio-base.h to avoid double
definitions with audio::common::2_0::types.h
Change-Id: I6ef18a2fbb173ae183cf2cd07c9758b2efd57752
Colin Cross [Fri, 7 Oct 2016 00:10:37 +0000 (00:10 +0000)]
Merge "Removes gnu designated initializers." am:
594952f2a2 am:
e72d1d1206 am:
9e36579d55
am:
cb5d4c6038
Change-Id: Ibc603eaa5413040eb5bf090c21f88132836ba624
Colin Cross [Thu, 6 Oct 2016 23:46:28 +0000 (23:46 +0000)]
Merge "Removes gnu designated initializers." am:
594952f2a2 am:
e72d1d1206
am:
9e36579d55
Change-Id: I935317b76902e6f7554108d817226be32c5e87d8
Colin Cross [Thu, 6 Oct 2016 23:42:58 +0000 (23:42 +0000)]
Merge "Removes gnu designated initializers." am:
594952f2a2
am:
e72d1d1206
Change-Id: Ib38b93b0c35ec8c0ca7e452b283a4059b220e423
Colin Cross [Thu, 6 Oct 2016 23:39:33 +0000 (23:39 +0000)]
Merge "Removes gnu designated initializers."
am:
594952f2a2
Change-Id: I9b6cf8060c2725d00e61ae282c049a668b699c17
Colin Cross [Thu, 6 Oct 2016 23:36:34 +0000 (23:36 +0000)]
Merge "Removes gnu designated initializers."
Ryan Haining [Thu, 8 Sep 2016 01:04:33 +0000 (18:04 -0700)]
Removes gnu designated initializers.
C99 has the '.field = value' syntax, C++ has neither. The only ISO way
to write this is without designating.
Test: m -j
Bug:
31997134
Change-Id: I66d5c8ac65be379865018ac88b09020524293d99
Andreas Huber [Mon, 3 Oct 2016 19:59:12 +0000 (12:59 -0700)]
Audio constants are now automatically extracted from .hal interface
android.hardware.audio.common@2.0 and made available to system/audio.h through
auto-generated "audio-base.h".
Bug:
31800672
Change-Id: I515f97638b499c83cae98de335ed2be830ad22cf
Test: make
Glenn Kasten [Tue, 4 Oct 2016 22:58:05 +0000 (22:58 +0000)]
Merge "fifo: Add test for multi-process"
Dan Willemsen [Tue, 4 Oct 2016 02:22:51 +0000 (02:22 +0000)]
Merge "Convert to Android.bp" am:
e6be5fc431 am:
481030b1e2 am:
48dadcacc3
am:
e9988801e9
Change-Id: I17c32b5201c7edff637214f106ee8a390496d3f3
Dan Willemsen [Tue, 4 Oct 2016 02:20:52 +0000 (02:20 +0000)]
Merge "Convert to Android.bp" am:
e6be5fc431 am:
481030b1e2
am:
48dadcacc3
Change-Id: Ib90430a1bfd5f8a62907cc954a697b9827047a2e
Dan Willemsen [Tue, 4 Oct 2016 02:17:19 +0000 (02:17 +0000)]
Merge "Convert to Android.bp" am:
e6be5fc431
am:
481030b1e2
Change-Id: I0455356090a92249e669de99d7e963fa4268e0e8
Dan Willemsen [Tue, 4 Oct 2016 02:15:20 +0000 (02:15 +0000)]
Merge "Convert to Android.bp"
am:
e6be5fc431
Change-Id: I8bb50a33ec0a1213d37201f0fb6dc4390190d117
Dan Willemsen [Tue, 4 Oct 2016 02:09:59 +0000 (02:09 +0000)]
Merge "Convert to Android.bp"
Dan Willemsen [Thu, 22 Sep 2016 23:05:13 +0000 (16:05 -0700)]
Convert to Android.bp
See build/soong/README.md for more information.
Test: mma -j
Test: camera_metadata_test on flounder
Change-Id: I0f699a2a0d120783a5f543cf6d454109a5fc624b
Glenn Kasten [Mon, 12 Sep 2016 16:35:05 +0000 (09:35 -0700)]
fifo: Add test for multi-process
Test: this is it
Change-Id: Iea4f6ee9f7ec4e1a2e3d49f0065493796aaeed20
Glenn Kasten [Fri, 2 Sep 2016 20:54:59 +0000 (13:54 -0700)]
fifo: Add support for multi-process
For multi-process, the indices are allocated in separate shared memory.
This permits the buffer, write index, and throttling read index to each
have their own protection.
By default, the indices are allocated within the object to retain
API compatibility for the single-process case.
Test: in next CL
Change-Id: I5fae59169dbf73e8e38bf0eba0dcf907da2f8679
Colin Cross [Fri, 30 Sep 2016 04:32:40 +0000 (04:32 +0000)]
Merge "Update escaping in Android.bp files" am:
1bfae98559 am:
8fce0b19ee am:
8cd8d232d3
am:
d1b183b8c2
Change-Id: I1107003c146e023b95e6528b4e3cc1f090a24d0e
Colin Cross [Fri, 30 Sep 2016 04:27:00 +0000 (04:27 +0000)]
Merge "Update escaping in Android.bp files" am:
1bfae98559 am:
8fce0b19ee
am:
8cd8d232d3
Change-Id: I2f71c4c0296609caf48aa9a10a05154f5fa952d3
Colin Cross [Fri, 30 Sep 2016 04:24:30 +0000 (04:24 +0000)]
Merge "Update escaping in Android.bp files" am:
1bfae98559
am:
8fce0b19ee
Change-Id: Idecdefd6e64c44e7496d17cad5d76113799df874
Colin Cross [Fri, 30 Sep 2016 04:21:33 +0000 (04:21 +0000)]
Merge "Update escaping in Android.bp files"
am:
1bfae98559
Change-Id: Iebdc04b6d38830c77f0b3e493b0a7f2487329804
Treehugger Robot [Fri, 30 Sep 2016 04:17:57 +0000 (04:17 +0000)]
Merge "Update escaping in Android.bp files"
Colin Cross [Thu, 29 Sep 2016 21:08:28 +0000 (14:08 -0700)]
Update escaping in Android.bp files
Strings like cflags in Android.bp files are parsed by blueprint,
written to build.ninja files, parsed by ninja, and then passed to
/bin/sh -c. This had resulted in a combination of blueprint
(\"), ninja ($$), and shell (\$) escaping being necessary.
Soong has been updated to automatically handle ninja and shell
escaping, remove extra escaping from Android.bp files.
Bug:
31221587
Test: m -j
Change-Id: Ib1deac0a236a2ad37fce394bbdefbf5a781a38a7
Zhijun He [Tue, 27 Sep 2016 22:26:53 +0000 (15:26 -0700)]
camera_metadata: cleanup dependency
camera_metadata doesn't depend on vendor tag header.
Bug:
30985004
Change-Id: Ib8939220801498a4427072b78efede7b08a7ffd3
rago [Tue, 20 Sep 2016 09:21:01 +0000 (09:21 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b am:
1414a77d6a am:
48309eb29c am:
b0b84bc962 am:
bfab6fae72 am:
4eb2a5da1d
am:
7dba99edcf
Change-Id: I949ec2eb379cf4f586e0c7f6190a6ef9e3c055a5
rago [Tue, 20 Sep 2016 08:13:33 +0000 (08:13 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b am:
1414a77d6a am:
48309eb29c am:
b0b84bc962 am:
bfab6fae72
am:
4eb2a5da1d
Change-Id: I7d08cfbf128556fa108ea6ad376f7cd10924cfc4
rago [Tue, 20 Sep 2016 07:15:42 +0000 (07:15 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b am:
1414a77d6a am:
48309eb29c am:
b0b84bc962
am:
bfab6fae72
Change-Id: Iff2f2afb8ad109b9dfdfa4e80dde7ab06bea485f
rago [Tue, 20 Sep 2016 06:51:45 +0000 (06:51 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b am:
1414a77d6a am:
48309eb29c am:
53c4169a75
am:
889c2d2231
Change-Id: I895cd36549acc2b95c42d01930477025ef87a261
rago [Tue, 20 Sep 2016 06:39:44 +0000 (06:39 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b am:
1414a77d6a am:
48309eb29c
am:
53c4169a75
Change-Id: Id9194c967ebe648f523ce3dfc0918fd4ffeb2d56
rago [Tue, 20 Sep 2016 06:38:02 +0000 (06:38 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b am:
1414a77d6a am:
48309eb29c
am:
b0b84bc962
Change-Id: I042fd15d5349c48f7c5aa9a97d31dc66c9380b93
rago [Tue, 20 Sep 2016 06:05:28 +0000 (06:05 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b am:
1414a77d6a
am:
48309eb29c
Change-Id: Ie6b3730caae23ff2d652475902d208f0db3063f5
rago [Tue, 20 Sep 2016 06:04:58 +0000 (06:04 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b am:
1414a77d6a
am:
48309eb29c
Change-Id: I44be4c384bc84e9775c20e1ae6ac9574a025d7d1
rago [Tue, 20 Sep 2016 04:52:09 +0000 (04:52 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5 am:
453066787b
am:
1414a77d6a
Change-Id: I6247298111aca3a0e3a1cfb6996d23a11b1795b0
rago [Tue, 20 Sep 2016 04:33:42 +0000 (04:33 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318 am:
0fafbe88b5
am:
453066787b
Change-Id: I56ee2f6ae9366d1ec501a76519cab46cf3381046
rago [Tue, 20 Sep 2016 04:27:29 +0000 (04:27 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a am:
e1bc1ac318
am:
0fafbe88b5
Change-Id: I6cdeb5b4234c5e6fcb2882ab7a778fa0894a28ed
rago [Tue, 20 Sep 2016 04:24:41 +0000 (04:24 +0000)]
Fix potential overflow in Visualizer effect am:
7bbd500874 am:
99589ed96f am:
8682da681a am:
a5dddadec9 am:
960cba3e1b am:
902b06895f am:
af1e40957a
am:
e1bc1ac318
Change-Id: Id679d6bcb437c23b4307eff166d3040ccf7aec48