OSDN Git Service
Ben Cheng [Tue, 26 Oct 2010 17:18:38 +0000 (10:18 -0700)]
am
5d992dfa: am
36bd1345: Fix for array lower-bound check for count-down loops.
Ben Cheng [Tue, 26 Oct 2010 17:16:28 +0000 (10:16 -0700)]
am
36bd1345: Fix for array lower-bound check for count-down loops.
Ben Cheng [Tue, 26 Oct 2010 03:54:31 +0000 (20:54 -0700)]
Fix for array lower-bound check for count-down loops.
If the counted loop is composed as
for (int i = hi; i >= lo; i--) {
.. = array[i];
}
The hoisted lower-bound check should be asserting "lo >= 0".
On the other hand if the counted loop is composed as
for (int i = hi; i > lo; i--) {
.. = array[i];
}
The hoisted lower-bound check should be asserting "lo + 1 >= 0".
Previously these two checks are reversed.
Bug:
3130818
Change-Id: Ibc5a6daa837880e9986e45bbc29d1a5e548be3ae
Ben Cheng [Fri, 22 Oct 2010 17:49:18 +0000 (10:49 -0700)]
Merge "Avoid conditional loads if WORKAROUND_CORTEX_A9_745320 is defined."
Ben Cheng [Fri, 22 Oct 2010 17:15:03 +0000 (10:15 -0700)]
Avoid conditional loads if WORKAROUND_CORTEX_A9_745320 is defined.
No noticeable performance impact by this change.
Bug:
3117632
Change-Id: I31c6adc6cb9999498bb456f1e87f6f04f33e4144
Patrick Scott [Thu, 21 Oct 2010 19:43:44 +0000 (12:43 -0700)]
Merge "Fix debug statements."
Patrick Scott [Thu, 21 Oct 2010 18:50:15 +0000 (14:50 -0400)]
Fix debug statements.
Shows up without NDEBUG.
Change-Id: I1270266369beb783242283af60ee268118c8fb3d
Carl Shapiro [Thu, 21 Oct 2010 17:51:57 +0000 (10:51 -0700)]
am
493d84f8: am
2e3ec716: Fix class loader interning following a String.intern.
Merge commit '
493d84f888a01747967cbc84603358f525fa7e77'
* commit '
493d84f888a01747967cbc84603358f525fa7e77':
Fix class loader interning following a String.intern.
Carl Shapiro [Wed, 20 Oct 2010 04:37:28 +0000 (21:37 -0700)]
am
2e3ec716: Fix class loader interning following a String.intern.
Merge commit '
2e3ec7160b265d520cd755f8c20163410d822373' into gingerbread-plus-aosp
* commit '
2e3ec7160b265d520cd755f8c20163410d822373':
Fix class loader interning following a String.intern.
Carl Shapiro [Wed, 20 Oct 2010 00:27:13 +0000 (17:27 -0700)]
Fix class loader interning following a String.intern.
Strings can be intered by the class loader, in the case of string
literals, or by the user, through String.intern. Literal strings
exist for the life of their referencing classes. User strings are
weak and may be garbage collected when unreferenced. These two
classes of strings are kept in seprate tables for the conveniance of
the garbage collector during root traversal.
When a class loader interns a string that was already interned by the
user the runtime must move the string from the intern table to the
literal table to increase the reference strength. Previously, this
was implemented by inserting the incoming string into the literal
table and removing any matching strings in the intern table. This
transition lost pointer equality. With this change we first insert
the exact string from the intern table into the literal table and
secondly remove its reference from the intern table. By moving the
string between tables pointer equality is preserved.
At this point lookupInternedString should be split into two functions,
possibly by pulled up the relevant bits into the public interface
functions. Since this change will be merged to gingerbread I will
leave the clean up to a separate change.
Bug:
3098960
Andy McFadden [Tue, 19 Oct 2010 20:37:01 +0000 (13:37 -0700)]
am
da34e27a: (-s ours) am
3db6149c: Merge "Update heap dump notes. DO NOT MERGE." into gingerbread
Merge commit '
da34e27a6de6eec8b4f1036c9ba4922a12a5bf19'
* commit '
da34e27a6de6eec8b4f1036c9ba4922a12a5bf19':
Update heap dump notes. DO NOT MERGE.
Andy McFadden [Tue, 19 Oct 2010 18:28:36 +0000 (11:28 -0700)]
am
3db6149c: Merge "Update heap dump notes. DO NOT MERGE." into gingerbread
Merge commit '
3db6149c9891089ed1b357ab69db5c57c9c1fb6c' into gingerbread-plus-aosp
* commit '
3db6149c9891089ed1b357ab69db5c57c9c1fb6c':
Update heap dump notes. DO NOT MERGE.
Andy McFadden [Tue, 19 Oct 2010 18:19:28 +0000 (11:19 -0700)]
Merge "Update heap dump notes. DO NOT MERGE." into gingerbread
Carl Shapiro [Tue, 19 Oct 2010 18:18:23 +0000 (11:18 -0700)]
am
e8debfcf: am
c6fb7a5e: Merge "Exit early if the we encounter a null reference." into gingerbread
Merge commit '
e8debfcf2d16ba18474ca51200e9b7f2d912dee3'
* commit '
e8debfcf2d16ba18474ca51200e9b7f2d912dee3':
Exit early if the we encounter a null reference.
Andy McFadden [Tue, 19 Oct 2010 17:44:34 +0000 (10:44 -0700)]
am
8ca802ff: am
7b4c1d52: Pop call frame before boxing result
Merge commit '
8ca802ff96060b730119b58379c2e6366afdbd3e'
* commit '
8ca802ff96060b730119b58379c2e6366afdbd3e':
Pop call frame before boxing result
buzbee [Tue, 19 Oct 2010 17:44:30 +0000 (10:44 -0700)]
am
8cb3d855: am
e09a766f: x86 mterp: fix cherry-pick/merge, issue
3095771
Merge commit '
8cb3d8558b3cdc3da00e736bb3cdb95adf653659'
* commit '
8cb3d8558b3cdc3da00e736bb3cdb95adf653659':
x86 mterp: fix cherry-pick/merge, issue
3095771
Andy McFadden [Tue, 19 Oct 2010 17:15:14 +0000 (10:15 -0700)]
Update heap dump notes. DO NOT MERGE.
We brought over the VM change that removed SIGUSR1 as a way to cause
an hprof dump, but didn't bring the replacement command-line stuff
("am dumpheap" and the updated version of runhat). This updates the
documentation to reflect the state of the world in gingerbread.
Bug
3110872.
Change-Id: Ia64190584a344995670e663636e8e2c0983fb29f
Carl Shapiro [Tue, 19 Oct 2010 04:24:31 +0000 (21:24 -0700)]
am
c6fb7a5e: Merge "Exit early if the we encounter a null reference." into gingerbread
Merge commit '
c6fb7a5e56d3d17848482d403d2b1464a89aca46' into gingerbread-plus-aosp
* commit '
c6fb7a5e56d3d17848482d403d2b1464a89aca46':
Exit early if the we encounter a null reference.
Carl Shapiro [Tue, 19 Oct 2010 04:22:43 +0000 (21:22 -0700)]
Merge "Exit early if the we encounter a null reference." into gingerbread
Andy McFadden [Tue, 19 Oct 2010 00:04:19 +0000 (17:04 -0700)]
am
7b4c1d52: Pop call frame before boxing result
Merge commit '
7b4c1d52a946506d49c6da5649d1677e92263d66' into gingerbread-plus-aosp
* commit '
7b4c1d52a946506d49c6da5649d1677e92263d66':
Pop call frame before boxing result
buzbee [Tue, 19 Oct 2010 00:03:52 +0000 (17:03 -0700)]
am
e09a766f: x86 mterp: fix cherry-pick/merge, issue
3095771
Merge commit '
e09a766f3a964fb98296939ce1f92b8c95bf8c25' into gingerbread-plus-aosp
* commit '
e09a766f3a964fb98296939ce1f92b8c95bf8c25':
x86 mterp: fix cherry-pick/merge, issue
3095771
Carl Shapiro [Mon, 18 Oct 2010 23:27:29 +0000 (16:27 -0700)]
Exit early if the we encounter a null reference.
Bug:
3108418
Change-Id: I057e7a674e2ab96671f4651811071b6810250528
Brian Carlstrom [Mon, 18 Oct 2010 22:37:24 +0000 (15:37 -0700)]
Open hprof files with O_TRUNC to avoid partial overwrites of existing files
Change-Id: I97a89071ad766005bb9f91661185dd901a35ae03
Andy McFadden [Mon, 18 Oct 2010 20:28:31 +0000 (13:28 -0700)]
Pop call frame before boxing result
After reflective method calls, primitive results need to be boxed
up in an appropriate object. This generally requires allocating an
object of the appropriate type. We were doing this before popping
the call frame, which meant that if the allocation caused a GC we
would be scanning results out of a "dead" stack frame.
We hit a case where a register went from holding a reference to
holding a primitive right before the method returned. The exported
PC was pointing at the last GC point, where the register was expected
to hold a reference, so precise GC was getting very confused.
Bug
3102352.
(cherry-pick from dalvik-dev)
Change-Id: I21f59f1d70689d9e4901deb3100c756fd85223e7
buzbee [Sat, 16 Oct 2010 00:51:37 +0000 (17:51 -0700)]
am
ef1ed3c5: (-s ours) x86 mterp: fix cherry-pick/merge, issue
3095771
Merge commit '
ef1ed3c5cbde4de64e1991de2dbea57efd964841'
* commit '
ef1ed3c5cbde4de64e1991de2dbea57efd964841':
x86 mterp: fix cherry-pick/merge, issue
3095771
Raphael [Fri, 15 Oct 2010 07:07:54 +0000 (00:07 -0700)]
am
f4b26ea7: resolved conflicts for merge of
b0b2a75d to gingerbread-plus-aosp
Merge commit '
f4b26ea7ea0a85e2592a0ec0e439ffa4f3c5a038'
* commit '
f4b26ea7ea0a85e2592a0ec0e439ffa4f3c5a038':
SDK: fix dx shell script to look for dx.jar in platform-tools
buzbee [Thu, 14 Oct 2010 00:47:52 +0000 (17:47 -0700)]
x86 mterp: fix cherry-pick/merge, issue
3095771
Bug http://b/issue?id=
3095771
Change
https://android-git.corp.google.com/g/#change,70700
was a cherry-pick/merge of
https://android-git.corp.google.com/g/#change,70388
It was not properly merged, and resulting in the register holding
the object head to be trashed (and subsequently broke GC).
Change-Id: Ic480104e3a643a5b744d36eb0aefaedd3e4f925c
buzbee [Thu, 14 Oct 2010 00:47:52 +0000 (17:47 -0700)]
x86 mterp: fix cherry-pick/merge, issue
3095771
Bug http://b/issue?id=
3095771
Change
https://android-git.corp.google.com/g/#change,70700
was a cherry-pick/merge of
https://android-git.corp.google.com/g/#change,70388
It was not properly merged, and resulting in the register holding
the object head to be trashed (and subsequently broke GC).
Change-Id: Ic480104e3a643a5b744d36eb0aefaedd3e4f925c
Raphael [Wed, 13 Oct 2010 20:36:32 +0000 (13:36 -0700)]
resolved conflicts for merge of
b0b2a75d to gingerbread-plus-aosp
Change-Id: Ie475c74ea64cab1e74171a7f885dd3e48f219922
Raphael [Wed, 13 Oct 2010 20:11:07 +0000 (13:11 -0700)]
SDK: fix dx shell script to look for dx.jar in platform-tools
Change-Id: I4b644dc686f1da75ef7fb34ea874b54ce44f8391
Andy McFadden [Tue, 12 Oct 2010 23:38:38 +0000 (16:38 -0700)]
am
141c9711: am
3f01142e: Merge "Added some threading notes" into gingerbread
Merge commit '
141c9711d546c161d7ad6b149392dfddf705a26e'
* commit '
141c9711d546c161d7ad6b149392dfddf705a26e':
Added some threading notes
Carl Shapiro [Tue, 12 Oct 2010 23:27:10 +0000 (16:27 -0700)]
am
565c5663: am
44dcf29d: Add include guards to avoid multiple definitions.
Merge commit '
565c56636641b9ed28ed479b6f4730e1a9df4f7e'
* commit '
565c56636641b9ed28ed479b6f4730e1a9df4f7e':
Add include guards to avoid multiple definitions.
Jean-Baptiste Queru [Tue, 12 Oct 2010 08:45:43 +0000 (01:45 -0700)]
am
65da91cf: am
16926bc4: Merge "Remove obsolete variable "len" to avoid compile failed"
Merge commit '
65da91cf96f8e567db9fc1221d2dcb12bad2ab80'
* commit '
65da91cf96f8e567db9fc1221d2dcb12bad2ab80':
Remove obsolete variable "len" to avoid compile failed
Carl Shapiro [Tue, 12 Oct 2010 01:58:54 +0000 (18:58 -0700)]
am
7876eb7d: am
0b89c266: Merge "Use the break position of the current mspace for sizing the zygote heap." into gingerbread
Merge commit '
7876eb7d797f5c3937b7d1be34f81e9aa3b865e9'
* commit '
7876eb7d797f5c3937b7d1be34f81e9aa3b865e9':
Use the break position of the current mspace for sizing the zygote heap.
Jean-Baptiste Queru [Tue, 12 Oct 2010 01:58:15 +0000 (18:58 -0700)]
am
90ee39ea: am
ad3ff025: Merge "Update Call386ABI.S to support 16 byte alignment"
Merge commit '
90ee39eabbee701b63e79ddaf4859481b7e0547a'
* commit '
90ee39eabbee701b63e79ddaf4859481b7e0547a':
Update Call386ABI.S to support 16 byte alignment
Jean-Baptiste Queru [Tue, 12 Oct 2010 01:58:09 +0000 (18:58 -0700)]
am
789fb059: am
bc02ca96: Merge "Fixed bug in OP_GOTO_32.S, added support for additional parameters to dvmHandleStackOverflow"
Merge commit '
789fb0592cb6ea7ac573bd81ea8fb0a8bb5e103f'
* commit '
789fb0592cb6ea7ac573bd81ea8fb0a8bb5e103f':
Fixed bug in OP_GOTO_32.S, added support for additional parameters to dvmHandleStackOverflow
Andy McFadden [Tue, 12 Oct 2010 00:25:42 +0000 (17:25 -0700)]
am
3f01142e: Merge "Added some threading notes" into gingerbread
Merge commit '
3f01142ed915021eb871a80d3f8eadca6e6bfc3b' into gingerbread-plus-aosp
* commit '
3f01142ed915021eb871a80d3f8eadca6e6bfc3b':
Added some threading notes
Andy McFadden [Mon, 11 Oct 2010 22:35:54 +0000 (15:35 -0700)]
Merge "Added some threading notes" into gingerbread
Carl Shapiro [Mon, 11 Oct 2010 22:17:47 +0000 (15:17 -0700)]
am
44dcf29d: Add include guards to avoid multiple definitions.
Merge commit '
44dcf29d18f819b4b9d78d4d81676681b57f44ce' into gingerbread-plus-aosp
* commit '
44dcf29d18f819b4b9d78d4d81676681b57f44ce':
Add include guards to avoid multiple definitions.
Carl Shapiro [Mon, 11 Oct 2010 21:55:08 +0000 (14:55 -0700)]
Add include guards to avoid multiple definitions.
Change-Id: I2a52823325a0a582a746890af7f040324d671806
Andy McFadden [Mon, 11 Oct 2010 21:46:25 +0000 (14:46 -0700)]
Added some threading notes
Explain thread attach/detach, behavior of threads running native code.
Added pthread_key_create destructor note to backward compatibility
section.
Change-Id: I954708c9ec7c83ba951c0f512c88d5c610a49411
Andy McFadden [Mon, 11 Oct 2010 19:37:06 +0000 (12:37 -0700)]
am
c7fb06ef: am
5276cccb: Verify method invocation type.
Merge commit '
c7fb06efb576b7ff0295dd70c8beaeea11918645'
* commit '
c7fb06efb576b7ff0295dd70c8beaeea11918645':
Verify method invocation type.
Dan Bornstein [Mon, 11 Oct 2010 18:36:14 +0000 (11:36 -0700)]
am
22156b4d: am
9be25d09: Clarify the invoke-* opcodes.
Merge commit '
22156b4d43d06446a0bb4d2c887c23bedabb3a96'
* commit '
22156b4d43d06446a0bb4d2c887c23bedabb3a96':
Clarify the invoke-* opcodes.
Jean-Baptiste Queru [Mon, 11 Oct 2010 15:07:39 +0000 (08:07 -0700)]
am
16926bc4: Merge "Remove obsolete variable "len" to avoid compile failed"
Merge commit '
16926bc4382640b73e439f678f675444d0d39e8f' into gingerbread-plus-aosp
* commit '
16926bc4382640b73e439f678f675444d0d39e8f':
Remove obsolete variable "len" to avoid compile failed
Jean-Baptiste Queru [Mon, 11 Oct 2010 15:00:48 +0000 (08:00 -0700)]
Merge "Remove obsolete variable "len" to avoid compile failed"
Carl Shapiro [Mon, 11 Oct 2010 06:05:05 +0000 (23:05 -0700)]
am
0b89c266: Merge "Use the break position of the current mspace for sizing the zygote heap." into gingerbread
Merge commit '
0b89c266321d6db8c50485e3b65d7def799ae0a3' into gingerbread-plus-aosp
* commit '
0b89c266321d6db8c50485e3b65d7def799ae0a3':
Use the break position of the current mspace for sizing the zygote heap.
Carl Shapiro [Mon, 11 Oct 2010 06:03:22 +0000 (23:03 -0700)]
Merge "Use the break position of the current mspace for sizing the zygote heap." into gingerbread
Carl Shapiro [Mon, 11 Oct 2010 01:50:22 +0000 (18:50 -0700)]
Use the break position of the current mspace for sizing the zygote heap.
Previously, the mspace footprint used the "overhead" of a heap which
underestimates the size of the zygote heap by 16 bytes, the specific
size of a descriptor deposited at the start of an mspace containing
the control information about that mspace. If a heap is a multiple of
a page or within 15 bytes of it, the size of the new heap would be
underestimated.
Bad things happened when this underestimate was used to create an
application heap. The starting address of the application heap was
based on a correctly computed value instead of the underestimate.
This caused the application heap to be one page to large and end one
page beyond where it should. This additional page happened to overlap
the first page one of the heap bitmaps. Furthermore, the mspace
routine would proceed access protect that page thinking it was unused
free space. During the next GC reads to the first page of the bitmap
would generate a SIGSEGV.
By using the break position, correctly rounded, for all sizing
computations this problem no longer exists.
Change-Id: Icb3c82731e589747e8e4cf16d0797052e64b3ad5
Jean-Baptiste Queru [Mon, 11 Oct 2010 01:49:37 +0000 (18:49 -0700)]
am
ad3ff025: Merge "Update Call386ABI.S to support 16 byte alignment"
Merge commit '
ad3ff0252ee5c59528828e0625490f0768d2081f' into gingerbread-plus-aosp
* commit '
ad3ff0252ee5c59528828e0625490f0768d2081f':
Update Call386ABI.S to support 16 byte alignment
Jean-Baptiste Queru [Mon, 11 Oct 2010 01:49:31 +0000 (18:49 -0700)]
am
bc02ca96: Merge "Fixed bug in OP_GOTO_32.S, added support for additional parameters to dvmHandleStackOverflow"
Merge commit '
bc02ca96c5cd3b45939809ed43ae2e7f2e4fb5b9' into gingerbread-plus-aosp
* commit '
bc02ca96c5cd3b45939809ed43ae2e7f2e4fb5b9':
Fixed bug in OP_GOTO_32.S, added support for additional parameters to dvmHandleStackOverflow
Jean-Baptiste Queru [Mon, 11 Oct 2010 01:35:44 +0000 (18:35 -0700)]
Merge "Update Call386ABI.S to support 16 byte alignment"
Jean-Baptiste Queru [Mon, 11 Oct 2010 01:34:16 +0000 (18:34 -0700)]
Merge "Fixed bug in OP_GOTO_32.S, added support for additional parameters to dvmHandleStackOverflow"
Andy McFadden [Sun, 10 Oct 2010 21:12:00 +0000 (14:12 -0700)]
am
5276cccb: Verify method invocation type.
Merge commit '
5276cccb15b6ce0133c8107ff9ff013b4a176ef7' into gingerbread-plus-aosp
* commit '
5276cccb15b6ce0133c8107ff9ff013b4a176ef7':
Verify method invocation type.
Andy McFadden [Sun, 10 Oct 2010 19:59:11 +0000 (12:59 -0700)]
Verify method invocation type.
Dalvik provides five different ways to invoke a method (virtual, super,
direct, static, interface). Using a virtual invoke instruction to call
a direct method will not produce the desired results.
This adds a test to the verifier that ensures the method targeted by
an invocation instruction is of an appropriate kind.
Bug
3082885.
(cherry-pick from dalvik-dev)
Change-Id: I3237cbefc7314f0b9d7557fc0bfd2b548ea30938
Dan Bornstein [Sun, 10 Oct 2010 20:20:02 +0000 (13:20 -0700)]
am
9be25d09: Clarify the invoke-* opcodes.
Merge commit '
9be25d09d24b3d6d0dd1a41c1c09471af4827687' into gingerbread-plus-aosp
* commit '
9be25d09d24b3d6d0dd1a41c1c09471af4827687':
Clarify the invoke-* opcodes.
Dan Bornstein [Sun, 10 Oct 2010 19:29:07 +0000 (12:29 -0700)]
Clarify the invoke-* opcodes.
In particular, make it a little more explicit what kinds of methods
are acceptable for each variant.
Change-Id: Icd9dad876c2d10c23462b4d85ccaa9441d7f2c04
Andy McFadden [Fri, 1 Oct 2010 22:22:35 +0000 (15:22 -0700)]
Merge "Use DMB ST for store fence."
Carl Shapiro [Fri, 1 Oct 2010 19:59:39 +0000 (12:59 -0700)]
am
5163f62f: am
7d3f633d: Merge "Include static fields when dumping class objects." into gingerbread
Merge commit '
5163f62f7048c4b651a425b4b7a3a1b0fb227eb6'
* commit '
5163f62f7048c4b651a425b4b7a3a1b0fb227eb6':
Include static fields when dumping class objects.
Carl Shapiro [Fri, 1 Oct 2010 19:57:44 +0000 (12:57 -0700)]
am
7d3f633d: Merge "Include static fields when dumping class objects." into gingerbread
Merge commit '
7d3f633d2c0061e579c57186276c05ddcc275641' into gingerbread-plus-aosp
* commit '
7d3f633d2c0061e579c57186276c05ddcc275641':
Include static fields when dumping class objects.
Carl Shapiro [Fri, 1 Oct 2010 19:54:52 +0000 (12:54 -0700)]
Merge "Include static fields when dumping class objects." into gingerbread
Andy McFadden [Fri, 1 Oct 2010 19:31:42 +0000 (12:31 -0700)]
Use DMB ST for store fence.
Change-Id: I4bde544a7c66e30a1756425ec088e53baa2f11a1
Carl Shapiro [Fri, 1 Oct 2010 00:20:11 +0000 (17:20 -0700)]
Include static fields when dumping class objects.
Change-Id: I8e7b1d1ef7ca205b489744dcbf0f210c1f2443c4
Elliott Hughes [Fri, 1 Oct 2010 17:52:29 +0000 (10:52 -0700)]
am
b11c54c9: am
307aa79a: Merge "Change Runtime.nativeLoad to return the dlerror(3) string." into gingerbread
Merge commit '
b11c54c9b7849eaa95423dbbf8433e9f1b20ec32'
* commit '
b11c54c9b7849eaa95423dbbf8433e9f1b20ec32':
Change Runtime.nativeLoad to return the dlerror(3) string.
Elliott Hughes [Fri, 1 Oct 2010 17:49:02 +0000 (10:49 -0700)]
am
307aa79a: Merge "Change Runtime.nativeLoad to return the dlerror(3) string." into gingerbread
Merge commit '
307aa79afc08c50e9ea69aac7bf5128bc75ac7ff' into gingerbread-plus-aosp
* commit '
307aa79afc08c50e9ea69aac7bf5128bc75ac7ff':
Change Runtime.nativeLoad to return the dlerror(3) string.
Elliott Hughes [Fri, 1 Oct 2010 17:35:13 +0000 (10:35 -0700)]
Merge "Change Runtime.nativeLoad to return the dlerror(3) string." into gingerbread
buzbee [Fri, 1 Oct 2010 06:19:49 +0000 (23:19 -0700)]
resolved conflicts for merge of
6d55b332 to master
Change-Id: I21e35d4cdf2636ae3cd7facd45ad4f5c4ab82e7b
buzbee [Fri, 1 Oct 2010 03:24:45 +0000 (20:24 -0700)]
am
b78c76f8: GC Card marking fix for SPUT_OBJECT - use correct object head
Merge commit '
b78c76f88ea42e7a3b295c210ca9ee86e7290043' into gingerbread-plus-aosp
* commit '
b78c76f88ea42e7a3b295c210ca9ee86e7290043':
GC Card marking fix for SPUT_OBJECT - use correct object head
buzbee [Fri, 1 Oct 2010 02:08:20 +0000 (19:08 -0700)]
GC Card marking fix for SPUT_OBJECT - use correct object head
Change-Id: I8b84a4f1e1690f5b62de7404ea6ede00317848bb
Andy McFadden [Fri, 1 Oct 2010 01:11:46 +0000 (18:11 -0700)]
am
33ff9f32: am
d8b5f50d: Correct dexopt for uniprocessors.
Merge commit '
33ff9f32d460a232729a123617ca81b3f67195c6'
* commit '
33ff9f32d460a232729a123617ca81b3f67195c6':
Correct dexopt for uniprocessors.
Dan Bornstein [Fri, 1 Oct 2010 01:11:15 +0000 (18:11 -0700)]
am
2428d518: am
f45b6cbe: Be explicit about both uniprocessor and SMP when calling dexopt.
Merge commit '
2428d518efb9b5a62d74f44a267f3a6c18982549'
* commit '
2428d518efb9b5a62d74f44a267f3a6c18982549':
Be explicit about both uniprocessor and SMP when calling dexopt.
Elliott Hughes [Thu, 30 Sep 2010 22:51:31 +0000 (15:51 -0700)]
Change Runtime.nativeLoad to return the dlerror(3) string.
This has a companion change in libcore:
https://android-git.corp.google.com/g/71342
Bug:
3044042
Change-Id: I070a80a41ec2f306f5092a641807017f70179451
Andy McFadden [Thu, 30 Sep 2010 22:40:43 +0000 (15:40 -0700)]
am
d8b5f50d: Correct dexopt for uniprocessors.
Merge commit '
d8b5f50d0c6c9a0ce157e89df4ee1e8eb8b334c3' into gingerbread-plus-aosp
* commit '
d8b5f50d0c6c9a0ce157e89df4ee1e8eb8b334c3':
Correct dexopt for uniprocessors.
Andy McFadden [Thu, 30 Sep 2010 21:02:54 +0000 (14:02 -0700)]
Correct dexopt for uniprocessors.
The SMP flag was defaulting to "true" for dexopt, even on uniprocessors.
With this change the VM now has three choices: dexopt for SMP, dexopt
for uniprocessor, or dexopt for current system. The last is used for
just-in-time dexopt (used by -eng and -userdebug builds on bootstrap DEX
files) and installd dexopt (used for apps on all builds).
The dexopt used by the build system during -user builds will either be
explicitly SMP or explicitly uniprocessor, since "current system" has
no meaning when you're cross-dexopting.
Also, unified the dexopt control flags into a single enum.
(cherry-pick from dalvik-dev)
Change-Id: Id1d9c548ca8567585a28ef9ee911cc2ac6b116dd
Dan Bornstein [Thu, 30 Sep 2010 22:11:27 +0000 (15:11 -0700)]
am
f45b6cbe: Be explicit about both uniprocessor and SMP when calling dexopt.
Merge commit '
f45b6cbed6ce7cb6a38746b5abe0213263106a71' into gingerbread-plus-aosp
* commit '
f45b6cbed6ce7cb6a38746b5abe0213263106a71':
Be explicit about both uniprocessor and SMP when calling dexopt.
Dan Bornstein [Thu, 30 Sep 2010 22:04:34 +0000 (15:04 -0700)]
Be explicit about both uniprocessor and SMP when calling dexopt.
Change-Id: Ic1b68dddf6822773041de6023c594a062e141325
Carl Shapiro [Thu, 30 Sep 2010 18:26:04 +0000 (11:26 -0700)]
am
f37569d1: am
1e053438: Merge "After trimming, set the footprint to the number of pages in use." into gingerbread
Merge commit '
f37569d1cf3ed24fa37488ceb9bac2a52f45260c'
* commit '
f37569d1cf3ed24fa37488ceb9bac2a52f45260c':
After trimming, set the footprint to the number of pages in use.
Carl Shapiro [Thu, 30 Sep 2010 18:24:50 +0000 (11:24 -0700)]
am
0cb51973: am
d4cdb357: Merge "Update the card table scanning for header-only card marks." into gingerbread
Merge commit '
0cb519734afc574b2ca60d72ced1e9fc46a8f4c9'
* commit '
0cb519734afc574b2ca60d72ced1e9fc46a8f4c9':
Update the card table scanning for header-only card marks.
Robert CH Chou [Thu, 30 Sep 2010 09:20:07 +0000 (17:20 +0800)]
Remove obsolete variable "len" to avoid compile failed
Change-Id: Ibf759acef58f6a3e404bfc4be13505774b3d39ad
Dan Bornstein [Thu, 30 Sep 2010 03:35:10 +0000 (20:35 -0700)]
am
c315cbf1: am
87f66617: Add --uniprocessor option to dex-preopt.
Merge commit '
c315cbf15411e9b4b1f7a9732f16117eaea7afcb'
* commit '
c315cbf15411e9b4b1f7a9732f16117eaea7afcb':
Add --uniprocessor option to dex-preopt.
Carl Shapiro [Wed, 29 Sep 2010 21:30:25 +0000 (14:30 -0700)]
am
1e053438: Merge "After trimming, set the footprint to the number of pages in use." into gingerbread
Merge commit '
1e053438810dbd8406ec8339b94801195261e849' into gingerbread-plus-aosp
* commit '
1e053438810dbd8406ec8339b94801195261e849':
After trimming, set the footprint to the number of pages in use.
Carl Shapiro [Wed, 29 Sep 2010 21:27:50 +0000 (14:27 -0700)]
Merge "After trimming, set the footprint to the number of pages in use." into gingerbread
Carl Shapiro [Wed, 29 Sep 2010 19:40:05 +0000 (12:40 -0700)]
am
d4cdb357: Merge "Update the card table scanning for header-only card marks." into gingerbread
Merge commit '
d4cdb3572b489e770d20a6afba0f86563f380825' into gingerbread-plus-aosp
* commit '
d4cdb3572b489e770d20a6afba0f86563f380825':
Update the card table scanning for header-only card marks.
Carl Shapiro [Wed, 29 Sep 2010 19:38:19 +0000 (12:38 -0700)]
Merge "Update the card table scanning for header-only card marks." into gingerbread
Dan Bornstein [Wed, 29 Sep 2010 17:04:22 +0000 (10:04 -0700)]
am
87f66617: Add --uniprocessor option to dex-preopt.
Merge commit '
87f666172f55863d6a50762a1a07a31b67eb48f6' into gingerbread-plus-aosp
* commit '
87f666172f55863d6a50762a1a07a31b67eb48f6':
Add --uniprocessor option to dex-preopt.
Carl Shapiro [Wed, 29 Sep 2010 08:09:11 +0000 (01:09 -0700)]
Update the card table scanning for header-only card marks.
Previously, the card table accessors assumed that objects had either
their header marked or would be marked exactly. As such, after
reckoning a marked card the scan would back up until it found an
object header and then move forward blackening each object within the
address range of the marked card.
Following a recent change we exclusively mark headers. The scan only
has to move forward until the end of a card. This saves scanning time
as dlmalloc's binning may leave large segments of the heap unused. It
is not uncommon for hundreds of cards to be spanned when backing up to
the first live object below a marked card.
In addition, this change fixes the card table verifier to search the
mark stack for gray objects. It is permissible for roots to point to
white objects on unmarked cards. This was incorrectly treated as an
error.
Change-Id: Ia6b6ee2012e381d644b8b3f38b39d746749ea47a
Carl Shapiro [Wed, 29 Sep 2010 03:30:42 +0000 (20:30 -0700)]
After trimming, set the footprint to the number of pages in use.
A trim can decrease the an mspace footprint but it will not decrease
its max footprint. We need to decrease the max footprint to make any
pages recovered by a trim available to external allocations.
By setting the ideal footprint after a trim we lift any soft limit in
effect and make the mspace footprint and max footprints equal.
Change-Id: Ia6eb99634ce1d732b417a90291b110d1fc46c2e3
Dan Bornstein [Wed, 29 Sep 2010 01:53:28 +0000 (18:53 -0700)]
Add --uniprocessor option to dex-preopt.
This tells the preoptimizer to target a uniprocessor (unsurprisingly).
By default, it targets SMP, which makes it do more changes than it has
to for a uniprocessor (e.g. editing how non-wide volatile fields are
accessed within bytecode). To be clear, when SMP-optimized code is run
on a uniprocessor, it should still work. We're just aiming to only
make truly necessary changes during optimization.
While I was in the territory, I went ahead and cleaned up some single
vs. double quote hygiene in the file.
Change-Id: Ia45992939a436d0be6db8363c43d430de4acb80b
Dan Bornstein [Wed, 29 Sep 2010 01:40:01 +0000 (18:40 -0700)]
am
b3a94965: am
148283d7: Plumb SMP optimization control through to dexopt.
Merge commit '
b3a949656a773953a44b148a6cdcba19f1c48e87'
* commit '
b3a949656a773953a44b148a6cdcba19f1c48e87':
Plumb SMP optimization control through to dexopt.
Dan Bornstein [Wed, 29 Sep 2010 01:37:39 +0000 (18:37 -0700)]
am
148283d7: Plumb SMP optimization control through to dexopt.
Merge commit '
148283d71a7e35b9b506cbb49294b6822719c25e' into gingerbread-plus-aosp
* commit '
148283d71a7e35b9b506cbb49294b6822719c25e':
Plumb SMP optimization control through to dexopt.
Andy McFadden [Wed, 29 Sep 2010 00:38:21 +0000 (17:38 -0700)]
am
63114829: am
de9cdfa9: Fix verification of switch offsets in large methods.
Merge commit '
63114829802ecdade4c95fe08a02acec67bd17bd'
* commit '
63114829802ecdade4c95fe08a02acec67bd17bd':
Fix verification of switch offsets in large methods.
Dan Bornstein [Tue, 28 Sep 2010 22:46:54 +0000 (15:46 -0700)]
Plumb SMP optimization control through to dexopt.
Change-Id: I3bfaf6723e7b14d001f9de60cc1c1fd4f8e1ed99
buzbee [Tue, 28 Sep 2010 22:22:48 +0000 (15:22 -0700)]
resolved conflicts for merge of
2e75e47d to master
Change-Id: I644b3cd50e3c63b209741c8b818b4c1435ee8218
Andy McFadden [Tue, 28 Sep 2010 22:15:04 +0000 (15:15 -0700)]
am
de9cdfa9: Fix verification of switch offsets in large methods.
Merge commit '
de9cdfa9d6d5fa5c46a0ec0f3f1e8de08a688841' into gingerbread-plus-aosp
* commit '
de9cdfa9d6d5fa5c46a0ec0f3f1e8de08a688841':
Fix verification of switch offsets in large methods.
Johnnie Birch [Tue, 28 Sep 2010 21:58:37 +0000 (14:58 -0700)]
Fixed bug in OP_GOTO_32.S, added support for additional parameters to dvmHandleStackOverflow
Change-Id: I4d8d75418395661ffc8e7055eeb4600bb5b8b0bc
Andy McFadden [Tue, 28 Sep 2010 21:43:28 +0000 (14:43 -0700)]
Fix verification of switch offsets in large methods.
The verifier was only using the low 16 bits when checking the offset
to a switch table. This was failing on really large methods.
We also blew up the arbitrary size cap again, so I made it a warning
rather than a failure (it really wasn't doing anybody any good).
Changed to width-specific types for the various offsets and sizes.
Bug
3044850.
(cherry-pick+squash from dalvik-dev)
Change-Id: Ic7ebb86728cb39151f617a3e69e1c1994e61b5d9
Johnnie Birch [Tue, 28 Sep 2010 21:39:15 +0000 (14:39 -0700)]
Update Call386ABI.S to support 16 byte alignment
Change-Id: I61125ffab37f728665a91907bb699a0568568418
Carl Shapiro [Tue, 28 Sep 2010 21:00:06 +0000 (14:00 -0700)]
am
252dfcbb: am
b755f9a3: Do not grow if we are invoked for an external allocation.
Merge commit '
252dfcbbc8ab27ba7f86908fbf8c13425d166a70'
* commit '
252dfcbbc8ab27ba7f86908fbf8c13425d166a70':
Do not grow if we are invoked for an external allocation.
buzbee [Tue, 28 Sep 2010 19:28:21 +0000 (12:28 -0700)]
am
b36ea791: Merge "Change GC card making to use object head, bug fix for volatile sput obj" into gingerbread
Merge commit '
b36ea7918612c81cb42ff2021443358a9f109a6d' into gingerbread-plus-aosp
* commit '
b36ea7918612c81cb42ff2021443358a9f109a6d':
Change GC card making to use object head, bug fix for volatile sput obj
buzbee [Tue, 28 Sep 2010 19:26:06 +0000 (12:26 -0700)]
Merge "Change GC card making to use object head, bug fix for volatile sput obj" into gingerbread
Carl Shapiro [Tue, 28 Sep 2010 18:35:26 +0000 (11:35 -0700)]
am
b755f9a3: Do not grow if we are invoked for an external allocation.
Merge commit '
b755f9a3caeaf65e95480ac66c2c95553bf79389' into gingerbread-plus-aosp
* commit '
b755f9a3caeaf65e95480ac66c2c95553bf79389':
Do not grow if we are invoked for an external allocation.