OSDN Git Service
Grace Kloba [Mon, 7 Dec 2009 22:27:17 +0000 (14:27 -0800)]
Modify AndroidWebHistoryBridge to prepare uploading
detachHistoryItem() to WebKit.
I think it is easy to read this way that the constructor
sets the m_historyItem and the new method will detach it.
Grace Kloba [Mon, 7 Dec 2009 17:54:17 +0000 (09:54 -0800)]
Continue https://android-git.corp.google.com/g/#change,34687,
We should use #if PLATFORM(ANDROID) now
Android (Google) Code Review [Mon, 7 Dec 2009 17:39:36 +0000 (09:39 -0800)]
Merge change I38601c0e into eclair-mr2
* changes:
Fix the wrong layout in the layout test.
Cary Clark [Mon, 7 Dec 2009 15:36:50 +0000 (10:36 -0500)]
fix crash reading readonly node state
Something about rebuildTextView() invalidates the current cached
frame -- reading the last obtained frame after calling it may
crash. Why, I don't know. Until I figure that out, read the
cached state first.
Also remove some tests for null frame and node since the null
case has already been handled earlierin motionUp().
fixes http://b/
2307964
Leon Scroggins [Fri, 4 Dec 2009 19:54:57 +0000 (14:54 -0500)]
Store InputType information for <input> fields, return SEARCH action for SEARCH <input>
Fixes http://b/issue?id=
2299660 and http://b/issue?id=
2299650
Also remove isPassword, which is redundant.
Android (Google) Code Review [Mon, 7 Dec 2009 15:03:46 +0000 (07:03 -0800)]
Merge change I9a5736f5 into eclair-mr2
* changes:
Fixes a Geolocation bug with cached positions.
Steve Block [Thu, 3 Dec 2009 12:52:03 +0000 (12:52 +0000)]
Fixes a Geolocation bug with cached positions.
When a Geolocation watch calls back with a cached position, it could be cleared in the callback.
This change makes sure the watch still exists after the callback before starting the Geolocation service.
Change-Id: I9a5736f5ce78e1c4bb36659245ffb61b485c4018
Steve Block [Fri, 4 Dec 2009 15:36:28 +0000 (15:36 +0000)]
Moves JSC-specific functions from jni_utility and moves them to a new jsc/jni_utility_private.h.
See https://bugs.webkit.org/show_bug.cgi?id=32157
Change-Id: I1f7f0bb6fa9e72ee3eeb31160e0a828b3d076fee
Grace Kloba [Thu, 3 Dec 2009 01:39:47 +0000 (17:39 -0800)]
Fix the wrong layout in the layout test.
When we create a new WebFrameView, the bounds needs
to be transferred from the old WebFrameView. Otherwise
the new View will have (0,0) as bounds.
Add transitionToCommitted() for transitionToCommittedFromCachedFrame().
Grace Kloba [Sat, 5 Dec 2009 01:37:14 +0000 (17:37 -0800)]
am
daa8318d: (-s ours) DO NOT MERGE. This is cherry picked from https://android-git.corp.google.com/g/#change,28737
Merge commit '
daa8318de3c63a28eccb52546c230e5c5caee962' into eclair-mr2
* commit '
daa8318de3c63a28eccb52546c230e5c5caee962':
DO NOT MERGE.
Grace Kloba [Sat, 3 Oct 2009 00:38:57 +0000 (17:38 -0700)]
DO NOT MERGE.
This is cherry picked from
https://android-git.corp.google.com/g/#change,28737
Fix http://b/issue?id=
2304741
Add check null of getRealObject(). When a WebView is
removed, there is a slight chance that getRealObject()
for WebView's JavaObject be null.
Fix http://b/issue?id=
2159815
Android (Google) Code Review [Fri, 4 Dec 2009 19:21:16 +0000 (11:21 -0800)]
Merge change I2b870c71 into eclair-mr2
* changes:
Enables x-mac-cyrillic on Android, now that this is in our version of ICU.
Android (Google) Code Review [Fri, 4 Dec 2009 19:08:35 +0000 (11:08 -0800)]
Merge change If686b999 into eclair-mr2
* changes:
Pass up flags for the main resource and user gesture.
Android (Google) Code Review [Fri, 4 Dec 2009 18:53:31 +0000 (10:53 -0800)]
Merge change I49b2fbe0 into eclair-mr2
* changes:
Only re-center the page if it is zoom change or orientation change. Do not re-center the page if it is caused by show/hide soft keyboard.
Cary Clark [Fri, 4 Dec 2009 18:33:04 +0000 (13:33 -0500)]
fix nav cache debugging
last change broke debugging code outside of the build
Patrick Scott [Fri, 4 Dec 2009 18:18:31 +0000 (13:18 -0500)]
Pass up flags for the main resource and user gesture.
This requires a change to the framework.
Cary Clark [Thu, 3 Dec 2009 16:02:54 +0000 (11:02 -0500)]
move input-related fields out of CachedNode to expand
Some of the fields in CachedNode are relevant only to input
fields and text areas. Move these into their own vector
so that we can add more data without making all CacheNodes
bigger.
Remove CacheNode entries that are no longer used, or can
be consolidated into the node type. Alphabetize some interfaces
and implementations. Update the debugging output.
part of http://b/
2299660
Steve Block [Fri, 4 Dec 2009 13:42:01 +0000 (13:42 +0000)]
Enables x-mac-cyrillic on Android, now that this is in our version of ICU.
See https://android-git.corp.google.com/g/#change,34457,
which adds the encoding to ICU 3.8 in eclair-mr2, and
https://android-git.corp.google.com/g/#change,34758,
which adds the encoding to ICU 4.2 in master.
Change-Id: I2b870c714a3ee397964e6bfe14c95bdcca9ea24a
Grace Kloba [Fri, 4 Dec 2009 08:32:52 +0000 (00:32 -0800)]
Only re-center the page if it is zoom change or
orientation change. Do not re-center the page if
it is caused by show/hide soft keyboard.
Fix http://b/issue?id=
2303918
Android (Google) Code Review [Thu, 3 Dec 2009 23:47:48 +0000 (15:47 -0800)]
Merge change Iceb63592 into eclair-mr2
* changes:
Experimental change. Cache pages with unload event for back/forward. This will improve the history navigation. But it may break some sites. See discussion in https://bugs.webkit.org/show_bug.cgi?id=29021.
Grace Kloba [Thu, 3 Dec 2009 17:53:55 +0000 (09:53 -0800)]
Experimental change. Cache pages with unload event
for back/forward. This will improve the history
navigation. But it may break some sites. See discussion
in https://bugs.webkit.org/show_bug.cgi?id=29021.
Grace Kloba [Thu, 3 Dec 2009 19:39:15 +0000 (11:39 -0800)]
Rework CL, https://android-git.corp.google.com/g/#change,34511
due to the history unfork change.
Grace Kloba [Thu, 3 Dec 2009 19:01:07 +0000 (11:01 -0800)]
another file to fix the build
Grace Kloba [Thu, 3 Dec 2009 18:56:34 +0000 (10:56 -0800)]
Fix the build due to auto merge
Grace Kloba [Wed, 2 Dec 2009 20:37:26 +0000 (12:37 -0800)]
After turning on page cache, the parent HistoryItem
can be destroyed before the child HistoryItem, add
an extra checking to avoid crash.
Android (Google) Code Review [Thu, 3 Dec 2009 12:56:02 +0000 (04:56 -0800)]
Merge change I70c3076b into eclair-mr2
* changes:
Fixes a crashing Geolocation bug when a watch is cleared from certain callbacks.
Ben Murdoch [Thu, 26 Nov 2009 14:58:02 +0000 (14:58 +0000)]
Android History unforking pt4: Android specific changes to makefiles and other code that has not been upstreamed yet (i.e. WebKit/android).
This does NOT need to be upstreamed to WebKit (yet).
Change-Id: I821fb90c3e463ef5fc4fa001ee5b8d967f9f7e48
Ben Murdoch [Thu, 26 Nov 2009 14:53:09 +0000 (14:53 +0000)]
Android History unforking pt3: Changes to the notifyHIstoryItemChanged function and the places it is used.
This needs to be upstreamed to webkit.org.
Change-Id: I5dc4e40939448e0b1dfcd6393082036fc8174aa9
Ben Murdoch [Thu, 26 Nov 2009 14:49:53 +0000 (14:49 +0000)]
Android History unforking pt2: BackForwardList changes. Fire a notification to the FrameLoaderClient that the BackForwardList has been modified.
This needs to be upstreamed to webkit.org.
Change-Id: I14633c51276bd92ed56139b4c473cc8ac9bacb72
Ben Murdoch [Thu, 26 Nov 2009 14:11:05 +0000 (14:11 +0000)]
Android history unforking pt 1: Add Android specific files and #if PLATFORM(ANDROID) guarded code in WebCore/history/HistoryItem.cpp
This should be upstreamed to webkit.org
Change-Id: I3f822d5a6579080658242f846214e1c3fe31fa01
Steve Block [Thu, 3 Dec 2009 11:11:15 +0000 (11:11 +0000)]
Fixes a crashing Geolocation bug when a watch is cleared from certain callbacks.
BUG: http://b/
2297475
This will be upstreamed to webkit.org in https://bugs.webkit.org/show_bug.cgi?id=32111
Change-Id: I70c3076b1a85c89bc4c587ea9fedaa84bd7b0575
Leon Scroggins [Wed, 2 Dec 2009 19:47:32 +0000 (14:47 -0500)]
Save form data for elements other than type "text".
Partial fix for http://b/issue?id=
2232001
When returning the form data for a page, check other types of textfields
besides "text" input elements. Also consider "email", "number", etc.
Grace Kloba [Tue, 24 Nov 2009 22:22:22 +0000 (14:22 -0800)]
Enable WebKit page cache through WebSettings.
Add setXX() for the meta data in Settings.
Add CachedFramePlatformDataAndroid to preserve the
state for the cachedFrame.
http://b/issue?id=
2284168
Android (Google) Code Review [Wed, 2 Dec 2009 17:51:27 +0000 (09:51 -0800)]
Merge change Ie0a2c0d4 into eclair-mr2
* changes:
Move dump display tree to sdcard as dom and render tree.
Android (Google) Code Review [Wed, 2 Dec 2009 17:41:07 +0000 (09:41 -0800)]
Merge change I3aa3fc5b into eclair-mr2
* changes:
skip nodes when building nav cache if parents are clipped out
Cary Clark [Wed, 2 Dec 2009 17:12:19 +0000 (12:12 -0500)]
skip nodes when building nav cache if parents are clipped out
This is a fairly conservative fix, since it actually checks to
see if a parent element is clipped out, rather than the bounds
of the element itself.
fixes http://b/
2291936
Cary Clark [Wed, 2 Dec 2009 13:59:01 +0000 (08:59 -0500)]
nav to container if it wants key events
When a text field or text area (or plugin) has another navable
element completely overlaying it, allow the trackball to move
from that inner element to the outer one.
Also, allow this to get a 'second chance' -- treat the case
when one element overlays another as a spacial nav and allow
it to retry in nav find algorithms.
fixes http://b/
2266756
Steve Block [Thu, 26 Nov 2009 11:24:22 +0000 (11:24 +0000)]
Updates Geolocation V8 bindings to match patch submitted to webkit.org.
See http://trac.webkit.org/changeset/51540
Change-Id: If60a5650750b1dc48353773947d451f4e8a3ec52
Grace Kloba [Mon, 23 Nov 2009 23:40:48 +0000 (15:40 -0800)]
Move dump display tree to sdcard as dom and render tree.
Fix dump render tree code.
Derek Sollenberger [Tue, 1 Dec 2009 15:53:06 +0000 (10:53 -0500)]
cleaning up local JNI references for plugins and caching appropriate JNI ids.
Derek Sollenberger [Tue, 1 Dec 2009 14:36:06 +0000 (09:36 -0500)]
Adding native portion of the PluginActivity class.
Android (Google) Code Review [Tue, 1 Dec 2009 14:15:31 +0000 (06:15 -0800)]
Merge change I783ff698 into eclair-mr2
* changes:
Removes superfluous file V8 DerivedSourcesAllInOne.cpp from Android build.
Derek Sollenberger [Tue, 1 Dec 2009 13:43:57 +0000 (08:43 -0500)]
Cleanup how a plugin requests to go full-screen.
Android (Google) Code Review [Tue, 1 Dec 2009 13:17:57 +0000 (05:17 -0800)]
Merge change I24ba66f9 into eclair-mr2
* changes:
Cleaning up android_npapi by removing implemented functions and unused parameters.
Android (Google) Code Review [Tue, 1 Dec 2009 13:15:06 +0000 (05:15 -0800)]
Merge change Iae9809cb into eclair-mr2
* changes:
Fixes Makefiles to have proper dependency on HTMLTagNames.in and HTMLAttributeNames.in.
Steve Block [Mon, 30 Nov 2009 14:56:15 +0000 (14:56 +0000)]
Removes superfluous file V8 DerivedSourcesAllInOne.cpp from Android build.
This was added in https://android-git.corp.google.com/w/?p=platform/external/webkit.git;a=commitdiff;h=
6d62749f698529d29ec7cf61f6c8ec323ae52b83#patch1
Also revert Android-specific changes to DerivedSourcesAllInOne.cpp, to avoid future conflicts in WebKit merge.
Change-Id: I783ff698af8212c02c48012f97bd1bc3d90b7ea2
Steve Block [Tue, 1 Dec 2009 11:55:51 +0000 (11:55 +0000)]
Fixes Makefiles to have proper dependency on HTMLTagNames.in and HTMLAttributeNames.in.
Previously, the path to these files was expanded prior to execution of the rule,
thus breaking the dependency.
Change-Id: Iae9809cb925dfc26606f02a47a4dd930c99a3106
Cary Clark [Mon, 30 Nov 2009 20:46:06 +0000 (15:46 -0500)]
navigate preferably between children of the same parent
The nav cache attempts to take advantage of the order that
the dom is walked to know when multiple nodes have the same
parent. The old implementation doesn't always work, and a
simpler non-cached version makes more sense.
The algorithm now walks nodes until the parent has more than
one child, and assigns that parent as the 'parent group'. On
the other end, nodes with no parent group are never allowed
to get preferential matching treatment.
Android (Google) Code Review [Mon, 30 Nov 2009 20:39:07 +0000 (12:39 -0800)]
Merge change Ib72d8281 into eclair-mr2
* changes:
fix bugs in nav cache dump
Cary Clark [Mon, 30 Nov 2009 20:15:04 +0000 (15:15 -0500)]
fix bugs in nav cache dump
Fix errors in empty frames, escape character sequences,
and characters outside the ascii range. These fixes are
specific to dumping the nav cache and are commented out
in all builds.
Android (Google) Code Review [Mon, 30 Nov 2009 19:29:39 +0000 (11:29 -0800)]
Merge change I11fe1a14 into eclair-mr2
* changes:
add ANDROID to the list of platforms that support font-face
Mike Reed [Mon, 30 Nov 2009 18:18:08 +0000 (13:18 -0500)]
add ANDROID to the list of platforms that support font-face
Derek Sollenberger [Mon, 30 Nov 2009 16:53:41 +0000 (11:53 -0500)]
Cleaning up android_npapi by removing implemented functions and unused parameters.
Patrick Scott [Mon, 30 Nov 2009 15:42:28 +0000 (10:42 -0500)]
Fix a crash when closing the native history.
The item for a given frame can be null when closing the history while reusing
the same WebView. If the item is null, no need to visit the children since they
will also not have a history item.
Android (Google) Code Review [Mon, 30 Nov 2009 16:06:41 +0000 (08:06 -0800)]
Merge change Ie9bc2064 into eclair-mr2
* changes:
Remove the Android-specific setCMYKXXXColor methods, which are not used.
Derek Sollenberger [Tue, 24 Nov 2009 20:05:24 +0000 (15:05 -0500)]
Refactoring plugins to use new java interfaces.
This change contains extensive cleanup as we now keep track of a pointer
to the plugin's java entry point (WebkitPlugin.class). Also given that we
track this object and changes to plugin packaging we nolonger need to pass
additional parameters in quite a few methods.
Android (Google) Code Review [Fri, 27 Nov 2009 12:11:33 +0000 (04:11 -0800)]
Merge change I49a4a258 into eclair-mr2
* changes:
Removes superfluous code from Android implementation of AuthenticationChallenge.
Steve Block [Thu, 26 Nov 2009 12:54:29 +0000 (12:54 +0000)]
Removes superfluous code from Android implementation of AuthenticationChallenge.
- On Android, we use only the default constructor.
See WebCore/platform/network/ResourceHandleInternal.h.
- AuthenticationChallenge::sourceHandle is only required for CF.
See WebCore/platform/network/cf/AuthenticationCF.cpp.
The method was originally added only for CF in http://trac.webkit.org/changeset/18880
but has since been copied to other platforms, despite not being required.
Change-Id: I49a4a2587a9551107a105573bd9da2e56ee0f52e
Steve Block [Thu, 26 Nov 2009 15:50:24 +0000 (15:50 +0000)]
Remove the Android-specific setCMYKXXXColor methods, which are not used.
Change-Id: Ie9bc2064b10c01579d60e31f62ea6996974f8f4a
Android (Google) Code Review [Thu, 26 Nov 2009 10:21:19 +0000 (02:21 -0800)]
Merge change Ice535a82 into eclair-mr2
* changes:
Restores the default value for ENABLE(ARCHIVE) in wtf/Platform.h.
Android (Google) Code Review [Wed, 25 Nov 2009 16:43:40 +0000 (08:43 -0800)]
Merge change Ie4e91d61 into eclair-mr2
* changes:
Bring Android files in line with what landed at webkit.org.
Android (Google) Code Review [Wed, 25 Nov 2009 16:34:23 +0000 (08:34 -0800)]
Merge change I4b0151ad into eclair-mr2
* changes:
Fixes a PLATFORM(ANDROID) guard in RenderBlock.h which causes problems when building on Mac.
Andrei Popescu [Wed, 25 Nov 2009 16:20:53 +0000 (16:20 +0000)]
Bring Android files in line with what landed at webkit.org.
Picks up changes made by Apple in
http://trac.webkit.org/changeset/51191/trunk/WebCore/platform/android/LocalizedStringsAndroid.cpp
Android (Google) Code Review [Wed, 25 Nov 2009 16:27:02 +0000 (08:27 -0800)]
Merge change I1890130f into eclair-mr2
* changes:
Update files in platform/android to match what was upstreamed in
Andrei Popescu [Tue, 24 Nov 2009 12:04:22 +0000 (12:04 +0000)]
Update files in platform/android to match what was upstreamed in
https://bugs.webkit.org/show_bug.cgi?id=31825
https://bugs.webkit.org/show_bug.cgi?id=31831
Steve Block [Wed, 25 Nov 2009 15:13:50 +0000 (15:13 +0000)]
Restores the default value for ENABLE(ARCHIVE) in wtf/Platform.h.
This default was recently removed but is required to build on Mac.
See https://android-git.corp.google.com/w/?p=platform/external/webkit.git;a=commitdiff;h=
2cc706295f906df0bb49f51c9efe92a97c427464#patch1
Change-Id: Ice535a8205d14a0f3c3bfc4f32bc7d71132fbc2a
Leon Scroggins [Tue, 24 Nov 2009 19:55:38 +0000 (14:55 -0500)]
Remove nativeTextInputMotionUp.
Function is not needed. Requires a change to frameworks/base
Steve Block [Wed, 25 Nov 2009 15:02:57 +0000 (15:02 +0000)]
Fixes a PLATFORM(ANDROID) guard in RenderBlock.h which causes problems when building on Mac.
This code was modified recently to aid upstreaming by wrapping all Android changes in PLATFORM(ANDROID).
To allow the build to succeed on other paltforms, we need to be more careful with our use of the guards.
See https://android-git.corp.google.com/w/?p=platform/external/webkit.git;a=commitdiff;h=
bc7b84de3fd863c500a8169fd00dca3811cadbb3#patch28
Change-Id: I4b0151ad62023821171742c5dfbba1dd7b39d8ed
Steve Block [Wed, 25 Nov 2009 11:14:04 +0000 (11:14 +0000)]
Fixes use of statics of non-built-in types in Geolocation.
The Mac build requires that only built-in types are used as statics.
Change-Id: I69a3f063c5728d76a13f73b8b056187d5678e0ab
Android (Google) Code Review [Wed, 25 Nov 2009 13:49:08 +0000 (05:49 -0800)]
Merge change I6d6312e9 into eclair-mr2
* changes:
Fixes WTF include in WebCore/page/Geolocation.cpp to fix Mac build.
Android (Google) Code Review [Wed, 25 Nov 2009 11:26:54 +0000 (03:26 -0800)]
Merge change I973e6b03 into eclair-mr2
* changes:
Unfork WebCore/bridge/jni.
Android (Google) Code Review [Wed, 25 Nov 2009 10:38:22 +0000 (02:38 -0800)]
Merge change I685fd143 into eclair-mr2
* changes:
Removes superfluous use of LOCAL_SRC_FILES in derived Makefiles.
Steve Block [Tue, 24 Nov 2009 23:25:53 +0000 (23:25 +0000)]
Fixes WTF include in WebCore/page/Geolocation.cpp to fix Mac build.
Also fixes include problems in files in WebKit/android.
Change-Id: I6d6312e9753eb2bbf0b61f20a6ef0eb56f990991
Steve Block [Tue, 24 Nov 2009 23:25:05 +0000 (23:25 +0000)]
Removes superfluous use of LOCAL_SRC_FILES in derived Makefiles.
Change-Id: I685fd143279f92570a1844c847478e0cbe038e1e
Android (Google) Code Review [Tue, 24 Nov 2009 19:33:26 +0000 (11:33 -0800)]
Merge change Ib6355d33 into eclair-mr2
* changes:
remove obsolete code block
Cary Clark [Tue, 24 Nov 2009 18:26:16 +0000 (13:26 -0500)]
remove obsolete code block
This block was commented out in Android to improve performance.
It has now been removed from webkit altogether.
It needs to be removed to allow webkit to build for Safari,
since the interfaces it references are now obsolete.
Patrick Scott [Tue, 24 Nov 2009 13:44:18 +0000 (08:44 -0500)]
Fix the occassional build break.
WebCoreJniOnLoad.cpp now depends on some generated headers so it can occassional
fail to build if make has many jobs. Add LOCAL_ADDITIONAL_DEPENDENCIES to
prevent build breakage.
This was pulled from the old perf/Android.mk file.
Ben Murdoch [Mon, 23 Nov 2009 14:25:39 +0000 (14:25 +0000)]
Unfork WebCore/bridge/jni.
Change-Id: I973e6b03286b1d8f6e6325a2b31d0cf9e99d19b3
Android (Google) Code Review [Tue, 24 Nov 2009 10:59:58 +0000 (02:59 -0800)]
Merge change I46e116c9 into eclair-mr2
* changes:
Updates MainThreadAndroid.cpp to reflect version upstreamed to webkit.org.
Android (Google) Code Review [Mon, 23 Nov 2009 21:16:38 +0000 (13:16 -0800)]
Merge change Ia6cf2f30 into eclair-mr2
* changes:
Updates an Android-specific work-around in V8GCController.cpp now that std::sort is available on Android.
Android (Google) Code Review [Mon, 23 Nov 2009 18:40:30 +0000 (10:40 -0800)]
Merge change If7c73ee1 into eclair-mr2
* changes:
Moves initializeMaximumHTTPConnectionCountPerHost to a new ResourceRequestAndroid.cpp file.
Steve Block [Mon, 23 Nov 2009 17:44:27 +0000 (17:44 +0000)]
Updates an Android-specific work-around in V8GCController.cpp now that std::sort is available on Android.
Change-Id: Ia6cf2f309894c877e23ad8f07439d0892810cbb2
Steve Block [Mon, 23 Nov 2009 17:59:53 +0000 (17:59 +0000)]
Moves initializeMaximumHTTPConnectionCountPerHost to a new ResourceRequestAndroid.cpp file.
This is in line with other WebKit ports, ready for upstreaming to webkit.org.
Change-Id: If7c73ee1c65ee69bba54b7acbc462ff3444e781e
Android (Google) Code Review [Mon, 23 Nov 2009 17:37:01 +0000 (09:37 -0800)]
Merge change I30add3d6 into eclair-mr2
* changes:
Removes Android-specific wrapper for std::sort in Profile class.
Steve Block [Mon, 23 Nov 2009 17:27:34 +0000 (17:27 +0000)]
Removes some Symbian platform files which are not not used by Android are no longer in webkit.org.
These files were removed from WebKit in http://trac.webkit.org/changeset/44603 and
should have been removed from Android in a previous WebKit merge.
Change-Id: Icb84e9fe3d433c752415875cc170ff6af9be3c31
Steve Block [Mon, 23 Nov 2009 16:44:44 +0000 (16:44 +0000)]
Updates MainThreadAndroid.cpp to reflect version upstreamed to webkit.org.
See https://bugs.webkit.org/show_bug.cgi?id=31807
Change-Id: I46e116c933475699cba499e3c27921e00ebab666
Steve Block [Fri, 20 Nov 2009 15:27:15 +0000 (15:27 +0000)]
Removes Android-specific wrapper for std::sort in Profile class.
It appears that previosuly, a wrapper function was required to perform
the required type casting when passing a custom comparison function to
Android's std::sort. This is no longer required, so the wrapper can be
removed.
Change-Id: I30add3d6b41eca2558867755a34dda21a180166f
Patrick Scott [Mon, 23 Nov 2009 15:05:03 +0000 (10:05 -0500)]
Fix the sim build.
Android (Google) Code Review [Mon, 23 Nov 2009 14:58:11 +0000 (06:58 -0800)]
Merge change Ia4f91efd into eclair-mr2
* changes:
Moves get_thread_msec from JavaScriptCore/wtf/CurrentTime to WebKit/android/Timecounter.
Android (Google) Code Review [Mon, 23 Nov 2009 14:50:51 +0000 (06:50 -0800)]
Merge change I7f9c0552 into eclair-mr2
* changes:
Updates Threading.h to reflect final version of Android atomicIncrement/Decrement submitted to webkit.org.
Patrick Scott [Mon, 23 Nov 2009 13:19:13 +0000 (08:19 -0500)]
Move the benchmark code inside libwebcore.so
This adds about 8k of code to the library but it allows the benchmark to run
without modifying the library. This makes it ideal when testing libwebcore.so
since it is the exact same as our running library. It also makes it possible to
always build the benchmark app.
Android (Google) Code Review [Mon, 23 Nov 2009 11:51:08 +0000 (03:51 -0800)]
Merge change Ic9c0f729 into eclair-mr2
* changes:
Update the Android-specific fix in StringHash::equal to match the fix recently made in webkit.org.
Steve Block [Fri, 20 Nov 2009 17:32:13 +0000 (17:32 +0000)]
Update the Android-specific fix in StringHash::equal to match the fix recently made in webkit.org.
StringHash::equal includes an Android-specific fix for platforms which don't
provide 4-byte alignment ...
https://android-git.corp.google.com/w/?p=platform/external/webkit.git;a=commitdiff;h=
05d23612a67d710479fb2359e98d7ac49a982025
This was recently fixed in webkit.org ...
http://trac.webkit.org/changeset/51006
This patch updates Android to use the fix from webkit.org to avoid future merge conflicts.
Background ...
The fix in webkit.org uses a loop, whereas the Android fix uses memcmp.
Tests by WebKit have apparently shown a loop to be faster than memcmp for small
strings. This is consistent with an equivalent fix in AtomicString ...
http://trac.webkit.org/changeset/19930
Change-Id: Ic9c0f729117e31bfdcb1bc1c28e85c048a464173
Steve Block [Mon, 23 Nov 2009 10:49:08 +0000 (10:49 +0000)]
Updates Threading.h to reflect final version of Android atomicIncrement/Decrement submitted to webkit.org.
See https://bugs.webkit.org/show_bug.cgi?id=31715
Change-Id: I7f9c0552bd9f3c51e7b869bd1c782ef72d28f1a4
Leon Scroggins [Fri, 20 Nov 2009 19:47:54 +0000 (14:47 -0500)]
Draw ListBoxes to look like MenuLists.
Cherry-pick of an earlier change, listed below, which was somehow
lost. Fixes http://b/issue?id=
2273867
https://android-git.corp.google.com/g/#change,5072
Fix <select with multiple and/or size > 1.
With the latest WebKit drop we lost a hack we had to make ListBoxes
behave like MenuLists. Rather than reviving it, now in WebViewCore
check for isListBox(). This makes a click once again open the list
so the user can choose the selection. Also disable WebKit's drawing
of the text shown, and simply draw it ourselves, so we can draw
nothing or the first item selected.
Android (Google) Code Review [Fri, 20 Nov 2009 16:33:49 +0000 (08:33 -0800)]
Merge change Id484e955 into eclair-mr2
* changes:
Bring TextBreakIteratorInternalICU.cpp in to line with WebKit version.
Steve Block [Fri, 20 Nov 2009 15:57:33 +0000 (15:57 +0000)]
Bring TextBreakIteratorInternalICU.cpp in to line with WebKit version.
Note that this is a comment change only.
See http://trac.webkit.org/changeset/45762#file3
Change-Id: Id484e955a5aeb948dc8068626e8013dbad757e22
Steve Block [Fri, 20 Nov 2009 13:26:23 +0000 (13:26 +0000)]
Moves get_thread_msec from JavaScriptCore/wtf/CurrentTime to WebKit/android/Timecounter.
This function is an Android addition to JavaScriptCore::WTF, but is not used anywhere in WebCore or JavaScriptCore.
Futhermore, JavaScriptCore/wtf/CurrentTime does not contain any other platform additions.
It's used primarily in WebKit/android/TimeCounter, so I've moved it there.
I've also updated the name to getThreadMsec to match WebKit style.
Change-Id: Ia4f91efd3caaafd1fb079afe6c493aefea402582
Steve Block [Fri, 20 Nov 2009 12:33:44 +0000 (12:33 +0000)]
Removes a superfluous Android include from TypeTraits.cpp.
Change-Id: I344d69490b8050ff659e2b380c05fb9872d66cde
Steve Block [Fri, 20 Nov 2009 11:13:56 +0000 (11:13 +0000)]
Cleans up Threading.cpp/h ready for upstreaming to webkit.org.
$ diff ~/WebKitTipOfTree/JavaScriptCore/wtf/Threading.cpp JavaScriptCore/wtf/Threading.cpp
$ diff ~/WebKitTipOfTree/JavaScriptCore/wtf/Threading.h JavaScriptCore/wtf/Threading.h
75a76,77
> #elif PLATFORM(ANDROID)
> #include "cutils/atomic.h"
234a237,241
> #elif PLATFORM(ANDROID)
>
> inline int atomicIncrement(int volatile* addend) { return android_atomic_inc(addend); }
> inline int atomicDecrement(int volatile* addend) { return android_atomic_dec(addend); }
>
Change-Id: Ie4835ff88aae608b7a1844be1b422d105b327528