OSDN Git Service
Pavlin Radoslavov [Thu, 13 Jul 2017 17:19:07 +0000 (17:19 +0000)]
Allocate buffers of the right size when BT_HDR is included
am:
8810ffba99
Change-Id: Iba43743c47ce1e0dc0221177b0d168692fa44bdf
Pavlin Radoslavov [Thu, 6 Jul 2017 20:39:02 +0000 (13:39 -0700)]
Allocate buffers of the right size when BT_HDR is included
Bug:
63146105
Test: External script
Change-Id: I1f2c871e3fcf57aabdad9d07905e6dae643bd496
Merged-In: I1f2c871e3fcf57aabdad9d07905e6dae643bd496
Ajay Panicker [Wed, 12 Jul 2017 18:45:08 +0000 (11:45 -0700)]
Allow collection of Bluetooth firmware dumps in bugreports (3/3)
This patch is temporary and should be removed once the bug is resolved
Bug:
63390057
Test: Force a hci timeout and collect a bugreport on walleye
Change-Id: Idab6d87c1b0540ea325fa1019ea2c9e97f3218f2
Jack He [Thu, 29 Jun 2017 20:58:47 +0000 (13:58 -0700)]
GATT: Expose opportunistic client API to Java
* Opportunistic GATT connection allows system service to subscribe to
characteristic notifications without holding the BLE connection
* Exposing this flag to Java allows Android applications to use it
Bug:
63347806
Test: make, test on Android App
Change-Id: Ic470acd63bf45d1c33696abed1e93b30746fb7a2
Merged-In: Ic470acd63bf45d1c33696abed1e93b30746fb7a2
(cherry picked from commit
5120fedf20eb29fa65cef561c475d18d51197b25)
Jakub Pawlowski [Thu, 22 Jun 2017 19:45:30 +0000 (12:45 -0700)]
Fix crashes on stack shutdown
During stack shutdown, Unregister would sometimes get called after the
stack is already cleaned up, and the AdvertiseManager::Get would crash
on null check assertion. Ensure that stack is initialized before
Unregister call.
Bug:
37888261
Test: none
Change-Id: I7a4bbcd24ec7d24d21d04fe842985baaac899321
Merged-In: I7a4bbcd24ec7d24d21d04fe842985baaac899321
TreeHugger Robot [Fri, 7 Jul 2017 21:22:41 +0000 (21:22 +0000)]
Merge "Revert "Blacklist Kinivo BTC350 for Absolute Volume"" into oc-dr1-dev
Tom Turney [Fri, 7 Jul 2017 18:11:46 +0000 (18:11 +0000)]
Revert "Blacklist Kinivo BTC350 for Absolute Volume"
This reverts commit
84e8fa9b0873c31b6ee5dce53405db9e9ff77a31.
This is actually due to b/
63073544 not an issue with the device.
Change-Id: I8433adcfc7ff8f3bf8a16eccb72f0522fa896fef
Jinguang Dong [Wed, 28 Jun 2017 01:50:37 +0000 (09:50 +0800)]
Do not delete device record on HCI_ERR_KEY_MISSING
If an auth_complete event is received with HCI_ERR_KEY_MISSING, the
p_dev_rec->sm4 flag will be set to "BTM_SM4_UNKNOWN" in the
BTM_SecClearSecurityFlags() function. This will prevent the
BTM_SM4_RETRY procedure from being executed, which can cause
pairing failures.
To reproduce:
1. Two Phones, A: Android O, B: Android N.
2. Enable B in Bluetooth visable mode
3. A start discovery and create pairing with B successfully
4. B cancel pairing with A by remove A from pairing device
list of B.
5. A create paring with B again by touch paired device in A,
this first step will be failed.
Bug:
62615213
Test: manual
Change-Id: I514ba2f4d0fd2621c11bd83aeec24b8c6c6d2d5a
Signed-off-by: Yequan Song <songyequan@huawei.com>
(cherry picked from commit
549ec693c2a3a240a5b688a1311cc7c55daa59fc)
Philip Cuadra [Fri, 9 Jun 2017 21:36:06 +0000 (14:36 -0700)]
Bluetooth - Add tracing for TX queue and LDAC ABR
For debugging, add tracing to show the length of the TX queue and the
LDAC ABR level.
Test: Ran bluetooth, took a systrace
Change-Id: Ia23764d68f27ae8209e37c4a0836852d73cf6cbc
Srinu Jella [Wed, 7 Dec 2016 13:46:31 +0000 (19:16 +0530)]
Don't initiate role switch for blacklisted devices
Some devices always reject role switches and role switch
retries from the DUT may lead to A2DP glitches and LMP timeouts.
Test: manual
Bug:
33000157
Change-Id: I535a2c45ced0e14cf5530f78f3367569b306b1f4
Merged-In: I535a2c45ced0e14cf5530f78f3367569b306b1f4
(cherry picked from commit
811200c8d120d987695445c28fda378677ba21c1)
Pavlin Radoslavov [Sat, 1 Jul 2017 04:25:15 +0000 (21:25 -0700)]
Add missing lock protection when freeing RFCOMM port queues
Bug:
63100223
Test: Code compilation
Change-Id: Ibbafb9586e9807688276c9eb2f6399cb3ee487c9
(cherry picked from commit
16f4cf0bb17cee817da11f2775f4a00d290eaba7)
TreeHugger Robot [Thu, 6 Jul 2017 17:19:45 +0000 (17:19 +0000)]
Merge "A2DP: Add mandatory elements for SBC SRC capabilities" into oc-dr1-dev
koh.changseok [Mon, 3 Jul 2017 17:37:42 +0000 (02:37 +0900)]
A2DP: Add mandatory elements for SBC SRC capabilities
* The SBC items below are mandatory for SBC SRC capabilities
(see A2DP_SPEC_V13.pdf, Section 4.3.2):
- Channel Mode - mono
- Block Length - 4, 8, 12, 16
* Updated/fixed the corresponding unit tests
Bug:
63260735
Test: Manual - A2DP SBC streaming
Change-Id: I04c4f0b830411bc736d7c402b86006c182af02e7
(cherry picked from commit
444ea2c15a24cabaae87c8806b5d50e6ecb9a24d)
Srinu Jella [Thu, 8 Dec 2016 13:33:20 +0000 (19:03 +0530)]
Dynamic blacklist device for role switch
- Blacklist the device if it's rejected the role switch for
max number of times. Same is added to the interop_database.
- Maximum number of failed (BTM_MAX_SW_ROLE_FAILED_ATTEMPTS)
attempts set to 3 and it is configurable.
- Same blacklisted device is referred by the BTM module when
any other module like profile is requesting for role switch
and BTM module returns BTM_REPEATED_ATTEMPTS as the switch
role status.
Test: Code compilation
Bug:
32999957
Change-Id: Ie999104a2c8ca507605ef3e1d454865cee98dcd2
(cherry picked from commit
942648ef5a4b25508cc9ffe7073ddab5e04a9ab4)
Ben YoungTae Kim [Tue, 20 Jun 2017 13:56:08 +0000 (19:26 +0530)]
Set the A2DP media channel as a high priority L2CAP link
Use dynamic ACL buffer allocation for high priority links:
1. Ensure dedicated ACL buffers for high priority links
2. Adjust buffer allocation if the priority of the link changes
Test: Manually tested with 4 HID devices and A2DP streaming scenario
Bug:
30787081
Change-Id: Id3c4a76e360aee322e9f8073bd399807e7987990
(cherry picked from commit
624ba681a63fa5ecf778b0b019735359654c6dd0)
Marie Janssen [Fri, 23 Jun 2017 20:01:35 +0000 (20:01 +0000)]
btif: Pass UIDs changed up to the Java layer
am:
39f664e629
Change-Id: I61d182617ea69cb060fb27e26a3d3b0a24fb07c0
Marie Janssen [Fri, 23 Jun 2017 00:21:10 +0000 (17:21 -0700)]
btif: Pass UIDs changed up to the Java layer
Previously we were simply responding with an INTERIM response and
leaving it at that.
Test: connect to BMW kit and check that interim is sent from Java
Bug:
62775732
Change-Id: Idb7de4417438f0c9697ee5c838b511cdd2223e80
(cherry picked from commit
3d7c99dc6db3f2a0392a0b273140eb03e0050ee5)
Jacky Cheung [Fri, 23 Jun 2017 02:50:50 +0000 (02:50 +0000)]
Fix BLE remote address resolution
am:
5235a8c4cc
Change-Id: I533d76ef00b9971c48347362b5092b81471e46d4
Jacky Cheung [Wed, 21 Jun 2017 16:44:23 +0000 (09:44 -0700)]
Fix BLE remote address resolution
The hash segment of the resolvable device address needs to be extracted
for comparison.
Bug:
62589903
Test: manual
(cherry picked from commit
7c58ca38433bc923c653c334b712fb05d25cab36)
Merged-In: I979a8ad3074b692503b0c882bd90041ba4fbfb4d
Change-Id: I5db8f266c9ee3022b2a8a882540870e5eecd0736
TreeHugger Robot [Thu, 22 Jun 2017 01:06:35 +0000 (01:06 +0000)]
Merge "Ensure we don't send more packets than firmware allows" into oc-dr1-dev
TreeHugger Robot [Thu, 22 Jun 2017 00:39:43 +0000 (00:39 +0000)]
Merge "Fix transport quota exhaustion" into oc-dr1-dev
Subramanian Srinivasan [Wed, 21 Jun 2017 23:29:05 +0000 (23:29 +0000)]
Fix peer address type in LE extended create connection command
am:
77ecddc3a4
Change-Id: Ida0be85163d5f615e8a2bb286edd372fd67699dd
Yamei Du [Wed, 18 Nov 2015 09:28:07 +0000 (17:28 +0800)]
Ensure we don't send more packets than firmware allows
Make TX complete callback after we've sent the packet
to the lower layers and adjusted our in flight packet
count.
Bug:
26763700
Test: manual
Change-Id: Iaba14a11c1583da2a72769ebd096e0baedf857c3
Ruina Liu [Thu, 24 Sep 2015 02:04:16 +0000 (10:04 +0800)]
Fix transport quota exhaustion
BREDR and BLE use round-robin for link quota.
If you have exhausted one transport's quota,
the break will cause traffic for all transports
to cease.
Change to a continue to prevent this.
Change-Id: I7ca739dfbf02acd2e30527c16ca616a7bad70c51
Test: manual
CR-Id: ALPS02303646
Subramanian Srinivasan [Fri, 9 Jun 2017 00:19:05 +0000 (17:19 -0700)]
Fix peer address type in LE extended create connection command
As per BT Spec 5.0, peer address type in LE extended create
connection command can have only either 0x00 or 0x01 as valid
values. This change fixes setting of incorrect peer address
type values in extended create connection command.
Bug:
62578331
Bug:
62358300
Change-Id: I792d48be7637fc571727e7e51de1fc397158b4d5
Pavlin Radoslavov [Wed, 21 Jun 2017 02:49:01 +0000 (02:49 +0000)]
Add a mechanism to avoid using AVDTP RECONFIGURE for blacklisted devices
am:
b5c932fe13
Change-Id: Icf9a802783136090208dbb7eba95a4904e035819
Pavlin Radoslavov [Mon, 19 Jun 2017 19:44:11 +0000 (12:44 -0700)]
Add a mechanism to avoid using AVDTP RECONFIGURE for blacklisted devices
Some carkits report SUCCESS for AVDTP RECONFIGURE commands when
changing A2DP codec configuration. However, there is no audio coming
from the carkit.
Bug:
37625892
Test: Manual - A2DP Codec reconfiguration while streaming audio
Change-Id: I01f37a2514e490986a20e96ace78c92463403396
Merged-In: I01f37a2514e490986a20e96ace78c92463403396
(cherry picked from commit
e91297a4d1a77ae0c367fbe756090b7357e9893a)
Pavlin Radoslavov [Tue, 20 Jun 2017 16:46:40 +0000 (16:46 +0000)]
Disable 48.0kHz sampling rate for AAC - update the unit test
am:
78120a1a24
Change-Id: Ieb4ee6ed56ed5be7d797f493ce8c27cbbfd1c3ab
Pavlin Radoslavov [Tue, 20 Jun 2017 04:12:37 +0000 (21:12 -0700)]
Disable 48.0kHz sampling rate for AAC - update the unit test
Some carkits have issues playing A2DP audio using AAC with 48.0kHz
sampling rate, while playing AAC with 44.1kHz sampling rate is fine.
Bug:
38443632
Bug:
62301376
Test: manual
Change-Id: I5a8b72e86fb1a2cbf92f85e7a6c340cee58dadb5
(cherry picked from commit
858b6a15f528468e2b1b497dba27337f40220f7b)
Jakub Pawlowski [Wed, 14 Jun 2017 02:03:08 +0000 (02:03 +0000)]
Fix HID crashing on no descriptor
am:
a87ca9a392
Change-Id: Ide869d7b5cbf08196a77f4e8516f67b8dc2ef628
Jakub Pawlowski [Tue, 13 Jun 2017 21:16:57 +0000 (14:16 -0700)]
Fix HID crashing on no descriptor
Bug:
62461796
Test: compilation test
Change-Id: Ic7b1fcc4b6f3c8680f1810679ed609f2691fa4aa
Martin Brabham [Mon, 12 Jun 2017 18:26:49 +0000 (18:26 +0000)]
bta_dm: Stop copying garbage
am:
e92648629c -s ours
Change-Id: I5f5f01d79ed8f16f7761e43028f5e221b1e7423d
Martin Brabham [Mon, 1 May 2017 23:30:40 +0000 (16:30 -0700)]
bta_dm: Stop copying garbage
After we reach 7 ACL connections we have 7 peer device records.
Once we reach this then we lose a connection and shrink the list we
copy garbage into the last peer device record. This can cause the flag
remove_dev_pending to be set to something > 0 thus true which causes the
stack to remove the device and its bonding information on the next
acl change event.
ACL Connections can happen from any connection (pairing, SDP, etc...)
Bug:
36598959
Test: Manual
Change-Id: Ifbaa4098edba442274ffde183960ef53169988e7
Merged-In: Ifbaa4098edba442274ffde183960ef53169988e7
Jack He [Fri, 9 Jun 2017 23:30:00 +0000 (23:30 +0000)]
eSCO: Limit number of retries after mSBC connection failure
am:
12fb8883d0
Change-Id: I910b806866109a2ac70b1a9975baa908e307e67c
Jack He [Wed, 7 Jun 2017 23:44:30 +0000 (16:44 -0700)]
eSCO: Limit number of retries after mSBC connection failure
* When peer device supports mSBC and codec negotiation, Fluoride stack
will try to do the following when establishing a eSCO/SCO connection:
1) Negotiate to mSBC by sending +BCS:2
2) Try establishing eSCO/SCO connection using mSBC T2 settings
3) If that failed, downgrade to mSBC T1 settings and retry
4) If that failed, re-negotiate codec to CVSD, by sending +BCS:1
5) Retry using CVSD S4 (HFP 1.7 and above) or S3 settings
6) If this failed stop trying and report failure to upper stack
* Retry is achieved by:
* Retry is only possible when inuse_codec = BTA_AG_CODEC_MSBC
* Set codec_msbc_settings to BTA_AG_SCO_MSBC_SETTINGS_T1 when T2
failed to connect in step 3 above
* Set codec_fallback to true when T1 failed so that CVSD is used
in step 4 above
* Retry stop is achieved by:
* Set inuse_codec = BTA_AG_CODEC_CVSD
* Set codec_msbc_settings back to BTA_AG_SCO_MSBC_SETTINGS_T2
* Set codec_fallback to false and codec_updated to true so that
the stack is ready for the next application triggerred SCO
connection attempt
* Removed retry_with_sco_only as both Setup Synchronous Connection
Command (0x0028) and Enhanced Setup Synchronous Connection Command
(0x003D) fall back to SCO connection if eSCO is not supported.
See page 858/2772 and 895/2772 of BT4.2 specification document
* Besides both code paths are the same for retry_with_sco_only after
eSCO changes went in
Bug:
62426841
Test: make, HFP regression, testplans/91406
Change-Id: I205311c55e8763c48b6eb43c27f242927384036e
(cherry picked from commit
e82e56bb2a1e5565b73333b60dc6b30936f52e80)
Pavlin Radoslavov [Fri, 9 Jun 2017 02:10:13 +0000 (02:10 +0000)]
Ignore the Class Of Device if the value is invalid
am:
7fe86917d7
Change-Id: I9d35ec3793ed61e10f11a500af868ebda682764b
Pavlin Radoslavov [Thu, 8 Jun 2017 22:22:52 +0000 (15:22 -0700)]
Ignore the Class Of Device if the value is invalid
If a Bluetooth Device is dual-mode and is discoverable as both
a Classic and a LE device, ignore unknown "zero" values
triggered by the LE advertisements. Otherwise, those could overwrite
a valid (previously discovered) Class Of Device.
Bug:
37615863
Test: Manual with LG HBS1100 headset
Change-Id: I5a0f6ef56248b41d973b850a5542475e45e0312d
(cherry picked from commit
a052757882927c042399d614bc298f9704ce07a3)
Jakub Pawlowski [Thu, 8 Jun 2017 17:59:34 +0000 (17:59 +0000)]
Fix GATT over BREDR not connecting
am:
e0035727e3
Change-Id: I97ece2b97b1000bb9104757680e03063ee04c432
Jakub Pawlowski [Wed, 7 Jun 2017 18:26:36 +0000 (11:26 -0700)]
Fix GATT over BREDR not connecting
For BREDR connections, the upper stack always sends the request with
transport type DUMO, and this should be treated as BREDR if the device
is not known as LE only.
Bug:
62387078
Test: pts GattOverBrEdrTest
Change-Id: I726252e85e78bff2c9585332d2748a0d92a9f6d3
Jakub Pawlowski [Wed, 7 Jun 2017 23:54:59 +0000 (23:54 +0000)]
Merge "Fix loops iteration" into oc-dr1-dev
Pavlin Radoslavov [Wed, 7 Jun 2017 22:05:45 +0000 (22:05 +0000)]
Disable 48.0kHz sampling rate for AAC
am:
ad73569d62
Change-Id: Ic295d9d8d09ba555372bd786b8045e309c80c390
Jakub Pawlowski [Wed, 7 Jun 2017 16:07:26 +0000 (09:07 -0700)]
Fix loops iteration
The erase() already increment the iterator. If the loop additionally do
"it++", it will skip some elements, and might iterate over the end.
Test: compilation test
Change-Id: Ibd9c993d8e80d807f5d7bc920da36ee538477438
Pavlin Radoslavov [Fri, 2 Jun 2017 17:45:43 +0000 (10:45 -0700)]
Disable 48.0kHz sampling rate for AAC
Some carkits have issues playing A2DP audio using AAC with 48.0kHz
sampling rate, while playing AAC with 44.1kHz sampling rate is fine.
Bug:
38443632
Bug:
62301376
Test: manual
Change-Id: I50de2db1d5386d41bfe361fbac99fc7ebbbd3640
(cherry picked from commit
3d268331ae32bd70f60984c9553db1c961073c42)
Jakub Pawlowski [Wed, 7 Jun 2017 04:05:28 +0000 (04:05 +0000)]
Use std::unordered_set for keeping app_hold_link am:
3dda89880b am:
f21ae6ed4f am:
f13ffd521a
am:
f987dd4bec
Change-Id: I2425fb1baf970e3d121e14e8294d45e2513ad47c
Jakub Pawlowski [Wed, 7 Jun 2017 03:53:55 +0000 (03:53 +0000)]
Use std::unordered_set for keeping app_hold_link am:
3dda89880b am:
f21ae6ed4f
am:
f13ffd521a
Change-Id: I51e28d5202184f3dafba5d22682497f649ff326f
Jakub Pawlowski [Wed, 7 Jun 2017 03:45:56 +0000 (03:45 +0000)]
Use std::unordered_set for keeping app_hold_link am:
3dda89880b
am:
f21ae6ed4f
Change-Id: I1d06135b7488cfe3a9f8dd7f33ef71aec4abef86
Jakub Pawlowski [Wed, 7 Jun 2017 03:38:55 +0000 (03:38 +0000)]
Use std::unordered_set for keeping app_hold_link
am:
3dda89880b
Change-Id: I75b54eb119d655ede8331eb8105b01329a46a92e
Jakub Pawlowski [Mon, 5 Jun 2017 22:23:32 +0000 (15:23 -0700)]
Use std::unordered_set for keeping app_hold_link
Change-Id: Ia8a0c9a2264979c1ff89faa5ddf17a83fcb7c7ce
Jakub Pawlowski [Wed, 7 Jun 2017 01:53:46 +0000 (01:53 +0000)]
Get rid of clcb_idx in favour of pointers am:
e4f42abab3 am:
5958c225ad am:
09273a05f4
am:
866740dbf9
Change-Id: I721e60b6f892cee0901540be505a75be6e3d6d0b
Jakub Pawlowski [Wed, 7 Jun 2017 01:53:29 +0000 (01:53 +0000)]
use std::queue for keeping tGATT_CMD_Q am:
d1a9313471 am:
05bd66b651 am:
8b37d9d337
am:
ad1e6a7c44
Change-Id: I0707f44414c56587e42ff41be058efc040c3e3ca
Jakub Pawlowski [Wed, 7 Jun 2017 01:49:31 +0000 (01:49 +0000)]
Get rid of clcb_idx in favour of pointers am:
e4f42abab3 am:
5958c225ad
am:
09273a05f4
Change-Id: I332f5503adbc01a98ebc9554be2f6102770c00e7
Jakub Pawlowski [Wed, 7 Jun 2017 01:49:13 +0000 (01:49 +0000)]
use std::queue for keeping tGATT_CMD_Q am:
d1a9313471 am:
05bd66b651
am:
8b37d9d337
Change-Id: I78e802eada40f4b5c29cb74fba580fed9b1c6ce7
Jakub Pawlowski [Wed, 7 Jun 2017 01:47:00 +0000 (01:47 +0000)]
Get rid of clcb_idx in favour of pointers am:
e4f42abab3
am:
5958c225ad
Change-Id: Iad5b0a28e81f8a7eb6e332c22481ae49656e975e
Jakub Pawlowski [Wed, 7 Jun 2017 01:46:46 +0000 (01:46 +0000)]
use std::queue for keeping tGATT_CMD_Q am:
d1a9313471
am:
05bd66b651
Change-Id: I2face2724f4c52c14769bd1c79a6783f8e4c2d47
Jakub Pawlowski [Wed, 7 Jun 2017 01:44:28 +0000 (01:44 +0000)]
Get rid of clcb_idx in favour of pointers
am:
e4f42abab3
Change-Id: Ie15226cacea4121d0bb7ca9a9cec732d0170f4f1
Jakub Pawlowski [Wed, 7 Jun 2017 01:44:16 +0000 (01:44 +0000)]
Refactor tGATT_BG_CONN_DEV am:
7cfd8391f6 am:
77157460ba am:
7b55503837
am:
3491d92903
Change-Id: I1e69aa803d3e25080cd9e485e69eefe1918de025
Jakub Pawlowski [Wed, 7 Jun 2017 01:44:15 +0000 (01:44 +0000)]
use std::queue for keeping tGATT_CMD_Q
am:
d1a9313471
Change-Id: I2708947e05fdf3835c23874af353349b203f11e4
Jakub Pawlowski [Wed, 7 Jun 2017 01:41:42 +0000 (01:41 +0000)]
Refactor tGATT_BG_CONN_DEV am:
7cfd8391f6 am:
77157460ba
am:
7b55503837
Change-Id: I3f1ef7c9daea0aee2769cc4386eb32b2d8c3e96f
Jakub Pawlowski [Wed, 7 Jun 2017 01:39:45 +0000 (01:39 +0000)]
Refactor tGATT_BG_CONN_DEV am:
7cfd8391f6
am:
77157460ba
Change-Id: I0d5bc72270c5d7b2cd88cb5e91ace28a07e2cc99
Jakub Pawlowski [Wed, 31 May 2017 16:44:00 +0000 (09:44 -0700)]
Get rid of clcb_idx in favour of pointers
Test: compilation test
Change-Id: Ib2c4b13b85343693e6cff4a94eed49382e3aec00
Jakub Pawlowski [Wed, 31 May 2017 00:19:46 +0000 (17:19 -0700)]
use std::queue for keeping tGATT_CMD_Q
Test: compilation
Change-Id: I4df9a075d27a306067c48c652f5da1fb156c4a9b
Jakub Pawlowski [Wed, 7 Jun 2017 01:37:14 +0000 (01:37 +0000)]
Refactor tGATT_BG_CONN_DEV
am:
7cfd8391f6
Change-Id: Ie9855cd0da4a631303cb4228928587b4ee3abe99
Jakub Pawlowski [Tue, 6 Jun 2017 17:03:07 +0000 (10:03 -0700)]
Refactor tGATT_BG_CONN_DEV
* Use list for keeping the devices instead of fixes array, get rid of
the in_use field.
* Use unordered_set instead of array to keep gatt_if of apps interested
in specific device.
* the in_use flag was never cleared before, this had the potential to
fill the whole array when multiple devices were addred/removed to the
whitelist. This issue is fixed now.
Test: compilation test
Change-Id: Id87c2ae9c5b0ce0887a4fa9be50e34d646d22a13
Ting-Yuan Huang [Wed, 7 Jun 2017 00:53:41 +0000 (00:53 +0000)]
Merge "Suppress false compiler warnings" am:
1e37a045a7 am:
cbd6ec860d am:
2b64c1eb00
am:
544f01deaa
Change-Id: Ia48478fa59a447ab61673aac1c0a10da91172263
Ting-Yuan Huang [Wed, 7 Jun 2017 00:40:09 +0000 (00:40 +0000)]
Merge "Suppress false compiler warnings" am:
1e37a045a7 am:
cbd6ec860d
am:
2b64c1eb00
Change-Id: I7422a7ba773ebb1036cb8f4915b0e52e3b48f41b
Ting-Yuan Huang [Wed, 7 Jun 2017 00:38:09 +0000 (00:38 +0000)]
Merge "Suppress false compiler warnings" am:
1e37a045a7
am:
cbd6ec860d
Change-Id: I0b1c8842ace8c0c0314d977a1ae7531dabaaa9ea
Ting-Yuan Huang [Wed, 7 Jun 2017 00:35:41 +0000 (00:35 +0000)]
Merge "Suppress false compiler warnings"
am:
1e37a045a7
Change-Id: I93f117b739af6a3ab0db85ee310186cdcea689db
Treehugger Robot [Wed, 7 Jun 2017 00:25:50 +0000 (00:25 +0000)]
Merge "Suppress false compiler warnings"
Jakub Pawlowski [Wed, 7 Jun 2017 00:12:08 +0000 (00:12 +0000)]
Linux build fix am:
66e8571f6c am:
1f99591592 am:
1da224279c
am:
a0946e07c1
Change-Id: Iaeb6426769e79ab75e090184467d5716cee263e9
Jakub Pawlowski [Tue, 6 Jun 2017 23:57:41 +0000 (23:57 +0000)]
Linux build fix am:
66e8571f6c am:
1f99591592
am:
1da224279c
Change-Id: Iebe58ffae32d0762a383a51ce1ae3ee175894e50
Jakub Pawlowski [Tue, 6 Jun 2017 23:54:08 +0000 (23:54 +0000)]
Linux build fix am:
66e8571f6c
am:
1f99591592
Change-Id: I4548a48d8ba1ce9025f75c3574b50e6ede6b8ab2
Jakub Pawlowski [Tue, 6 Jun 2017 23:52:41 +0000 (23:52 +0000)]
Linux build fix
am:
66e8571f6c
Change-Id: I351660a275f1d837c6c07f269580dbd7e11de0f9
Ting-Yuan Huang [Tue, 9 May 2017 22:57:40 +0000 (15:57 -0700)]
Suppress false compiler warnings
In theory, static analyzer can't be 100% acurate for certain types of
analysis.
Bug:
38178471
Test: Built without seeing these warnings.
Change-Id: I63d2d02565cc040189ed70813eb42e06dd8c9f2a
Jakub Pawlowski [Tue, 6 Jun 2017 22:11:30 +0000 (15:11 -0700)]
Linux build fix
Change-Id: I2850577447a605877a8bc12f5ad852cacf4e0b3e
Jakub Pawlowski [Tue, 6 Jun 2017 21:53:40 +0000 (21:53 +0000)]
Get rid of BTA_GATTC_API_REFRESH_EVT am:
d7ee6f2e85 am:
96e7c2a740 am:
55418cf457
am:
bb1a19ce4d
Change-Id: Ie9ba9347fa624215ec5a7214527b85f1658524c0
Jakub Pawlowski [Tue, 6 Jun 2017 21:53:24 +0000 (21:53 +0000)]
Get rid of trivial BTA_GATTC_ events am:
31a6bf4f11 am:
195f8c2599 am:
8984cf457f
am:
155ae3d0de
Change-Id: I60130937330d0aace504f42eb7effe91f7dd2a07
Jakub Pawlowski [Tue, 6 Jun 2017 21:40:14 +0000 (21:40 +0000)]
Get rid of BTA_GATTC_API_REFRESH_EVT am:
d7ee6f2e85 am:
96e7c2a740
am:
55418cf457
Change-Id: I0173cb0f311c54618b60f67ca5033fde5debbb8c
Jakub Pawlowski [Tue, 6 Jun 2017 21:39:58 +0000 (21:39 +0000)]
Get rid of trivial BTA_GATTC_ events am:
31a6bf4f11 am:
195f8c2599
am:
8984cf457f
Change-Id: I160733d1e62357d9785c3c7f31b1a3c962ef51ad
Jakub Pawlowski [Tue, 6 Jun 2017 21:26:09 +0000 (21:26 +0000)]
Get rid of BTA_GATTC_API_REFRESH_EVT am:
d7ee6f2e85
am:
96e7c2a740
Change-Id: I32957ad7b296c7b5d64d38698bc7edef48f2a6c5
Jakub Pawlowski [Tue, 6 Jun 2017 21:25:53 +0000 (21:25 +0000)]
Get rid of trivial BTA_GATTC_ events am:
31a6bf4f11
am:
195f8c2599
Change-Id: Ice81eee5f60a28b960dd2139d79c998bc84f43e9
Jakub Pawlowski [Tue, 6 Jun 2017 21:20:58 +0000 (21:20 +0000)]
Get rid of BTA_GATTC_API_REFRESH_EVT
am:
d7ee6f2e85
Change-Id: Ic9f253ab5489d133698cae3f243ccda7d78d1c62
Jakub Pawlowski [Tue, 6 Jun 2017 21:20:43 +0000 (21:20 +0000)]
Get rid of trivial BTA_GATTC_ events
am:
31a6bf4f11
Change-Id: Id25b40895fae8722534e830f06532b62aac44d7b
Jakub Pawlowski [Mon, 5 Jun 2017 19:42:45 +0000 (12:42 -0700)]
Get rid of BTA_GATTC_API_REFRESH_EVT
Test: compilation test
Change-Id: I631962183ac63d2b168005060bb1f0d4964b0884
Jakub Pawlowski [Mon, 5 Jun 2017 19:20:04 +0000 (12:20 -0700)]
Get rid of trivial BTA_GATTC_ events
Test: compilation test
Change-Id: I8c705d1bb0532cbe0dd69b1f3b0b5d1a63534a23
Jakub Pawlowski [Tue, 6 Jun 2017 20:57:27 +0000 (20:57 +0000)]
Initial DBus transport support am:
79c2ff968f am:
0c00f5664a am:
43ffbbe81f
am:
51393cd234
Change-Id: I73b7d89ffc568ad0e26dbe40be792b17631246f6
Jakub Pawlowski [Tue, 6 Jun 2017 20:57:14 +0000 (20:57 +0000)]
Fix order of parameters to BTA_GATTC_Open am:
11410a31b1
am:
8ebf607111
Change-Id: I4dc35b81cc939eeb7a9abc5d3f9b19751dfcb5bc
Jakub Pawlowski [Tue, 6 Jun 2017 20:55:46 +0000 (20:55 +0000)]
Initial DBus transport support am:
79c2ff968f am:
0c00f5664a
am:
43ffbbe81f
Change-Id: Id6150d77ca20f17ba6af59ef09b8efc8982f3250
Jakub Pawlowski [Tue, 6 Jun 2017 20:55:19 +0000 (20:55 +0000)]
Fix order of parameters to BTA_GATTC_Open
am:
11410a31b1
Change-Id: Id66d9c2503bc391911a09884d77a4fc4ea0f0bb2
Jakub Pawlowski [Tue, 6 Jun 2017 20:53:19 +0000 (20:53 +0000)]
Initial DBus transport support am:
79c2ff968f
am:
0c00f5664a
Change-Id: Icb9097f15cb87a5e864ad38fd2285161f57ae65d
Jakub Pawlowski [Tue, 6 Jun 2017 20:51:19 +0000 (20:51 +0000)]
Initial DBus transport support
am:
79c2ff968f
Change-Id: If2e1458120b318d983acbc50cf5f9653e17f03f5
Jakub Pawlowski [Mon, 31 Oct 2016 19:56:12 +0000 (12:56 -0700)]
Initial DBus transport support
This patch adds initial support for DBus transport on Linux. It exposes
initial implementation of Adapter that can be Enabled and Disabled. One
can also introspect the interface to find the exposed methods. Further
patches will extend it's functionality.
Test: ninja -C out/Default -j 40
Change-Id: I173cc752b8d8aaa8706ed36f75f5a043cc987b1a
Jakub Pawlowski [Tue, 6 Jun 2017 00:28:48 +0000 (00:28 +0000)]
Fix order of parameters to BTA_GATTC_Open am:
47474c3e58 am:
73275ae076 am:
3923f52175
am:
66570f8572
Change-Id: If261005ccd39e204abf1d0b2849afd44a2e4dec8
Jakub Pawlowski [Tue, 6 Jun 2017 00:16:50 +0000 (00:16 +0000)]
Fix order of parameters to BTA_GATTC_Open am:
47474c3e58 am:
73275ae076
am:
3923f52175
Change-Id: Id7001fa6be73111e26a29cef7acb8f2230a95806
Jakub Pawlowski [Tue, 6 Jun 2017 00:11:50 +0000 (00:11 +0000)]
Fix order of parameters to BTA_GATTC_Open am:
47474c3e58
am:
73275ae076
Change-Id: Iad0473d3cd1c6ef355c410b2fb50578856d24116
Jakub Pawlowski [Tue, 6 Jun 2017 00:06:50 +0000 (00:06 +0000)]
Fix order of parameters to BTA_GATTC_Open
am:
47474c3e58
Change-Id: I4a305269942e19b5a33521f3071cf24253db81c4
Jakub Pawlowski [Sat, 3 Jun 2017 23:39:04 +0000 (16:39 -0700)]
Fix order of parameters to BTA_GATTC_Open
Different order of parameters in different flavours of method caused
bug in btif_gatt_client.cc, where every client would be started as
opportunistic. This issue was introduced in commit
16bb48b320cde54a1a06a525f4d9be1421689649
Bug:
34951749
Test: sl4a GattReadTest was flaky without this patch
Change-Id: I243b11bd8e2c0da9f01cbd3eab95dc808bd54006
Jakub Pawlowski [Sat, 3 Jun 2017 23:39:04 +0000 (16:39 -0700)]
Fix order of parameters to BTA_GATTC_Open
Different order of parameters in different flavours of method caused
bug in btif_gatt_client.cc, where every client would be started as
opportunistic. This issue was introduced in commit
16bb48b320cde54a1a06a525f4d9be1421689649
Bug:
34951749
Test: sl4a GattReadTest was flaky without this patch
Change-Id: I243b11bd8e2c0da9f01cbd3eab95dc808bd54006
Jakub Pawlowski [Sat, 3 Jun 2017 02:43:19 +0000 (02:43 +0000)]
Pass GATT cb's by reference and other style fixes am:
f4c0292c63 am:
f5de435643 am:
75c8ce2a50
am:
1e76bd7e38
Change-Id: I6fc85537118159e1c8592baa14c08ba940ac3527
Jakub Pawlowski [Sat, 3 Jun 2017 02:43:16 +0000 (02:43 +0000)]
Use std::queue for pending_enc_clcb am:
eb3ab848f8 am:
8db401f92d am:
8395ce7081
am:
0d810425bf
Change-Id: I3d372d48ddc10d323b0b4de9a6aec458bbb996ff
Jakub Pawlowski [Sat, 3 Jun 2017 02:39:34 +0000 (02:39 +0000)]
Pass GATT cb's by reference and other style fixes am:
f4c0292c63 am:
f5de435643
am:
75c8ce2a50
Change-Id: Ia56eab5e39f6c374d4f6cc3263cab4083ac557f4