OSDN Git Service
Tony Wickham [Thu, 12 Nov 2015 23:46:33 +0000 (23:46 +0000)]
Revert "Reverting folder cell width on portrait phones."
This reverts commit
b25e684a766362422f5693f7a2189910c1275584.
Change-Id: Ie86adc4b35c73ab7ef78d73225b437adc4751172
Tony Wickham [Thu, 12 Nov 2015 21:12:06 +0000 (13:12 -0800)]
Reverting folder cell width on portrait phones.
The extra folder cell space added in ag/790800 looks bad on phones in
portrait mode, so reverting it here. However, we keep the extra space
on tablets or phones in landscape mode, since it provides more room
for long app names (bug
22462641).
Bug:
25662215
Change-Id: I2a37b884458ee557c9b8cff0c3edef16bfc50efb
Tony Wickham [Wed, 11 Nov 2015 17:16:14 +0000 (17:16 +0000)]
Merge "Handle more cases in FocusHelper#handleHotseatButtonKeyEvent()." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 11 Nov 2015 00:52:14 +0000 (16:52 -0800)]
Handle more cases in FocusHelper#handleHotseatButtonKeyEvent().
The first of these cases seems like they should already have been
present, and the last couple allow you to switch pages by hitting
arrow keys on the edges of the hotseat.
Bug:
25589939
Change-Id: I9378b209250f7dc376fa97efde979bcee2979537
Tony Wickham [Tue, 10 Nov 2015 22:44:32 +0000 (14:44 -0800)]
Don't add offset to CellLayout's fullscreen children.
Bug:
25411084
Change-Id: Ifbcd0a53cf04a7fc29386f4f09aaf7f972e7354a
Tony Wickham [Sat, 7 Nov 2015 01:08:57 +0000 (17:08 -0800)]
Added unit tests for b/
25434120 regression.
Change-Id: I55b10274c4bb63ec6fd3138236e78a04e3eac91a
Tony Wickham [Fri, 6 Nov 2015 18:10:05 +0000 (18:10 +0000)]
Merge "Make sure user can always get to next page with keyboard." into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 6 Nov 2015 18:08:44 +0000 (18:08 +0000)]
Merge "Stop explicitly snapping to page when navigating with keyboard." into ub-launcher3-burnaby-polish
Tony Wickham [Thu, 5 Nov 2015 20:14:26 +0000 (12:14 -0800)]
Make sure user can always get to next page with keyboard.
There's a case where hitting the left/right arrow in the first/last
column wouldn't give focus to an icon on the next page because it is
vertically too far from the first icon to be considered. This makes
for a bad user experience, because there is no way to switch pages
with the keyboard. So now we brute-force search for an appropriate
icon if none was found in this case.
Bug:
25434120
Change-Id: Ifdead0e3b458717ccb33e2f0ec7c15f1fcce4b95
Sunny Goyal [Thu, 5 Nov 2015 10:39:57 +0000 (16:09 +0530)]
Ignoring DeadObjectException in startListening
> As of android M, the platform somtimes throws DeadObjectException
instead of TransactionTooLargeException
Bug:
25305031
Change-Id: I3a98db8a5041aef01640d16f9beb71b72bf598f1
Tony Wickham [Thu, 5 Nov 2015 01:44:32 +0000 (17:44 -0800)]
Stop explicitly snapping to page when navigating with keyboard.
When an icon grabs focus, it already snaps to its own page, so
the explicit snapToPage() is redundant. And in the case where no icon
will grab the focus, the explicit call puts us in a weird state
because the page snaps but the focus doesn't change (see bug).
(This happens, for instance, if you are moving from an icon on the
bottom right of page 1 and the only icon on page 2 is in the top
left. In this case, the second icon won't take focus because the
angle is too wide according to FocusLogic#handleDpadHorizontal().)
Bug:
25434120
Change-Id: I17b0ef7d86426a2599bc948bf2313dca7e112364
Tony Wickham [Sat, 31 Oct 2015 01:04:48 +0000 (18:04 -0700)]
Stop clearing focus when snapping to a new workspace page.
Clearing the focus was causing the first child in the new page to
immediately take focus, which caused FocusIndicatorView jank when
using a keyboard.
Bug:
25256728
Change-Id: I5ab31ebc3fe370d7ac9e9792b30dab3467023738
Tony Wickham [Fri, 30 Oct 2015 16:52:22 +0000 (09:52 -0700)]
Set parallax offset to be 0.5f for default wallpapers.
This ensures they are centered as they were without any offset.
Bug:
25347076
Change-Id: Id773cd89463d47b350e60878c00e1112e0244414
Tony Wickham [Fri, 23 Oct 2015 18:43:47 +0000 (11:43 -0700)]
Setting correct height for search bar widget options bundle.
- Seperate search bar height from its top and bottom paddings
- Report this height plus 8dps top and bottom for the widget options
- Use a separate bottom padding to adjust spacing between QSB and
the workspace
- Add tests to verify the height of the search bar in both normal and
tall modes (ran on Nexus 6, 7, and 10)
Change-Id: Ia7557785d1b38194eee869d0460456e8f33447d5
Winson Chung [Wed, 28 Oct 2015 22:35:00 +0000 (22:35 +0000)]
Merge "Disabling the desaturation of fast scroll items." into ub-launcher3-burnaby-polish
Winson [Wed, 28 Oct 2015 22:30:38 +0000 (15:30 -0700)]
Disabling the desaturation of fast scroll items.
Change-Id: I7e90e3b35dc6473ba5e2319abcea5c0c76cbd708
Tony Wickham [Tue, 27 Oct 2015 01:02:26 +0000 (01:02 +0000)]
Merge "Add null check in Launcher onNewIntent() before moveToDefaultScreen()." into ub-launcher3-burnaby-polish
Sunny Goyal [Mon, 26 Oct 2015 17:42:12 +0000 (10:42 -0700)]
Fixing null check when calling mutateOnMainThread
Bug:
25269169
Change-Id: I74f7fb833a374f59a16487099f1bf72b086e88ee
Tony [Mon, 26 Oct 2015 00:39:37 +0000 (17:39 -0700)]
Add null check in Launcher onNewIntent() before moveToDefaultScreen().
There is a race condition that occurs primarily (maybe entirely) with
Android Auto, it seems because they hijack the Home intent or something
similar. I'm not exactly sure how Android Auto works, but if I pair my
phone with the Desktop Head Unit (car dashboard emulator), I can repro
the NPE fairly easily by simply force closing Android Auto and then
disconnecting my phone from the DHU. If I don't force close Android
Auto, then pressing home launches Android Auto or other apps that I
assume handle some custom intent, such as Car Home Ultra, instead of
normal Home intents such as Launcher3/Google Now Launcher. So I think
what's happening is that, when the phone is disconnected from the car,
Android Auto restores and launches the real home intent (Launcher 3)
around the same time that it destroys the previous home intent
(Android Auto, Car Home Ultra, etc.). This could cause the NPE if both
intents are actually Launcher 3, as is the case when Android Auto is
already closed, because mWorkspace is set to null in
Launcher#onDestroy() (something like onNewIntent() --> post() called
--> onDestroy() --> post() runs). This is consistent with the fact
that I can guarantee a repro if I use postDelayed() instead of post().
Long-winded explanation aside, I think this fix is safe, especially
since we already have a null check for mWorkspace in onNewIntent(),
just not inside the post().
Bug:
24610231
Change-Id: I42f75b83946f375d947be1961a1f2a03a3707a84
Tony Wickham [Fri, 23 Oct 2015 18:38:46 +0000 (18:38 +0000)]
Merge "Set search bar height before setting up views in Launcher." into ub-launcher3-burnaby-polish
Tony Wickham [Thu, 22 Oct 2015 00:50:22 +0000 (17:50 -0700)]
Don't add cells to FocusLogic sparse matrix if they aren't focusable.
Previously, any child of ShortcutAndWidgetContainer was added to the
matrix, causing widgets (which aren't focusable) to be considered as
potential targets to gain focus when an arrow key was pressed. But if
the algorithm chose them, they couldn't take the focus so nothing
happened (i.e. the focus stayed on the app/folder it was on before).
Bug:
25126768
Change-Id: Id55fc310f7f58fb8795cce51dcefe4fd1210f788
Tony Wickham [Wed, 21 Oct 2015 21:21:14 +0000 (21:21 +0000)]
Merge "Hide the "Set Wallpaper" action bar when clicked." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 21 Oct 2015 20:56:59 +0000 (13:56 -0700)]
Hide the "Set Wallpaper" action bar when clicked.
This already happens everywhere except for the case where an external
app such as Photos started the wallpaper picker. So not only is this
more consistent, it also prevents crashes and other potential issues
caused by clicking "Set Wallpaper" too many times.
Bug:
25026717
Change-Id: I63c6a0ce68656e6e68094e88074a836d8c1034f9
Sunny Goyal [Tue, 13 Oct 2015 17:19:01 +0000 (10:19 -0700)]
Do not animate folder when it is closed while changing activity state
Bug:
21733536
Change-Id: I36aa3041b9300c917e320b511e00a1721e44f854
Tony Wickham [Tue, 20 Oct 2015 20:24:36 +0000 (13:24 -0700)]
Set search bar height before setting up views in Launcher.
This ensures that the QSB widget options are set correctly the first
time they are used.
Bug:
24704753
Change-Id: I2bb13ff012b6f13ca076deed61f0b08a7037e2fa
Geoff Mendal [Wed, 21 Oct 2015 15:54:05 +0000 (15:54 +0000)]
Import translations. DO NOT MERGE
am:
6ce85953ac -s ours
* commit '
6ce85953acf0399965c6c8a75f5e6eea5a643678':
Import translations. DO NOT MERGE
Geoff Mendal [Wed, 21 Oct 2015 15:03:43 +0000 (08:03 -0700)]
Import translations. DO NOT MERGE
Change-Id: I4f645e8f071559ad56ee7963934f1039b06d6e96
Auto-generated-cl: translation import
Geoff Mendal [Wed, 21 Oct 2015 15:02:37 +0000 (08:02 -0700)]
Import translations. DO NOT MERGE
Change-Id: I1cea6130293678ef0d5da961d11428f14e62ee25
Auto-generated-cl: translation import
Sunny Goyal [Wed, 21 Oct 2015 00:18:25 +0000 (00:18 +0000)]
Merge "Fixing disabled icon getting changed back to normal state on long press" into ub-launcher3-burnaby-polish
Tony Wickham [Tue, 20 Oct 2015 23:24:53 +0000 (16:24 -0700)]
Fix regression where keyboard couldn't switch between workspace pages.
Bug:
25122302
Change-Id: Id1d7628753ce7ef37af50e8594e541dcb6bea13e
Sunny Goyal [Tue, 20 Oct 2015 22:17:00 +0000 (15:17 -0700)]
Fixing disabled icon getting changed back to normal state on long press
Change-Id: I4f35c1cbecfef7891f8b1187ba3be0af695d4fd5
Sunny Goyal [Tue, 20 Oct 2015 18:05:22 +0000 (18:05 +0000)]
Fixing ConcurrentModificationException in tests
am:
ec7c9178dd
* commit '
ec7c9178dd1f17cf8479acd4e0b4575a91cfb255':
Fixing ConcurrentModificationException in tests
Sunny Goyal [Tue, 20 Oct 2015 17:31:09 +0000 (10:31 -0700)]
Fixing ConcurrentModificationException in tests
Change-Id: I7aabc62aa249dae979366ce2871604f5822f3139
Sunny Goyal [Tue, 20 Oct 2015 17:17:08 +0000 (17:17 +0000)]
Merge "Refactoring getPreferenceKey method" into ub-launcher3-burnaby-polish
Sunny Goyal [Mon, 19 Oct 2015 23:59:07 +0000 (16:59 -0700)]
Refactoring getPreferenceKey method
This method was returnning a constant and getting inlined by proguard.
Change-Id: I87348e25b21483adc1b27d16f99dec4b73205701
Sunny Goyal [Tue, 20 Oct 2015 00:32:10 +0000 (17:32 -0700)]
Using UiSelector instead of BySelector
Change-Id: Ie912cc7291a2533f6686bdb34e108be15ce244ac
Geoff Mendal [Mon, 19 Oct 2015 16:25:53 +0000 (16:25 +0000)]
Import translations. DO NOT MERGE
am:
f58538672a -s ours
* commit '
f58538672aaeb1d0d00a9c65a773f5e251003c3b':
Import translations. DO NOT MERGE
Geoff Mendal [Mon, 19 Oct 2015 15:50:56 +0000 (08:50 -0700)]
Import translations. DO NOT MERGE
Change-Id: If930ef94a3abe3e27123d1fe3553b0a3a453ffec
Auto-generated-cl: translation import
Geoff Mendal [Mon, 19 Oct 2015 15:49:51 +0000 (08:49 -0700)]
Import translations. DO NOT MERGE
Change-Id: Iee53921c75c785c7d73dd375b4e044761a5a7246
Auto-generated-cl: translation import
Sunny Goyal [Sat, 17 Oct 2015 00:49:33 +0000 (00:49 +0000)]
Merge "Adding tests for rotation preference Updating the gradle file to run tests directly from AndroidStudio" into ub-launcher3-burnaby-polish
Sunny Goyal [Sat, 17 Oct 2015 00:18:54 +0000 (17:18 -0700)]
Adding tests for rotation preference
Updating the gradle file to run tests directly from AndroidStudio
Change-Id: Iac23dfc6f995477f2406071fbfab3a16ee58ce6f
Winson Chung [Fri, 16 Oct 2015 22:20:14 +0000 (22:20 +0000)]
Merge "Fix issue with source params not reporting predicted apps." into ub-launcher3-burnaby-polish
Winson [Fri, 16 Oct 2015 21:57:24 +0000 (14:57 -0700)]
Fix issue with source params not reporting predicted apps.
Bug:
25020080
Change-Id: Iaa67ccbb3e3a6c264aaa4fa3c915faad8a69bbbc
Tony Wickham [Fri, 16 Oct 2015 20:40:34 +0000 (20:40 +0000)]
Add LauncherCallbacks method to add additional search widget options.
am:
775455c4a8
* commit '
775455c4a8266655bf43b943e969d42ac32609ec':
Add LauncherCallbacks method to add additional search widget options.
Sunny Goyal [Fri, 16 Oct 2015 18:32:43 +0000 (18:32 +0000)]
Merge "Preventing activity to restart when keyboard is connected or keyboard type changes" into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 16 Oct 2015 16:49:32 +0000 (09:49 -0700)]
Add LauncherCallbacks method to add additional search widget options.
Bug:
25000458
Change-Id: I5e8d48617568569bc6e4f284749c3ed9fb20a68f
Tony Wickham [Fri, 16 Oct 2015 17:12:23 +0000 (10:12 -0700)]
Close some Cursors and call super.onFinishInflate().
Android Studio gave these warnings, and they seem like good ideas.
Change-Id: I9a4d3997fd18e86e007e4511e1ac9e8a75509265
Tony Wickham [Thu, 15 Oct 2015 18:00:59 +0000 (18:00 +0000)]
Merge "Fix "The specified child already has a parent" IllegalStateException." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 14 Oct 2015 22:23:04 +0000 (15:23 -0700)]
Fix "The specified child already has a parent" IllegalStateException.
The problem was due to a race condition between removing a prebound
widget view from the drag layer and adding the same view to the
workspace upon dropping it; if you let go of the widget immediately
after picking it up, the latter happened before the former.
Specifically, the flow was: long-click a widget --> drop --> remove
the view from the drag layer if it's not null (it is, so nothing
happens) --> the view is finally bound/inflated and added to the drag
layer --> add the view to the workspace --> already has a parent.
There are actually 2 problems here: one is that the bind/inflate is
asynchronous, and can therefore happen after dropping the widget view
being inflated, and the other is that the view is added to the
workspace even though the transition has barely started (we usually
ignore drops if the transition is less than half complete). It turns
out that this second problem was also due to a race condition, this
time between dropping a widget or app onto the workspace and calling
LauncherStateTransitionAnimation.dispatchOnLauncherTransitionStart().
If the drop happened before the dispatch, as in the case of the
crash, then the drop was accepted because the transition progress was
still 1.0 from the previous transition.
I fixed the first problem by removing the drag layer widget view
in Launcher where it is potentially used instead of Workspace. And I
fixed the second problem by setting mTransitionProgress to 0 in
Workspace.onLauncherTransitionPrepare().
I also added some debugging logs.
Bug:
23896857
Change-Id: I66944e6d3f23b70dea15f7fb01af0763a1bfcbda
Sunny Goyal [Wed, 14 Oct 2015 19:16:24 +0000 (19:16 +0000)]
am
28c6b963: Showing a permission prompt for direct call shortcuts
* commit '
28c6b963d4ccac73ab857c839420513dd560945c':
Showing a permission prompt for direct call shortcuts
Sunny Goyal [Wed, 14 Oct 2015 18:53:04 +0000 (11:53 -0700)]
Preventing activity to restart when keyboard is connected or keyboard type changes
Bug:
20820889
Change-Id: Ib0b21c04290607ddd67cef2003e6d89f5d6492d8
Winson [Tue, 13 Oct 2015 17:47:51 +0000 (10:47 -0700)]
Fixing issue with overview panel buttons.
Bug:
22699895
Change-Id: I8a2f05a6008343327e34cbd3169e4056729e0b75
Tony Wickham [Mon, 12 Oct 2015 22:57:23 +0000 (15:57 -0700)]
Increase folder cell width slightly.
The increased breathing room makes it more likely that long app names
will fit in the folder cells without being cut off.
Bug:
22462641
Change-Id: I110ede040f9e8fdddbf0c4e7a395ac71435559f3
Sunny Goyal [Mon, 12 Oct 2015 18:42:05 +0000 (11:42 -0700)]
Showing a permission prompt for direct call shortcuts
Bug:
24580949
Change-Id: Idc92f9f5979a730f43b4905af2bc47b6834dc7a7
Geoff Mendal [Mon, 12 Oct 2015 14:00:09 +0000 (07:00 -0700)]
Import translations. DO NOT MERGE
Change-Id: I30deecd0fedace5365a877a8333206e7cb015afb
Auto-generated-cl: translation import
Tony Wickham [Fri, 9 Oct 2015 22:37:02 +0000 (22:37 +0000)]
Merge "Actually call LauncherTransitionable.onLauncherTransitionStep()." into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 9 Oct 2015 01:40:31 +0000 (01:40 +0000)]
am
37860923: Merge "Added launcher callback to specify search bar height." into ub-launcher3-burnaby
* commit '
37860923619b1e467975a74764dff03ab657bdc7':
Added launcher callback to specify search bar height.
Tony Wickham [Fri, 9 Oct 2015 01:37:39 +0000 (01:37 +0000)]
Merge "Added launcher callback to specify search bar height." into ub-launcher3-burnaby
Tony Wickham [Fri, 9 Oct 2015 00:38:29 +0000 (00:38 +0000)]
am
d6b4037b: Grid adjustments, specifically for Ryu.
* commit '
d6b4037b093445fefa7d036da339dd549fae7a9b':
Grid adjustments, specifically for Ryu.
Tony Wickham [Wed, 23 Sep 2015 21:55:17 +0000 (14:55 -0700)]
Added launcher callback to specify search bar height.
The search bar can now be be normal or tall. When it is set to tall,
the hotseat and page indicators move down so that the workspace isn't
compressed quite as much.
Change-Id: Id92a946eab3a93524999f92efd847a501a95f002
Sunny Goyal [Fri, 25 Sep 2015 19:55:01 +0000 (12:55 -0700)]
Verify that the widget id is valid, before binding the widget
Bug:
23820213
Bug:
24054205
Bug:
24582322
Change-Id: I25a09b0a2a706812a7d82729b5dc554ffba84a2a
Sunny Goyal [Thu, 8 Oct 2015 20:59:19 +0000 (20:59 +0000)]
Merge "Null check in PackageInstallerCompat" into ub-launcher3-burnaby-polish
Sunny Goyal [Thu, 8 Oct 2015 20:57:51 +0000 (20:57 +0000)]
Merge "Update the widget spans after the provider changes" into ub-launcher3-burnaby-polish
Sunny Goyal [Thu, 8 Oct 2015 20:56:37 +0000 (13:56 -0700)]
Null check in PackageInstallerCompat
Bug:
24582224
Change-Id: I2cd4ca12d48b3316a8a519092118d9e2970d944d
Tony Wickham [Thu, 24 Sep 2015 01:37:57 +0000 (18:37 -0700)]
Grid adjustments, specifically for Ryu.
> Less than 14% of the screen is used for left/right workspace padding.
(To be clear, this means 7% for the left and 7% for the right.)
> Hotseat icons are the same size as workspace icons.
> Far left and right hotseat edges line up with workspace edges.
> All Apps button is scaled down 8dp.
Bug:
24003478
Change-Id: Idb057ab0f6ba29e7fd93feac7573ca2e07c7e839
Sunny Goyal [Thu, 8 Oct 2015 14:41:15 +0000 (07:41 -0700)]
Using 23 instead of Build.Versoin.M until the final SDK is available.
Change-Id: I9f8f6fe049afcd0ceb0797ddc803a2e77bab0437
Sunny Goyal [Fri, 26 Jun 2015 02:35:49 +0000 (19:35 -0700)]
Moving a few testing classes to a separate package
Change-Id: Ied1c063de3e938695493e4937f554686e0719dad
Sunny Goyal [Wed, 7 Oct 2015 17:22:44 +0000 (17:22 +0000)]
Merge "Fixing overscroll effect when the navigation bar is opaque" into ub-launcher3-burnaby-polish
Geoff Mendal [Wed, 7 Oct 2015 14:19:53 +0000 (07:19 -0700)]
Import translations. DO NOT MERGE
Change-Id: Ibbe258e46dd396e9186a47b3881796e12f689e33
Auto-generated-cl: translation import
Sunny Goyal [Wed, 23 Sep 2015 18:40:53 +0000 (11:40 -0700)]
Verifying that the table was successfully created during initialzation
Table creation sometimes fails scilently, which leads to a crash loop.
This way, we will try to create a table every time after crash, so
the device would eventually be able to recover.
Bug:
24263894
Change-Id: Ic0169d33f4092042423afa24320182786c544d47
Geoff Mendal [Tue, 6 Oct 2015 21:15:30 +0000 (21:15 +0000)]
am
53d3be63: (-s ours) Import translations. DO NOT MERGE
* commit '
53d3be63a5ab056280279bcb13089faae0e7796f':
Import translations. DO NOT MERGE
Geoff Mendal [Tue, 6 Oct 2015 21:06:53 +0000 (14:06 -0700)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
22482938
Change-Id: I758693c47b7d200da62bc1e9df4d0faaf9b147f2
Tony Wickham [Tue, 6 Oct 2015 20:53:46 +0000 (20:53 +0000)]
am
3a3517fb: Add widget size options for QSB.
* commit '
3a3517fb6c17120c6d11e5c95a0de4e81205d0ae':
Add widget size options for QSB.
Tony Wickham [Tue, 6 Oct 2015 18:27:04 +0000 (11:27 -0700)]
Add widget size options for QSB.
Bug:
24704753
Change-Id: I3e16c1f67a67b08b3843f7f38312447bdfa6a91e
Tony Wickham [Fri, 2 Oct 2015 23:22:08 +0000 (16:22 -0700)]
Actually call LauncherTransitionable.onLauncherTransitionStep().
Previously, it was only called at the start and end of the transition;
now it is called as the animation interpolates. Specifically, a dummy
ValueAnimator is played alongside the transition animation and calls
dispatchOnLauncherTransitionStep() as it goes.
One place where this is important is in Workspace, where
mTransitionProgress is used to determine things like whether the
workspace should accept a drop - hence the bug that caused apps dragged
from All Apps to vanish when dropped before the transition ended.
Bug:
24215358
Change-Id: I32cd633c53557305caf84e87c9a4d4f07eef2223
Sunny Goyal [Mon, 5 Oct 2015 17:36:54 +0000 (10:36 -0700)]
Update the widget spans after the provider changes
Bug:
24003213
Change-Id: I51ad5919a808ef10385d62a48a94589eefcb06bc
Sunny Goyal [Mon, 5 Oct 2015 18:26:19 +0000 (18:26 +0000)]
Merge "Jailing the saved instance state of all the dynamically generated views" into ub-launcher3-burnaby-polish
Sunny Goyal [Fri, 28 Aug 2015 00:45:46 +0000 (17:45 -0700)]
Jailing the saved instance state of all the dynamically generated views
Using itemId instead of generating a new id for each item. This is because
if the process gets killed, View.generateId will get reset but we will still
receive the generated item id map in onRestoreInstance. This will cause
conflicts with newly generated item ids.
We wrap all the generated homescreen views inside a single sparse array. This
ensures that we do not cause any conflict with dynamically generated views in
other parts of the UI.
Bug:
16840760
Change-Id: I6fe69c2e1dd463402f51222715fae31b9d4dd240
Winson Chung [Mon, 5 Oct 2015 17:58:42 +0000 (17:58 +0000)]
Merge "Fixing regression when removing last item from folder." into ub-launcher3-burnaby-polish
Geoff Mendal [Mon, 5 Oct 2015 14:19:24 +0000 (07:19 -0700)]
Import translations. DO NOT MERGE
Change-Id: Id66043bc65557ef6a886bb1bec6ef18590a7056b
Auto-generated-cl: translation import
Winson [Sat, 3 Oct 2015 00:14:14 +0000 (17:14 -0700)]
Fixing regression when removing last item from folder.
- The regression caused the folder and all its contents to be removed
before the new item could be moved to the place of the folder. In
addition, in this case, the LauncherModel would get out of sync with
the db because we move the last item to the workspace, but don’t
remove it from the contents, so deleting the folder would remove the
item’s mapping in sBgItemIdMap.
Bug:
24620815
Change-Id: I17137f28b0f1617a890488c7a9c5b8a9e8df0e91
Sunny Goyal [Fri, 2 Oct 2015 20:23:05 +0000 (20:23 +0000)]
am
c84e6e19: Disabling widget debug
* commit '
c84e6e19363c590bbfbac17e9ab7cc61a04d552a':
Disabling widget debug
Sunny Goyal [Fri, 2 Oct 2015 19:48:37 +0000 (12:48 -0700)]
Disabling widget debug
Change-Id: I876a904358ce455c97a7a25a34c66af5e9316469
Winson [Fri, 2 Oct 2015 18:25:46 +0000 (11:25 -0700)]
Fixing regression in removing widgets via accessibility.
- Regression was introduced in ag/765323, but not visible in normal
drag and drop because the view is already removed from the parent.
However, when accessibility is enabled, it was only removing it from
the db, but not from the parents.
Change-Id: I37483d0cd6306d270441b11e6f05247d58b88521
Sunny Goyal [Fri, 2 Oct 2015 17:40:35 +0000 (17:40 +0000)]
Merge "Do not reinflate/rebind widgets if we are going the rebind the full workspace anyway." into ub-launcher3-burnaby-polish
Winson [Fri, 2 Oct 2015 17:21:59 +0000 (17:21 +0000)]
am
058c21db: Ensure accessibility delegate is set on all apps icons.
* commit '
058c21db49f4f058b7d84c8de55d3c649918ab70':
Ensure accessibility delegate is set on all apps icons.
Winson [Fri, 2 Oct 2015 17:14:14 +0000 (10:14 -0700)]
Ensure accessibility delegate is set on all apps icons.
Bug:
24605237
Change-Id: I801e2aca1732c021b06d996d907f368f97277cf9
Sunny Goyal [Fri, 2 Oct 2015 02:35:03 +0000 (19:35 -0700)]
Make sure that the dimensions are not negative when drawing pending widget
Bug:
24585203
Change-Id: I3d328d0e1fe81d2704bb5b9d4b340a367bfb9249
Sunny Goyal [Fri, 2 Oct 2015 01:50:48 +0000 (18:50 -0700)]
Do not reinflate/rebind widgets if we are going the rebind the full
workspace anyway.
Bug:
23820213
Bug:
24582781
Change-Id: I2cb4927916fed64a69100beb41ee14653ea1d70a
Winson Chung [Thu, 1 Oct 2015 22:53:15 +0000 (22:53 +0000)]
Merge "Replace Long.compare() with implementation." into ub-launcher3-burnaby-polish
Winson [Thu, 1 Oct 2015 22:34:08 +0000 (15:34 -0700)]
Replace Long.compare() with implementation.
- Long.compare() was added in API level 19.
Change-Id: Ic7020c941403c10daa6feacdc737c6a82676ada0
Winson Chung [Thu, 1 Oct 2015 19:33:58 +0000 (19:33 +0000)]
Merge "Fixing regression in search bar animation." into ub-launcher3-burnaby-polish
Winson [Thu, 1 Oct 2015 19:19:23 +0000 (12:19 -0700)]
Fixing regression in search bar animation.
- The other case should fall through to the animation even
when there is no search bar overlay.
Change-Id: Id91bea78b56934cc1c3379777068adc100f11dba
Sunny Goyal [Thu, 1 Oct 2015 18:36:29 +0000 (18:36 +0000)]
Merge "Adding progress information for preload icons in content description" into ub-launcher3-burnaby-polish
Sunny Goyal [Thu, 1 Oct 2015 18:25:28 +0000 (18:25 +0000)]
Merge "Fixing 'Item removed' announced twice when using accessible DnD" into ub-launcher3-burnaby-polish
Sunny Goyal [Thu, 1 Oct 2015 18:24:23 +0000 (11:24 -0700)]
Adding progress information for preload icons in content description
Bug:
24086091
Change-Id: Id8fb024973f4affd998627d30077e2764b07edc4
Winson Chung [Wed, 30 Sep 2015 23:00:57 +0000 (23:00 +0000)]
Merge "Don’t create dummy app info." into ub-launcher3-burnaby-polish
Winson [Wed, 30 Sep 2015 22:33:00 +0000 (15:33 -0700)]
Don’t create dummy app info.
Bug:
24539514
Change-Id: I5d14a4d9993e072451f8e7ed9a4cea219ae5d246
Geoff Mendal [Wed, 30 Sep 2015 20:04:22 +0000 (20:04 +0000)]
am
91dd0872: (-s ours) Import translations. DO NOT MERGE
* commit '
91dd087271807980638a490fd8072d28a39ada8d':
Import translations. DO NOT MERGE
Geoff Mendal [Wed, 30 Sep 2015 19:08:36 +0000 (14:08 -0500)]
Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Bug:
22482938
Change-Id: Id607b75f77fe89ee801336c8bc3e7d7db3ad59fa