OSDN Git Service

android-x86/frameworks-av.git
7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d am...
Robert Shih [Thu, 25 May 2017 22:16:28 +0000 (22:16 +0000)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d am: afa728e0b7 am: 63f4d38b3e am: 19b6a74a9d  -s ours am: 9b2197958f
am: c50cf9d602

Change-Id: I68b8517da95e6d1761bcd7866bfc31ee4ebb1a78

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d am...
Robert Shih [Thu, 25 May 2017 22:10:55 +0000 (22:10 +0000)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d am: afa728e0b7 am: 63f4d38b3e am: 19b6a74a9d  -s ours
am: 9b2197958f

Change-Id: I145e55761b6c846f1b7a67f81b93f9e9e55e8cdc

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d am...
Robert Shih [Thu, 25 May 2017 22:06:24 +0000 (22:06 +0000)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d am: afa728e0b7 am: 63f4d38b3e
am: 19b6a74a9d  -s ours

Change-Id: Ibc36c2ba098a7ddcf35dcfdc6095786b8bb92925

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d am...
Robert Shih [Thu, 25 May 2017 22:01:55 +0000 (22:01 +0000)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d am: afa728e0b7
am: 63f4d38b3e

Change-Id: I970ff440d2efd77587bbd110f379a9e5ae8a03ca

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d
Robert Shih [Thu, 25 May 2017 21:57:23 +0000 (21:57 +0000)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: ebeb47000d
am: afa728e0b7

Change-Id: I8e5afcf1bb874447737d1a7c7c45ecd4e54dacd1

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor
Robert Shih [Thu, 25 May 2017 21:52:55 +0000 (21:52 +0000)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor
am: ebeb47000d

Change-Id: I1ae0603aa9b798bd6c624d96c18ef6457212bfa7

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: 6301f88251
Robert Shih [Thu, 25 May 2017 21:17:55 +0000 (21:17 +0000)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor am: 6301f88251
am: 188e7dbd05

Change-Id: If13260b623df38c7ba99becca87025e985d23c5c

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor
Robert Shih [Thu, 25 May 2017 21:12:52 +0000 (21:12 +0000)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor
am: 6301f88251

Change-Id: I1f9e4a9fbbd0c17b19151cdec2c2b2b7f9cf2392

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor
Robert Shih [Tue, 23 May 2017 00:32:29 +0000 (17:32 -0700)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor

Bug: 37622974
Bug: 37622987
Bug: 37623757
Test: run poc and observe no crash
Change-Id: I1e25c011f02bec26a1480ec9a217a52f15d43cf2

7 years agoDO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor
Robert Shih [Tue, 23 May 2017 00:32:29 +0000 (17:32 -0700)]
DO NOT MERGE Don't leak `this` out of GraphicBufferSource ctor

Bug: 37622974
Bug: 37622987
Bug: 37623757
Test: run poc and observe no crash
Change-Id: I1e25c011f02bec26a1480ec9a217a52f15d43cf2

7 years agoMerge "Modifying MetaData invalidates previous char*" into nyc-dev am: eb36bac938
Marco Nelissen [Tue, 16 May 2017 19:46:12 +0000 (19:46 +0000)]
Merge "Modifying MetaData invalidates previous char*" into nyc-dev am: eb36bac938
am: 670ba92946

Change-Id: I2890cde112e1b3bd910094774764a658079fb4e9

7 years agoMerge "Modifying MetaData invalidates previous char*" into nyc-dev
Marco Nelissen [Tue, 16 May 2017 19:42:43 +0000 (19:42 +0000)]
Merge "Modifying MetaData invalidates previous char*" into nyc-dev
am: eb36bac938

Change-Id: I1a401b30afed8fccdf48c9b41ae414f7410520a9

7 years agoMerge "Modifying MetaData invalidates previous char*" into nyc-dev
Marco Nelissen [Tue, 16 May 2017 19:37:16 +0000 (19:37 +0000)]
Merge "Modifying MetaData invalidates previous char*" into nyc-dev

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 16:03:30 +0000 (16:03 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408 am: a2fbd251ca am: 4bd7103388 am: dd2f7e982f am: 00be42f32c am: e4b59cb256 am: 15f2244696 am: 6721b0295f am: 7c3b47540e
am: 0967b342f4

Change-Id: I9a41425bbfbb6c71fd2dd91e9d4b9b6abed024b4

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 16:00:03 +0000 (16:00 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408 am: a2fbd251ca am: 4bd7103388 am: dd2f7e982f am: 00be42f32c am: e4b59cb256 am: 15f2244696 am: 6721b0295f
am: 7c3b47540e

Change-Id: I7af91e2469b5e7e3b7a2d4f0e65cb9620bfe037c

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 15:56:30 +0000 (15:56 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408 am: a2fbd251ca am: 4bd7103388 am: dd2f7e982f am: 00be42f32c am: e4b59cb256 am: 15f2244696
am: 6721b0295f

Change-Id: I56cc783d993f01ee26df858151d1ee649ee62c51

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 15:53:29 +0000 (15:53 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408 am: a2fbd251ca am: 4bd7103388 am: dd2f7e982f am: 00be42f32c am: e4b59cb256
am: 15f2244696

Change-Id: I220aa6cbd2de6ac74a409d6be5aa62c331931929

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 15:49:58 +0000 (15:49 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408 am: a2fbd251ca am: 4bd7103388 am: dd2f7e982f am: 00be42f32c
am: e4b59cb256

Change-Id: I89844419918d671a11696909cf530185ab452822

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 15:46:30 +0000 (15:46 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408 am: a2fbd251ca am: 4bd7103388 am: dd2f7e982f
am: 00be42f32c

Change-Id: I651a449830219d0e7513417246d0d269cf44fe88

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 15:42:58 +0000 (15:42 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408 am: a2fbd251ca am: 4bd7103388
am: dd2f7e982f

Change-Id: I4cdcb7694baea6c10980860880c4bdcf41905a8f

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 15:39:56 +0000 (15:39 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408 am: a2fbd251ca
am: 4bd7103388

Change-Id: I159ed2c6b4184689517bf39d791cb516d505e4ed

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6...
Marco Nelissen [Tue, 16 May 2017 15:36:54 +0000 (15:36 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6 am: 55057ab408
am: a2fbd251ca

Change-Id: I8a0e99463feb24350f02d5b5ccdc9419ebb2d71d

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6
Marco Nelissen [Tue, 16 May 2017 15:33:25 +0000 (15:33 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f am: 60657857c6
am: 55057ab408

Change-Id: I5107a57def4be19aad9dca950cca06bebecad1e8

7 years agoMerge "Fix memory leak in error case" into klp-dev am: 5136b7436f
Marco Nelissen [Tue, 16 May 2017 15:30:24 +0000 (15:30 +0000)]
Merge "Fix memory leak in error case" into klp-dev am: 5136b7436f
am: 60657857c6

Change-Id: I1564d4e2626a31b7018bae301c50a268ccc79749

7 years agoMerge "Fix memory leak in error case" into klp-dev
Marco Nelissen [Tue, 16 May 2017 15:27:25 +0000 (15:27 +0000)]
Merge "Fix memory leak in error case" into klp-dev
am: 5136b7436f

Change-Id: I479e015461fa46227c4cae49829b0f3c0d769de9

7 years agoMerge "Fix memory leak in error case" into klp-dev
Marco Nelissen [Tue, 16 May 2017 15:20:59 +0000 (15:20 +0000)]
Merge "Fix memory leak in error case" into klp-dev

7 years agoModifying MetaData invalidates previous char*
Marco Nelissen [Mon, 15 May 2017 22:40:14 +0000 (15:40 -0700)]
Modifying MetaData invalidates previous char*

so don't use those char* after having updated the MetaData

Bug: 36576151
Change-Id: I1430f3151cb929e436fbdac566cf91fc4164b934

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367...
Marco Nelissen [Mon, 15 May 2017 17:20:29 +0000 (17:20 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367 am: 412be4b735 am: 045c64fe94 am: fd7cba4d0e am: 433dacf8db am: 8c805395e5 am: bf913622a7 am: d68e4e45b0
am: 90f3fe5f66

Change-Id: I7bd6c35a924687ca4a6e659dc49754acf01a7f44

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367...
Marco Nelissen [Mon, 15 May 2017 17:17:59 +0000 (17:17 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367 am: 412be4b735 am: 045c64fe94 am: fd7cba4d0e am: 433dacf8db am: 8c805395e5 am: bf913622a7
am: d68e4e45b0

Change-Id: Ia1ca35c6f723696256c4e379b29f2ac64e9e10b4

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367...
Marco Nelissen [Mon, 15 May 2017 17:15:30 +0000 (17:15 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367 am: 412be4b735 am: 045c64fe94 am: fd7cba4d0e am: 433dacf8db am: 8c805395e5
am: bf913622a7

Change-Id: I0306abb9a6a8ffd5bc4351b4af78121fd32a4890

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367...
Marco Nelissen [Mon, 15 May 2017 17:12:25 +0000 (17:12 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367 am: 412be4b735 am: 045c64fe94 am: fd7cba4d0e am: 433dacf8db
am: 8c805395e5

Change-Id: Id4f4b331c2f4fd56a18e032ad1d55983e6b91bc5

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367...
Marco Nelissen [Mon, 15 May 2017 17:09:55 +0000 (17:09 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367 am: 412be4b735 am: 045c64fe94 am: fd7cba4d0e
am: 433dacf8db

Change-Id: Ibffd67ae4a98c0b38c42f68efcb8cc7b401deb0c

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367...
Marco Nelissen [Mon, 15 May 2017 17:07:58 +0000 (17:07 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367 am: 412be4b735 am: 045c64fe94
am: fd7cba4d0e

Change-Id: I0c11db2bb63c110732c925cfc482deee246dc720

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367...
Marco Nelissen [Mon, 15 May 2017 17:04:56 +0000 (17:04 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367 am: 412be4b735
am: 045c64fe94

Change-Id: I02f221f5a4a14706c83ce12c3273df75bd23361f

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367
Marco Nelissen [Mon, 15 May 2017 17:01:55 +0000 (17:01 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89 am: b65b0a8367
am: 412be4b735

Change-Id: I70263d5cb5fca57353337a60686d1468692819cf

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89
Marco Nelissen [Mon, 15 May 2017 16:59:57 +0000 (16:59 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf am: 086cee9d89
am: b65b0a8367

Change-Id: I2faa1a87e934851ee2a4a865e3e3d7084381dac6

7 years agoLimit ogg packet size am: bf928560ac am: f349435fcf
Marco Nelissen [Mon, 15 May 2017 16:56:55 +0000 (16:56 +0000)]
Limit ogg packet size am: bf928560ac am: f349435fcf
am: 086cee9d89

Change-Id: I9687649ed25dade9f872c83a290bbcd0abb4b5fc

7 years agoLimit ogg packet size am: bf928560ac
Marco Nelissen [Mon, 15 May 2017 16:53:54 +0000 (16:53 +0000)]
Limit ogg packet size am: bf928560ac
am: f349435fcf

Change-Id: I952944295017f01b254c80c8db935e33c51337f3

7 years agoLimit ogg packet size
Marco Nelissen [Mon, 15 May 2017 16:50:55 +0000 (16:50 +0000)]
Limit ogg packet size
am: bf928560ac

Change-Id: I102f6e9b1b4933d043b2a3e1e3f7fc885aaf6779

7 years agoLimit ogg packet size
Marco Nelissen [Fri, 12 May 2017 22:35:30 +0000 (15:35 -0700)]
Limit ogg packet size

A malformed ogg file might lace together a very large packet, which
could lead to out of memory conditions. Limit the packet size to
avoid this.

Bug: 36592202
Change-Id: I8650b3ec54a0de9ec302a7cbac296bb85efcfb3d

7 years agoPrevent OOB write in soft_avc encoder am: 463452a949 am: 97db64baf6 am: b6bf46944f...
Ray Essick [Fri, 12 May 2017 17:57:32 +0000 (17:57 +0000)]
Prevent OOB write in soft_avc encoder am: 463452a949 am: 97db64baf6 am: b6bf46944f am: cd35c846f0 am: a43be7d42d
am: 3c375611d6

Change-Id: I2af6025bbfea9927fb37e876b449f93732ddcd33

7 years agoPrevent OOB write in soft_avc encoder am: 463452a949 am: 97db64baf6 am: b6bf46944f...
Ray Essick [Fri, 12 May 2017 17:55:01 +0000 (17:55 +0000)]
Prevent OOB write in soft_avc encoder am: 463452a949 am: 97db64baf6 am: b6bf46944f am: cd35c846f0
am: a43be7d42d

Change-Id: I9cf2d9117293f14f14fc240c674f02594f8944bd

7 years agoPrevent OOB write in soft_avc encoder am: 463452a949 am: 97db64baf6 am: b6bf46944f
Ray Essick [Fri, 12 May 2017 17:52:31 +0000 (17:52 +0000)]
Prevent OOB write in soft_avc encoder am: 463452a949 am: 97db64baf6 am: b6bf46944f
am: cd35c846f0

Change-Id: Id65aa9338a1a362488f33708b4bf5f36d8581104

7 years agoPrevent OOB write in soft_avc encoder am: 463452a949 am: 97db64baf6
Ray Essick [Fri, 12 May 2017 17:50:30 +0000 (17:50 +0000)]
Prevent OOB write in soft_avc encoder am: 463452a949 am: 97db64baf6
am: b6bf46944f

Change-Id: Ib5533f65db8acecfa3b02e13a07815af8901047c

7 years agoPrevent OOB write in soft_avc encoder am: 463452a949
Ray Essick [Fri, 12 May 2017 17:48:28 +0000 (17:48 +0000)]
Prevent OOB write in soft_avc encoder am: 463452a949
am: 97db64baf6

Change-Id: Ia77a7a995dab5a20d1757ab36d0dda680946274b

7 years agoPrevent OOB write in soft_avc encoder
Ray Essick [Fri, 12 May 2017 17:45:57 +0000 (17:45 +0000)]
Prevent OOB write in soft_avc encoder
am: 463452a949

Change-Id: I7cad9d84093cce83b2edf09a55bb8b9a588bee43

7 years agoFix memory leak in error case
Marco Nelissen [Fri, 12 May 2017 17:45:14 +0000 (10:45 -0700)]
Fix memory leak in error case

Bug: 37239013
Change-Id: Ic33e0f7ed946d0729efa46f69aff1a5d35e81b1e

7 years agoPrevent OOB write in soft_avc encoder
Ray Essick [Wed, 10 May 2017 22:38:51 +0000 (15:38 -0700)]
Prevent OOB write in soft_avc encoder

Soft avc encoder cached buffer sizes across a point where the sizes
could be reset by an app, allowing crafted requests to hit outside
of the current buffer. This remedies that by forcing buffer reallocation
with new sizes whenever the encoder state at such 'reset' points.

Bug: 35421151
Test: run POC with no crash
Change-Id: I8c689846142264f7b6a277332260a6bd8a2bd92d

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am...
Roger1 Jonsson [Tue, 11 Apr 2017 17:59:23 +0000 (17:59 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am: 6dfbcefe4b am: 85f575dc67 am: c5bea960dc am: c510b7fb9b am: 2f72b15892 am: 4f383edd27 am: 9d31e50055
am: 2046d33198

Change-Id: I124c627d756728847927c8a764180815a9a5fe42

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am...
Roger1 Jonsson [Tue, 11 Apr 2017 17:54:53 +0000 (17:54 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am: 6dfbcefe4b am: 85f575dc67 am: c5bea960dc am: c510b7fb9b am: 2f72b15892 am: 4f383edd27
am: 9d31e50055

Change-Id: I161ae5bf7df872b7ef5ca116ffd6e84018f73ea3

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am...
Roger1 Jonsson [Tue, 11 Apr 2017 17:50:21 +0000 (17:50 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am: 6dfbcefe4b am: 85f575dc67 am: c5bea960dc am: c510b7fb9b am: 2f72b15892
am: 4f383edd27

Change-Id: Ica34036c7643495fb521b9a6f859d9388f3fd1cd

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am...
Roger1 Jonsson [Tue, 11 Apr 2017 17:45:52 +0000 (17:45 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am: 6dfbcefe4b am: 85f575dc67 am: c5bea960dc am: c510b7fb9b
am: 2f72b15892

Change-Id: I7c0c20fd9da75dcf7dcd68b7b49aaf31b77162ae

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am...
Roger1 Jonsson [Tue, 11 Apr 2017 17:40:50 +0000 (17:40 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am: 6dfbcefe4b am: 85f575dc67 am: c5bea960dc
am: c510b7fb9b

Change-Id: Ia652aac790d73def27c400b1ac327a4ad1ff8ceb

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am...
Roger1 Jonsson [Tue, 11 Apr 2017 17:35:50 +0000 (17:35 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am: 6dfbcefe4b am: 85f575dc67
am: c5bea960dc

Change-Id: I0448adf35221404dbc19c4ed14f2d0252770499e

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am...
Roger1 Jonsson [Tue, 11 Apr 2017 17:32:20 +0000 (17:32 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f am: 6dfbcefe4b
am: 85f575dc67

Change-Id: Ie8f3698b61e3f4d13383eaf1f36788186fdf3676

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f
Roger1 Jonsson [Tue, 11 Apr 2017 17:27:19 +0000 (17:27 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev am: d12204372f
am: 6dfbcefe4b

Change-Id: I2c528d91424183cbc31c6d8a55ec1f35c685315b

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev
Roger1 Jonsson [Tue, 11 Apr 2017 17:22:19 +0000 (17:22 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev
am: d12204372f

Change-Id: Ic2bca43957197cf537760826de60fcb85777cb1b

7 years agoMerge "Avoid crash for stss sync sample number 0" into lmp-dev
TreeHugger Robot [Tue, 11 Apr 2017 17:02:45 +0000 (17:02 +0000)]
Merge "Avoid crash for stss sync sample number 0" into lmp-dev

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 22:01:52 +0000 (22:01 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8 am: 82ffcbd667 am: 9edaa79f62 am: 56c520c4ca am: 12c176066e am: 8671302d0b am: 4a9200308c am: 2d4e2b4975  -s ours am: f919c05b04
am: 5161b33805

Change-Id: Idb2c6b18bb7df8042a0901b82d3a0b4f529fadda

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 22:01:38 +0000 (22:01 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into nyc-dev am: 3294a9fe16
am: b706fb9d69

Change-Id: Ic4de546269b2eb85f79f25900705999a7a5d24e6

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 21:57:25 +0000 (21:57 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8 am: 82ffcbd667 am: 9edaa79f62 am: 56c520c4ca am: 12c176066e am: 8671302d0b am: 4a9200308c am: 2d4e2b4975  -s ours
am: f919c05b04

Change-Id: Id439de2be22f5b0cf8099c6670430d283a863334

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 21:57:09 +0000 (21:57 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into nyc-dev
am: 3294a9fe16

Change-Id: I61c43661f42204e9aeebb44df9418d7ca5bb9e8e

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 21:52:43 +0000 (21:52 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8 am: 82ffcbd667 am: 9edaa79f62 am: 56c520c4ca am: 12c176066e am: 8671302d0b am: 4a9200308c
am: 2d4e2b4975  -s ours

Change-Id: Ifb9839ce10ac5bd7d60873b434eceefb43182241

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 21:52:07 +0000 (21:52 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into nyc-dev

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 21:04:05 +0000 (21:04 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8 am: 82ffcbd667 am: 9edaa79f62 am: 56c520c4ca am: 12c176066e am: 8671302d0b
am: 4a9200308c

Change-Id: I1534efa8ced51e1b43611da84283d67af1d4f8bd

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 20:59:36 +0000 (20:59 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8 am: 82ffcbd667 am: 9edaa79f62 am: 56c520c4ca am: 12c176066e
am: 8671302d0b

Change-Id: I8cda69d1fdf55fe8be6d904813eb0e87db043c8a

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 20:55:06 +0000 (20:55 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8 am: 82ffcbd667 am: 9edaa79f62 am: 56c520c4ca
am: 12c176066e

Change-Id: Id2207725fc2e69c8aee4a24ee605dc7fae8939e2

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 20:50:38 +0000 (20:50 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8 am: 82ffcbd667 am: 9edaa79f62
am: 56c520c4ca

Change-Id: I27e648ddd65325600cad22d5b0fef03aa4a9447a

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 20:45:34 +0000 (20:45 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8 am: 82ffcbd667
am: 9edaa79f62

Change-Id: Iad06395ed255dbd48b0a77147b6da809963e4306

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 20:41:04 +0000 (20:41 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf am: 59bc7f77f8
am: 82ffcbd667

Change-Id: I1b2ea29d1c22f1714f0c0e90a56c585176742dd2

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 20:36:33 +0000 (20:36 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e am: 0893c50bcf
am: 59bc7f77f8

Change-Id: I133f8566b649821e06cfb21a95b20f84eb839219

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 20:32:06 +0000 (20:32 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev am: 922ad6183e
am: 0893c50bcf

Change-Id: I819b55a95ff50c51488bac50c43fea8b2244a410

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 20:27:43 +0000 (20:27 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev
am: 922ad6183e

Change-Id: I8fbd67b5fe298d6f842d224109e2ab0b52a2b59a

7 years agoMerge "Don't allow using or allocating a buffer after the first state transition...
Marco Nelissen [Mon, 10 Apr 2017 19:57:08 +0000 (19:57 +0000)]
Merge "Don't allow using or allocating a buffer after the first state transition" into klp-dev

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:33:40 +0000 (23:33 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours am: 73db408aa3 am: 0bb0a8e1e8 am: 4d86bef7f7 am: 241f5feb8a am: a7cec6180f am: d022170614 am: cbdc2b7899 am: c9f14c3442
am: 08bb4c4a5b

Change-Id: If0971ae6886ac4ba33eb4c77dcb8f4f72f64d775

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:31:10 +0000 (23:31 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours am: 73db408aa3 am: 0bb0a8e1e8 am: 4d86bef7f7 am: 241f5feb8a am: a7cec6180f am: d022170614 am: cbdc2b7899
am: c9f14c3442

Change-Id: Ia734cfbc610399df85fc2168f7d958bed639c4f7

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:28:09 +0000 (23:28 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours am: 73db408aa3 am: 0bb0a8e1e8 am: 4d86bef7f7 am: 241f5feb8a am: a7cec6180f am: d022170614
am: cbdc2b7899

Change-Id: Id114e3cd00bcdbb000d26e0d48e4ec91affd062c

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:25:09 +0000 (23:25 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours am: 73db408aa3 am: 0bb0a8e1e8 am: 4d86bef7f7 am: 241f5feb8a am: a7cec6180f
am: d022170614

Change-Id: I488701da8808d3da8695aaabae74074f8080d512

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:22:11 +0000 (23:22 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours am: 73db408aa3 am: 0bb0a8e1e8 am: 4d86bef7f7 am: 241f5feb8a
am: a7cec6180f

Change-Id: I75a8ee185d28f82f6760a9b7d392161762e3399d

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:19:37 +0000 (23:19 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours am: 73db408aa3 am: 0bb0a8e1e8 am: 4d86bef7f7
am: 241f5feb8a

Change-Id: I52d24edf474be0f12e7debf052e1398a56674dc8

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:16:08 +0000 (23:16 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours am: 73db408aa3 am: 0bb0a8e1e8
am: 4d86bef7f7

Change-Id: I53fd99fb4436b2cce7a8473a1e188cf8fcdf19eb

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:13:37 +0000 (23:13 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours am: 73db408aa3
am: 0bb0a8e1e8

Change-Id: Id88b6709127ad9799d63dff3c1310001142a0a2c

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e4...
Roger1 Jonsson [Wed, 5 Apr 2017 23:10:38 +0000 (23:10 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d am: ab28d49e41  -s ours
am: 73db408aa3

Change-Id: Ibe55680e73e9caddc3fc79883fa17a50742f393d

7 years agoAvoid crash for stss sync sample number 0
Roger1 Jonsson [Wed, 26 Oct 2016 07:20:00 +0000 (09:20 +0200)]
Avoid crash for stss sync sample number 0

A sample number value of 0 means that the value stored in
the mSyncSamples array, would become negative (-1),
when converted to index value. This causes a crash.

Make sure that stss sample numbers are bigger
than 0 before converting sample number to index value.

Bug: 32423862
bug: 35645051
Test: Playback video that triggers stss sync sample number 0
Change-Id: I35bee7c718e01b086d7e05deda13b38083f509f5

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d
Roger1 Jonsson [Wed, 5 Apr 2017 23:07:37 +0000 (23:07 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3 am: e77a32bd3d
am: ab28d49e41  -s ours

Change-Id: I63e6f4ea65dda85e5d779f6aaf1fbd4ca5806f8c

7 years agoAvoid crash for stss sync sample number 0 am: 5c364997a3
Roger1 Jonsson [Wed, 5 Apr 2017 22:52:35 +0000 (22:52 +0000)]
Avoid crash for stss sync sample number 0 am: 5c364997a3
am: e77a32bd3d

Change-Id: If61ba19bc937c6b7c7227296ddba5a1797072f9d

7 years agoAvoid crash for stss sync sample number 0
Roger1 Jonsson [Wed, 5 Apr 2017 22:49:34 +0000 (22:49 +0000)]
Avoid crash for stss sync sample number 0
am: 5c364997a3

Change-Id: Ia97daf543c65b52db1c5d09471ed8d00a434364d

7 years agoAvoid crash for stss sync sample number 0
Roger1 Jonsson [Wed, 26 Oct 2016 07:20:00 +0000 (09:20 +0200)]
Avoid crash for stss sync sample number 0

A sample number value of 0 means that the value stored in
the mSyncSamples array, would become negative (-1),
when converted to index value. This causes a crash.

Make sure that stss sample numbers are bigger
than 0 before converting sample number to index value.

Bug: 32423862
bug: 35645051
Test: Playback video that triggers stss sync sample number 0
Change-Id: I35bee7c718e01b086d7e05deda13b38083f509f5

7 years agoDon't allow using or allocating a buffer after the first state transition
Marco Nelissen [Mon, 27 Mar 2017 22:04:25 +0000 (15:04 -0700)]
Don't allow using or allocating a buffer after the first state transition

Bug: 35467458
Change-Id: Ia76c8cec8ad2abb95ca29b2a89075f7acab4b174

7 years agoDon't allow using or allocating a buffer after the first state transition
Marco Nelissen [Mon, 27 Mar 2017 22:04:25 +0000 (15:04 -0700)]
Don't allow using or allocating a buffer after the first state transition

Bug: 35467458
Change-Id: Ia76c8cec8ad2abb95ca29b2a89075f7acab4b174

7 years agoDO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd...
Robert Shih [Wed, 15 Mar 2017 00:40:34 +0000 (00:40 +0000)]
DO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd am: aca26c9d45  -s ours am: 1e4d8d67bc  -s ours am: 413ad04890 am: 27ba2d85d6  -s ours am: 4066f0e808 am: db11181861 am: b38fd0baf8 am: acc15f5a71  -s ours am: 9fd47e325d
am: 11ae272995

Change-Id: Iab5689785f643a7ea53eb279456429f1446a613d

7 years agoDO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd...
Robert Shih [Wed, 15 Mar 2017 00:36:04 +0000 (00:36 +0000)]
DO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd am: aca26c9d45  -s ours am: 1e4d8d67bc  -s ours am: 413ad04890 am: 27ba2d85d6  -s ours am: 4066f0e808 am: db11181861 am: b38fd0baf8 am: acc15f5a71  -s ours
am: 9fd47e325d

Change-Id: I0329cb6982a4303aecafa69c38e73de1b7148586

7 years agoFLACExtractor: copy protect mWriteBuffer am: 8ee699977c am: 038fd6e5ec am: 4eea0b3aa4...
Robert Shih [Wed, 15 Mar 2017 00:35:32 +0000 (00:35 +0000)]
FLACExtractor: copy protect mWriteBuffer am: 8ee699977c am: 038fd6e5ec am: 4eea0b3aa4 am: b06f7c6e15 am: 5c1a7d4c64 am: 5b937b03d5 am: ced3c15960 am: 5f6b69ea29
am: 5770ac25f3

Change-Id: I531cbbcdba72ef21b5938468bc3aa1eda067d55a

7 years agoFLACExtractor: copy protect mWriteBuffer am: 8ee699977c am: 038fd6e5ec am: 4eea0b3aa4...
Robert Shih [Wed, 15 Mar 2017 00:30:32 +0000 (00:30 +0000)]
FLACExtractor: copy protect mWriteBuffer am: 8ee699977c am: 038fd6e5ec am: 4eea0b3aa4 am: b06f7c6e15 am: 5c1a7d4c64 am: 5b937b03d5 am: ced3c15960
am: 5f6b69ea29

Change-Id: I5b3ebe0b7272970e401b0bedcdcf65f92cf23687

7 years agoDO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd...
Robert Shih [Wed, 15 Mar 2017 00:30:31 +0000 (00:30 +0000)]
DO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd am: aca26c9d45  -s ours am: 1e4d8d67bc  -s ours am: 413ad04890 am: 27ba2d85d6  -s ours am: 4066f0e808 am: db11181861 am: b38fd0baf8
am: acc15f5a71  -s ours

Change-Id: If271c8cc840e5447f9bfa882cba4ae76801cd17b

7 years agoDO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd...
Robert Shih [Wed, 15 Mar 2017 00:25:32 +0000 (00:25 +0000)]
DO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd am: aca26c9d45  -s ours am: 1e4d8d67bc  -s ours am: 413ad04890 am: 27ba2d85d6  -s ours am: 4066f0e808 am: db11181861
am: b38fd0baf8

Change-Id: I0d43d8afed17f5c64e731080002260ec2f05cfee

7 years agoFLACExtractor: copy protect mWriteBuffer am: 8ee699977c am: 038fd6e5ec am: 4eea0b3aa4...
Robert Shih [Wed, 15 Mar 2017 00:25:31 +0000 (00:25 +0000)]
FLACExtractor: copy protect mWriteBuffer am: 8ee699977c am: 038fd6e5ec am: 4eea0b3aa4 am: b06f7c6e15 am: 5c1a7d4c64 am: 5b937b03d5
am: ced3c15960

Change-Id: I0e56cd59a6c8818f6fbd1f909c226970cd3b330e

7 years agoDO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd...
Robert Shih [Wed, 15 Mar 2017 00:21:02 +0000 (00:21 +0000)]
DO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd am: aca26c9d45  -s ours am: 1e4d8d67bc  -s ours am: 413ad04890 am: 27ba2d85d6  -s ours am: 4066f0e808
am: db11181861

Change-Id: I857531fc1e7a6727de639813c63423758eb37017

7 years agoFLACExtractor: copy protect mWriteBuffer am: 8ee699977c am: 038fd6e5ec am: 4eea0b3aa4...
Robert Shih [Wed, 15 Mar 2017 00:20:32 +0000 (00:20 +0000)]
FLACExtractor: copy protect mWriteBuffer am: 8ee699977c am: 038fd6e5ec am: 4eea0b3aa4 am: b06f7c6e15 am: 5c1a7d4c64
am: 5b937b03d5

Change-Id: I07fae26ec82b190b82c2949a4fbfc1d4e293fda5

7 years agoDO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd...
Robert Shih [Wed, 15 Mar 2017 00:15:30 +0000 (00:15 +0000)]
DO NOT MERGE FLACExtractor: copy protect mWriteBuffer am: 13c77f4fe0 am: 761abda1bd am: aca26c9d45  -s ours am: 1e4d8d67bc  -s ours am: 413ad04890 am: 27ba2d85d6  -s ours
am: 4066f0e808

Change-Id: Icaa568c50688db3157c524978deda0a52ca87e37