OSDN Git Service
Jean-Luc Duprat [Fri, 29 Aug 2014 19:41:04 +0000 (19:41 +0000)]
Tablegen fixes for new syntax when initializing bits from variables.
Followup to r215086.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216757
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Fri, 29 Aug 2014 17:58:16 +0000 (17:58 +0000)]
[FastISel][AArch64] Fix an incorrect kill flag due to a bug in SelectTrunc.
When we select a trunc instruction we don't emit any code if the type is already
i32 or smaller. This is because the instruction that uses the truncated value
will deal with it.
This behavior can incorrectly transfer a kill flag, which was meant for the
result of the truncate, onto the source register.
%2 = trunc i32 %1 to i16
... = ... %2 -> ... = ... vreg1 <kill>
... = ... %1 ... = ... vreg1
This commit fixes this by emitting a COPY instruction, so that the result and
source register are distinct virtual registers.
This fixes rdar://problem/
18178188.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216750
91177308-0d34-0410-b5e6-
96231b3b80d8
Tilmann Scheller [Fri, 29 Aug 2014 17:19:00 +0000 (17:19 +0000)]
[ARM] Add Thumb-2 code size optimization test for ASR (register).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216746
91177308-0d34-0410-b5e6-
96231b3b80d8
Tilmann Scheller [Fri, 29 Aug 2014 17:02:28 +0000 (17:02 +0000)]
[ARM] Add Thumb-2 code size optimization test for ASR (immediate).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216744
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Fri, 29 Aug 2014 16:33:41 +0000 (16:33 +0000)]
Fix a typo in AddAliasScopeMetadata
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216741
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 29 Aug 2014 16:01:17 +0000 (16:01 +0000)]
Make fabs safe to speculatively execute
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216736
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 29 Aug 2014 16:01:14 +0000 (16:01 +0000)]
R600/SI: Use mad for fsub + fmul
We can use a negate source modifier to match
this for fsub.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216735
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 29 Aug 2014 15:34:58 +0000 (15:34 +0000)]
AArch64: only try to get operand of a known node.
A bug in r216725 meant we tried to discover the type of a SETCC before
confirming the node actually was a SETCC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216734
91177308-0d34-0410-b5e6-
96231b3b80d8
Frederic Riss [Fri, 29 Aug 2014 15:32:15 +0000 (15:32 +0000)]
Remove unnecessary regex in test pattern per dblaikie suggestion.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216733
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Fri, 29 Aug 2014 15:32:09 +0000 (15:32 +0000)]
typo
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216732
91177308-0d34-0410-b5e6-
96231b3b80d8
Jingyue Wu [Fri, 29 Aug 2014 15:30:20 +0000 (15:30 +0000)]
[NVPTX] Make the alignment an explicit argument to ldu/ldg
Summary:
Instead of specifying the alignment as metadata which may be destroyed by
transformation passes, make the alignment the second argument to ldu/ldg
intrinsic calls.
Test Plan:
ldu-ldg.ll
ldu-i8.ll
ldu-reg-plus-offset.ll
Reviewers: eliben, meheff, jholewinski
Reviewed By: meheff, jholewinski
Subscribers: jholewinski, llvm-commits
Differential Revision: http://reviews.llvm.org/D5093
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216731
91177308-0d34-0410-b5e6-
96231b3b80d8
Tilmann Scheller [Fri, 29 Aug 2014 15:13:35 +0000 (15:13 +0000)]
[ARM] Make Thumb-2 code size optimization test more strict.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216729
91177308-0d34-0410-b5e6-
96231b3b80d8
Tilmann Scheller [Fri, 29 Aug 2014 15:04:40 +0000 (15:04 +0000)]
[ARM] Add a first test for the Thumb-2 code size optimization pass.
While working on a Thumb-2 code size optimization I just realized that we don't have any regression tests for it.
So here's a first test case, I plan to increase the coverage over time.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216728
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 29 Aug 2014 13:05:18 +0000 (13:05 +0000)]
AArch64: skip select/setcc combine in complex case.
In an llvm-stress generated test, we were trying to create a v0iN type and
asserting when that failed. This case could probably be handled by the
function, but not without added complexity and the situation it arises in is
sufficiently odd that there's probably no benefit anyway.
Should fix PR20775.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216725
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnaud A. de Grandmaison [Fri, 29 Aug 2014 09:54:11 +0000 (09:54 +0000)]
[AArch64] FPLoadBalancing: move ownership of the chain to its current accumulator register
and forget about the previously used accumulator.
Coming up with a simple testcase is not easy, as this highly depends on
what the register allocator is doing: this issue showed up while working
with the PBQP allocator, which produced a different allocation scheme.
A testcase would need to come up with chain starting in D[0-7], then
moving to D[8-15], followed by a call to a function whose regmask
clobbers the starting accumulator in D[0-7], then another use of the chain.
Fixed some formatting, added some invariant checks while there.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216721
91177308-0d34-0410-b5e6-
96231b3b80d8
Frederic Riss [Fri, 29 Aug 2014 09:00:26 +0000 (09:00 +0000)]
Use DwarfDebug::attachLowHighPC for the compilation unit DIE.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216719
91177308-0d34-0410-b5e6-
96231b3b80d8
Robert Khasanov [Fri, 29 Aug 2014 08:46:04 +0000 (08:46 +0000)]
[SKX] Enable lowering of integer CMP operations.
Added new types to Legalizer.
Fixed getSetCCResultType function
Added lowering tests.
Reviewed by Elena Demikhovsky.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216717
91177308-0d34-0410-b5e6-
96231b3b80d8
Job Noorman [Fri, 29 Aug 2014 08:23:53 +0000 (08:23 +0000)]
Do not assume the value passed to memset is an i32.
The code in SelectionDAG::getMemset for some reason assumes the value passed to
memset is an i32. This breaks the generated code for targets that only have
registers smaller than 32 bits because the value might get split into multiple
registers by the calling convention. See the test for the MSP430 target included
in the patch for an example.
This patch ensures that nothing is assumed about the type of the value. Instead,
the type is taken from the selected overload of the llvm.memset intrinsic.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216716
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Fri, 29 Aug 2014 06:01:43 +0000 (06:01 +0000)]
Add conversion constructor to convert ArrayRef<T*> to ArrayRef<const T*>. Reviewed with Chandler and David Blaikie.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216709
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Fri, 29 Aug 2014 01:31:42 +0000 (01:31 +0000)]
[AArch64] Fix some failures exposed by value type v4f16 and v8f16.
1) Add some missing bitcast patterns for v8f16.
2) Add type promotion for operand of ld/st operations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216706
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Bieneman [Fri, 29 Aug 2014 01:05:16 +0000 (01:05 +0000)]
Cleaning up static initializers in Signals.inc
Reviewed by: Chandlerc
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216704
91177308-0d34-0410-b5e6-
96231b3b80d8
Chris Bieneman [Fri, 29 Aug 2014 01:05:12 +0000 (01:05 +0000)]
Cleaning up static initializers in TimeValue.
Code reviewed by Chandlerc
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216703
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 29 Aug 2014 00:50:36 +0000 (00:50 +0000)]
Introduce -DLLVM_USE_SANITIZER=Undefined CMake option to build UBSan-ified version of LLVM/Clang.
I've fixed most of the simple bugs and currently "check-llvm" test suite
has 26 failures, and "check-clang" suite has 5 failures.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216701
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Fri, 29 Aug 2014 00:19:21 +0000 (00:19 +0000)]
[FastISel][AArch64] Don't fold instructions that are not in the same basic block.
This fix checks first if the instruction to be folded (e.g. sign-/zero-extend,
or shift) is in the same machine basic block as the instruction we are folding
into.
Not doing so can result in incorrect code, because the value might not be
live-out of the basic block, where the value is defined.
This fixes rdar://problem/
18169495.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216700
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Fri, 29 Aug 2014 00:06:43 +0000 (00:06 +0000)]
Revert two GEP-related InstCombine commits
This reverts commit r216523 and r216598; people have reported
regressions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216698
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Thu, 28 Aug 2014 22:42:00 +0000 (22:42 +0000)]
Don't promote byval pointer arguments when padding matters
Don't promote byval pointer arguments when when their size in bits is
not equal to their alloc size in bits. This can happen for x86_fp80,
where the size in bits is 80 but the alloca size in bits in 128.
Promoting these types can break passing unions of x86_fp80s and other
types.
Patch by Thomas Jablin!
Reviewed By: rnk
Differential Revision: http://reviews.llvm.org/D5057
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216693
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Thu, 28 Aug 2014 22:08:28 +0000 (22:08 +0000)]
AArch64: More correctly constrain target vector extend lowering.
The AArch64 target lowering for [zs]ext of vectors is set up to handle
input simple types and expects the generic SDag path to do something reasonable
with anything that's not a simple type. The code, however, was only
checking that the result type was a simple type and assuming that
implied that the source type would also be a simple type. That's not a
valid assumption, as operations like "zext <1 x i1> %0 to <1 x i32>"
demonstrate. The fix is to simply explicitly validate the source type
as well as the result type.
PR20791
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216689
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 28 Aug 2014 21:51:37 +0000 (21:51 +0000)]
Move FNEG next to FABS and make them more similar, so it's easier that they can be refactored. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216688
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 28 Aug 2014 20:13:31 +0000 (20:13 +0000)]
On MachO, don't put non-private constants in mergeable sections.
On MachO, putting a symbol that doesn't start with a 'L' or 'l' in one of the
__TEXT,__literal* sections prevents the linker from merging the context of the
section.
Since private GVs are the ones the get mangled to start with 'L' or 'l', we now
only put those on the __TEXT,__literal* sections.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216682
91177308-0d34-0410-b5e6-
96231b3b80d8
Frederic Riss [Thu, 28 Aug 2014 19:09:29 +0000 (19:09 +0000)]
Constify MCSymbol* parameters to DwarfDebug::attachLowHighPC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216681
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 28 Aug 2014 18:59:22 +0000 (18:59 +0000)]
Fix a logic bug in x86 vector codegen: sext (zext (x) ) != sext (x) (PR20472).
Remove a block of code from LowerSIGN_EXTEND_INREG() that was added with:
http://llvm.org/viewvc/llvm-project?view=revision&revision=177421
And caused:
http://llvm.org/bugs/show_bug.cgi?id=20472 (more analysis here)
http://llvm.org/bugs/show_bug.cgi?id=18054
The testcases confirm that we (1) don't remove a zext op that is necessary and (2) generate
a pmovz instead of punpck if SSE4.1 is available. Although pmovz is 1 byte longer, it allows
folding of the load, and so saves 3 bytes overall.
Differential Revision: http://reviews.llvm.org/D4909
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216679
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Thu, 28 Aug 2014 17:49:58 +0000 (17:49 +0000)]
Do not introduce new shuffle patterns after operation legalization if SHUFFLE_VECTOR
was marked custom. The target independent DAG combine has no way to know if
the shuffles it is introducing are ones that the target could support or not.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216678
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 28 Aug 2014 16:29:51 +0000 (16:29 +0000)]
Janitorial services: "Don’t duplicate function or class name at the beginning of the comment."
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216674
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 28 Aug 2014 16:01:50 +0000 (16:01 +0000)]
Remove local TLI vars that are just duplicates of the class var. No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216673
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Thu, 28 Aug 2014 15:53:16 +0000 (15:53 +0000)]
Use local vars to improve readability. No functional change.
Completes what was started in r216611 and r216623.
Used const refs instead of pointers; not sure if one is preferable to the other.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216672
91177308-0d34-0410-b5e6-
96231b3b80d8
Sid Manning [Thu, 28 Aug 2014 14:16:32 +0000 (14:16 +0000)]
Minor spelling correction.
Reviewers: adasgupt, jverma, sidneym
Differential Revision: http://reviews.llvm.org/D5025
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216667
91177308-0d34-0410-b5e6-
96231b3b80d8
Aaron Ballman [Thu, 28 Aug 2014 13:23:26 +0000 (13:23 +0000)]
Silence a -Wsign-compare warning. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216666
91177308-0d34-0410-b5e6-
96231b3b80d8
Arnaud A. de Grandmaison [Thu, 28 Aug 2014 10:15:47 +0000 (10:15 +0000)]
[PBQP] Only output debug information when requested
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216660
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Thu, 28 Aug 2014 10:08:37 +0000 (10:08 +0000)]
InstCombine: Remove redundant combines
InstSimplify already handles icmp (X+Y), X (and things like it)
appropriately. The first thing that InstCombine does is run
InstSimplify on the instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216659
91177308-0d34-0410-b5e6-
96231b3b80d8
Erik Eckstein [Thu, 28 Aug 2014 07:04:02 +0000 (07:04 +0000)]
Fix: SLPVectorizer tried to move an instruction which was replaced by a vector instruction.
For a detailed description of the problem see the comment in the test file.
The problematic moveBefore() calls are not required anymore because the new
scheduling algorithm ensures a correct ordering anyway.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216656
91177308-0d34-0410-b5e6-
96231b3b80d8
David Xu [Thu, 28 Aug 2014 04:59:53 +0000 (04:59 +0000)]
Generate CMN when comparing a short int with minus
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216651
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Hibbits [Thu, 28 Aug 2014 04:40:55 +0000 (04:40 +0000)]
Test commit. Fix whitespace from a previous patch of mine.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216650
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 28 Aug 2014 04:25:17 +0000 (04:25 +0000)]
[MCJIT] Fix format specifiers for debug output in RuntimeDyld.
More work on http://llvm.org/PR20640
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216648
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Thu, 28 Aug 2014 04:02:50 +0000 (04:02 +0000)]
MC: Don't crash when the COFF section limit is reached
I've decided not to commit a test, it takes 2.5 seconds to run on my an
incredibly strong machine.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216647
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 28 Aug 2014 04:00:24 +0000 (04:00 +0000)]
[x86] Fix whitespace and formatting around this function with
clang-format, no functionality changed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216646
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 28 Aug 2014 03:57:13 +0000 (03:57 +0000)]
[x86] Hoist conditions from *every single if* in this routine to
a single early exit.
And factor the subsequent cast<> from all but one block into a single
variable.
No functionality changed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216645
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 28 Aug 2014 03:52:45 +0000 (03:52 +0000)]
[x86] Inline an SSE4 helper function for INSERT_VECTOR_ELT lowering, no
functionality changed.
Separating this into two functions wasn't helping. There was a decent
amount of boilerplate duplicated, and some subsequent refactorings here
will pull even more common code out.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216644
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 28 Aug 2014 03:41:28 +0000 (03:41 +0000)]
[x86] Clean up some tests to use FileCheck and combine two into a single
file.
Changing code that is covered by these tests is just too hard to debug
currently, and now it will be clear the nature of the changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216643
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Thu, 28 Aug 2014 03:34:28 +0000 (03:34 +0000)]
InstSimplify: Move a transform from InstCombine to InstSimplify
Several combines involving icmp (shl C2, %X) C1 can be simplified
without introducing any new instructions. Move them to InstSimplify;
while we are at it, make them more powerful.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216642
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Thu, 28 Aug 2014 02:06:55 +0000 (02:06 +0000)]
[FastISel] Undo phi node updates when falling-back to SelectionDAG.
The included test case would fail, because the MI PHI node would have two
operands from the same predecessor.
This problem occurs when a switch instruction couldn't be selected. This happens
always, because there is no default switch support for FastISel to begin with.
The problem was that FastISel would first add the operand to the PHI nodes and
then fall-back to SelectionDAG, which would then in turn add the same operands
to the PHI nodes again.
This fix removes these duplicate PHI node operands by reseting the
PHINodesToUpdate to its original state before FastISel tried to select the
instruction.
This fixes <rdar://problem/
18155224>.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216640
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Thu, 28 Aug 2014 00:09:46 +0000 (00:09 +0000)]
[FastISel]
Currently instructions are folded very aggressively for AArch64 into the memory
operation, which can lead to the use of killed operands:
%vreg1<def> = ADDXri %vreg0<kill>, 2
%vreg2<def> = LDRBBui %vreg0, 2
... = ... %vreg1 ...
This usually happens when the result is also used by another non-memory
instruction in the same basic block, or any instruction in another basic block.
This fix teaches hasTrivialKill to not only check the LLVM IR that the value has
a single use, but also to check if the register that represents that value has
already been used. This can happen when the instruction with the use was folded
into another instruction (in this particular case a load instruction).
This fixes rdar://problem/
18142857.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216634
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 27 Aug 2014 23:09:40 +0000 (23:09 +0000)]
Revert "[FastISel][AArch64] Don't fold instructions too aggressively into the memory operation."
Quentin pointed out that this is not the correct approach and there is a better and easier solution.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216632
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Wed, 27 Aug 2014 23:06:08 +0000 (23:06 +0000)]
Fix unaligned reads/writes in X86JIT and RuntimeDyldELF.
Summary:
Introduce support::ulittleX_t::ref type to Support/Endian.h and use it in x86 JIT
to enforce correct endianness and fix unaligned accesses.
Test Plan: regression test suite
Reviewers: lhames
Subscribers: ributzka, llvm-commits
Differential Revision: http://reviews.llvm.org/D5011
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216631
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 27 Aug 2014 22:52:33 +0000 (22:52 +0000)]
[FastISel][AArch64] Don't fold instructions too aggressively into the memory operation.
Currently instructions are folded very aggressively into the memory operation,
which can lead to the use of killed operands:
%vreg1<def> = ADDXri %vreg0<kill>, 2
%vreg2<def> = LDRBBui %vreg0, 2
... = ... %vreg1 ...
This usually happens when the result is also used by another non-memory
instruction in the same basic block, or any instruction in another basic block.
If the computed address is used by only memory operations in the same basic
block, then it is safe to fold them. This is because all memory operations will
fold the address computation and the original computation will never be emitted.
This fixes rdar://problem/
18142857.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216629
91177308-0d34-0410-b5e6-
96231b3b80d8
Renato Golin [Wed, 27 Aug 2014 21:58:56 +0000 (21:58 +0000)]
Avoid zero length memset error
Adding a check on buffer lenght to avoid a __warn_memset_zero_len
warning on GCC 4.8.2.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216624
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Wed, 27 Aug 2014 21:42:42 +0000 (21:42 +0000)]
Use local variable in visitFADD. No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216623
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 27 Aug 2014 21:40:50 +0000 (21:40 +0000)]
[FastISel][AArch64] Fix a comment in my previous commit (r216617).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216622
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 27 Aug 2014 21:38:33 +0000 (21:38 +0000)]
[FastISel][AArch64] Fix simplify address when the address comes from a shift.
When the address comes directly from a shift instruction then the address
computation cannot be folded into the memory instruction, because the zero
register is not available as a base register. Simplify addess needs to emit the
shift instruction and use the result as base register.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216621
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 27 Aug 2014 21:11:13 +0000 (21:11 +0000)]
Fix a double free in llvm::getBitcodeTargetTriple.
Unfortunately this is only used by ld64, so no testcase, but should fix the darwin LTO bootstrap.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216618
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 27 Aug 2014 21:04:52 +0000 (21:04 +0000)]
[FastISel][AArch64] Use the zero register for stores.
Use the zero register directly when possible to avoid an unnecessary register
copy and a wasted register at -O0. This also uses integer stores to store a
positive floating-point zero. This saves us from materializing the positive zero
in a register and then storing it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216617
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Wed, 27 Aug 2014 20:57:52 +0000 (20:57 +0000)]
Group unsafe-math optimizations for fsub into one block. No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216616
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 27 Aug 2014 20:47:33 +0000 (20:47 +0000)]
[FastISel] Fix a potential bug in FastEmitInst_ri
FastEmitInst_ri was constraining the first operand without checking if it is
a virtual register. Use constrainOperandRegClass as all the other
FastEmitInst_* functions.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216613
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Wed, 27 Aug 2014 20:40:31 +0000 (20:40 +0000)]
Use local variable to improve readability.
No functional change intended.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216611
91177308-0d34-0410-b5e6-
96231b3b80d8
Sanjay Patel [Wed, 27 Aug 2014 20:27:05 +0000 (20:27 +0000)]
typo in comment
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216609
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 27 Aug 2014 20:25:55 +0000 (20:25 +0000)]
Don't create a MemoryBuffer just to get the MemoryBufferRef. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216608
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Wed, 27 Aug 2014 20:14:18 +0000 (20:14 +0000)]
Convert a few more cases of direct intialization of unique_ptrs from MemoryBuffer::getMemBuffer to move initialization now that it returns by unique_ptr instead of raw pointer.
Cleanup/improvements following r216583.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216605
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Wed, 27 Aug 2014 20:10:38 +0000 (20:10 +0000)]
X86 MC: Handle instructions like fxsave that match multiple operand sizes
Instructions like 'fxsave' and control flow instructions like 'jne'
match any operand size. The loop I added to the Intel syntax matcher
assumed that using a different size would give a different instruction.
Now it handles the case where we get the same instruction for different
memory operand sizes.
This also allows us to remove the hack we had for unsized absolute
memory operands, because we can successfully match things like 'jnz'
without reporting ambiguity. Removing this hack uncovered test case
involving 'fadd' that was ambiguous. The memory operand could have been
single or double precision.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216604
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Wed, 27 Aug 2014 20:08:37 +0000 (20:08 +0000)]
InstCombine: Combine gep X, (Y-X) to Y
We try to perform this transform in InstSimplify but we aren't always
able to. Sometimes, we need to insert a bitcast if X and Y don't have
the same time.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216598
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Wed, 27 Aug 2014 20:08:34 +0000 (20:08 +0000)]
InstSimplify: Don't simplify gep X, (Y-X) to Y if types differ
It's incorrect to perform this simplification if the types differ.
A bitcast would need to be inserted for this to work.
This fixes PR20771.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216597
91177308-0d34-0410-b5e6-
96231b3b80d8
Nico Weber [Wed, 27 Aug 2014 20:06:19 +0000 (20:06 +0000)]
Reland r216439 215441, majnemer has a real fix for PR20771.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216586
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 27 Aug 2014 20:03:13 +0000 (20:03 +0000)]
Return a std::unique_ptr when creating a new MemoryBuffer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216583
91177308-0d34-0410-b5e6-
96231b3b80d8
Nico Weber [Wed, 27 Aug 2014 20:00:13 +0000 (20:00 +0000)]
Revert r216439 (and r216441, else the former doesn't revert cleanly).
It caused PR 20771. I'll land a test on the clang side.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216582
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 27 Aug 2014 19:49:03 +0000 (19:49 +0000)]
Remove unused argument.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216580
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Wed, 27 Aug 2014 19:36:53 +0000 (19:36 +0000)]
Use BitVector instead of int in R600 SIISelLowering.
int may not have enough bits in it, which was detected by UBSan
bootstrap (it reported left shift by a too large constant).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216579
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Wed, 27 Aug 2014 19:03:22 +0000 (19:03 +0000)]
yaml::Stream doesn't need to take ownership of the buffer.
In fact, most users were already using the StringRef version.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216575
91177308-0d34-0410-b5e6-
96231b3b80d8
Zachary Turner [Wed, 27 Aug 2014 18:13:25 +0000 (18:13 +0000)]
Fix some semantic usability issues with DynamicLibrary.
This patch allows invalid DynamicLibrary instances to be
constructed, and fixes the const-correctness of the isValid()
method.
No functional change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216571
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Wed, 27 Aug 2014 18:03:46 +0000 (18:03 +0000)]
InstSimplify: Compute comparison ranges for left shift instructions
'shl nuw CI, x' produces [CI, CI << CLZ(CI)]
'shl nsw CI, x' produces [CI << CLO(CI)-1, CI] if CI is negative
'shl nsw CI, x' produces [CI, CI << CLZ(CI)-1] if CI is non-negative
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216570
91177308-0d34-0410-b5e6-
96231b3b80d8
Zachary Turner [Wed, 27 Aug 2014 17:51:43 +0000 (17:51 +0000)]
Revert "Limit the symbol search in DynamicLibrary to the module that was opened."
This reverts commit r216563, which breaks lli's dynamic symbol resolution.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216569
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Wed, 27 Aug 2014 17:48:07 +0000 (17:48 +0000)]
[MCJIT] Replace a C-style cast in RuntimeDyldImpl.h.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216568
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Wed, 27 Aug 2014 17:41:06 +0000 (17:41 +0000)]
[MCJIT] More endianness fixes for RuntimeDyldMachO.
http://llvm.org/PR20640
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216567
91177308-0d34-0410-b5e6-
96231b3b80d8
Zachary Turner [Wed, 27 Aug 2014 17:06:22 +0000 (17:06 +0000)]
Limit the symbol search in DynamicLibrary to the module that was opened.
Differential Revision: http://reviews.llvm.org/D5030
Reviewed By: Reid Kleckner, Rafael Espindola
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216563
91177308-0d34-0410-b5e6-
96231b3b80d8
Oliver Stannard [Wed, 27 Aug 2014 16:16:04 +0000 (16:16 +0000)]
Teach the AArch64 backend about v4f16 and v8f16
This teaches the AArch64 backend to deal with the operations required
to deal with the operations on v4f16 and v8f16 which are exposed by
NEON intrinsics, plus the add, sub, mul and div operations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216555
91177308-0d34-0410-b5e6-
96231b3b80d8
Michael Zolotukhin [Wed, 27 Aug 2014 15:01:18 +0000 (15:01 +0000)]
[SLP] Re-enable vectorization of GEP expressions (re-apply r210342 with a fix).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216549
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Wed, 27 Aug 2014 13:11:55 +0000 (13:11 +0000)]
Clang-format over X86AsmInstrumentation.* with LLVM style.
r216536 mistakenly used -style=Google instead of LLVM.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216543
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Wed, 27 Aug 2014 11:47:52 +0000 (11:47 +0000)]
Add an explicit cast to pacify implicit boolean conversion warnings.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216539
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 27 Aug 2014 11:39:47 +0000 (11:39 +0000)]
[x86] Fix a regression introduced with r213897 for 32-bit targets where
we stopped efficiently lowering sextload using the SSE41 instructions
for that operation.
This is a consequence of a bad predicate I used thinking of the memory
access needs. The code actually handles the cases where the predicate
doesn't apply, and handles them much better. =] Simple fix and a test
case added. Fixes PR20767.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216538
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Wed, 27 Aug 2014 11:22:16 +0000 (11:22 +0000)]
[SDAG] Re-instate r215611 with a fix to a pesky X86 DAG combine.
This combine is essentially combining target-specific nodes back into target
independent nodes that it "knows" will be combined yet again by a target
independent DAG combine into a different set of target-independent nodes that
are legal (not custom though!) and thus "ok". This seems... deeply flawed. The
crux of the problem is that we don't combine un-legalized shuffles that are
introduced by legalizing other operations, and thus we don't see a very
profitable combine opportunity. So the backend just forces the input to that
combine to re-appear.
However, for this to work, the conditions detected to re-form the unlegalized
nodes must be *exactly* right. Previously, failing this would have caused poor
code (if you're lucky) or a crasher when we failed to select instructions.
After r215611 we would fall back into the legalizer. In some cases, this just
"fixed" the crasher by produces bad code. But in the test case added it caused
the legalizer and the dag combiner to iterate forever.
The fix is to make the alignment checking in the x86 side of things match the
alignment checking in the generic DAG combine exactly. This isn't really a
satisfying or principled fix, but it at least make the code work as intended.
It also highlights that it would be nice to detect the availability of under
aligned loads for a given type rather than bailing on this optimization. I've
left a FIXME to document this.
Original commit message for r215611 which covers the rest of the chang:
[SDAG] Fix a case where we would iteratively legalize a node during
combining by replacing it with something else but not re-process the
node afterward to remove it.
In a truly remarkable stroke of bad luck, this would (in the test case
attached) end up getting some other node combined into it without ever
getting re-processed. By adding it back on to the worklist, in addition
to deleting the dead nodes more quickly we also ensure that if it
*stops* being dead for any reason it makes it back through the
legalizer. Without this, the test case will end up failing during
instruction selection due to an and node with a type we don't have an
instruction pattern for.
It took many million runs of the shuffle fuzz tester to find this.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216537
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Wed, 27 Aug 2014 11:10:54 +0000 (11:10 +0000)]
Clang-format over X86AsmInstrumentation.*.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216536
91177308-0d34-0410-b5e6-
96231b3b80d8
Robert Khasanov [Wed, 27 Aug 2014 09:34:37 +0000 (09:34 +0000)]
[SKX] Added new versions of cmp instructions in avx512_icmp_cc multiclass, added VL multiclass.
Added encoding tests
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216532
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Wed, 27 Aug 2014 07:38:43 +0000 (07:38 +0000)]
AVX-512: Added intrinsic for VMOVSS store form with mask.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216530
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Wed, 27 Aug 2014 05:25:25 +0000 (05:25 +0000)]
Simplify creation of a bunch of ArrayRefs by using None, makeArrayRef or just letting them be implicitly created.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216525
91177308-0d34-0410-b5e6-
96231b3b80d8
Craig Topper [Wed, 27 Aug 2014 05:25:00 +0000 (05:25 +0000)]
Fix some cases were ArrayRefs were being passed by reference. Also remove 'const' from some other ArrayRef uses since its implicitly const already.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216524
91177308-0d34-0410-b5e6-
96231b3b80d8
David Majnemer [Wed, 27 Aug 2014 05:16:04 +0000 (05:16 +0000)]
InstCombine: Optimize GEP's involving ptrtoint better
We supported transforming:
(gep i8* X, -(ptrtoint Y))
to:
(inttoptr (sub (ptrtoint X), (ptrtoint Y)))
However, this only fired if 'X' had type i8*. Generalize this to
support various types of different sizes. This results in much better
CodeGen, especially for pointers to packed structs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216523
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Wed, 27 Aug 2014 05:04:14 +0000 (05:04 +0000)]
Remove type unit skeletons. GDB no longer needs them & this saves a heap of space.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216521
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 27 Aug 2014 00:58:30 +0000 (00:58 +0000)]
[FastISel][AArch64] Fix address simplification.
When a shift with extension or an add with shift and extension cannot be folded
into the memory operation, then the address calculation has to be materialized
separately. While doing so the code forgot to consider a possible sign-/zero-
extension. This fix folds now also the sign-/zero-extension into the add or
shift instruction which is used to materialize the address.
This fixes rdar://problem/
18141718.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216511
91177308-0d34-0410-b5e6-
96231b3b80d8
Juergen Ributzka [Wed, 27 Aug 2014 00:58:26 +0000 (00:58 +0000)]
[FastISel][AArch64] Fold Sign-/Zero-Extend into the shift immediate instruction.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216510
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Wed, 27 Aug 2014 00:04:16 +0000 (00:04 +0000)]
Fix a couple of debug info test cases to match the metadata schema change in r216239
Found these while testing something else.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216505
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 26 Aug 2014 22:00:09 +0000 (22:00 +0000)]
Pass a std::unique_ptr<MemoryBuffer>& to getLazyBitcodeModule.
By taking a reference we can do the ownership transfer in one place instead of
expecting every caller to do it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216492
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 26 Aug 2014 21:49:01 +0000 (21:49 +0000)]
Pass a MemoryBufferRef when we can avoid taking ownership.
The attached patch simplifies a few interfaces that don't need to take
ownership of a buffer.
For example, both parseAssembly and parseBitcodeFile will parse the
entire buffer before returning. There is no need to take ownership.
Using a MemoryBufferRef makes it obvious in the type signature that
there is no ownership transfer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216488
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Tue, 26 Aug 2014 21:04:04 +0000 (21:04 +0000)]
Give ExecutionEngine of top level buffers.
Long term the idea if for the engine to not own the buffers, but for now
this is consistent with the rest of the API.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216484
91177308-0d34-0410-b5e6-
96231b3b80d8