OSDN Git Service
Malcolm Priestley [Sat, 24 May 2014 13:37:09 +0000 (14:37 +0100)]
staging: vt6656: camel case and clean up CARDvSetBSSMode
camel case changes
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:08 +0000 (14:37 +0100)]
staging: vt6656: camel case clean up CARDbRadioPowerOn
camel case changes
pDevice -> priv
bResult -> ret
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:07 +0000 (14:37 +0100)]
staging: vt6656: camel case clean up CARDbRadioPowerOff
camel case changes
pDevice -> priv
bResult -> ret
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:06 +0000 (14:37 +0100)]
staging: vt6656: camel case clean up CARDvUpdateNextTBTT
camel case changes
pDevice -> priv
qwTSF -> tsf
wBeaconInterval -> beacon_interval
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:05 +0000 (14:37 +0100)]
staging: vt6656: camel case and clean up CARDvSetFirstNextTBTT
camel case changes
pDevice -> priv
wBeaconInterval -> beacon_interval
qwNextTBTT -> next_tbtt
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:04 +0000 (14:37 +0100)]
staging: vt6656: CARDqGetNextTBTT remove camel case
qwTSF -> tsf
wBeaconInterval -> beacon_interval
uBeaconInterval -> beacon_int
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:03 +0000 (14:37 +0100)]
staging: vt6656: CARDbClearCurrentTSF remove camel case
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:02 +0000 (14:37 +0100)]
staging: vt6656: CARDbGetCurrentTSF remove camel case
pDevice -> priv
pqwCurrTSF -> current_tsf
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:01 +0000 (14:37 +0100)]
staging: vt6656: camel case and clean up CARDvAdjustTSF
camel case changes
pDevice -> priv
byRxRate -> rx_rate
qwBSSTimestamp -> time_stamp
qwLocalTSF -> local_tsf
qwTSFOffset -> tsf_offset
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:37:00 +0000 (14:37 +0100)]
staging: vt6656: CARDqGetTSFOffset remove camel case
camel case changes
byRxRate -> rx_rate
qwTSF1 -> tsf1
qwTSF2 -> tsf2
qwTSFOffset -> tsf_offset
wRxBcnTSFOffst -> rx_bcn_offset
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:36:59 +0000 (14:36 +0100)]
staging: vt6656: camel case and cleanup CARDbyGetPktType
camel case changes
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:36:58 +0000 (14:36 +0100)]
staging: vt6656: camel case clean up CARDbIsOFDMinBasicRate
camel case change
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 24 May 2014 13:36:57 +0000 (14:36 +0100)]
staging: vt6656: Convert remaining locks to spin_lock_irqsave.
Convert all remaining locks to spin_lock_irqsave and
spin_unlock_irqrestore
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sun, 25 May 2014 17:56:30 +0000 (10:56 -0700)]
Merge tag 'iio-for-3.16c' of git://git./linux/kernel/git/jic23/iio into staging-next
Jonathan writes:
Third round of new stuff for IIO in the 3.16 cycle.
This (rather late) set consists only of fixes to patches earlier in the
cycle or minor fixes for other problems (such as randconfig build issues
picked up by Arnd). I've included the general minor fixes here as it is
very late in the current cycle and they can all wait for the merge window.
* Recent change to hid-sensors introduced a possible infinite loop due to a
typo. In the same series, a report interval unit read was added but in the
case where the hardware doesn't support it a value of 0 would lead to some
nasty issues. The patch sets it to the specified default of msecs.
* Anon inodes were used by IIO without being explicitly selected. This has
been true for a long time so it clearly only effects rather unusual
configurations (rand configs)
* at91 requires the input subsytem but this wasn't explicity in the Kconfig.
* A couple of parts supported by the max1363 driver were using the wrong
iio_chan_spec arrays and hence would missreport their bit depths. This has
been there a long time and was never right so isn't a regression.
Toralf Förster [Sat, 24 May 2014 13:25:00 +0000 (14:25 +0100)]
fix format string missmatch in staging/iio/Documentation/iio_utils.h
spotted by cppcheck
Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Jonathan Cameron [Sat, 24 May 2014 11:52:10 +0000 (12:52 +0100)]
iio:adc:max1363 incorrect resolutions for max11604, max11605, max11610 and max11611.
Cc: Stable@vger.kernel.org>
Reported-by: Erik Habbinga <Erik.Habbinga@schneider-electric.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Greg Kroah-Hartman [Sat, 24 May 2014 20:01:06 +0000 (13:01 -0700)]
Revert "staging: r8188eu: Add support for Dlink DWA-121 802.11n Wireless N 150 Pico Adapter"
This reverts commit
599a2c02a784934b9bf0725920c1bc235b9b28ce.
Larry writes:
This patch should be dropped. The 0x2001:0x3308 device is an
RTL8188CU, not RTL8188EU. As a result, it is already in the USB
device tables.
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Kim Nylund <kim@pratsam.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:24:05 +0000 (22:24 +0200)]
Staging: bcm: Shortened prototype for GetNextTargetBufferLocation()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:24:04 +0000 (22:24 +0200)]
Staging: bcm: Shortened lines in SearchClsid()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:24:03 +0000 (22:24 +0200)]
Staging: bcm: Shortened lines in deleteSFBySfid()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:24:02 +0000 (22:24 +0200)]
Staging: bcm: Shortened lines in CopyIpAddrToClassifier()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:24:01 +0000 (22:24 +0200)]
Staging: bcm: Replaced member accessing by variable
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:24:00 +0000 (22:24 +0200)]
Staging: bcm: Shortened lines and replaced member accessing in CopyIpAddrToClassifier()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:59 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in CopyClassifierRuleToSF()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:58 +0000 (22:23 +0200)]
Staging: bcm: Replaced member accessing with variable
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:57 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in DeleteClassifierRuleFromSF()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:56 +0000 (22:23 +0200)]
Staging: bcm: Shortened line in DeleteAllClassifiersForSF()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:55 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in CopyToAdapter()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:54 +0000 (22:23 +0200)]
Staging: bcm: Replaced struct member accessing with variable
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:53 +0000 (22:23 +0200)]
Staging: bcm: Outsourced PHS rule applying
This patch outsources the big PHS-rule-applying code chunk into a
function.
It also replaces member accessing by using variables.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:52 +0000 (22:23 +0200)]
Staging: bcm: Shortened some lines in DumpCmControlPacker()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:51 +0000 (22:23 +0200)]
Staging: bcm: Replaced long member-accessing
This patch replaces long object->member.member foo by variable useage.
Increases the reading experience a lot by introducing only one variable
(as it decreases the whoa-wall-of-text experience).
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:50 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in RestoreSFParam()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:49 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in StoreSFParam()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:48 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in StoreCmControlResponseMessage()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:47 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in RestoreCmControlResponseMessage()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:46 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in SetupTargetDsxBuffers()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:45 +0000 (22:23 +0200)]
Staging: bcm: Shortenend lines in GetNextTargetBufferLocation()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:44 +0000 (22:23 +0200)]
Staging: bcm: Shortened line
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:43 +0000 (22:23 +0200)]
Staging: bcm: Simplified by using variables
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:42 +0000 (22:23 +0200)]
Staging: bcm: Outsourced restoring of endianess for ip adresses
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:41 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in get_dsx_sf_data_to_application()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:40 +0000 (22:23 +0200)]
Staging: bcm: Shortened lines in OverrideServiceFlowParams()
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matthias Beyer [Fri, 23 May 2014 20:23:39 +0000 (22:23 +0200)]
Staging: bcm: Shortened code by using variable
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Davide Gianforte [Fri, 23 May 2014 20:06:44 +0000 (22:06 +0200)]
staging: gdm72xx: code cleanup
Checkpatch.pl cleanup
Thanks again to Greg KH and Dan Carpenter for the patience :)
Signed-off-by: Davide Gianforte <davide@gengisdave.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mitchel Humpherys [Fri, 23 May 2014 20:01:22 +0000 (13:01 -0700)]
staging: ion: WARN when the handle kmap_cnt is going to wrap around
There are certain client bugs (double unmap, for example) that can cause
the handle->kmap_cnt (an unsigned int) to wrap around from zero. This
causes problems when the handle is destroyed because we have:
while (handle->kmap_cnt)
ion_handle_kmap_put(handle);
which takes a long time to complete when kmap_cnt starts at ~0 and can
result in a watchdog timeout.
WARN and bail when kmap_cnt is about to wrap around from zero.
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Acked-by: Colin Cross <ccross@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Joseph [Fri, 23 May 2014 19:45:08 +0000 (21:45 +0200)]
staging/olpc_dcon: fix checkpatch warnings
WARNING: Missing a blank line after declarations
Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:19 +0000 (18:00 +0100)]
staging: vt6656: camel case cleanup CARDbAddBasicRate
camel case changes
pDevice -> priv
wRateIdx -> rate_idx
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:18 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up CARDvUpdateBasicTopRate
Camel case changes
pDevice -> priv
byTopOFDM -> top_ofdm
byTopCCK -> top_cck
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:17 +0000 (18:00 +0100)]
staging: vt6656: camel case cleanup vUpdateIFS
camel case changes
pDevice -> priv
byMaxMin -> max_min
byData -> data
pItemRates -> item_rates
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:16 +0000 (18:00 +0100)]
staging: vt6656: camel case cleanup CARDvSetRSPINF
camel case changes
pDevice -> priv
byBBType -> bb_type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:15 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up CARDvCalculateOFDMRParameter
Camel case changes
wRate -> rate
byBBType -> bb_type
pbyTxRate -> tx_rate
pbyRsvTime -> rsv_time
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:14 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvWriteBeaconInterval
camel case changes
pDevice -> priv
wInterval -> interval
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:13 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvDisableBarkerPreambleMd
camel case changes
pDevice -> priv
phyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:12 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvEnableBarkerPreambleMd
Camel case changes
pDevice -> priv
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:11 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvDisableProtectMD
camel case changes
pDevice -> priv
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:10 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvEnableProtectMD
Camel case changes
pDevice -> priv
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:09 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvWriteBSSIDAddress
camel case changes
pDevice -> priv
pbyEtherAddr -> addr
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:08 +0000 (18:00 +0100)]
staging: vt6656: MACvWriteBSSIDAddress remove pbyData
Remove pbyData and point directly to pbyEtherAddr
The size is always ETH_ALEN (6)
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:07 +0000 (18:00 +0100)]
staging: vt6656: camel case cleanup MACvWriteWord
camel case changes
pDevice -> priv
byRegOfs -> reg_ofs
wData -> word
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:06 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvRegBitsOn
camel case changes
pDevice -> priv
byRegOfs -> reg_ofs
byBits -> bits
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:05 +0000 (18:00 +0100)]
staging: vt6656: camel case cleanup MACvRegBitsOff
camel case changes
pDevice -> priv
byRegOfs -> reg_ofs
byBits -> bits
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:04 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvDisableKeyEntry
Camel case changes
pDevice -> priv
uEntryIdx -> entry_idx
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:03 +0000 (18:00 +0100)]
staging: vt6656: MACvDisableKeyEntry fix sizeof uEntryIdx to u8
Remove byData and change all callers to u8.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:02 +0000 (18:00 +0100)]
staging: vt6656: camel case clean up MACvSetBBType
Camel case changes
pDevice -> priv
byType -> type
pbyData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:01 +0000 (18:00 +0100)]
staging: vt6656: remove camel case MACbShutdown
Camel case changes
pDevice -> priv
signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 May 2014 17:00:00 +0000 (18:00 +0100)]
staging: vt6656: remove camel case MACvWriteMultiAddr
Camel case changes.
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaitanya Hazarey [Fri, 23 May 2014 19:24:37 +0000 (12:24 -0700)]
Staging: xgifb: Fixed a code-style warning
Added a blank line after declarations to fix the following warning issued by checkpatch.pl:
drivers/staging/xgifb/vb_init.c:800: WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joel Pelaez Jorge [Fri, 23 May 2014 19:27:43 +0000 (14:27 -0500)]
Staging: rtl8192u: Remove old WIRELESS_EXT support
Remove support for building against ancient WIRELESS_EXT versions,
only leaving support for the current version: 22
Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 23 May 2014 18:02:34 +0000 (14:02 -0400)]
staging: dgap: Change GFP_ATOMICs to GFP_KERNEL
We don't need to use GFP_ATOMIC at driver load time
so use GFP_KERNEL instead.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 23 May 2014 17:45:57 +0000 (13:45 -0400)]
staging: dgap: Simplify get_altpin and get_useintr functions
Simplify dgap_config_get_useintr and dgap_config_get_altpin
changing the case statement to an if statement.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 23 May 2014 17:13:03 +0000 (13:13 -0400)]
staging: dgap: Replace double negative conditionals
This patch replaces double negativeconditionals
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 23 May 2014 16:54:04 +0000 (12:54 -0400)]
staging: dgap: Remove more extra white space and tabs
Removes more extra white space and tabs
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 23 May 2014 14:14:02 +0000 (10:14 -0400)]
staging: dgap: Remove unnecessary initialization of variables in declarations
Removes unnecessary initialization of variables in declarations
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Djordje Zekovic [Fri, 23 May 2014 14:18:03 +0000 (14:18 +0000)]
staging: usbip: use kcalloc instead of kzalloc for array allocations
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
Signed-off-by: Djordje Zekovic <dj@zeko.me>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eli Billauer [Fri, 16 May 2014 08:26:35 +0000 (11:26 +0300)]
devres: Add devm_get_free_pages API
devm_get_free_pages() and devm_free_pages() are the managed counterparts
for __get_free_pages() and free_pages().
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Senna Tschudin [Tue, 20 May 2014 10:33:41 +0000 (12:33 +0200)]
staging: r8712u: Remove useless return variables
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gengis Dave [Thu, 22 May 2014 23:07:13 +0000 (01:07 +0200)]
staging: gdm72xx: return values cleanup
Return values cleanup
Signed-off-by: Davide Gianforte <davide@gengisdave.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Senna Tschudin [Tue, 20 May 2014 10:33:44 +0000 (12:33 +0200)]
staging: ft1000: Remove useless return variables
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benoit Taine [Mon, 19 May 2014 16:24:26 +0000 (18:24 +0200)]
staging: rts5208: Use pci_device_id rather than DEFINE_PCI_DEVICE_TABLE
This patch enhances kernel style usage for the rts5208 driver.
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
kernel coding style guidelines. This issue was reported by checkpatch.
Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julia Lawall [Mon, 19 May 2014 04:31:12 +0000 (06:31 +0200)]
staging: rtl8192e: make return of 0 explicit
Delete unnecessary use of a local variable to immediately return 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@
-ret = 0;
... when != ret = e
return
- ret
+ 0
;
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masaru Nomura [Sat, 17 May 2014 01:04:10 +0000 (02:04 +0100)]
staging: dgnc: dgnc_tty: Remove a prohibited space
Remove a prohibited space before a closed parenthesis of if statement
to meet kernel coding style.
Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masaru Nomura [Sat, 17 May 2014 00:17:07 +0000 (01:17 +0100)]
staging: dgnc: dgnc_tty: Add a required space
Add a required space before an open parenthesis of if statement
to meet kernel coding style.
Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eli Billauer [Sun, 11 May 2014 16:53:46 +0000 (19:53 +0300)]
staging: xillybus: Use devm_ API on probe and remove
Suggested-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Fri, 16 May 2014 03:31:45 +0000 (12:31 +0900)]
staging: ft1000: Convert printk to dev_err in ft1000_cs.c
This patch converts printk to dev_err in ft1000_cs.c
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 21 May 2014 20:17:51 +0000 (16:17 -0400)]
staging: dgap: replace dgap_savestring function with kstrdup
Removes dgap_savestring function to use kstrdup instead.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 21 May 2014 19:48:47 +0000 (15:48 -0400)]
staging: dgap: Remove unnecessary test on count
This patch removes an unnecessary test. We've already
tested it by the time we get here with no possiblity
of it being changed.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 21 May 2014 19:16:02 +0000 (15:16 -0400)]
staging: dgap: Remove erroneous comment
This patch removes a false comment
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 21 May 2014 19:08:32 +0000 (15:08 -0400)]
staging: dgap: Remove dead sniff buffer code
The sniff buffer was a /proc filesystem file. This
module no longer uses /proc. This patch removes
the deaed code associated with the sniff buffer.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 21 May 2014 17:02:52 +0000 (13:02 -0400)]
staging: dgap: fix smatch warn: unsigned var is never less than zero
This patch fixes a smatch warning about an unsigned
integer being tested for less than zero.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 19 May 2014 09:56:34 +0000 (18:56 +0900)]
staging: dgap: implement error handling in dgap_tty_register()
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need to check NULL for them.
- If one of those is failed, it need to add proper handler for
avoiding memory leak.
- If both of drivers are registered normally, and
then set TRUE to dgap_major_serial{print}_registered. If one
of drivers is failed to register, leave a default value as
FALSE.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vitaly Osipov [Sun, 18 May 2014 06:59:36 +0000 (16:59 +1000)]
staging: wlan-ng: use netdev_() instead of printk()
Replaced all uses of printk() in wlan-ng with netdev_err / _warn
where a netdev exists. If a few cases where a netdev does not yet
exist, dev_ or pr_ was used.
Checkpatch complains about lines over 80 chars or split string
constants - the messages are just too long, keeping it completely
happy would make the code less readable.
Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Fri, 16 May 2014 22:24:09 +0000 (00:24 +0200)]
staging/wlan-ng: log with netdev_xxx and dev_xxx
Wherever possible, replaced printk() and pr_xxx() calls with
netdev_xxx() / dev_xxx() calls; used pr_xxx() otherwise.
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Fri, 16 May 2014 22:14:52 +0000 (00:14 +0200)]
staging/wlan-ng: rearrange comments
Gathered together comments in front of multicast filtering block.
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Fri, 16 May 2014 22:14:51 +0000 (00:14 +0200)]
staging/wlan-ng: multicast address checking
Used is_multicast_ether_addr() to perform the checking.
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Fri, 16 May 2014 22:14:50 +0000 (00:14 +0200)]
staging/wlan-ng: compare using ether_addr_equal_unaligned
Replaced generic memcmp() with dedicated ether_addr_equal_unaligned()
call. I did not find any clue of u16 alignment for both addresses.
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Fri, 16 May 2014 22:30:16 +0000 (00:30 +0200)]
staging/wlan-ng: add prefix to function name
Renamed convert_frame_to_ether() to p80211_convert_to_ether().
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Paul Davies C [Sun, 11 May 2014 13:11:33 +0000 (18:41 +0530)]
staging: octeon-usb: Fix lines with more than 80 chars in octeon-hcd.c
Some lines with more than 80 characters are converted in to multiple lines.
Signed-off-by: Paul Davies C <pauldaviesc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Paul Davies C [Sun, 11 May 2014 13:11:32 +0000 (18:41 +0530)]
staging: octeon-usb: Add blank line after all declarations in octeon-hcd.c
Add blank lines after each declarations in drivers/staging/octeon-usb/octeon-hcd.c.
Signed-off-by: Paul Davies C <pauldaviesc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aaro Koskinen [Sun, 11 May 2014 11:15:20 +0000 (14:15 +0300)]
staging: octeon-usb: use generic prefetch
Use generic prefetch.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>