OSDN Git Service

android-x86/system-bt.git
5 years agoAdd information request after acl connect
Chris Manton [Thu, 31 Oct 2019 21:36:02 +0000 (14:36 -0700)]
Add information request after acl connect

The 2 information requests are optional, but convention
by legacy android stack and other devices I've tested against
send these commands after acl connection.

Bug: 143697964
Test: Verified on actual device with wireshark

Change-Id: Idd651ac30e8d843c88105f4145756320c0f68902

5 years agoExtend l2cap functionality for CoC
Chris Manton [Fri, 1 Nov 2019 03:39:11 +0000 (20:39 -0700)]
Extend l2cap functionality for CoC

Keep packets flowing after reception
Add search for channel using remote id

Bug: 143697964
Test: Verified using wireshark

Change-Id: I238c23f58f215316223bf28548422759016bc8ab

5 years agoSwap cid parameters
Chris Manton [Thu, 31 Oct 2019 23:19:14 +0000 (16:19 -0700)]
Swap cid parameters

Confusingly the destination cid in this packet is actually the cid
of the remote and the source cid is the cid of the local.

Bug: 143697964
Test: Verified correct behavior on wireshark
Change-Id: I7c7b80458d91c2cbd48b5990ae9202fc062cd59b

5 years agoMerge changes I9693f8e4,I3568a3dc
Treehugger Robot [Thu, 31 Oct 2019 16:35:47 +0000 (16:35 +0000)]
Merge changes I9693f8e4,I3568a3dc

* changes:
  L2CAP Classic Cert: Auto generate cid for incoming request
  L2CAP: Fix SignallingManager request queuing

5 years agoMerge "Signal id of zero is silently ignored per spec"
Treehugger Robot [Thu, 31 Oct 2019 05:53:42 +0000 (05:53 +0000)]
Merge "Signal id of zero is silently ignored per spec"

5 years agoMerge changes I33b0ace1,I3af9a79d
Treehugger Robot [Thu, 31 Oct 2019 00:01:36 +0000 (00:01 +0000)]
Merge changes I33b0ace1,I3af9a79d

* changes:
  Separate out connect actions for initiate/target
  Remove channel connection timeouts

5 years agoL2CAP Classic Cert: Auto generate cid for incoming request
Hansong Zhang [Wed, 30 Oct 2019 23:43:39 +0000 (16:43 -0700)]
L2CAP Classic Cert: Auto generate cid for incoming request

Previously the scid on cert side was hardcoded. Instead, let the cert
stack generate one, from kFirstDynamicChannelForIncomingRequest.

Test: run_cert_test
Bug: 143543622
Change-Id: I9693f8e4666c80bb62fedd0d94163e38f71211ae

5 years agoL2CAP: Fix SignallingManager request queuing
Hansong Zhang [Mon, 28 Oct 2019 21:55:02 +0000 (14:55 -0700)]
L2CAP: Fix SignallingManager request queuing

We should always wait for an outgoing request to be handled before
sending the next one. Fix the logic in queuing.

Test: run_cert_test.sh
Bug: 141557006
Change-Id: I3568a3dca4857f1ba4fa47618408f40e2f1f7d04

5 years agoMerge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""
Colin Cross [Wed, 30 Oct 2019 20:39:36 +0000 (20:39 +0000)]
Merge "Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL""

5 years agoSeparate out connect actions for initiate/target
Chris Manton [Tue, 29 Oct 2019 23:28:29 +0000 (16:28 -0700)]
Separate out connect actions for initiate/target

One connect path is soliciated the other as a response
to the service being listened on.

Bug: 141758481
Test: Compiles and bluetooth_test_gd

Change-Id: I33b0ace1c3b691632db9a89ed85892187d3c5fed

5 years agoRemove channel connection timeouts
Chris Manton [Wed, 30 Oct 2019 18:31:41 +0000 (11:31 -0700)]
Remove channel connection timeouts

Defer timeout to lower layer.
Remove hex values for psms
Formalize cid name change to abstract away actual l2cap channel
identifiers from clients.
  (cid) channel_id ==>  connection interface descriptor

Bug: 141758481
Test: Compiles
Change-Id: I3af9a79d7fd721d0d58b131e15cdd7c0204b90cf

5 years agoRevert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"
Cody Schuffelen [Wed, 30 Oct 2019 18:39:20 +0000 (18:39 +0000)]
Revert "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"

This reverts commit f58a420f29d3d37fcbceb5b8ce8c5dd12ecc3124.

Reason for revert: Crashing on cuttlefish
Bug: 143621633

Change-Id: I2dcd365093ba68c8d917e5a029484b0a7e132ce6

5 years agoSignal id of zero is silently ignored per spec
Chris Manton [Wed, 30 Oct 2019 18:14:09 +0000 (11:14 -0700)]
Signal id of zero is silently ignored per spec

Must initialize with a valid signal id.

Bug: 141758481
Test: Verified connection response recieved with non-zero signal id
Change-Id: Icf0ca6a3404759da3734c2d760683a71063340a4

5 years agoMerge "Add inquiry module unit tests"
Treehugger Robot [Wed, 30 Oct 2019 14:52:34 +0000 (14:52 +0000)]
Merge "Add inquiry module unit tests"

5 years agoMerge "Dont disconnect if connection complete event with an ACL connection exists"
Treehugger Robot [Wed, 30 Oct 2019 14:49:03 +0000 (14:49 +0000)]
Merge "Dont disconnect if connection complete event with an ACL connection exists"

5 years agoMerge "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"
Treehugger Robot [Wed, 30 Oct 2019 13:09:09 +0000 (13:09 +0000)]
Merge "RootCanal: Upgrade the LinkLayer in RootCanal to PDL"

5 years agoL2cap shim layer with legacy
Chris Manton [Tue, 29 Oct 2019 00:30:39 +0000 (17:30 -0700)]
L2cap shim layer with legacy

Bug: 141758481
Test: compiles and gracefully fails connect operation
Change-Id: Id0cdc9f0cd8efed18f9a3b6df24207726f0bbd3a

5 years agogd shim layer
Chris Manton [Tue, 29 Oct 2019 00:29:29 +0000 (17:29 -0700)]
gd shim layer

Bug: 141758481
Test: Compiles and fails connect gracefully
Change-Id: I5a11b7796cd8a6990a0b9a006437b81805b4c4d0

5 years agoMerge "Interop Workaround: Add Joy-Con"
Treehugger Robot [Wed, 30 Oct 2019 02:33:47 +0000 (02:33 +0000)]
Merge "Interop Workaround: Add Joy-Con"

5 years agoMerge "Execute channel fail callbacks when link not up"
Treehugger Robot [Wed, 30 Oct 2019 02:13:41 +0000 (02:13 +0000)]
Merge "Execute channel fail callbacks when link not up"

5 years agoDont disconnect if connection complete event with an ACL connection exists
Vic Huang [Tue, 15 Oct 2019 10:06:39 +0000 (18:06 +0800)]
Dont disconnect if connection complete event with an ACL connection exists

When create connection and connect request from the same device happen
at the same time, the first connection complete event will work as
expected and set link state to LST_CONNECTED.
But the second connection complete event will disconnect the exist
connection due to the link state is LST_CONNECTED and status is
HCI_ERR_CONNECTION_EXISTS.

Bug: 141872633
Test: Create connection and receive connect request at the same time.
      Check if connection work as expected.

Change-Id: Ibefa1021c3d314522a62cae0b1a31a34b0f8dbc8

5 years agoMerge changes I40aa2b5f,Ica99086c
Treehugger Robot [Wed, 30 Oct 2019 00:25:30 +0000 (00:25 +0000)]
Merge changes I40aa2b5f,Ica99086c

* changes:
  HCI: Add LeAdvertisingManager
  HCI: Add VSC Advertising packets

5 years agoInterop Workaround: Add Joy-Con
cncn [Mon, 28 Oct 2019 21:05:30 +0000 (14:05 -0700)]
Interop Workaround: Add Joy-Con

Bug: 142440781
Test: 1) checking logcat, a log will be printed when when apply special
workaround.
2) testing on device, latency is high on device without the fix and
low with the fix
Change-Id: I0c6548946e9b0e17425086e562fba2150ba0e2cc

5 years agoExecute channel fail callbacks when link not up
Chris Manton [Tue, 29 Oct 2019 23:28:40 +0000 (16:28 -0700)]
Execute channel fail callbacks when link not up

When a user requests a channel to a device but the link
is not up, the request sits in a pending queue until
the link is complete.

Should the link not complete successfully, the user
needs to be notified that the channel connection
failed.

Bug: 141758481
Test: Verified callback completes on real device when timeout failure
Change-Id: I6ea887db30bfe9c9762756cf3c28c68e2e088b8f

5 years agoRootCanal: Upgrade the LinkLayer in RootCanal to PDL
Chienyuan [Wed, 9 Oct 2019 10:11:34 +0000 (18:11 +0800)]
RootCanal: Upgrade the LinkLayer in RootCanal to PDL

Bug: 140384404
Test: run_cert.sh
Change-Id: If66b15cdd942c7214a00a317c2b435da03ffebb7

5 years agoMerge "L2CAP Fix Echo Response"
Treehugger Robot [Mon, 28 Oct 2019 17:52:44 +0000 (17:52 +0000)]
Merge "L2CAP Fix Echo Response"

5 years agoHCI: Add LeAdvertisingManager
Myles Watson [Mon, 14 Oct 2019 23:58:31 +0000 (16:58 -0700)]
HCI: Add LeAdvertisingManager

Bug: 139080884
Test: builds
Change-Id: I40aa2b5f0cf85ce601c310020ed51a204cc0501b

5 years agoHCI: Add VSC Advertising packets
Myles Watson [Tue, 22 Oct 2019 23:21:44 +0000 (16:21 -0700)]
HCI: Add VSC Advertising packets

Bug: 139080884
Test: bluetooth_test_gd
Change-Id: Ica99086cafc3c35afce88b13c03fd3f74deb5232

5 years agoMerge "Switch role to MASTER after connecting"
Treehugger Robot [Mon, 28 Oct 2019 15:45:15 +0000 (15:45 +0000)]
Merge "Switch role to MASTER after connecting"

5 years agoMerge "Merge Coral/Flame into AOSP master"
Xin Li [Sun, 27 Oct 2019 04:44:29 +0000 (04:44 +0000)]
Merge "Merge Coral/Flame into AOSP master"

5 years agoMerge "bluetooth_test_gd: Remove leaked thread and DB"
Treehugger Robot [Fri, 25 Oct 2019 23:50:11 +0000 (23:50 +0000)]
Merge "bluetooth_test_gd: Remove leaked thread and DB"

5 years agoMerge "Unify log tag for shim layer"
Treehugger Robot [Fri, 25 Oct 2019 23:48:53 +0000 (23:48 +0000)]
Merge "Unify log tag for shim layer"

5 years agoAdd inquiry module unit tests
Chris Manton [Wed, 23 Oct 2019 23:53:23 +0000 (16:53 -0700)]
Add inquiry module unit tests

Test: bluetooth_test_gd
Bug: 142061208

Change-Id: I0d18af5592d09d1a63f3c37f10838fd95269dac8

5 years agobluetooth_test_gd: Remove leaked thread and DB
Myles Watson [Fri, 25 Oct 2019 21:21:44 +0000 (14:21 -0700)]
bluetooth_test_gd: Remove leaked thread and DB

Test: bluetooth_test_gd
Change-Id: I1e76bdd41b51f6ec3ef284f176f9a7ce76d273be

5 years agoMerge "L2CAP: Store dynamic channel connection requests when no link"
Treehugger Robot [Fri, 25 Oct 2019 21:20:49 +0000 (21:20 +0000)]
Merge "L2CAP: Store dynamic channel connection requests when no link"

5 years agoUse AddressWithType in PairingHandlerLe
Jakub Pawlowski [Thu, 24 Oct 2019 18:12:35 +0000 (20:12 +0200)]
Use AddressWithType in PairingHandlerLe

Bug: 142341141
Test: updated unittests
Change-Id: Ic543148ca2d36f44e64ffb00744adf6d557b84c3

5 years agoExpose Role through AclConnection, Link, and le::FixedChannel
Jakub Pawlowski [Fri, 25 Oct 2019 09:36:43 +0000 (11:36 +0200)]
Expose Role through AclConnection, Link, and le::FixedChannel

Role is needed in SMP to properly bootstrap the pairing process

Bug: 142341141
Change-Id: If0815c7bc9d07180950e66dbaafd69220e933340

5 years agoL2CAP Fix Echo Response
Hansong Zhang [Fri, 25 Oct 2019 18:05:30 +0000 (11:05 -0700)]
L2CAP Fix Echo Response

Fix Echo Response Packet for PTS L2CAP/COS/ECH/BV-01-C

Test: run_cert_test
Bug: 141557006
Change-Id: I5e575d578e4b2f1aed04e35a32ece37889ee156f

5 years agoL2CAP: Store dynamic channel connection requests when no link
Hansong Zhang [Fri, 25 Oct 2019 00:23:18 +0000 (17:23 -0700)]
L2CAP: Store dynamic channel connection requests when no link

Test: run_cert_test
Bug: 141557006
Change-Id: I37e1ec379458f40ab944ab69b0ed9c774350078a

5 years agoMerge "L2CAP: Allow opening connection, and add PTS request_connection test"
Treehugger Robot [Fri, 25 Oct 2019 20:16:45 +0000 (20:16 +0000)]
Merge "L2CAP: Allow opening connection, and add PTS request_connection test"

5 years agoMerge "Add required header_libs"
Marco Nelissen [Fri, 25 Oct 2019 19:47:54 +0000 (19:47 +0000)]
Merge "Add required header_libs"

5 years agoUnify log tag for shim layer
Chris Manton [Fri, 25 Oct 2019 19:44:56 +0000 (12:44 -0700)]
Unify log tag for shim layer

Bug: 140421729
Test: Compiles
Change-Id: I7809e11273a38aa260881faf6fd10246b78a9d6d

5 years agoMerge Coral/Flame into AOSP master
Xin Li [Fri, 25 Oct 2019 17:28:40 +0000 (10:28 -0700)]
Merge Coral/Flame into AOSP master

Bug: 141248619
Change-Id: I4818ef97dfd59ee7573b3c2b84a90559d8dec289
Merged-In: Id56826347023d4ad4c211ad5e39164bc47fdf530

5 years agoL2CAP: Allow opening connection, and add PTS request_connection test
Hansong Zhang [Tue, 22 Oct 2019 23:11:53 +0000 (16:11 -0700)]
L2CAP: Allow opening connection, and add PTS request_connection test

* Allow reserving a channel to send channel connection request
* Handle open channel request from user API
* Add PTS test_basic_operation_request_connection
(L2CAP/COS/CED/BV-01-C)

Test: run_cert_test
Bug: 141557006
Change-Id: Ia8245a3f944dd1e731808d1c99ac79047b9d67a8

5 years agoMerge "Make FixedChannel and Link aware of address type"
Jakub Pawlowski [Thu, 24 Oct 2019 14:06:53 +0000 (07:06 -0700)]
Merge "Make FixedChannel and Link aware of address type"
am: b033f7d85a

Change-Id: Id56826347023d4ad4c211ad5e39164bc47fdf530

5 years agoMerge "Make FixedChannel and Link aware of address type"
Jakub Pawlowski [Thu, 24 Oct 2019 13:39:36 +0000 (13:39 +0000)]
Merge "Make FixedChannel and Link aware of address type"

5 years agoMake FixedChannel and Link aware of address type
Jakub Pawlowski [Thu, 24 Oct 2019 12:01:36 +0000 (14:01 +0200)]
Make FixedChannel and Link aware of address type

Bug: 140938432
Bug: 142341141
Change-Id: I120179eef18f3ac59e32e9196f700e51c47d1a84

5 years agoSwitch role to MASTER after connecting
Ted Wang [Mon, 21 Oct 2019 09:32:12 +0000 (17:32 +0800)]
Switch role to MASTER after connecting

It could cause issues and audio glitches when phone is at SLAVE role
after Bluetooth connection has been established, especially in dynamic
channel environment.
Request role switch after remote send connection request to make phone
at MASTER role.

Bug: 130190036
Test: Create connection from remote device and check it switched role
Change-Id: I11334a730c9fe93b841a4ed54dd6b89e9edf87f3

5 years agoMerge "Skip QD1A.190821.011 in stage-aosp-master" into stage-aosp-master
TreeHugger Robot [Thu, 24 Oct 2019 00:26:49 +0000 (00:26 +0000)]
Merge "Skip QD1A.190821.011 in stage-aosp-master" into stage-aosp-master

5 years agoAdd required header_libs
Marco Nelissen [Mon, 21 Oct 2019 21:53:45 +0000 (14:53 -0700)]
Add required header_libs

Test: build
Bug: 143245419
Change-Id: Iadfb621e477e1cef325385f3f5b10285cb3fc752

5 years agoMerge "HCI: Add fuzz test for HCI packets"
Jack He [Wed, 23 Oct 2019 22:24:16 +0000 (15:24 -0700)]
Merge "HCI: Add fuzz test for HCI packets"
am: 78487afd40

Change-Id: I6227fffca99e9e9ba8e4d1a054931a6995201033

5 years agoMerge "HCI: Add fuzz test for HCI packets"
Treehugger Robot [Wed, 23 Oct 2019 20:01:41 +0000 (20:01 +0000)]
Merge "HCI: Add fuzz test for HCI packets"

5 years agoMerge "PDL: Parameterize the root namespace"
Myles Watson [Wed, 23 Oct 2019 18:53:04 +0000 (11:53 -0700)]
Merge "PDL: Parameterize the root namespace"
am: 58da1ac0cc

Change-Id: I36c39a750ddc94e9ca4c2cb2f83c0d8fb79ff002

5 years agoMerge "L2CAP: Handle initial channel configuration"
Hansong Zhang [Wed, 23 Oct 2019 18:48:10 +0000 (11:48 -0700)]
Merge "L2CAP: Handle initial channel configuration"
am: 0f5ae76dfb

Change-Id: Iabaaa863fc8b3e17e6d800bbc81ed4b56a423a94

5 years agoMerge "PDL: Parameterize the root namespace"
Treehugger Robot [Wed, 23 Oct 2019 18:44:38 +0000 (18:44 +0000)]
Merge "PDL: Parameterize the root namespace"

5 years agoMerge "L2CAP: Handle initial channel configuration"
Treehugger Robot [Wed, 23 Oct 2019 18:00:24 +0000 (18:00 +0000)]
Merge "L2CAP: Handle initial channel configuration"

5 years agoMerge "Connect inquiry results back to legacy layer"
Chris Manton [Wed, 23 Oct 2019 17:45:41 +0000 (10:45 -0700)]
Merge "Connect inquiry results back to legacy layer"
am: 67895fd9a4

Change-Id: Ib0cd94877050a13ebc53ecf04459f38ee25e07d4

5 years agoMerge "Module: Mark getters as const"
Myles Watson [Wed, 23 Oct 2019 17:43:28 +0000 (10:43 -0700)]
Merge "Module: Mark getters as const"
am: 48ea0a7ab6

Change-Id: I1d4588c09a3dfbe9231096eb7d807f607d9364e3

5 years agoMerge "Connect inquiry results back to legacy layer"
Chris Manton [Wed, 23 Oct 2019 17:17:25 +0000 (17:17 +0000)]
Merge "Connect inquiry results back to legacy layer"

5 years agoMerge "Module: Mark getters as const"
Treehugger Robot [Wed, 23 Oct 2019 17:09:12 +0000 (17:09 +0000)]
Merge "Module: Mark getters as const"

5 years agoConnect inquiry results back to legacy layer
Chris Manton [Tue, 22 Oct 2019 21:24:58 +0000 (14:24 -0700)]
Connect inquiry results back to legacy layer

Bug: 141963466
Test: Compile
Change-Id: I949b1d90ead14cf15baa2a74db979ec76151650a
Merged-In: I949b1d90ead14cf15baa2a74db979ec76151650a

5 years agoStore Handler in common::CallbackList, and execute callbacks on proper handlers
Jakub Pawlowski [Wed, 23 Oct 2019 08:27:12 +0000 (01:27 -0700)]
Store Handler in common::CallbackList, and execute callbacks on proper handlers
am: b0e16b3158

Change-Id: I1073c2650b52765714e598f9cbd0210486480990

5 years agoModule: Mark getters as const
Myles Watson [Fri, 18 Oct 2019 18:21:47 +0000 (11:21 -0700)]
Module: Mark getters as const

Test: bluetooth_test_gd
Change-Id: Ieea21b113154bac1539a1ff73f4ca46ad37dfe35

5 years agoL2CAP: Handle initial channel configuration
Hansong Zhang [Wed, 16 Oct 2019 20:31:52 +0000 (13:31 -0700)]
L2CAP: Handle initial channel configuration

On channel open, send an empty configuration request, and always
respond empty to configuration request, to allow L2CAP basic dynamic
channel setup for testing.

Test: run_cert_test
Bug: 141557006

Change-Id: I95774ea093d069c83313c3e6d00d0bc2c3e6c4ed

5 years agoHCI: Add fuzz test for HCI packets
Jack He [Tue, 22 Oct 2019 22:57:10 +0000 (15:57 -0700)]
HCI: Add fuzz test for HCI packets

* Add fuzz test for a subset of HCI packets
* Modify the fuzz test generator to generate and register fuzz test at
  the same time

Bug: 142684649
Test: bluetooth_gd_fuzz_test
Change-Id: I1962fd497467bbf469d773823e3e6cf81f62772b

5 years agoStore Handler in common::CallbackList, and execute callbacks on proper handlers
Jakub Pawlowski [Tue, 22 Oct 2019 21:31:29 +0000 (23:31 +0200)]
Store Handler in common::CallbackList, and execute callbacks on proper handlers

Bug: 143169747
Change-Id: Ib8b6901956ffde9969decbe0b4653758d6a9ce52

5 years agoMerge "L2CAP: Call AclConnection.RegisterDisconnectCallback() in LinkManager"
Jack He [Tue, 22 Oct 2019 18:33:08 +0000 (11:33 -0700)]
Merge "L2CAP: Call AclConnection.RegisterDisconnectCallback() in LinkManager"
am: 632abab46f

Change-Id: Ic7e47293fc6b5e7ad4cf8d6b2701f860115feb7f

5 years agoMerge "L2CAP: Call AclConnection.RegisterDisconnectCallback() in LinkManager"
Treehugger Robot [Tue, 22 Oct 2019 18:12:07 +0000 (18:12 +0000)]
Merge "L2CAP: Call AclConnection.RegisterDisconnectCallback() in LinkManager"

5 years agoMerge changes If88cfd69,Icea6e47b
Chris Manton [Tue, 22 Oct 2019 16:15:57 +0000 (09:15 -0700)]
Merge changes If88cfd69,Icea6e47b
am: 256e3c0a5e

Change-Id: I0828c72ede14fe37aae9f404c86c3423d1659125

5 years agoMerge "RootCanal: Use gd/os/log.h logging"
Myles Watson [Tue, 22 Oct 2019 16:15:29 +0000 (09:15 -0700)]
Merge "RootCanal: Use gd/os/log.h logging"
am: 64e221d32a

Change-Id: I18f1f7086f46e8f9e7c5835468dbd168b532bda6

5 years agoMerge changes If88cfd69,Icea6e47b
Treehugger Robot [Tue, 22 Oct 2019 16:05:30 +0000 (16:05 +0000)]
Merge changes If88cfd69,Icea6e47b

* changes:
  Conditional entry between legacy Gd stack
  Gd shim layer neighbor modules

5 years agoMerge "RootCanal: Use gd/os/log.h logging"
Treehugger Robot [Tue, 22 Oct 2019 15:59:23 +0000 (15:59 +0000)]
Merge "RootCanal: Use gd/os/log.h logging"

5 years agoMerge "AVRCP Controller get play status"
Joseph Pirozzo [Tue, 22 Oct 2019 15:18:34 +0000 (08:18 -0700)]
Merge "AVRCP Controller get play status"
am: 7b6a6bbed7

Change-Id: Ia2045a9565efc64e513b4408c25197060d7bdc83

5 years agoMerge "AVRCP Controller get play status"
Joseph Pirozzo [Tue, 22 Oct 2019 15:06:10 +0000 (15:06 +0000)]
Merge "AVRCP Controller get play status"

5 years agoHCI: Use AddressWithType in various LE connection APIs
Jack He [Tue, 22 Oct 2019 10:14:50 +0000 (03:14 -0700)]
HCI: Use AddressWithType in various LE connection APIs
am: 1d4c6df162

Change-Id: I8c1bcea5d8d0a2ed607fb124cb71ae1a6b47ce34

5 years agoConditional entry between legacy Gd stack
Chris Manton [Fri, 18 Oct 2019 16:30:27 +0000 (09:30 -0700)]
Conditional entry between legacy Gd stack

Bug: 141963466
Test: Inquiry/Discoverable operational in Gd mode
Change-Id: If88cfd69d4eb60e615c1f84e8972676e27364c73

5 years agoGd shim layer neighbor modules
Chris Manton [Thu, 17 Oct 2019 17:56:37 +0000 (10:56 -0700)]
Gd shim layer neighbor modules

Bug: 141963466
Test: Compiles for realz

Change-Id: Icea6e47bd9539613ea441ae2aed604b59e4b692f

5 years agoMerge changes I87ce02f0,I2c81de7a
Jack He [Tue, 22 Oct 2019 02:12:01 +0000 (19:12 -0700)]
Merge changes I87ce02f0,I2c81de7a
am: 4d5c3e4427

Change-Id: Ifc3e57496feafbd146e3d0dbea92cc239bc0a011

5 years agoL2CAP: Call AclConnection.RegisterDisconnectCallback() in LinkManager
Jack He [Tue, 22 Oct 2019 01:44:27 +0000 (18:44 -0700)]
L2CAP: Call AclConnection.RegisterDisconnectCallback() in LinkManager

* LinkManager should get ACL disconnection callback from HCI since it
  needs to be able to free Link objects after tearing down Link states
* Previously, only Link is getting this callback, as result, there is a
  memory leak when ACL is disconnected as the Link object was never
  removed

Test: bluetooth_test_gd
Bug: 140938432
Change-Id: I28ed509cbaaa1c4917e1f632a6c35247f3ebe2ef

5 years agoHCI: Use AddressWithType in various LE connection APIs
Jack He [Tue, 22 Oct 2019 00:03:18 +0000 (17:03 -0700)]
HCI: Use AddressWithType in various LE connection APIs

* Use AddressWithType object to ease object management and hashing
* Track classic and LE pending connections separately in AclManager
* Report peer resolvable address in LE enhanced connection complete
  event if it is not empty

Bug: 138261114
Test: bluetooth_test_gd
Change-Id: I2bea155485a5bdc3d087336c6276952f3d64f0ac

5 years agoMerge changes I87ce02f0,I2c81de7a
Treehugger Robot [Tue, 22 Oct 2019 00:09:24 +0000 (00:09 +0000)]
Merge changes I87ce02f0,I2c81de7a

* changes:
  L2CAP: Use AddressWithType in L2CAP LE APIs
  HCI: Create AddressWithType and its unit tests

5 years agoAVRCP Controller get play status
Joseph Pirozzo [Mon, 21 Oct 2019 22:39:09 +0000 (15:39 -0700)]
AVRCP Controller get play status

Correct the parsing error in the GET_PLAY_STATUS message and call the
proper jni callback when it is received.

Bug: 139033614
Test: Connect AVRCP change media players, observe correct value parsed.
Change-Id: I8302b64efdd72bfa671cca5b8c512a436fa54ab3

5 years agoMerge "Import base::CallbackList into bluetooth::common::CallbackList"
Jakub Pawlowski [Mon, 21 Oct 2019 22:19:37 +0000 (15:19 -0700)]
Merge "Import base::CallbackList into bluetooth::common::CallbackList"
am: 655c8beda9

Change-Id: Id425eaae227f90a4c22ecadb473d9a036f7ac2d1

5 years agoL2CAP: Use AddressWithType in L2CAP LE APIs
Jack He [Mon, 21 Oct 2019 22:03:11 +0000 (15:03 -0700)]
L2CAP: Use AddressWithType in L2CAP LE APIs

* Bluetooth Low Energy connections always require explicit AddressType
  information
* Replacing existing Address and AddressType arguments in l2cap::le
  stack with hci::AddressWithType objects for easier hashing and
  managment

Bug: 140938432
Test: bluetooth_test_gd
Change-Id: I87ce02f0a0c867053a2b3560886924a566881801

5 years agoHCI: Create AddressWithType and its unit tests
Jack He [Mon, 21 Oct 2019 22:01:41 +0000 (15:01 -0700)]
HCI: Create AddressWithType and its unit tests

* Create hci::AddressWithType that has both hci::Address and
  hci::AddressType in the same copyable, hashable, and comparable
  object for easier management
* Create unit tests for the hash function

Bug: 139135297
Test: bluetooth_test_gd.AddressWithTypeTest
Change-Id: I2c81de7a3bd19656b687ef498f02d6380321f92d

5 years agoMerge "Import base::CallbackList into bluetooth::common::CallbackList"
Treehugger Robot [Mon, 21 Oct 2019 21:40:33 +0000 (21:40 +0000)]
Merge "Import base::CallbackList into bluetooth::common::CallbackList"

5 years agoMerge "Add FUZZ test generator for packets and L2CAP fuzz tests"
Jack He [Mon, 21 Oct 2019 18:32:06 +0000 (11:32 -0700)]
Merge "Add FUZZ test generator for packets and L2CAP fuzz tests"
am: 21b5002021

Change-Id: I247bb7436007edf4f0e1d8b0788a2ee07877a469

5 years agoMerge "Add FUZZ test generator for packets and L2CAP fuzz tests"
Treehugger Robot [Mon, 21 Oct 2019 18:12:49 +0000 (18:12 +0000)]
Merge "Add FUZZ test generator for packets and L2CAP fuzz tests"

5 years agoImport base::CallbackList into bluetooth::common::CallbackList
Jakub Pawlowski [Mon, 21 Oct 2019 15:05:42 +0000 (17:05 +0200)]
Import base::CallbackList into bluetooth::common::CallbackList

We need a good mechanism for keeping lists of callbacks. Import if from
libchrome for now.

Test: compilation, libchrome already test that.
Change-Id: Ia88be4d80464b981e3794a6ca73909a1e7ce8c04

5 years agoMerge "Make le LinkManager aware of AddressType"
Jakub Pawlowski [Fri, 18 Oct 2019 23:55:41 +0000 (16:55 -0700)]
Merge "Make le LinkManager aware of AddressType"
am: afa8a7ce65

Change-Id: If30dcce2f776674c7e3a353ce7231f3639cf45c5

5 years agoMerge "Make le LinkManager aware of AddressType"
Jakub Pawlowski [Fri, 18 Oct 2019 23:26:51 +0000 (23:26 +0000)]
Merge "Make le LinkManager aware of AddressType"

5 years agoAdd FUZZ test generator for packets and L2CAP fuzz tests
Jack He [Fri, 18 Oct 2019 23:11:17 +0000 (16:11 -0700)]
Add FUZZ test generator for packets and L2CAP fuzz tests

* Add fuzz test generator for packet generator to generate macros for
  fuzz tests
* Add a few fuzz tests for L2CAP packets

Bug: 142684649
Test: bluetooth_gd_fuzz_test
Change-Id: I75bf726b40caef3c7895596039d01c395d34506f

5 years agoUpdate file group names
Martin Brabham [Fri, 18 Oct 2019 23:08:09 +0000 (16:08 -0700)]
Update file group names
am: a5be8689ef

Change-Id: I8c310e1a3a68e291105496b8928b7b6fe34c52f3

5 years agoMake le LinkManager aware of AddressType
Jakub Pawlowski [Wed, 16 Oct 2019 20:25:28 +0000 (22:25 +0200)]
Make le LinkManager aware of AddressType

Bug: 142341141
Change-Id: I53b0d0eb8140a6109c0d3f237059b790c76a2111

5 years agoUpdate file group names
Martin Brabham [Fri, 18 Oct 2019 20:59:24 +0000 (13:59 -0700)]
Update file group names

Bug: N/A
Test: builds
Change-Id: Ie33178a3397343d0a80959a9e39f2f4ba03d5734

5 years agoPDL: Parameterize the root namespace
Myles Watson [Thu, 17 Oct 2019 16:12:36 +0000 (09:12 -0700)]
PDL: Parameterize the root namespace

Bug: 140384404
Test: bluetooth_packet_parser_test
Change-Id: I08aa14159ac86faf9e4e130540ecab77b93526e4

5 years agoRootCanal: Use gd/os/log.h logging
Myles Watson [Thu, 17 Oct 2019 18:36:33 +0000 (11:36 -0700)]
RootCanal: Use gd/os/log.h logging

Bug: 140384404
Test: builds
Change-Id: I442c9629ace0c39f26de59aaab70efa955f34c78

5 years agoMerge "Add a fuzzer in bluetooth gd for l2cap dynamic channel allocator"
Zongheng Wang [Fri, 18 Oct 2019 00:52:38 +0000 (17:52 -0700)]
Merge "Add a fuzzer in bluetooth gd for l2cap dynamic channel allocator"
am: 18662ec821

Change-Id: Ibc79a89528d4f494dc8d7cc13ba7060941739fc2

5 years agoMerge "Add a fuzzer in bluetooth gd for l2cap dynamic channel allocator"
Treehugger Robot [Fri, 18 Oct 2019 00:34:20 +0000 (00:34 +0000)]
Merge "Add a fuzzer in bluetooth gd for l2cap dynamic channel allocator"

5 years agoConnect gd/neighbor into build system
Chris Manton [Thu, 17 Oct 2019 21:47:07 +0000 (14:47 -0700)]
Connect gd/neighbor into build system
am: af1058bdfa

Change-Id: I036113f1e52116a7786ac92f27877f5b65675cf0