OSDN Git Service

android-x86/system-bt.git
5 years agoFix BlockingQueue bug when using vector am: 5041e4f269
Chienyuan [Mon, 29 Apr 2019 23:46:21 +0000 (16:46 -0700)]
Fix BlockingQueue bug when using vector am: 5041e4f269
am: 23719768e2

Change-Id: I07e9a9fed0fccb9561c37623f67bc55afea9f8a9

5 years agoRemove redundant Bluetooth from internal class names am: b45ecd2fd7
Zach Johnson [Mon, 29 Apr 2019 23:46:02 +0000 (16:46 -0700)]
Remove redundant Bluetooth from internal class names am: b45ecd2fd7
am: 273f0a1389

Change-Id: Ia1011184c162a29be434beb5aaa58005c01477a0

5 years agoFix BlockingQueue bug when using vector
Chienyuan [Mon, 29 Apr 2019 23:32:06 +0000 (16:32 -0700)]
Fix BlockingQueue bug when using vector
am: 5041e4f269

Change-Id: I665ed4ef6ad47ad4b5b5f42c226d68b872fade7e

5 years agoRemove redundant Bluetooth from internal class names
Zach Johnson [Mon, 29 Apr 2019 23:31:49 +0000 (16:31 -0700)]
Remove redundant Bluetooth from internal class names
am: b45ecd2fd7

Change-Id: Id7b7adfe228e2729eaf542aba0ce0bcbf005e527

5 years agoAdd a persistent key to overwrite MIN_CE_LEN for Hearing Aids am: 4900661c49
Stanley Tng [Mon, 29 Apr 2019 21:17:46 +0000 (14:17 -0700)]
Add a persistent key to overwrite MIN_CE_LEN for Hearing Aids am: 4900661c49
am: 4bab1efe4a

Change-Id: Ibd083e39bd6d2221d26c513e52c52429d8db7fb0

5 years agoFix BlockingQueue bug when using vector
Chienyuan [Mon, 29 Apr 2019 20:41:32 +0000 (13:41 -0700)]
Fix BlockingQueue bug when using vector

return value instead of reference when take

Test: run unittest
Change-Id: I268f5022306353493a348a52ed363cf60a125661

5 years agoRemove redundant Bluetooth from internal class names
Zach Johnson [Mon, 29 Apr 2019 19:07:23 +0000 (12:07 -0700)]
Remove redundant Bluetooth from internal class names

Test: atest --host bluetooth_test_gd and ./cert/run_cert.sh
Change-Id: I55b2c1ecc1ec254a197d6fde70968a9aa8c06c00

5 years agoAdd a persistent key to overwrite MIN_CE_LEN for Hearing Aids
Stanley Tng [Mon, 29 Apr 2019 20:36:52 +0000 (13:36 -0700)]
Add a persistent key to overwrite MIN_CE_LEN for Hearing Aids
am: 4900661c49

Change-Id: Iae6e1b3eec5a45a5923fafcbe01d00960ee73cab

5 years agoAdd a persistent key to overwrite MIN_CE_LEN for Hearing Aids
Stanley Tng [Sat, 27 Apr 2019 21:51:11 +0000 (14:51 -0700)]
Add a persistent key to overwrite MIN_CE_LEN for Hearing Aids

To help in debugging the noise issues on Hearing Aids, add a new
persistent key, persist.bluetooth.hearingaidmincelen, to overwrite the
MIN_CE_LEN parameter that are used for the Connection Parameter Update
operations.

Bug: 130916579
Test: Manual testing
Change-Id: I1c52b2f99235f8d88e0a1d278dbf3174f1c60709

5 years agoMerge changes Ibcb21966,I026b9e89 am: 1e6d32cd3a
Zach Johnson [Sat, 27 Apr 2019 03:01:57 +0000 (20:01 -0700)]
Merge changes Ibcb21966,I026b9e89 am: 1e6d32cd3a
am: 094f1d311a

Change-Id: I9ae83d891e57fb0bcba05b8a985c2b2ab4d9a67c

5 years agoMerge changes Ibcb21966,I026b9e89
Zach Johnson [Sat, 27 Apr 2019 02:57:05 +0000 (19:57 -0700)]
Merge changes Ibcb21966,I026b9e89
am: 1e6d32cd3a

Change-Id: I47e78cde67529f6e1192cb28c29122af66485684

5 years agoMerge changes Ibcb21966,I026b9e89
Treehugger Robot [Sat, 27 Apr 2019 02:42:45 +0000 (02:42 +0000)]
Merge changes Ibcb21966,I026b9e89

* changes:
  Migrate GD code to module
  Add basic concept of module and module registry + dependency graph

5 years agoImplement blocking queue am: 9c2f4d0dbc
Chienyuan [Sat, 27 Apr 2019 00:20:24 +0000 (17:20 -0700)]
Implement blocking queue am: 9c2f4d0dbc
am: e20f3bfd99

Change-Id: I0c8a46eaf226a14870fbe64d74c92915e763d934

5 years agoImplement blocking queue
Chienyuan [Sat, 27 Apr 2019 00:16:20 +0000 (17:16 -0700)]
Implement blocking queue
am: 9c2f4d0dbc

Change-Id: I51ff86db093683bb7ba868e0b37e1b6851846583

5 years agoMigrate GD code to module
Zach Johnson [Fri, 26 Apr 2019 18:57:05 +0000 (11:57 -0700)]
Migrate GD code to module

Test: atest --host bluetooth_test_gd
Change-Id: Ibcb219666ff5552efc602bf063e69a6e6b7e4bd8

5 years agoAdd basic concept of module and module registry + dependency graph
Zach Johnson [Fri, 26 Apr 2019 05:24:54 +0000 (22:24 -0700)]
Add basic concept of module and module registry + dependency graph

Modules have protected lifecycle functions.
Modules are identified by a factory object that knows how to construct them.
Modules can indicate which dependencies they have.

Dependencies are started before their dependent modules.
Don't support incremental module stop for the moment - it's all or nothing.

Test: atest --host bluetooth_test_gd:ModuleTest
Change-Id: I026b9e893501506a6cea8387941b3a9424a9bec9

5 years agoImplement blocking queue
Chienyuan [Fri, 26 Apr 2019 18:59:35 +0000 (11:59 -0700)]
Implement blocking queue

Test: run unittest
Change-Id: I93c59a2d8c9bbe9bee762412b368773c4b35456f

5 years agoAdd workaround for "Service Changed" indications breaking server-only remotes am...
Jakub Pawlowski [Fri, 26 Apr 2019 13:51:29 +0000 (06:51 -0700)]
Add workaround for "Service Changed" indications breaking server-only remotes am: 890c501e97
am: f00a819e6e

Change-Id: I39046286b91ded7374d759c0a9b9297c8a08ac35

5 years agoAdd workaround for "Service Changed" indications breaking server-only remotes
Jakub Pawlowski [Fri, 26 Apr 2019 13:47:23 +0000 (06:47 -0700)]
Add workaround for "Service Changed" indications breaking server-only remotes
am: 890c501e97

Change-Id: Ic0727d12da91674737a0b3300eb4a0aa1e686349

5 years agoAdd workaround for "Service Changed" indications breaking server-only remotes
Jakub Pawlowski [Wed, 24 Apr 2019 21:00:16 +0000 (23:00 +0200)]
Add workaround for "Service Changed" indications breaking server-only remotes

Test: Connect with ruwido remote when magictether service is registered
Bug: 122994857
Change-Id: Ibb2c1272bb08c7a127c8f7d37ee6a05f15618fc2

5 years ago[automerger skipped] Merge "Call gatt_disconnect if the LE connection is not establis...
weichinweng [Thu, 25 Apr 2019 09:39:04 +0000 (02:39 -0700)]
[automerger skipped] Merge "Call gatt_disconnect if the LE connection is not established and no APP use it." into qt-dev
am: f0de66b7c3 -s ours
am skip reason: change_id Ifed10c67141cb4c9221478db759c5614714fff30 with SHA1 c04984def6 is in history

Change-Id: I7f5cf5430265ecad70d65837fbf21d89ae9e59f1

5 years ago[automerger skipped] HearingAid: add addToWhiteList NativeInterface API
weichinweng [Thu, 25 Apr 2019 09:19:12 +0000 (02:19 -0700)]
[automerger skipped] HearingAid: add addToWhiteList NativeInterface API
am: 3d6b283c3f -s ours
am skip reason: change_id I57c327380f07243e484c5c3afedfe60404f883fa with SHA1 32b0d4687b is in history

Change-Id: Id1aa80c2f396483859a62c1d6954e4f0ebc174c7

5 years agoBasic integration of GD with ACTS am: facafb0849
Zach Johnson [Thu, 25 Apr 2019 06:36:08 +0000 (23:36 -0700)]
Basic integration of GD with ACTS am: facafb0849
am: 95f83c04dc

Change-Id: Id4d85e5cb0e5e79cdbaabeb3206373d9d2d95540

5 years agoBasic integration of GD with ACTS
Zach Johnson [Thu, 25 Apr 2019 06:31:03 +0000 (23:31 -0700)]
Basic integration of GD with ACTS
am: facafb0849

Change-Id: Ib0aeae59c7f0e5b72bc36a456225a676e819d610

5 years agoMerge "Call gatt_disconnect if the LE connection is not established and no APP use...
TreeHugger Robot [Thu, 25 Apr 2019 05:36:05 +0000 (05:36 +0000)]
Merge "Call gatt_disconnect if the LE connection is not established and no APP use it." into qt-dev

5 years agoMerge "Revert "Revert "Cert for HAL adapter""" am: 1bc6c42328
Hansong Zhang [Thu, 25 Apr 2019 01:53:46 +0000 (18:53 -0700)]
Merge "Revert "Revert "Cert for HAL adapter""" am: 1bc6c42328
am: 34ee7abdc1

Change-Id: Icbb156c805056590ab8195c33f47bcf8982dfea8

5 years agoMerge "Revert "Revert "Cert for HAL adapter"""
Hansong Zhang [Thu, 25 Apr 2019 01:49:12 +0000 (18:49 -0700)]
Merge "Revert "Revert "Cert for HAL adapter"""
am: 1bc6c42328

Change-Id: I8ccd9a439f0e30152290139049b3f1d24f26ba14

5 years agoBasic integration of GD with ACTS
Zach Johnson [Mon, 22 Apr 2019 23:34:49 +0000 (16:34 -0700)]
Basic integration of GD with ACTS

* Add GD base test, which can parse config and bring up rootcanal.
* Add GD device controller, which is only optimized for host at this point.
* Add host config for running tests,
* Add basic hal test to test end to end flows.

Missing from this patch:
* GD cert device controller (should be similar to GD device)

Test: after setting up acts (gd/cert/set_up_acts.sh): gd/cert/run_cert.sh

Change-Id: Ibde7c7b0fe85b64643ed11fffe833e9ff53ed48c

5 years agoMerge "Revert "Revert "Cert for HAL adapter"""
Treehugger Robot [Thu, 25 Apr 2019 01:30:36 +0000 (01:30 +0000)]
Merge "Revert "Revert "Cert for HAL adapter"""

5 years agoSimple btsnoop logger implementation am: e066082980
Jack He [Wed, 24 Apr 2019 20:46:27 +0000 (13:46 -0700)]
Simple btsnoop logger implementation am: e066082980
am: 44ae3aff14

Change-Id: I9a212763b0135d55c2fb3441d3d019acd339afdf

5 years agoSimple btsnoop logger implementation
Jack He [Wed, 24 Apr 2019 20:41:23 +0000 (13:41 -0700)]
Simple btsnoop logger implementation
am: e066082980

Change-Id: Ib5452a6cf4b9b00cadb35c9741ea33c5ba2363bf

5 years agoRevert "Revert "Cert for HAL adapter""
Hansong Zhang [Wed, 24 Apr 2019 17:25:42 +0000 (17:25 +0000)]
Revert "Revert "Cert for HAL adapter""

This reverts commit 865d9d138f1099a0236847e39329ee641c62b1ae.

Reason for revert: Re-landing CL I3cf2f54605ce2709d1c149b1221dedc8dc5dca92

Change-Id: I63d60ab99d3a4a1b369f77d6c48eff0f463506e4

5 years agoSimple btsnoop logger implementation
Jack He [Mon, 22 Apr 2019 18:45:26 +0000 (11:45 -0700)]
Simple btsnoop logger implementation

Test: run unit test and check btsnoop log
Change-Id: Ib5ea3fc6440c48e1a7b5d5f3bcc3a0b1c23ac9c2

5 years agoMerge "Revert "Cert for HAL adapter"" am: a1cdf837cf
SzuWei Lin [Wed, 24 Apr 2019 14:30:10 +0000 (07:30 -0700)]
Merge "Revert "Cert for HAL adapter"" am: a1cdf837cf
am: 75c1830da0

Change-Id: I3a3516037202a0d482c28ea6fecfc39cbcf76e84

5 years agoMerge "Revert "Cert for HAL adapter""
SzuWei Lin [Wed, 24 Apr 2019 14:25:06 +0000 (07:25 -0700)]
Merge "Revert "Cert for HAL adapter""
am: a1cdf837cf

Change-Id: Idb0c25b945284e7f83467793a8afde35a3b2274f

5 years agoMerge "Revert "Cert for HAL adapter""
Treehugger Robot [Wed, 24 Apr 2019 14:08:23 +0000 (14:08 +0000)]
Merge "Revert "Cert for HAL adapter""

5 years agoMerge "HearingAid: add addToWhiteList NativeInterface API" am: 4bafb40345
Weichin Weng [Wed, 24 Apr 2019 09:32:01 +0000 (02:32 -0700)]
Merge "HearingAid: add addToWhiteList NativeInterface API" am: 4bafb40345
am: ed58588c92

Change-Id: Id20059c6ef71e216a6a43ccb46c5e1828ae3c779

5 years agoMerge "HearingAid: add addToWhiteList NativeInterface API"
Weichin Weng [Wed, 24 Apr 2019 09:26:53 +0000 (02:26 -0700)]
Merge "HearingAid: add addToWhiteList NativeInterface API"
am: 4bafb40345

Change-Id: I6fa5a9d38d9de413f306e0c9bbb303ee227e237a

5 years agoHearingAid: add addToWhiteList NativeInterface API
weichinweng [Tue, 23 Apr 2019 02:56:20 +0000 (10:56 +0800)]
HearingAid: add addToWhiteList NativeInterface API

Add a new native interface API, addToWhiteList, that adds a LE device to
the whitelist.

Bug: 129452236
Test: Manual testing with Hearing Aids
Change-Id: I57c327380f07243e484c5c3afedfe60404f883fa
Merged-In: I57c327380f07243e484c5c3afedfe60404f883fa

5 years agoMerge "HearingAid: add addToWhiteList NativeInterface API"
Weichin Weng [Wed, 24 Apr 2019 09:15:31 +0000 (09:15 +0000)]
Merge "HearingAid: add addToWhiteList NativeInterface API"

5 years agoRevert "Cert for HAL adapter"
SzuWei Lin [Wed, 24 Apr 2019 07:10:06 +0000 (07:10 +0000)]
Revert "Cert for HAL adapter"

This reverts commit 7b003eb97a032ae16fb5e793bd641635319724c4.

Reason for revert: aosp_x86_64-eng build error

Change-Id: I6e5484f960209b8486806ab21b8d694437e3c10f

5 years agoHearingAid: add addToWhiteList NativeInterface API
weichinweng [Tue, 23 Apr 2019 02:56:20 +0000 (10:56 +0800)]
HearingAid: add addToWhiteList NativeInterface API

Add a new native interface API, addToWhiteList, that adds a LE device to
the whitelist.

Bug: 129452236
Test: Manual testing with Hearing Aids
Change-Id: I57c327380f07243e484c5c3afedfe60404f883fa

5 years agoMerge "Cert for HAL adapter" am: 3cad2ebdaa
Hansong Zhang [Wed, 24 Apr 2019 00:06:56 +0000 (17:06 -0700)]
Merge "Cert for HAL adapter" am: 3cad2ebdaa
am: de6d004b99

Change-Id: If5a8ae1d17a4388c0a00bf2dfb9581cea54acdc8

5 years agoMerge "Cert for HAL adapter"
Hansong Zhang [Tue, 23 Apr 2019 23:58:38 +0000 (16:58 -0700)]
Merge "Cert for HAL adapter"
am: 3cad2ebdaa

Change-Id: I84ca06a36e62021f822c9570202dc8afe4b9a44e

5 years agoMerge "Cert for HAL adapter"
Treehugger Robot [Tue, 23 Apr 2019 23:49:26 +0000 (23:49 +0000)]
Merge "Cert for HAL adapter"

5 years agoMerge "PDL: Use underscores for field names" am: 86939cc6d5
Myles Watson [Tue, 23 Apr 2019 23:23:11 +0000 (16:23 -0700)]
Merge "PDL: Use underscores for field names" am: 86939cc6d5
am: 7bc015c4bb

Change-Id: I72eec2486f0683b4b820ca07cc028bcf7982cad2

5 years agoMerge "PDL: Use underscores for field names"
Myles Watson [Tue, 23 Apr 2019 23:18:07 +0000 (16:18 -0700)]
Merge "PDL: Use underscores for field names"
am: 86939cc6d5

Change-Id: If3963204dc87892e5771e18e2c93f85e43ee2a5c

5 years agoMerge "PDL: Use underscores for field names"
Treehugger Robot [Tue, 23 Apr 2019 23:02:27 +0000 (23:02 +0000)]
Merge "PDL: Use underscores for field names"

5 years agoRoot-canal: Add missing payload size field to loopback evt am: 5af185de3e
Hansong Zhang [Tue, 23 Apr 2019 22:05:49 +0000 (15:05 -0700)]
Root-canal: Add missing payload size field to loopback evt am: 5af185de3e
am: 8216f7609f

Change-Id: I4351bb7f843fa382617cb9e1badeb2ed3ac331b1

5 years agoRoot-canal: Add missing payload size field to loopback evt
Hansong Zhang [Tue, 23 Apr 2019 22:00:09 +0000 (15:00 -0700)]
Root-canal: Add missing payload size field to loopback evt
am: 5af185de3e

Change-Id: I921f8b004ad8cd05d9b1161587a02c0348d9b7d3

5 years agoCert for HAL adapter
Hansong Zhang [Mon, 8 Apr 2019 23:18:21 +0000 (16:18 -0700)]
Cert for HAL adapter

Introducing cert framework and a simple test case for HCI HAL
transportation adapter

Test-prerequisite: gRPC python. Install from pip
(https://grpc.io/blog/installation)

Test: 1. start HCI rootcanal or HIDL transport
      $ANDROID_HOST_OUT/nativetest64/root-canal/root-canal
      2. start stack with facade
      $ANDROID_HOST_OUT/bin/stack_with_facade
      3. run a simple test case
      $ANDROID_HOST_OUT/nativetest64/bluetooth_cert_test/bluetooth_cert_test

Or: One-liner: python cert/run_cert.py

Change-Id: I3cf2f54605ce2709d1c149b1221dedc8dc5dca92

5 years agoPDL: Use underscores for field names
Myles Watson [Mon, 22 Apr 2019 21:16:41 +0000 (14:16 -0700)]
PDL: Use underscores for field names

field_name : FieldType,

Test: bluetooth_packet_parser_test
Change-Id: I3b6d673111c7c4d7b5814563b132a3b48d3fdfcf

5 years agoRoot-canal: Add missing payload size field to loopback evt
Hansong Zhang [Tue, 23 Apr 2019 20:06:52 +0000 (13:06 -0700)]
Root-canal: Add missing payload size field to loopback evt

Bug: 131168063
Test: 1. Download AOSP CL929617 and 948661
      2. mma. Run python cert/run_cert.py
      3. Check btsnoop log

Change-Id: I1e31a1323f4aa8cb549af7545029b9d21eaabe9c

5 years agoDO NOT MERGE Don't persist bonds using sample LTK
Jakub Pawlowski [Tue, 23 Apr 2019 18:55:18 +0000 (11:55 -0700)]
DO NOT MERGE Don't persist bonds using sample LTK
am: 5ae23a59e8

Change-Id: I836bb075dc622b8b2779c4a2706b928f2b36a00b

5 years agoDO NOT MERGE Don't persist bonds using sample LTK
Jakub Pawlowski [Mon, 11 Mar 2019 18:22:01 +0000 (19:22 +0100)]
DO NOT MERGE Don't persist bonds using sample LTK

Test: compilation, manual testing
Bug: 128437297
Change-Id: I52fd484d42bf87e96dbc9e6456090f231ed48111

5 years ago[automerger skipped] Merge "HFP: Fix null pointer dereference in bta_ag_codec_negotia...
Ray Kuo [Tue, 23 Apr 2019 01:54:34 +0000 (18:54 -0700)]
[automerger skipped] Merge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()." into qt-dev
am: f2fec6a5cd -s ours
am skip reason: change_id I28d90823340d8721ee2349d3f55f07d1e823fee3 with SHA1 da2ca6a40f is in history

Change-Id: I2cb7dd72182a839ffab91af6e361846022c4b08c

5 years ago[automerger skipped] Merge "Use GATT_WRITE_NO_RSP for "state change" updates" into...
Weichin Weng [Tue, 23 Apr 2019 01:28:48 +0000 (18:28 -0700)]
[automerger skipped] Merge "Use GATT_WRITE_NO_RSP for "state change" updates" into qt-dev
am: a19d137829 -s ours
am skip reason: change_id I55e9b4b0b8c76412e5810e1cec5d96819527d099 with SHA1 3bf4b087a8 is in history

Change-Id: I8e80f7ae94f6789130c3c9b6a121a703f02f8f20

5 years agoMerge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()." into qt-dev
TreeHugger Robot [Tue, 23 Apr 2019 01:24:26 +0000 (01:24 +0000)]
Merge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()." into qt-dev

5 years agoTEST: Fix net_test_stock_rfcomm unit test
Jack He [Tue, 23 Apr 2019 01:21:40 +0000 (18:21 -0700)]
TEST: Fix net_test_stock_rfcomm unit test
am: 1b9c2af1fc

Change-Id: Id6bfe19de739f53212637364b2f00bf2048494e1

5 years agoMerge "Use GATT_WRITE_NO_RSP for "state change" updates" into qt-dev
Weichin Weng [Tue, 23 Apr 2019 00:24:21 +0000 (00:24 +0000)]
Merge "Use GATT_WRITE_NO_RSP for "state change" updates" into qt-dev

5 years agoCall gatt_disconnect if the LE connection is not established and no APP use it.
weichinweng [Mon, 25 Mar 2019 05:51:10 +0000 (13:51 +0800)]
Call gatt_disconnect if the LE connection is not established and no APP use it.

When the LE connection hold APP is removed, if the LE connection is not
established and no APP use it, we never free transport control block
(p_tcb) or close it. For BLE device that have not established and no APP
use it, will call gatt_disconnect to free p_tcb and go to close state.

Bug: 127908699
Test: GattConnectTest
Change-Id: Ifed10c67141cb4c9221478db759c5614714fff30
Merged-In: Ifed10c67141cb4c9221478db759c5614714fff30

5 years agoTEST: Fix net_test_stock_rfcomm unit test
Jack He [Sun, 21 Apr 2019 00:01:53 +0000 (17:01 -0700)]
TEST: Fix net_test_stock_rfcomm unit test

* Properly mock updated L2CAP registeration method by including the
  filtered btsnoop option
* Properly mock btsnoop module by creating a separate file to link with
  the test executable

Fixes: 123361801
Test: atest net_test_stack_rfcomm
Change-Id: I89ca875cbcc941feddd7c501fa1b7e14f8d14794

5 years agoMerge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()." am: 8eb55ba33a
Ray Kuo [Fri, 19 Apr 2019 14:10:57 +0000 (07:10 -0700)]
Merge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()." am: 8eb55ba33a
am: 6423e26b6a

Change-Id: Ib500c95268919c3efee1240bb766f2d08f364c23

5 years agoMerge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()."
Ray Kuo [Fri, 19 Apr 2019 14:05:51 +0000 (07:05 -0700)]
Merge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()."
am: 8eb55ba33a

Change-Id: I61e73aa166442ac881459f4eeda56491c7ecf54b

5 years agoMerge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()."
Treehugger Robot [Fri, 19 Apr 2019 13:54:34 +0000 (13:54 +0000)]
Merge "HFP: Fix null pointer dereference in bta_ag_codec_negotiate()."

5 years agoHFP: Fix null pointer dereference in bta_ag_codec_negotiate().
Ray Kuo [Tue, 16 Apr 2019 13:36:23 +0000 (21:36 +0800)]
HFP: Fix null pointer dereference in bta_ag_codec_negotiate().

BTM_ReadRemoteFeatures function will return NULL if ACL link to the remote
device is disconnected. Need to check whether p_rem_feat is nullptr
before dereferencing it.

Bug: 129736080
Test: make, force BTM_ReadRemoteFeatures() to return null and perform
MT/MO call tests.

Change-Id: I28d90823340d8721ee2349d3f55f07d1e823fee3
Merged-In: I28d90823340d8721ee2349d3f55f07d1e823fee3

5 years agoCall gatt_disconnect if the LE connection is not established and no APP use it. am...
weichinweng [Fri, 19 Apr 2019 11:53:08 +0000 (04:53 -0700)]
Call gatt_disconnect if the LE connection is not established and no APP use it. am: c04984def6
am: 4bbd21854f

Change-Id: I919f50da1fe3936d3fc880c0b9f6707ee8b0d776

5 years agoCall gatt_disconnect if the LE connection is not established and no APP use it.
weichinweng [Fri, 19 Apr 2019 11:48:02 +0000 (04:48 -0700)]
Call gatt_disconnect if the LE connection is not established and no APP use it.
am: c04984def6

Change-Id: Ic4547081033a5f37124094ec822e3e4e14403e9f

5 years agoCall gatt_disconnect if the LE connection is not established and no APP use it.
weichinweng [Mon, 25 Mar 2019 05:51:10 +0000 (13:51 +0800)]
Call gatt_disconnect if the LE connection is not established and no APP use it.

When the LE connection hold APP is removed, if the LE connection is not
established and no APP use it, we never free transport control block
(p_tcb) or close it. For BLE device that have not established and no APP
use it, will call gatt_disconnect to free p_tcb and go to close state.

Bug: 127908699
Test: GattConnectTest
Change-Id: Ifed10c67141cb4c9221478db759c5614714fff30

5 years agoMerge "btif: Short circuit NIAP key attestation check" into qt-dev
Martin Brabham [Fri, 19 Apr 2019 04:07:35 +0000 (21:07 -0700)]
Merge "btif: Short circuit NIAP key attestation check" into qt-dev
am: c12e92e84e

Change-Id: Ide66bf81d299c8ac422741ddbd2fbf383a1aa9cf

5 years agoMerge "Use GATT_WRITE_NO_RSP for "state change" updates" am: a61ee1ba8a
weichinweng [Fri, 19 Apr 2019 03:55:51 +0000 (20:55 -0700)]
Merge "Use GATT_WRITE_NO_RSP for "state change" updates" am: a61ee1ba8a
am: b676616f23

Change-Id: I3d97167049a1cce33d7d26b655ed1dca2c6c69ee

5 years agoMerge "Use GATT_WRITE_NO_RSP for "state change" updates"
weichinweng [Fri, 19 Apr 2019 03:49:44 +0000 (20:49 -0700)]
Merge "Use GATT_WRITE_NO_RSP for "state change" updates"
am: a61ee1ba8a

Change-Id: I653082394e8cb744cbe7eb2b85ad641e0dd73b18

5 years agoMerge "btif: Short circuit NIAP key attestation check" into qt-dev
TreeHugger Robot [Fri, 19 Apr 2019 03:46:23 +0000 (03:46 +0000)]
Merge "btif: Short circuit NIAP key attestation check" into qt-dev

5 years agoMerge "Use GATT_WRITE_NO_RSP for "state change" updates"
Treehugger Robot [Fri, 19 Apr 2019 03:36:29 +0000 (03:36 +0000)]
Merge "Use GATT_WRITE_NO_RSP for "state change" updates"

5 years agoMerge "HCI: Use fixed-width types" am: 81aa71744a
Myles Watson [Fri, 19 Apr 2019 02:45:31 +0000 (19:45 -0700)]
Merge "HCI: Use fixed-width types" am: 81aa71744a
am: 7dea65e3e2

Change-Id: I599d00fd1500e6d5cbe261e236a9b62b96fb5894

5 years agoMerge "HCI: Use fixed-width types"
Myles Watson [Fri, 19 Apr 2019 02:40:27 +0000 (19:40 -0700)]
Merge "HCI: Use fixed-width types"
am: 81aa71744a

Change-Id: Iabb16df2d3dc46067ab919fd05137a6cabc56552

5 years agoMerge "Revert "DO NOT MERGE: osi: Offload mutex pointer to local scope"" into qt-dev
Zach Johnson [Fri, 19 Apr 2019 02:37:08 +0000 (19:37 -0700)]
Merge "Revert "DO NOT MERGE: osi: Offload mutex pointer to local scope"" into qt-dev
am: ed47259e9b

Change-Id: Ic95e37525a282e3ff13c57d752f1d28cfa7a1ecd

5 years agoMerge "HCI: Use fixed-width types"
Treehugger Robot [Fri, 19 Apr 2019 02:34:30 +0000 (02:34 +0000)]
Merge "HCI: Use fixed-width types"

5 years agoMerge changes I321e12bf,If7e6e586,Ie145d1dd am: 0c9c1fca6f
Myles Watson [Fri, 19 Apr 2019 02:27:00 +0000 (19:27 -0700)]
Merge changes I321e12bf,If7e6e586,Ie145d1dd am: 0c9c1fca6f
am: 542b848068

Change-Id: Ia3c9f733fa8a5f167fa4834425a569d0b2e4344b

5 years agoMerge changes I321e12bf,If7e6e586,Ie145d1dd
Myles Watson [Fri, 19 Apr 2019 02:17:03 +0000 (19:17 -0700)]
Merge changes I321e12bf,If7e6e586,Ie145d1dd
am: 0c9c1fca6f

Change-Id: I287cfb4e5e0150c4690a2b988ff931d13a60d4de

5 years agoMerge "Revert "DO NOT MERGE: osi: Offload mutex pointer to local scope"" into qt-dev
Zach Johnson [Fri, 19 Apr 2019 02:01:29 +0000 (02:01 +0000)]
Merge "Revert "DO NOT MERGE: osi: Offload mutex pointer to local scope"" into qt-dev

5 years agoRevert "DO NOT MERGE: osi: Offload mutex pointer to local scope"
Zach Johnson [Fri, 19 Apr 2019 01:59:54 +0000 (01:59 +0000)]
Revert "DO NOT MERGE: osi: Offload mutex pointer to local scope"

This reverts commit 15529d316435ae977d3d578faa382bc1af89e787.

Reason for revert: causes crash at ToT

Bug: 130840078
Change-Id: Iee8a968afe385fff35f9db4e3a628f0592ee9a5b

5 years agoMerge changes I321e12bf,If7e6e586,Ie145d1dd
Treehugger Robot [Fri, 19 Apr 2019 02:00:31 +0000 (02:00 +0000)]
Merge changes I321e12bf,If7e6e586,Ie145d1dd

* changes:
  l2cap: Add FCS support
  packet/parser: Add tests for payload size modifier
  packet/parser: Add Checksum support

5 years agoMerge "rootcanal: Check return values from callbacks" am: 5baca4a9e1
Myles Watson [Fri, 19 Apr 2019 01:08:09 +0000 (18:08 -0700)]
Merge "rootcanal: Check return values from callbacks" am: 5baca4a9e1
am: 8b7a98258f

Change-Id: I0c5c8c5182b508b67968c3c5c078a5f2bbebc260

5 years agoUse GATT_WRITE_NO_RSP for "state change" updates
weichinweng [Wed, 17 Apr 2019 07:52:07 +0000 (15:52 +0800)]
Use GATT_WRITE_NO_RSP for "state change" updates

For Hearing Aid, replaces the GATT_WRITE with GATT_WRITE_NO_RSP for the
"state change" updates that are send to the devices. Using no response
write is faster and these informational updates does not need a
confirmation from the devices.

Bug: 130332748
Test: 1.run unit test
2.Forget/Repair HearingAid device from Bluetooth UI.
3.Disconnect/Reconnect HearingAid device from Bluetooth UI.
4.HearingAid device power off/on, check them can reconnect.
5.Multiple click connect/disconnect from Bluetooth UI within 1 sec,
check them can reconnect.
6.One side HearingAid device power off/on when playing music, check it
can reconnect and music is work fine.

Change-Id: I55e9b4b0b8c76412e5810e1cec5d96819527d099
Merged-In: I55e9b4b0b8c76412e5810e1cec5d96819527d099

5 years agoMerge "rootcanal: Check return values from callbacks"
Myles Watson [Fri, 19 Apr 2019 00:47:58 +0000 (17:47 -0700)]
Merge "rootcanal: Check return values from callbacks"
am: 5baca4a9e1

Change-Id: I9806a40a3ceb043ecfd8c6bfad757cc8a18b93e5

5 years agoUse GATT_WRITE_NO_RSP for "state change" updates
weichinweng [Wed, 17 Apr 2019 07:52:07 +0000 (15:52 +0800)]
Use GATT_WRITE_NO_RSP for "state change" updates

For Hearing Aid, replaces the GATT_WRITE with GATT_WRITE_NO_RSP for the
"state change" updates that are send to the devices. Using no response
write is faster and these informational updates does not need a
confirmation from the devices.

Bug: 130332748
Test: 1.run unit test
2.Forget/Repair HearingAid device from Bluetooth UI.
3.Disconnect/Reconnect HearingAid device from Bluetooth UI.
4.HearingAid device power off/on, check them can reconnect.
5.Multiple click connect/disconnect from Bluetooth UI within 1 sec,
check them can reconnect.
6.One side HearingAid device power off/on when playing music, check it
can reconnect and music is work fine.

Change-Id: I55e9b4b0b8c76412e5810e1cec5d96819527d099

5 years agoMerge "rootcanal: Check return values from callbacks"
Treehugger Robot [Fri, 19 Apr 2019 00:28:28 +0000 (00:28 +0000)]
Merge "rootcanal: Check return values from callbacks"

5 years agoHCI: Use fixed-width types
Myles Watson [Fri, 12 Apr 2019 17:40:43 +0000 (10:40 -0700)]
HCI: Use fixed-width types

Test: run bluetooth_test_gd
Change-Id: I9a9ef272d92635d7d56b8515a1889b7922ea3b87

5 years agoMerge "DO NOT MERGE: osi: Offload mutex pointer to local scope" into qt-dev
Martin Brabham [Thu, 18 Apr 2019 22:07:44 +0000 (15:07 -0700)]
Merge "DO NOT MERGE: osi: Offload mutex pointer to local scope" into qt-dev
am: a57d08524b

Change-Id: I83fd01a4d52d5e84095fb52dd7000cdce2232adf

5 years agol2cap: Add FCS support
Myles Watson [Wed, 17 Apr 2019 00:05:10 +0000 (17:05 -0700)]
l2cap: Add FCS support

Test: bluetooth_gd_test --gtest_filter=*Fcs*
Change-Id: I321e12bfb3ec8b5652d26d2b2e5066dc6a80895c

5 years agopacket/parser: Add tests for payload size modifier
Myles Watson [Wed, 17 Apr 2019 23:17:56 +0000 (16:17 -0700)]
packet/parser: Add tests for payload size modifier

Test: bluetooth_packet_parser_test --gtest_filter=*SizeMod*
Change-Id: If7e6e586477e6580adc540127f82500642658aea

5 years agoBitInserter: Add byte observer for checksums am: afafb32eb7
Myles Watson [Thu, 18 Apr 2019 21:49:23 +0000 (14:49 -0700)]
BitInserter: Add byte observer for checksums am: afafb32eb7
am: a5672e4897

Change-Id: I8cf6445f41f3c1af6c8f223c8397ba42a296e8aa

5 years agoBitInserter: Add byte observer for checksums
Myles Watson [Thu, 18 Apr 2019 21:42:03 +0000 (14:42 -0700)]
BitInserter: Add byte observer for checksums
am: afafb32eb7

Change-Id: If4c71d919a302df6b56c8ad2187ca40abb250c45

5 years agopacket/parser: Add Checksum support
Myles Watson [Thu, 18 Apr 2019 16:09:01 +0000 (09:09 -0700)]
packet/parser: Add Checksum support

Make TypeDef represent Enum, Custom, and Checksum types.
Add SimpleSum as a test checksum.

Test: bluetooth_test_gd --gtest_filter=*SimpleSum*
Change-Id: Ie145d1dd17a710b50e98de8714102945b3c65c99

5 years agobtif: Short circuit NIAP key attestation check
Martin Brabham [Mon, 15 Apr 2019 21:14:54 +0000 (14:14 -0700)]
btif: Short circuit NIAP key attestation check

Ensure the check always passes so bluetooth is stable.
There is a vendor code issue with keymaster having random HAL errors (-1).
Revert this change after the keystore issues are resolved.
b/130045583
b/130163310

Bug: 129759834
Test: atest net_test_btif
Change-Id: I65c13eb4638799ca73bc2d3d8d07cdf14a8624c7

5 years agoMerge "DO NOT MERGE: osi: Offload mutex pointer to local scope" into qt-dev
TreeHugger Robot [Thu, 18 Apr 2019 21:15:08 +0000 (21:15 +0000)]
Merge "DO NOT MERGE: osi: Offload mutex pointer to local scope" into qt-dev

5 years agoBitInserter: Add byte observer for checksums
Myles Watson [Tue, 16 Apr 2019 17:24:26 +0000 (10:24 -0700)]
BitInserter: Add byte observer for checksums

Test: bluetooth_test_gd --gtest_filter=*BitInserter*
Change-Id: I9ef5bc5951244279fc142127a5c3c9a54c4eaf5c

5 years agopacket: Support fixed-width custom types am: af1b2d152f
Myles Watson [Thu, 18 Apr 2019 14:20:59 +0000 (07:20 -0700)]
packet: Support fixed-width custom types am: af1b2d152f
am: 422d3f38b4

Change-Id: I999131e50c4296aa11698ad69af43d365aa95ccc

5 years agopacket: Support fixed-width custom types
Myles Watson [Thu, 18 Apr 2019 14:16:56 +0000 (07:16 -0700)]
packet: Support fixed-width custom types
am: af1b2d152f

Change-Id: I62a9d400acc11c43fd7aa09b40534eecfa294eb1