OSDN Git Service

pg-rex/syncrep.git
15 years agoAdd refentrytitle elements to refentry pages. Their absence confused the
Peter Eisentraut [Wed, 12 Nov 2008 15:52:44 +0000 (15:52 +0000)]
Add refentrytitle elements to refentry pages.  Their absence confused the
man page tools somewhat.

15 years agoDo not use ICONST/SCONST in rules other than Iconst/Sconst.
Michael Meskes [Wed, 12 Nov 2008 15:50:20 +0000 (15:50 +0000)]
Do not use ICONST/SCONST in rules other than Iconst/Sconst.

15 years agoSupport of multibyte encoding for pg_trgm
Teodor Sigaev [Wed, 12 Nov 2008 13:43:54 +0000 (13:43 +0000)]
Support of multibyte encoding for pg_trgm

15 years agoIf we're going to use a SQL function for this, at least make it schema-proof.
Tom Lane [Wed, 12 Nov 2008 13:38:04 +0000 (13:38 +0000)]
If we're going to use a SQL function for this, at least make it schema-proof.

15 years agoarray_length() function, and for SQL compatibility also cardinality()
Peter Eisentraut [Wed, 12 Nov 2008 13:09:28 +0000 (13:09 +0000)]
array_length() function, and for SQL compatibility also cardinality()
function as a special case.

This version still has the suspicious behavior of returning null for an
empty array (rather than zero), but this may need a wholesale revision of
empty array behavior, currently under discussion.

Jim Nasby, Robert Haas, Peter Eisentraut

15 years agoFix off-by-one error in autovacuum shmem struct sizing. This could lead to
Heikki Linnakangas [Wed, 12 Nov 2008 10:10:32 +0000 (10:10 +0000)]
Fix off-by-one error in autovacuum shmem struct sizing. This could lead to
autovacuum worker sending SIGUSR1 signal to wrong process, per Zou Yong's
report.

Backpatch to 8.3.

15 years agoClean up the ancient decision to show only two fractional-seconds digits
Tom Lane [Wed, 12 Nov 2008 01:36:20 +0000 (01:36 +0000)]
Clean up the ancient decision to show only two fractional-seconds digits
in "postgres_verbose" intervalstyle, and the equally arbitrary decision to
show at least two fractional-seconds digits in most other datetime display
styles.  This results in some minor changes in the expected regression test
outputs.

Also, coalesce a lot of repetitive code in datetime.c into subroutines,
for clarity and ease of maintenance.  In particular this roughly halves
the number of #ifdef HAVE_INT64_TIMESTAMP segments.

Ron Mayer, with some additional kibitzing from Tom Lane

15 years agoDetect and error out on inability to get proper linkage information required for...
Andrew Dunstan [Wed, 12 Nov 2008 00:00:05 +0000 (00:00 +0000)]
Detect and error out on inability to get proper linkage information required for plperl, usually due to absence of perl ExtUtils::Embed module. Backpatch as far as 8.1.

15 years agoMention the tup_fetched column in pg_stat_database.
Magnus Hagander [Tue, 11 Nov 2008 20:06:21 +0000 (20:06 +0000)]
Mention the tup_fetched column in pg_stat_database.

Greg Sabino Mullane

15 years agoEnsure that the phrels sets of PlaceHolderVars appearing in an AppendRelInfo's
Tom Lane [Tue, 11 Nov 2008 19:05:21 +0000 (19:05 +0000)]
Ensure that the phrels sets of PlaceHolderVars appearing in an AppendRelInfo's
translated_vars list get updated when pulling up an appendrel member.  It's
not clear that this really matters at present, since relatively little gets
done with the outputs of an appendrel child relation; but it probably will
come back to bite us sometime if we leave them with the wrong values.

15 years agoGet rid of adjust_appendrel_attr_needed(), which has been broken ever since
Tom Lane [Tue, 11 Nov 2008 18:13:32 +0000 (18:13 +0000)]
Get rid of adjust_appendrel_attr_needed(), which has been broken ever since
we extended the appendrel mechanism to support UNION ALL optimization.  The
reason nobody noticed was that we are not actually using attr_needed data for
appendrel children; hence it seems more reasonable to rip it out than fix it.
Back-patch to 8.2 because an Assert failure is possible in corner cases.
Per examination of an example from Jim Nasby.

In HEAD, also get rid of AppendRelInfo.col_mappings, which is quite inadequate
to represent UNION ALL situations; depend entirely on translated_vars instead.

15 years agoMake psql report "SSL connection (unknown cipher)" when libpq has set
Magnus Hagander [Tue, 11 Nov 2008 15:01:53 +0000 (15:01 +0000)]
Make psql report "SSL connection (unknown cipher)" when libpq has set
up a SSL connection, but psql is compiled without support for it.

Not a really realistic use-case, but the patch also cuts down on
the number of places with #ifdef's...

15 years agoFix sloppy omission of now-required #include's.
Tom Lane [Tue, 11 Nov 2008 14:17:02 +0000 (14:17 +0000)]
Fix sloppy omission of now-required #include's.

15 years agoChange error messages to print the physical path, like
Heikki Linnakangas [Tue, 11 Nov 2008 13:19:16 +0000 (13:19 +0000)]
Change error messages to print the physical path, like
"base/11517/3767_fsm", instead of symbolic names like "1663/11517/3767/1",
per Alvaro's suggestion. I didn't change the messages in the higher-level
index, heap and FSM routines, though, where the fork is implicit.

15 years agoReplaced manually synced preproc.y by the one created by the new script.
Michael Meskes [Tue, 11 Nov 2008 11:41:24 +0000 (11:41 +0000)]
Replaced manually synced preproc.y by the one created by the new script.
Adapted regression test files accordingly.

15 years agoAdd an explicit caution about how to use pg_do_encoding_conversion with
Tom Lane [Tue, 11 Nov 2008 03:01:20 +0000 (03:01 +0000)]
Add an explicit caution about how to use pg_do_encoding_conversion with
non-null-terminated input.  Per discussion with ITAGAKI Takahiro.

15 years agoAdd support for input and output of interval values formatted per ISO 8601;
Tom Lane [Tue, 11 Nov 2008 02:42:33 +0000 (02:42 +0000)]
Add support for input and output of interval values formatted per ISO 8601;
specifically, we can input either the "format with designators" or the
"alternative format", and we can output the former when IntervalStyle is set
to iso_8601.

Ron Mayer

15 years agoFix a case of string building.
Alvaro Herrera [Mon, 10 Nov 2008 21:49:16 +0000 (21:49 +0000)]
Fix a case of string building.

15 years agoFix bugs in sqlchar_to_unicode and unicode_to_sqlchar: both were measuring
Tom Lane [Mon, 10 Nov 2008 18:02:20 +0000 (18:02 +0000)]
Fix bugs in sqlchar_to_unicode and unicode_to_sqlchar: both were measuring
the length of a UTF8 character with pg_mblen (wrong if DB encoding isn't
UTF8), and the latter was blithely assuming that a static buffer would somehow
revert to all zeroes for each use.

15 years agoFix 'Q' format char parsing in the new to_timestamp() code. Used to crash.
Heikki Linnakangas [Mon, 10 Nov 2008 17:36:53 +0000 (17:36 +0000)]
Fix 'Q' format char parsing in the new to_timestamp() code. Used to crash.

15 years agoAdd a --locale switch to createdb, to ease the creation of databases with
Alvaro Herrera [Mon, 10 Nov 2008 16:25:41 +0000 (16:25 +0000)]
Add a --locale switch to createdb, to ease the creation of databases with
different locales.  This is just syntactical sweetener over --lc-collate and
--lc-ctype.  Per discussion.

While at it, properly document --lc-ctype and --lc-collate in SGML docs,
which apparently were forgotten (or purposefully ommited?) when they were
created.

15 years agopg_do_encoding_conversion cannot return NULL (at least not unless the input
Tom Lane [Mon, 10 Nov 2008 15:18:40 +0000 (15:18 +0000)]
pg_do_encoding_conversion cannot return NULL (at least not unless the input
is NULL), so remove some useless tests for the case.

15 years agoFix old bug in contrib/sslinfo: X509_NAME_to_text freed the BIO_s_mem buffer
Tom Lane [Mon, 10 Nov 2008 14:57:38 +0000 (14:57 +0000)]
Fix old bug in contrib/sslinfo: X509_NAME_to_text freed the BIO_s_mem buffer
it was using too soon.  In a situation where pg_do_encoding_conversion is
a no-op, this led to garbage data returned.

In HEAD, also modify the code that's ensuring null termination to make it
a tad more obvious what's happening.

15 years agoMake relhasrules and relhastriggers work like relhasindex, namely we let
Tom Lane [Mon, 10 Nov 2008 00:49:37 +0000 (00:49 +0000)]
Make relhasrules and relhastriggers work like relhasindex, namely we let
VACUUM reset them to false rather than trying to clean 'em up during DROP.

15 years agoReplace pg_class.reltriggers with relhastriggers, which is just a boolean hint
Tom Lane [Sun, 9 Nov 2008 21:24:33 +0000 (21:24 +0000)]
Replace pg_class.reltriggers with relhastriggers, which is just a boolean hint
("there might be triggers") rather than an exact count.  This is necessary
catalog infrastructure for the upcoming patch to reduce the strength of
locking needed for trigger addition/removal.  Split out and committed
separately for ease of reviewing/testing.

In passing, also get rid of the unused pg_class columns relukeys, relfkeys,
and relrefs, which haven't been maintained in many years and now have no
chance of ever being maintained (because of wishing to avoid locking).

Simon Riggs

15 years agoAdd a startup check that pg_xlog and pg_xlog/archive_status exist.
Tom Lane [Sun, 9 Nov 2008 17:51:15 +0000 (17:51 +0000)]
Add a startup check that pg_xlog and pg_xlog/archive_status exist.
If the latter doesn't exist, automatically recreate it.  (We don't do
this for pg_xlog, though, per discussion.)

Jonah Harris

15 years agoAdd some documentation about handling of fractions in interval input.
Tom Lane [Sun, 9 Nov 2008 17:09:48 +0000 (17:09 +0000)]
Add some documentation about handling of fractions in interval input.
(It's always worked like this, but we never documented it before.)

15 years agoAdd a new GUC variable called "IntervalStyle" that decouples interval output
Tom Lane [Sun, 9 Nov 2008 00:28:35 +0000 (00:28 +0000)]
Add a new GUC variable called "IntervalStyle" that decouples interval output
from DateStyle, and create a new interval style that produces output matching
the SQL standard (at least for interval values that fall within the standard's
restrictions).  IntervalStyle is also used to resolve the conflict between the
standard and traditional Postgres rules for interpreting negative interval
input.

Ron Mayer

15 years agoFix recently added code for SQL years-months interval syntax so that
Tom Lane [Sat, 8 Nov 2008 20:51:49 +0000 (20:51 +0000)]
Fix recently added code for SQL years-months interval syntax so that
it behaves correctly for a leading minus sign, zero year value, and
nonzero month value.  Per discussion with Ron Mayer.

15 years agoAdd some more citext test cases, per David Wheeler. Also remove the
Tom Lane [Fri, 7 Nov 2008 23:17:30 +0000 (23:17 +0000)]
Add some more citext test cases, per David Wheeler.  Also remove the
citext-to-and-from-xml tests, since those caused variation between
installations with or without libxml without really proving much.  Instead
repurpose citext_1.out as the expected results in glibc en_US (and probably
other) locales.

15 years agoImprove documentation of pg_typeof, per gripe from David Wheeler.
Tom Lane [Fri, 7 Nov 2008 22:54:41 +0000 (22:54 +0000)]
Improve documentation of pg_typeof, per gripe from David Wheeler.

15 years agoImplement ALTER DATABASE SET TABLESPACE to move a whole database (or at least
Tom Lane [Fri, 7 Nov 2008 18:25:07 +0000 (18:25 +0000)]
Implement ALTER DATABASE SET TABLESPACE to move a whole database (or at least
as much of it as lives in its default tablespace) to a new tablespace.

Guillaume Lelarge, with some help from Bernd Helmle and Tom Lane

15 years agoImprove bulk-insert performance by keeping the current target buffer pinned
Tom Lane [Thu, 6 Nov 2008 20:51:15 +0000 (20:51 +0000)]
Improve bulk-insert performance by keeping the current target buffer pinned
(but not locked, as that would risk deadlocks).  Also, make it work in a small
ring of buffers to avoid having bulk inserts trash the whole buffer arena.

Robert Haas, after an idea of Simon Riggs'.

15 years agoImprove psql's \dC command to take a pattern parameter. Casts are shown
Tom Lane [Thu, 6 Nov 2008 15:18:36 +0000 (15:18 +0000)]
Improve psql's \dC command to take a pattern parameter.  Casts are shown
if their source or target types match the pattern (using the same definition
of "match" as \dT does).  Per recent discussion.

15 years agoThe logic in systable_beginscan to translate heap attribute numbers to
Heikki Linnakangas [Thu, 6 Nov 2008 13:07:08 +0000 (13:07 +0000)]
The logic in systable_beginscan to translate heap attribute numbers to
index column numbers needs to handle the case where you have more than
one scankey on the same index column. toast_fetch_datum_slice() needs it.

15 years agoThis maneuver really requires a comment ...
Tom Lane [Wed, 5 Nov 2008 20:17:18 +0000 (20:17 +0000)]
This maneuver really requires a comment ...

15 years agochange fix for suppress_redundant_updates_trigger() where relation has Oids, to only...
Andrew Dunstan [Wed, 5 Nov 2008 19:15:15 +0000 (19:15 +0000)]
change fix for suppress_redundant_updates_trigger() where relation has Oids, to only apply if present Oid is invalid, per second thought from TGL

15 years agofix suppress_redundant_updates_trigger() where relation has Oids, per gripe from...
Andrew Dunstan [Wed, 5 Nov 2008 18:49:28 +0000 (18:49 +0000)]
fix suppress_redundant_updates_trigger() where relation has Oids, per gripe from KaiGai Kohei

15 years agoA few additional test cases for array functionality
Peter Eisentraut [Wed, 5 Nov 2008 12:27:09 +0000 (12:27 +0000)]
A few additional test cases for array functionality

15 years agoRename several aliases for PLpgSQL_datum.dno to also be called dno.
Tom Lane [Wed, 5 Nov 2008 00:07:54 +0000 (00:07 +0000)]
Rename several aliases for PLpgSQL_datum.dno to also be called dno.
Hopefully this will forestall future confusion about their roles.

Jonah Harris

15 years agoDocument that SSL is only possible on tcp/ip connections in the
Bruce Momjian [Tue, 4 Nov 2008 22:40:40 +0000 (22:40 +0000)]
Document that SSL is only possible on tcp/ip connections in the
postgresql.conf 'ssl' section.

15 years agoDocument that 'sslmode' is ignored for Unix domain socket communication;
Bruce Momjian [Tue, 4 Nov 2008 22:36:07 +0000 (22:36 +0000)]
Document that 'sslmode' is ignored for Unix domain socket communication;
backpatch to 8.3.X.

15 years agoRevert unwanted patch, per Tom.
Alvaro Herrera [Tue, 4 Nov 2008 21:00:15 +0000 (21:00 +0000)]
Revert unwanted patch, per Tom.

15 years agoRemove unused rfno from PLpgSQL_recfield
Alvaro Herrera [Tue, 4 Nov 2008 20:58:46 +0000 (20:58 +0000)]
Remove unused rfno from PLpgSQL_recfield

Jonah Harris

15 years agoFix bug introduced in recent patch to make plpython cope with OUT arguments:
Tom Lane [Tue, 4 Nov 2008 15:16:48 +0000 (15:16 +0000)]
Fix bug introduced in recent patch to make plpython cope with OUT arguments:
the proc->argnames array has to be initialized to zero immediately on creation,
since the error recovery path will try to free its elements.

15 years agoExperimental new support for building man pages via docbook2x, an XSL-based
Peter Eisentraut [Tue, 4 Nov 2008 14:58:22 +0000 (14:58 +0000)]
Experimental new support for building man pages via docbook2x, an XSL-based
tool chain.  With some polishing, this might help us get rid of our ancient
and crufty man page build mechanism.

15 years agoADD array_ndims function
Peter Eisentraut [Tue, 4 Nov 2008 14:49:12 +0000 (14:49 +0000)]
ADD array_ndims function

Author: Robert Haas <robertmhaas@gmail.com>

15 years agoFix compiler warning about uninitialized variable
Peter Eisentraut [Tue, 4 Nov 2008 11:04:06 +0000 (11:04 +0000)]
Fix compiler warning about uninitialized variable

15 years agoAdd missing colon to docs.
Bruce Momjian [Tue, 4 Nov 2008 04:18:50 +0000 (04:18 +0000)]
Add missing colon to docs.

15 years agoRemove tabs from SGML file.
Bruce Momjian [Tue, 4 Nov 2008 00:59:45 +0000 (00:59 +0000)]
Remove tabs from SGML file.

15 years agoDisallow LOCK TABLE outside a transaction block (or function), since this case
Tom Lane [Tue, 4 Nov 2008 00:57:19 +0000 (00:57 +0000)]
Disallow LOCK TABLE outside a transaction block (or function), since this case
almost certainly represents user error.  Per a gripe from Sebastian Böhm
and subsequent discussion.

15 years agoFix compiler warnings (including a seriously bogus elog call); minor
Tom Lane [Tue, 4 Nov 2008 00:29:39 +0000 (00:29 +0000)]
Fix compiler warnings (including a seriously bogus elog call); minor
code beautification.

15 years agoUse bool for a boolean flag.
Tom Lane [Mon, 3 Nov 2008 23:49:07 +0000 (23:49 +0000)]
Use bool for a boolean flag.

15 years agoAllow uuid_in() to parse a wider variety of variant input formats for the UUID
Peter Eisentraut [Mon, 3 Nov 2008 22:14:40 +0000 (22:14 +0000)]
Allow uuid_in() to parse a wider variety of variant input formats for the UUID
data type.  This patch takes the approach of allowing an optional hyphen after
each group of four hex digits.

Author: Robert Haas <robertmhaas@gmail.com>

15 years agoDept of second thoughts: seems it'd be safer if pg_typeof is marked
Tom Lane [Mon, 3 Nov 2008 21:09:17 +0000 (21:09 +0000)]
Dept of second thoughts: seems it'd be safer if pg_typeof is marked
stable not immutable, since it depends on system catalog contents.

15 years agoClean up the messy semantics (not to mention inefficiency) of PageGetTempPage
Tom Lane [Mon, 3 Nov 2008 20:47:49 +0000 (20:47 +0000)]
Clean up the messy semantics (not to mention inefficiency) of PageGetTempPage
by splitting it into three functions with better-defined behaviors.

Zdenek Kotala

15 years agosuppress_redundant_updates_trigger function.
Andrew Dunstan [Mon, 3 Nov 2008 20:17:21 +0000 (20:17 +0000)]
suppress_redundant_updates_trigger function.

15 years agoFix silly typo in previous commit.
Alvaro Herrera [Mon, 3 Nov 2008 19:26:07 +0000 (19:26 +0000)]
Fix silly typo in previous commit.

15 years agoFix TransactionIdSetStatusBit so that it doesn't try to change a transaction
Alvaro Herrera [Mon, 3 Nov 2008 19:24:03 +0000 (19:24 +0000)]
Fix TransactionIdSetStatusBit so that it doesn't try to change a transaction
from COMMITTED to SUBCOMMITTED during recovery.  This wasn't previously
possible, but it is now due to the recent changes on clog commit protocol for
subtransactions.

Simon Riggs

15 years agoFix two error-recovery bugs in describeOneTableDetails(), and make the code
Tom Lane [Mon, 3 Nov 2008 19:08:56 +0000 (19:08 +0000)]
Fix two error-recovery bugs in describeOneTableDetails(), and make the code
to dump sequence values cope with sequences outside the search path and/or
having names that need quoting.  No back-patch needed because these are new
problems in 8.4.

Kris Jurka  (also a little bit of code beautification by tgl)

15 years agoReduce the acceptable staleness of pgstat data for autovacuum, per the
Alvaro Herrera [Mon, 3 Nov 2008 19:03:41 +0000 (19:03 +0000)]
Reduce the acceptable staleness of pgstat data for autovacuum, per the
longstanding note in the source that this patch removes.

15 years agoAdd pg_typeof() function.
Tom Lane [Mon, 3 Nov 2008 17:51:13 +0000 (17:51 +0000)]
Add pg_typeof() function.

Brendan Jurd

15 years agoSmall shell syntax improvement.
Bruce Momjian [Mon, 3 Nov 2008 15:56:47 +0000 (15:56 +0000)]
Small shell syntax improvement.

15 years agoUpdate URL to Docbook DSSSL stylesheets, per Gabriele Bartolini.
Alvaro Herrera [Mon, 3 Nov 2008 15:39:38 +0000 (15:39 +0000)]
Update URL to Docbook DSSSL stylesheets, per Gabriele Bartolini.

15 years agoFix mistakes in comment headers
Alvaro Herrera [Mon, 3 Nov 2008 15:10:17 +0000 (15:10 +0000)]
Fix mistakes in comment headers

15 years agoFix incorrect comment in SSL code
Magnus Hagander [Mon, 3 Nov 2008 14:18:57 +0000 (14:18 +0000)]
Fix incorrect comment in SSL code

15 years agoChange the pgstat logic so that the stats collector writes the stats file only
Tom Lane [Mon, 3 Nov 2008 01:17:08 +0000 (01:17 +0000)]
Change the pgstat logic so that the stats collector writes the stats file only
upon requests from backends, rather than on a fixed 500msec cycle.  (There's
still throttling logic to ensure it writes no more often than once per
500msec, though.)  This should result in a significant reduction in stats file
write traffic in typical scenarios where the stats are demanded only
infrequently.

This approach also means that the former difficulty with changing
stats_temp_directory on-the-fly has gone away, so remove the caution about
that as well as the thrashing we did to minimize the trouble window.

In passing, also fix pgstat_report_stat() so that we will send a stats
message if we have function call stats but not table stats to report;
this fixes a bug in the recent patch to support function-call stats.

Martin Pihlak

15 years agoRemove the last vestiges of the MAKE_PTR/MAKE_OFFSET mechanism. We haven't
Tom Lane [Sun, 2 Nov 2008 21:24:52 +0000 (21:24 +0000)]
Remove the last vestiges of the MAKE_PTR/MAKE_OFFSET mechanism.  We haven't
allowed different processes to have different addresses for the shmem segment
in quite a long time, but there were still a few places left that used the
old coding convention.  Clean them up to reduce confusion and improve the
compiler's ability to detect pointer type mismatches.

Kris Jurka

15 years agoRemove all uses of the deprecated functions heap_formtuple, heap_modifytuple,
Tom Lane [Sun, 2 Nov 2008 01:45:28 +0000 (01:45 +0000)]
Remove all uses of the deprecated functions heap_formtuple, heap_modifytuple,
and heap_deformtuple in favor of the newer functions heap_form_tuple et al
(which do the same things but use bool control flags instead of arbitrary
char values).  Eliminate the former duplicate coding of these functions,
reducing the deprecated functions to mere wrappers around the newer ones.
We can't get rid of them entirely because add-on modules probably still
contain many instances of the old coding style.

Kris Jurka

15 years agoMove from strcmp to strncmp to be more tolerant for changes to the parser.
Michael Meskes [Sat, 1 Nov 2008 19:53:35 +0000 (19:53 +0000)]
Move from strcmp to strncmp to be more tolerant for changes to the parser.

15 years agoUse string component in index structure.
Michael Meskes [Sat, 1 Nov 2008 12:42:14 +0000 (12:42 +0000)]
Use string component in index structure.

15 years agoDo not eat memory even in case of an out-of-memory error.
Michael Meskes [Sat, 1 Nov 2008 08:55:21 +0000 (08:55 +0000)]
Do not eat memory even in case of an out-of-memory error.

15 years agoSimplify ExecutorRun's API and save some trivial number of cycles by having
Tom Lane [Fri, 31 Oct 2008 21:07:55 +0000 (21:07 +0000)]
Simplify ExecutorRun's API and save some trivial number of cycles by having
it just return void instead of sometimes returning a TupleTableSlot.  SQL
functions don't need that anymore, and noplace else does either.  Eliminating
the return value also means one less hassle for the ExecutorRun hook functions
that will be supported beginning in 8.4.

15 years agoUpdate FSM on WAL replay. This is a bit limited; the FSM is only updated
Heikki Linnakangas [Fri, 31 Oct 2008 19:40:27 +0000 (19:40 +0000)]
Update FSM on WAL replay. This is a bit limited; the FSM is only updated
on non-full-page-image WAL records, and quite arbitrarily, only if there's
less than 20% free space on the page after the insert/update (not on HOT
updates, though). The 20% cutoff should avoid most of the overhead, when
replaying a bulk insertion, for example, while ensuring that pages that
are full are marked as full in the FSM.

This is mostly to avoid the nasty worst case scenario, where you replay
from a PITR archive, and the FSM information in the base backup is really
out of date. If there was a lot of pages that the outdated FSM claims to
have free space, but don't actually have any, the first unlucky inserter
after the recovery would traverse through all those pages, just to find
out that they're full. We didn't have this problem with the old FSM
implementation, because we simply threw the FSM information away on a
non-clean shutdown.

15 years agoAllow SQL-language functions to return the output of an INSERT/UPDATE/DELETE
Tom Lane [Fri, 31 Oct 2008 19:37:56 +0000 (19:37 +0000)]
Allow SQL-language functions to return the output of an INSERT/UPDATE/DELETE
RETURNING clause, not just a SELECT as formerly.

A side effect of this patch is that when a set-returning SQL function is used
in a FROM clause, performance is improved because the output is collected into
a tuplestore within the function, rather than using the less efficient
value-per-call mechanism.

15 years agoAdded missing ';'
Michael Meskes [Fri, 31 Oct 2008 16:36:13 +0000 (16:36 +0000)]
Added missing ';'

15 years agoUnite ReadBufferWithFork, ReadBufferWithStrategy, and ZeroOrReadBuffer
Heikki Linnakangas [Fri, 31 Oct 2008 15:05:00 +0000 (15:05 +0000)]
Unite ReadBufferWithFork, ReadBufferWithStrategy, and ZeroOrReadBuffer
functions into one ReadBufferExtended function, that takes the strategy
and mode as argument. There's three modes, RBM_NORMAL which is the default
used by plain ReadBuffer(), RBM_ZERO, which replaces ZeroOrReadBuffer, and
a new mode RBM_ZERO_ON_ERROR, which allows callers to read corrupt pages
without throwing an error. The FSM needs the new mode to recover from
corrupt pages, which could happend if we crash after extending an FSM file,
and the new page is "torn".

Add fork number to some error messages in bufmgr.c, that still lacked it.

15 years agoThe conversion rule from postgres.sgml to postgres.xml didn't work with
Peter Eisentraut [Fri, 31 Oct 2008 14:35:30 +0000 (14:35 +0000)]
The conversion rule from postgres.sgml to postgres.xml didn't work with
BSD sed.  So write it in Perl, which is more portable and a bit faster, too.
We already use Perl for standard documentation builds, so this imposes no
additional requirement.

15 years agoAdd test case for CREATE CAST.
Heikki Linnakangas [Fri, 31 Oct 2008 09:17:17 +0000 (09:17 +0000)]
Add test case for CREATE CAST.

15 years agoAdd support for user-defined I/O conversion casts.
Heikki Linnakangas [Fri, 31 Oct 2008 08:39:22 +0000 (08:39 +0000)]
Add support for user-defined I/O conversion casts.

15 years agoMessage improvement
Peter Eisentraut [Fri, 31 Oct 2008 07:15:11 +0000 (07:15 +0000)]
Message improvement
(also backported to 8.3)

15 years agoUpdate back-branch release notes.
Tom Lane [Thu, 30 Oct 2008 22:22:24 +0000 (22:22 +0000)]
Update back-branch release notes.

15 years agoRevert previous patch to put the shared memory segment on win32
Magnus Hagander [Thu, 30 Oct 2008 17:04:09 +0000 (17:04 +0000)]
Revert previous patch to put the shared memory segment on win32
in the Global\ namespace, because it caused permission errors on
a lot of platforms.

We need to come up with something better for 8.4, but for now
revert to the pre-8.3.4 behaviour.

15 years agoUpdate time zone data files to tzdata release 2008i (DST law changes in
Tom Lane [Thu, 30 Oct 2008 13:16:52 +0000 (13:16 +0000)]
Update time zone data files to tzdata release 2008i (DST law changes in
Argentina, Brazil, Mauritius, Syria).

15 years agoMissing space in error message
Peter Eisentraut [Thu, 30 Oct 2008 12:28:51 +0000 (12:28 +0000)]
Missing space in error message

15 years agoFix recoveryLastXTime logic so that it actually does what one would expect.
Tom Lane [Thu, 30 Oct 2008 04:06:16 +0000 (04:06 +0000)]
Fix recoveryLastXTime logic so that it actually does what one would expect.
Per gripe from Kevin Grittner.  Backpatch to 8.3, where the bug was introduced.

15 years agoMove forgotten comment closer to where it matters.
Peter Eisentraut [Wed, 29 Oct 2008 16:23:07 +0000 (16:23 +0000)]
Move forgotten comment closer to where it matters.

15 years agoSupport for Sun Studio compiler on Linux
Peter Eisentraut [Wed, 29 Oct 2008 16:06:47 +0000 (16:06 +0000)]
Support for Sun Studio compiler on Linux

This basically takes some build system code that was previously labeled
"Solaris" and ties it to the compiler rather than the operating system.

Author: Julius Stroffek <Julius.Stroffek@Sun.COM>

15 years agoRemove tab from sgml file.
Bruce Momjian [Wed, 29 Oct 2008 14:35:04 +0000 (14:35 +0000)]
Remove tab from sgml file.

15 years agoUpdate on array features support
Peter Eisentraut [Wed, 29 Oct 2008 11:33:46 +0000 (11:33 +0000)]
Update on array features support

15 years agoSince SQL:2003, the array size specification in the SQL ARRAY syntax has
Peter Eisentraut [Wed, 29 Oct 2008 11:24:53 +0000 (11:24 +0000)]
Since SQL:2003, the array size specification in the SQL ARRAY syntax has
been optional.

15 years agoUse Autoconf provided AS_HELP_STRING macro to automatically format and
Peter Eisentraut [Wed, 29 Oct 2008 09:27:24 +0000 (09:27 +0000)]
Use Autoconf provided AS_HELP_STRING macro to automatically format and
align strings in the --help output.  Do this through our abstraction layer
to eliminate redundancy and randomness in configure.in.

15 years agoUnicode escapes in strings and identifiers
Peter Eisentraut [Wed, 29 Oct 2008 08:04:54 +0000 (08:04 +0000)]
Unicode escapes in strings and identifiers

15 years agoBe more tense about not creating tuplestores with randomAccess = true unless
Tom Lane [Wed, 29 Oct 2008 00:00:39 +0000 (00:00 +0000)]
Be more tense about not creating tuplestores with randomAccess = true unless
backwards scan could actually happen.  In particular, pass a flag to
materialize-mode SRFs that tells them whether they need to require random
access.  In passing, also suppress unneeded backward-scan overhead for a
Portal's holdStore tuplestore.  Per my proposal about reducing I/O costs for
tuplestores.

15 years agoExtend ExecMakeFunctionResult() to support set-returning functions that return
Tom Lane [Tue, 28 Oct 2008 22:02:06 +0000 (22:02 +0000)]
Extend ExecMakeFunctionResult() to support set-returning functions that return
via a tuplestore instead of value-per-call.  Refactor a few things to reduce
ensuing code duplication with nodeFunctionscan.c.  This represents the
reasonably noncontroversial part of my proposed patch to switch SQL functions
over to returning tuplestores.  For the moment, SQL functions still do things
the old way.  However, this change enables PL SRFs to be called in targetlists
(observe changes in plperl regression results).

15 years agoChange WorkTableScan to not support backward scan. The apparent support
Tom Lane [Tue, 28 Oct 2008 17:13:51 +0000 (17:13 +0000)]
Change WorkTableScan to not support backward scan.  The apparent support
didn't actually work, because nodeRecursiveunion.c creates the underlying
tuplestore with backward scan disabled; which is a decision that we shouldn't
reverse because of performance cost.  We could imagine adding signaling from
WorkTableScan to RecursiveUnion about whether backward scan is needed ...
but in practice it'd be a waste of effort, because there simply isn't any
current or plausible future scenario where WorkTableScan would be called on
to scan backward.  So just dike out the code that claims to support it.

15 years agoArrange to squeeze out the MINIMAL_TUPLE_PADDING in the tuple representation
Tom Lane [Tue, 28 Oct 2008 15:51:03 +0000 (15:51 +0000)]
Arrange to squeeze out the MINIMAL_TUPLE_PADDING in the tuple representation
written to temp files by tuplesort.c and tuplestore.c.  This saves 2 bytes per
row for 32-bit machines, and 6 bytes per row for 64-bit machines, which seems
worth the slight additional uglification of the tuple read/write routines.

15 years agoAdd WITH [NO] DATA clause to CREATE TABLE AS, per SQL.
Peter Eisentraut [Tue, 28 Oct 2008 14:09:45 +0000 (14:09 +0000)]
Add WITH [NO] DATA clause to CREATE TABLE AS, per SQL.

Also, since WITH is now a reserved word, simplify the token merging code to
only deal with WITH_TIME.

by Tom Lane and myself

15 years agoRemove support for (insecure) crypt authentication.
Magnus Hagander [Tue, 28 Oct 2008 12:10:44 +0000 (12:10 +0000)]
Remove support for (insecure) crypt authentication.

This breaks compatibility with pre-7.2 versions.

15 years agoDowngrade can't-happen error reports to elog().
Alvaro Herrera [Mon, 27 Oct 2008 22:15:05 +0000 (22:15 +0000)]
Downgrade can't-happen error reports to elog().