OSDN Git Service
Jakub Pawlowski [Fri, 2 Mar 2018 17:14:20 +0000 (17:14 +0000)]
Add new sample rate BTAV_A2DP_CODEC_SAMPLE_RATE_24000
am:
bd39c6ee08
Change-Id: I0637185dd3175f307f50cca156d99d4543d8d97b
Jakub Pawlowski [Fri, 2 Mar 2018 09:56:09 +0000 (01:56 -0800)]
Add new sample rate BTAV_A2DP_CODEC_SAMPLE_RATE_24000
Test: compilation
Bug:
69623109
Change-Id: Ieffdd6e27ada8cbf221cfa7d1c0648aeb1c89be1
Jakub Pawlowski [Fri, 2 Mar 2018 01:00:21 +0000 (01:00 +0000)]
Hearing Aid BTIF interface implementation
am:
89b0ccb034
Change-Id: I93c072bbf8c774c7380e01558bbe6226eca6a431
Jakub Pawlowski [Thu, 1 Mar 2018 06:44:42 +0000 (22:44 -0800)]
Hearing Aid BTIF interface implementation
Boilerplate code - thread switching, logging and attaching to BTIF
infrastructure.
Test: manual with hearing aid
Bug:
69623109
Change-Id: I34a6542827a581a2fbe0b53e7220b7ff7ecbf540
Pavlin Radoslavov [Thu, 1 Mar 2018 23:36:51 +0000 (23:36 +0000)]
Merge "Multi-A2DP: stop or flush the A2DP queue only for Active peer"
am:
a41496e745
Change-Id: Ib1116eb7258d4cb74b2276290b574398c6a213b6
Treehugger Robot [Thu, 1 Mar 2018 23:27:53 +0000 (23:27 +0000)]
Merge "Multi-A2DP: stop or flush the A2DP queue only for Active peer"
Jakub Pawlowski [Thu, 1 Mar 2018 23:15:05 +0000 (23:15 +0000)]
Merge "Hearing Aid BTA interface"
am:
14e1e30fac
Change-Id: I170b4bda5887f7153c23846fadabab96ba0df4f9
Treehugger Robot [Thu, 1 Mar 2018 23:06:08 +0000 (23:06 +0000)]
Merge "Hearing Aid BTA interface"
Jakub Pawlowski [Thu, 1 Mar 2018 22:34:31 +0000 (22:34 +0000)]
Merge "Call BTA_VendorCleanup on proper thread"
am:
1184ac335f
Change-Id: Ifca440266846548be8a99ec5ab68c07f16e9e8be
Treehugger Robot [Thu, 1 Mar 2018 22:21:29 +0000 (22:21 +0000)]
Merge "Call BTA_VendorCleanup on proper thread"
Pavlin Radoslavov [Thu, 1 Mar 2018 21:36:20 +0000 (21:36 +0000)]
Merge "Pre-compute the RTP Header Marker Bit by using the correct peer address"
am:
60828d0b79
Change-Id: I98cff1eabab01255ec3137c7636df23aa6dcb7fd
Ajay Panicker [Thu, 1 Mar 2018 21:15:48 +0000 (21:15 +0000)]
Remove unused adjustAvrcpAbsoluteVolume
am:
ce268fc86f
Change-Id: I9a3df5c69021d252469bab429557fdfcd8be6756
Pavlin Radoslavov [Thu, 1 Mar 2018 16:26:43 +0000 (08:26 -0800)]
Multi-A2DP: stop or flush the A2DP queue only for Active peer
The A2DP queue should be flushed or the A2DP Tx/Rx operations
should be stopped only for the Active peer.
Otherwise, disconnecting a non-active A2DP Peer stops audio
output for the Active peer.
Bug:
73956686
Test: Manual: Connect two A2DP Sink devices, play music on the
Active device, disconnect the non-Active device
Change-Id: I32a624c012ef2cd9ef0057f7289a6ed713f88039
Jakub Pawlowski [Thu, 1 Mar 2018 06:59:32 +0000 (22:59 -0800)]
Hearing Aid BTA interface
This is the interface between the btif and bta layer, and also between
the profile implementation and audio source.
Submitting it in separate CL allows us to split the work on those
submodules.
Bug:
64038649
Test: compilation
Change-Id: I40663df4e3d8cfb401f9da6084b7212b7bdbcc8c
Jakub Pawlowski [Thu, 1 Mar 2018 19:54:16 +0000 (11:54 -0800)]
Call BTA_VendorCleanup on proper thread
Right now this function is running on any thread that call it, i.e. one
of Binder threads. This is introducing race condition during shutdown.
Test: restart bluetooth 10 times
Fix:
74075027
Change-Id: I426284792901e6a9540cb6420a7e27a340a3fe1d
Treehugger Robot [Thu, 1 Mar 2018 20:01:02 +0000 (20:01 +0000)]
Merge "Pre-compute the RTP Header Marker Bit by using the correct peer address"
Ajay Panicker [Wed, 28 Feb 2018 19:38:26 +0000 (11:38 -0800)]
Remove unused adjustAvrcpAbsoluteVolume
The AudioManager now handles all calculations for volume stepping now
and no longer uses adjustAvrcpAbsoluteVolume.
Bug:
68812037
Test: Compile and test Absolute Volume on a device that supports it
Change-Id: I34f27d27b4c5c3959a84a6dc438edfed45a0b3e3
Jakub Pawlowski [Thu, 1 Mar 2018 18:53:23 +0000 (18:53 +0000)]
Hearing Aid Audio HAL
am:
e470502f78
Change-Id: I72fa69c741e41e5ada66366bf74c56d510b503c4
Jakub Pawlowski [Fri, 23 Feb 2018 21:55:48 +0000 (13:55 -0800)]
Hearing Aid Audio HAL
The code is cloned from the existing A2DP Audio HAL.
In the future it will expand to include hearing-aid specific
mechanism.
Test: code compilation
Bug:
64038649
Change-Id: I976aa189929c3051b83615d1536315a099f31a67
Jakub Pawlowski [Thu, 1 Mar 2018 10:36:14 +0000 (10:36 +0000)]
Merge "Add new sample rate BTAV_A2DP_CODEC_SAMPLE_RATE_16000"
am:
25e8404e41
Change-Id: Ib80ac8807087f9521e8ae50e42bfee41f0fca75e
Treehugger Robot [Thu, 1 Mar 2018 10:25:39 +0000 (10:25 +0000)]
Merge "Add new sample rate BTAV_A2DP_CODEC_SAMPLE_RATE_16000"
Pavlin Radoslavov [Thu, 1 Mar 2018 07:34:28 +0000 (23:34 -0800)]
Pre-compute the RTP Header Marker Bit by using the correct peer address
The RTP Header Marker Bit is computed by using the peer address
to lookup the corresponding codec instead of using the codec
for the current active peer.
Also, the pre-computed result is stored in the SCB for the peer instead
of storing a pointer to the current codec config.
Bug:
73897470
Test: Manual - disconnect, reconnect A2DP headsets
Change-Id: Id015de7be2a297b86ac945c7b7c64e6bc13ffc42
Jakub Pawlowski [Thu, 1 Mar 2018 06:01:49 +0000 (06:01 +0000)]
Hearing Aid BTIF interface
am:
e893179687
Change-Id: Ie7b1229491ce78d8ebe286efee7ca2d87369ec50
Jakub Pawlowski [Thu, 1 Mar 2018 02:40:33 +0000 (18:40 -0800)]
Add new sample rate BTAV_A2DP_CODEC_SAMPLE_RATE_16000
Test: compilation
Bug:
69623109
Change-Id: Ib7c94c538d8636719658814d2a73bc997ab6dddc
Jakub Pawlowski [Wed, 22 Nov 2017 00:35:49 +0000 (16:35 -0800)]
Hearing Aid BTIF interface
This is first version of Hearing Aid interface.
Test: compilation
Bug:
69623109
Change-Id: I157dc8d1481c1f034c15aac7dd33a5103cf5ea14
Pavlin Radoslavov [Tue, 27 Feb 2018 08:44:26 +0000 (08:44 +0000)]
Merge changes from topics "bt-a2dp-remove-redundant-alarm-free", "bt-a2dp-codec-init-same-thread"
am:
51a906ba83
Change-Id: I4541641e477796c0ddcaa4cceb7df9bac300cd3f
Treehugger Robot [Tue, 27 Feb 2018 08:37:13 +0000 (08:37 +0000)]
Merge changes from topics "bt-a2dp-remove-redundant-alarm-free", "bt-a2dp-codec-init-same-thread"
* changes:
Removed redundant alarm_free() call on the wrong thread
Perform all codec-related init operations on the same thread
Pavlin Radoslavov [Tue, 27 Feb 2018 08:33:23 +0000 (08:33 +0000)]
Clear the A2DP active device within the native stack during cleanup
am:
2b13eb7b2a
Change-Id: I996cde9085b3cff94044b359b080a8e5404bfc17
Pavlin Radoslavov [Tue, 27 Feb 2018 07:16:43 +0000 (23:16 -0800)]
Removed redundant alarm_free() call on the wrong thread
Bug:
73741079
Bug:
73892830
Test: Manual - A2DP connect/disconnect; audio streaming
Change-Id: I3e553245ef5ac10835d08b78e52a3fbd945914ee
Pavlin Radoslavov [Tue, 27 Feb 2018 06:44:30 +0000 (22:44 -0800)]
Perform all codec-related init operations on the same thread
Renamed btif_a2dp_source_encoder_init_event() to
btif_a2dp_source_setup_codec_delayed() and moved the
peer parameter fetching from btif_a2dp_source_setup_codec()
to btif_a2dp_source_setup_codec_delayed()
Test: Manual - A2DP connect/disconnect; audio streaming
Change-Id: Ib29dd6b2bef3045be3727122e1f8608780921d98
Pavlin Radoslavov [Tue, 27 Feb 2018 06:53:05 +0000 (22:53 -0800)]
Clear the A2DP active device within the native stack during cleanup
Use explicit SetActivePeer(RawAddress::kEmpty) for BtifAvSource and
BtifAvSink during Cleanup()
Also, replaced incorrectly classified BTIF_TRACE_WARNING() log messages
with LOG_INFO().
Bug:
73832547
Test: Manual - A2DP streaming, enable Location -> Bluetooth scanning,
restart Bluetooth in Quick Settings
Change-Id: Ieeae8915a45dc0c98cd68bd4bb113424c2de74d9
Pavlin Radoslavov [Tue, 27 Feb 2018 04:47:56 +0000 (04:47 +0000)]
Initialize max number of connected A2DP devices in the native stack via JNI
am:
235bfcc900
Change-Id: I4ee35ac53e2258dd4e5c9b2b52425e1d44726c51
Pavlin Radoslavov [Tue, 27 Feb 2018 03:16:05 +0000 (19:16 -0800)]
Initialize max number of connected A2DP devices in the native stack via JNI
Pass the maximum number of connected A2DP devices from Java to the
native stack as a parameter to the init() call.
Bug:
72351654
Test: Manual: Connect to multiple A2DP devices, check the log messages
Change-Id: I0647c36fe7c6a2df2c42a60b53b5cf505160b1e6
Pavlin Radoslavov [Tue, 27 Feb 2018 01:47:09 +0000 (01:47 +0000)]
Merge "Add/update the BTIF A2DP log messages"
am:
fe5a83841b
Change-Id: Iaf15b40373679c2b505ad984ca89a6a396e81537
Treehugger Robot [Tue, 27 Feb 2018 01:02:21 +0000 (01:02 +0000)]
Merge "Add/update the BTIF A2DP log messages"
Myles Watson [Tue, 27 Feb 2018 00:37:34 +0000 (00:37 +0000)]
HCI: Set a timer to abort after a timeout
am:
5c550c1e1c
Change-Id: Ifb20e40988b4f36747fb5c008b363807e4638762
Myles Watson [Sat, 24 Feb 2018 01:28:23 +0000 (17:28 -0800)]
HCI: Set a timer to abort after a timeout
Add code to clean up the timer and close the file whether
abort gets called or not.
Bug:
72719600
Bug:
72474659
Test: Cause an HCI timeout and wait for the firmware dump
Change-Id: I713f440d77bfad4c9f17dfc57f98ba5bada37fff
Pavlin Radoslavov [Mon, 26 Feb 2018 20:08:22 +0000 (12:08 -0800)]
Add/update the BTIF A2DP log messages
* Added new log messages where needed
* Updated existing log messages so the message format is more aligned
with the rest of the messages
Test: Manual: A2DP streaming
Change-Id: I9f953c43df1ff415379bb7d7fb61f0d33760df30
Jakub Pawlowski [Mon, 26 Feb 2018 18:26:02 +0000 (18:26 +0000)]
Use assigned UUID for Hearing Aid Service
am:
8f081e4575
Change-Id: I449b645b0a9e03ecd3bfbaa6d4f527b736466546
Jakub Pawlowski [Thu, 22 Feb 2018 23:02:25 +0000 (15:02 -0800)]
Use assigned UUID for Hearing Aid Service
Test: manual
Bug:
64038649
Change-Id: Ie5b39d74d245373142be31027cccb5f51f8586bf
Pavlin Radoslavov [Sat, 24 Feb 2018 05:01:49 +0000 (05:01 +0000)]
Merge "Add explicit init/cleanup steps for A2DP Source and Sink"
am:
90835897a0
Change-Id: I5266a9852d4a9897c5283536baf07407f3ae4168
Treehugger Robot [Sat, 24 Feb 2018 04:49:57 +0000 (04:49 +0000)]
Merge "Add explicit init/cleanup steps for A2DP Source and Sink"
Manoj Babulal [Sat, 24 Feb 2018 04:17:56 +0000 (04:17 +0000)]
L2CAP: Discard pending requests on link disconnect
am:
72b71ec6d1
Change-Id: I79efe45e43f578e11256ce054744172320bfa02c
Pavlin Radoslavov [Fri, 23 Feb 2018 17:04:57 +0000 (09:04 -0800)]
Add explicit init/cleanup steps for A2DP Source and Sink
The startup/shutdown steps for A2DP Source and Sink
are done when setting/resetting the Active device, and this
implies the device has been connected.
The operations that must be done before the remote device
is connected are moved to init (and cleanup for the reverse operations)
Bug:
73832547
Test: Manual - Connect/disconnect/play A2DP to Headset
Change-Id: Iaa55c2d27443646111f07a53d2c5163bca9e256d
Manoj Babulal [Thu, 13 Jul 2017 07:04:09 +0000 (12:34 +0530)]
L2CAP: Discard pending requests on link disconnect
Scenario: A connection request packet is admitted to link tx queue in
L2CAP but before it could be transmitted (host busy), ACL link can get
disconnected (idle timeout) and the link tx queue is not flushed during
link disconnect handling. In such scenario, subsequent connection
attempt by host is seen to fail. This is because host is found to send
multiple connection requests (one connect request packet from the queue
and a new connection request packet per new request). Remote accepts old
connection request packet and waits for connection response from host.
For next connection request seen by remote, remote responds with 'No
PSM' resource error (as it already admitted one connection request and
it is in progress). Here when the connection response arrives from
remote, host ignores it because it sees packet id mismatch (host had
sent old connection request first and later information request/response
packets were exchanged. Remote had sent connection response copying
stale packet id picked from old connection request).
Drop queued packets as part of link disconnection handling.
This was already done in BLE transport case and is now being done
unconditionally.
Fixes:
73050475
Test: back-to-back PAN connect-disconnect iterations amidst ongoing
OPP file transfer and AV streaming
Change-Id: I42cc7ae90cc1152f1781282698529fe50f0ebf89
Ajay Panicker [Fri, 23 Feb 2018 22:25:25 +0000 (22:25 +0000)]
Uprev to AVDTP 1.3 and Implement AVDTP delay reports
am:
ef673c546c
Change-Id: I8efa11b2f70f97d0a78df496cb3119ac452d6896
Ajay Panicker [Wed, 21 Dec 2016 23:37:34 +0000 (15:37 -0800)]
Uprev to AVDTP 1.3 and Implement AVDTP delay reports
Implement receiving the delay report message which requires AVDTP 1.3.
Also start keeping track of total number of audio bytes sent over the
air. We now will report both of these values to the audio HAL so that
they can adjust audio playback using these values.
Bug:
32755225
Test: Manual test with a device that supports delay reporting
Testtracker: 145280
Change-Id: I22c1c6401e4912efab06fa56fb582faae4b38eaf
Yi Kong [Fri, 23 Feb 2018 18:50:15 +0000 (18:50 +0000)]
Merge "Remove unreachable code"
am:
c92e4a58de
Change-Id: Id9ab73026b0cf09ee78aa07832414846b4d48856
Treehugger Robot [Fri, 23 Feb 2018 18:32:54 +0000 (18:32 +0000)]
Merge "Remove unreachable code"
Pavlin Radoslavov [Fri, 23 Feb 2018 17:32:42 +0000 (17:32 +0000)]
Free the A2DP Source media alarm on the A2DP Source worker thread
am:
cc38c7fb41
Change-Id: I03ca80ed2cdeae946b0f6862268e90491a8fbe8c
Pavlin Radoslavov [Fri, 23 Feb 2018 11:35:37 +0000 (03:35 -0800)]
Free the A2DP Source media alarm on the A2DP Source worker thread
Move the alarm_free() for the A2DP Source media alarm from
btif_a2dp_source_shutdown() to btif_a2dp_source_shutdown_delayed().
The latter is executed on the btif_a2dp_source_thread.
This avoids a race condition with btif_a2dp_source_audio_tx_stop_event()
that also might attempt to free the same alarm.
Test: Manual - unpair A2DP device while A2DP streaming.
Bug:
73741079
Change-Id: Ia871fcbeaae7c351878228e7605e65307a3d1583
Pavlin Radoslavov [Thu, 22 Feb 2018 03:42:07 +0000 (03:42 +0000)]
Correct the value for BT_RC_NUM_APP for Multi-A2DP / Multi-AVRCP
am:
bd74060ea5
Change-Id: I2d92951f1f628194a0405f9f9fe8585d79d131b3
Ajay Panicker [Thu, 22 Feb 2018 00:14:26 +0000 (00:14 +0000)]
Replace AVRC callback function pointers with base::Callback
am:
0d6d447a1e
Change-Id: I7675b68af5d6b2b67b746140ef9e827c8b2e24fc
Pavlin Radoslavov [Sat, 10 Feb 2018 23:23:49 +0000 (15:23 -0800)]
Correct the value for BT_RC_NUM_APP for Multi-A2DP / Multi-AVRCP
The original value of BT_RC_NUM_APP was incorrectly increased from
1 to 12 for the purpose of supporting up to 6 AVRCP connected devices.
The new BT_RC_NUM_APP value is corrected to 6:
BT_RC_NUM_APP -> 1 -> 12 -> 6 (AVRCP-related - MaxDevices)
Test: Manual - connected to multiple headsets and selected each
headset to play audio.
Bug:
70350399
Change-Id: I53e350c2bf1717b1f031a7a265adf3417cf3c513
Ajay Panicker [Sun, 26 Nov 2017 00:27:33 +0000 (16:27 -0800)]
Replace AVRC callback function pointers with base::Callback
Replace function pointers with base::Callback for AVRCP to make
interfacing with the new AVRCP service easier.
Bug:
68812037
Test: Connect headset and see that Absolute volume and passthrough
commands still work.
Change-Id: I2ab20b7b59186aea413a736f43e926e17915a139
Andre Eisenbach [Wed, 21 Feb 2018 19:50:27 +0000 (19:50 +0000)]
Revert "Remove A2DP Source/Sink startup calls during A2DP initialization"
am:
57bb0b4934
Change-Id: I105fdb37da2c4e6b68bb54a0cdd765ac90bf6d2d
Andre Eisenbach [Wed, 21 Feb 2018 02:38:52 +0000 (02:38 +0000)]
Revert "Remove A2DP Source/Sink startup calls during A2DP initialization"
This reverts commit
83255478b0457f291d6a78795444ff3b895d4a90.
Reason for revert:
Prevents audio routing due to stale active device record if
Bluetooth is toggled without the process stopping completely
(ex. LE-only mode).
Bug:
72701090
Change-Id: Ifa798e63df14855b5bf0bd45e1557315cd51034d
Fixes:
73601288
Ajay Panicker [Wed, 21 Feb 2018 05:09:33 +0000 (05:09 +0000)]
Add packet classes needed for AVRCP Absolute Volume
am:
0c348413fb
Change-Id: If186451077737dc05095c34f27795c329776a94e
Ajay Panicker [Sat, 17 Feb 2018 19:22:48 +0000 (11:22 -0800)]
Add packet classes needed for AVRCP Absolute Volume
Add the Register Notification Request packet as well as the
packets Set Absolute Volume packet.
Bug:
68854188
Test: run host native test net_test_packets
Change-Id: Ie0d1f1fb23254c1353b6a73529ca93e92f231ed5
Yi Kong [Tue, 20 Feb 2018 17:48:09 +0000 (12:48 -0500)]
Remove unreachable code
The conditionals can never be true, as they are outside of the bounds of
their data types. Fixes tautological-constant-compare warning.
Bug:
72331526
Test: m
Change-Id: I74063fe19b319ee32e4c1c8b3a5fc7ed612586e3
Myles Watson [Sat, 17 Feb 2018 01:19:40 +0000 (01:19 +0000)]
OSI: Protect cutils/properties.h from direct calls
am:
158fe8e028
Change-Id: I8c163caf14182b5103c27a6c5e03bebbbdbdb59c
Myles Watson [Fri, 16 Feb 2018 21:11:04 +0000 (13:11 -0800)]
OSI: Protect cutils/properties.h from direct calls
Bug: None
Test: compile, no calls to property_get outside of libosi
change PROPERTY_VALUE_MAX in osi/include/properties.h
-> doesn't compile
Change-Id: I18c7b861782b1df4878da032ae3f0340dffdecab
Jakub Pawlowski [Sat, 17 Feb 2018 00:05:44 +0000 (00:05 +0000)]
Get rid of BTA_HOST_INTERLEAVE_SEARCH
am:
56363e828c
Change-Id: I4aaae9428d15db914c046b99bffc502b00bba2e5
Jakub Pawlowski [Fri, 16 Feb 2018 21:21:58 +0000 (13:21 -0800)]
Get rid of BTA_HOST_INTERLEAVE_SEARCH
Test: compilation
Change-Id: I6f91cd783fc1dd46cda55d3456a67eb78ba4c7ae
Jakub Pawlowski [Fri, 16 Feb 2018 06:03:03 +0000 (06:03 +0000)]
Merge "Make STREAM_TO_UINT64 globally available"
am:
4a31432f8b
Change-Id: Ib1d680b37168d12283fbd5106fd22e9875692805
Treehugger Robot [Fri, 16 Feb 2018 05:49:15 +0000 (05:49 +0000)]
Merge "Make STREAM_TO_UINT64 globally available"
Jakub Pawlowski [Fri, 16 Feb 2018 05:37:54 +0000 (05:37 +0000)]
Merge "Add btif_config_(get/set)_uint64"
am:
22e48923d4
Change-Id: Ieb06347f92ab27708bfa0c96532af337773c59f2
Jakub Pawlowski [Fri, 16 Feb 2018 05:36:28 +0000 (05:36 +0000)]
Reduce spammy error log in gatt_attr.cc, plus minor logging improvements
am:
ae2104f6ac
Change-Id: I169e0ae61b33d6062adb8c045779e9d53a9a2549
Treehugger Robot [Fri, 16 Feb 2018 04:49:38 +0000 (04:49 +0000)]
Merge "Add btif_config_(get/set)_uint64"
Jakub Pawlowski [Thu, 15 Feb 2018 18:09:03 +0000 (10:09 -0800)]
Add btif_config_(get/set)_uint64
Bug:
69623109
Test: added ConfigTest.config_get_uint64
Change-Id: Id2285a6f961f72d28912defad66663ddd05fb741
Jakub Pawlowski [Thu, 15 Feb 2018 23:38:39 +0000 (15:38 -0800)]
Reduce spammy error log in gatt_attr.cc, plus minor logging improvements
Test: compilation, observe colored log output on startup
Change-Id: I6671f5a900f15a57cc9b38b01aaec296002ad233
Jakub Pawlowski [Thu, 15 Feb 2018 18:18:29 +0000 (10:18 -0800)]
Make STREAM_TO_UINT64 globally available
Bug:
69623109
Change-Id: I38958dc16d42ab2396d3acd7605b63ec6a6c2dd8
Jakub Pawlowski [Thu, 15 Feb 2018 05:34:25 +0000 (05:34 +0000)]
Merge "Final IBluetoothHearingAid.aidl improvements"
am:
b053bd0bf6
Change-Id: I340b14e68ccc28eca81527d8985cc4411c6c93ea
Treehugger Robot [Thu, 15 Feb 2018 04:14:43 +0000 (04:14 +0000)]
Merge "Final IBluetoothHearingAid.aidl improvements"
Jakub Pawlowski [Wed, 14 Feb 2018 22:04:56 +0000 (14:04 -0800)]
Final IBluetoothHearingAid.aidl improvements
Use HiSyncId instead of CustomerId for unique hearing aid id, use proper
data type for it (64bit).
Make setVolume, adjustVolume return void, like for AVRCP.
Bug:
69623109
Test: compliance with the spec
Change-Id: I5fd51514793052d4ee2c3f9029eb75491145cc25
Pavlin Radoslavov [Wed, 14 Feb 2018 21:16:25 +0000 (21:16 +0000)]
Remove A2DP Source/Sink startup calls during A2DP initialization
am:
83255478b0
Change-Id: Ifa26a3efcbca74cdfe187e27871dc2123adfaa31
Pavlin Radoslavov [Wed, 14 Feb 2018 18:26:13 +0000 (10:26 -0800)]
Remove A2DP Source/Sink startup calls during A2DP initialization
Don't call btif_a2dp_source_startup() / btif_a2dp_sink_startup()
inside BtifAvSource::Init() / BtifAvSink::Init() .
Those calls are already happening at the right time later during
BtifAvSource::SetActivePeer() / BtifAvSink::SetActivePeer()
Bug:
72701090
Test: Manual with multiple headsets
Change-Id: I634a2c90a7758891565c97e86b83335608ffab69
Pavlin Radoslavov [Wed, 14 Feb 2018 14:24:55 +0000 (14:24 +0000)]
Use correct call btif_a2dp_sink_startup() for Sink peers
am:
b600f6b6fc
Change-Id: Ifaa3f3cb8c519999cf08273205dccc579f825157
Pavlin Radoslavov [Wed, 14 Feb 2018 12:12:54 +0000 (04:12 -0800)]
Use correct call btif_a2dp_sink_startup() for Sink peers
Replaced an incorrect call to btif_a2dp_source_startup() with
btif_a2dp_sink_startup() inside BtifAvSink::SetActivePeer()
Also, minor cleanup: fix log messages, add missing description for
some of the methods.
Bug:
72701090
Test: Manual with Headet
Change-Id: I0620833b02bd9012fea63ce2ce5e3c4c74d27bf7
Hansong Zhang [Wed, 14 Feb 2018 07:15:46 +0000 (07:15 +0000)]
A2DP: Cleanup UIPC when no active device
am:
f88552cdd8
Change-Id: If29bd610e0d1d9c63e1337363b33e8f1160b2ccb
Hansong Zhang [Fri, 2 Feb 2018 02:02:53 +0000 (18:02 -0800)]
A2DP: Cleanup UIPC when no active device
* Modified UIPC to support multiple users
* A2DP now calls UIPC_Close() when it has no active device, and calls
UIPC_Init() when it has an active device
Bug:
72701090
Test: Carkits with A2DP
Change-Id: Ic1b4b1be2aa01c9896883e3cb2a668d7a43316f9
Ajay Panicker [Wed, 14 Feb 2018 04:00:26 +0000 (04:00 +0000)]
Merge "Add AVRCP Browse packets to the completed packets."
am:
37a143f49a
Change-Id: Idcfb9df419b035f7f4a7fe335b4a97bab00db29a
Treehugger Robot [Wed, 14 Feb 2018 03:48:51 +0000 (03:48 +0000)]
Merge "Add AVRCP Browse packets to the completed packets."
Manu Viswanadhan [Wed, 14 Feb 2018 03:13:52 +0000 (03:13 +0000)]
Merge "btif: Remove unused synchronization in event_cleanup_stack"
am:
001f5a00b2
Change-Id: I05c6256acc7d5da4cede7bd20fcc0b8e4ff11837
Treehugger Robot [Wed, 14 Feb 2018 03:06:38 +0000 (03:06 +0000)]
Merge "btif: Remove unused synchronization in event_cleanup_stack"
Jakub Pawlowski [Wed, 14 Feb 2018 02:27:25 +0000 (02:27 +0000)]
Merge "IBluetoothHearingAid.aidl"
am:
03fa65fc71
Change-Id: Id8bacf4d75ba1b27f1f496bda7095bb75bcb5192
Treehugger Robot [Wed, 14 Feb 2018 02:13:41 +0000 (02:13 +0000)]
Merge "IBluetoothHearingAid.aidl"
Venkata Jagadeesh Garaga [Wed, 14 Feb 2018 01:33:58 +0000 (01:33 +0000)]
Merge "Adjust buffer length to fit in sdp_copy_raw_data()"
am:
29cb0b048b
Change-Id: Ia41425df56765dd9562f7ba65720751fd705dfc8
Ajay Panicker [Tue, 30 Jan 2018 18:36:45 +0000 (10:36 -0800)]
Add AVRCP Browse packets to the completed packets.
Also add class representations for the following packet types:
AVRCP Browse Packet
AVRCP Change Path
AVRCP Get Folder Items
AVRCP Get Item Attributes
AVRCP Set Browsed Player
AVRCP Get Total Number of Items
AVRCP Play Item
Bug:
68854188
Test: run host native test net_test_packets
Change-Id: I0bc682b11ec9181cfe1ed92678bb869ff3ef5740
Treehugger Robot [Wed, 14 Feb 2018 01:20:48 +0000 (01:20 +0000)]
Merge "Adjust buffer length to fit in sdp_copy_raw_data()"
Myles Watson [Wed, 14 Feb 2018 01:10:32 +0000 (01:10 +0000)]
Factor out libchrome_support_defaults
am:
65d24fb451
Change-Id: I392d30ac3ee7fb85e4121600b351971da6888508
Manu Viswanadhan [Fri, 14 Oct 2016 11:35:35 +0000 (17:05 +0530)]
btif: Remove unused synchronization in event_cleanup_stack
Use Case: Repeated BT ON/OFF
Failure: FD leak is observed with ON/OFF stress test
which eventually leads to crash due to unavailability
of FDs.
Steps:
BT ON/OFF
Root Cause: During stack cleanup an unused future
structure is created which is not freed, leading to FD
leak.
Fix: Remove the creation of the future structure
Test: BT ON/OFF
Fixes:
36019324
Change-Id: Id5945da87f00eb7ab77a5f217c95cc43f0136e06
Jakub Pawlowski [Tue, 13 Feb 2018 18:12:00 +0000 (10:12 -0800)]
IBluetoothHearingAid.aidl
Bug:
69623109
Test: Spec was reviewed, tests will be included with client/server implementation
Change-Id: I8c972ac0e4aa908a14893c957ae07dd2244abbfe
Venkata Jagadeesh Garaga [Thu, 15 Sep 2016 10:21:40 +0000 (15:51 +0530)]
Adjust buffer length to fit in sdp_copy_raw_data()
Align copy length with source buffer offset so that copy length will be
in boundary of the allocated buffer size
Test: Manual tested with DECK speaker.
Fixes:
35864526
Change-Id: If1a49e46e2948346226fbc96d7c2b56244cd60cc
Myles Watson [Tue, 13 Feb 2018 18:33:54 +0000 (10:33 -0800)]
Factor out libchrome_support_defaults
Disable Mac support for host binaries in one place, since
the dependency is based on libchrome support.
Test: build
Change-Id: I6641e18deffdff5205da181ad97e8b2892073a8f
Steven Moreland [Tue, 13 Feb 2018 17:49:49 +0000 (17:49 +0000)]
Merge "Remove libbluetooth-system requirement."
am:
a45d385323
Change-Id: I7e93d58e493338a6bbd01d68ad5c9aedd05107c9
Treehugger Robot [Tue, 13 Feb 2018 17:34:05 +0000 (17:34 +0000)]
Merge "Remove libbluetooth-system requirement."
Stanley Tng [Tue, 13 Feb 2018 16:54:26 +0000 (16:54 +0000)]
Add more details in native Bluetooth debug logs
am:
273ffd858e
Change-Id: I3a1ab4082b78e319ed71468ce655afffc9123e0e
Jakub Pawlowski [Tue, 13 Feb 2018 16:54:20 +0000 (16:54 +0000)]
Make loghex properly count numer length
am:
78b3e7b303
Change-Id: I303112998d7629c8a26a698c548b80bad58157fd
Stanley Tng [Thu, 8 Feb 2018 20:26:51 +0000 (12:26 -0800)]
Add more details in native Bluetooth debug logs
As part of debugging a security/pairing issue, these logs are modified
to give better debug information.
Test: compiled
Bug:
71364658
Change-Id: I742cc7dda0afc6350e881c22d03bdc1c69d37d88