OSDN Git Service
Itagaki Takahiro [Tue, 28 Sep 2010 06:56:46 +0000 (15:56 +0900)]
Only DISCARD ALL should be in the command_no_begin list.
We allowes DISCARD PLANS and TEMP in a transaction.
Itagaki Takahiro [Tue, 28 Sep 2010 05:24:02 +0000 (14:24 +0900)]
Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
Backpatch to 8.3.
Reported by Sergey Burladyan.
Robert Haas [Mon, 27 Sep 2010 13:14:14 +0000 (09:14 -0400)]
Add "(change requires restart)" note to some postgresql.conf parameters.
Devrim GÜNDÜZ
Tom Lane [Sat, 25 Sep 2010 23:04:02 +0000 (19:04 -0400)]
Fix another join removal bug: the check on PlaceHolderVars was wrong.
The previous coding would decide that join removal was unsafe upon finding
a PlaceHolderVar that needed to be evaluated at the inner rel and then used
above the join. However, this fails to cover the case of PlaceHolderVars
that refer to both the inner rel and some other rels. Per bug report from
Andrus.
Tom Lane [Sat, 25 Sep 2010 19:57:05 +0000 (15:57 -0400)]
Further fixes to the pg_get_expr() security fix in back branches.
It now emerges that the JDBC driver expects to be able to use pg_get_expr()
on an output of a sub-SELECT. So extend the check logic to be able to recurse
into a sub-SELECT to see if the argument is ultimately coming from an
appropriate column. Per report from Thomas Kellerer.
Peter Eisentraut [Sat, 25 Sep 2010 06:57:09 +0000 (09:57 +0300)]
Fix man page markup for <cmdsynopsis> with multiple variants
Command synopses using <cmdsynopsis> with multiple variants previously used
<sbr> to break lines between variants. The new man page toolchain introduced
in 9.0 makes a mess out of that, and that markup was probably wrong all along,
because <sbr> is supposed to break lines within a synopsis, not between them.
So fix that by using multiple <cmdsynopsis> elements inside <refsynopsisdiv>.
backpatched to 9.0
Tom Lane [Fri, 24 Sep 2010 17:48:20 +0000 (13:48 -0400)]
Still more .gitignore cleanup.
Fix overly-enthusiastic ignores, as identified by
git ls-files -i --exclude-standard
Robert Haas [Fri, 24 Sep 2010 02:00:26 +0000 (22:00 -0400)]
Add contrib/xml2/pgxml.sql to .gitignore
Kevin Grittner
Tom Lane [Thu, 23 Sep 2010 21:17:02 +0000 (17:17 -0400)]
ProcessIncomingNotify *must* reset notifyInterruptOccurred when called.
This was broken in 9.0 by careless addition of an early-exit path.
Bug report and diagnosis by Jeff Davis.
Tom Lane [Thu, 23 Sep 2010 20:53:22 +0000 (16:53 -0400)]
Prevent show_session_authorization from crashing when session_authorization
hasn't been set.
The only known case where this can happen is when show_session_authorization
is invoked in an autovacuum process, which is possible if an index function
calls it, as for example in bug #5669 from Andrew Geery. We could perhaps
try to return a sensible value, such as the name of the cluster-owning
superuser; but that seems like much more trouble than the case is worth,
and in any case it could create new possible failure modes. Simply
returning an empty string seems like the most appropriate fix.
Back-patch to all supported versions, even those before autovacuum, just
in case there's another way to provoke this crash.
Tom Lane [Thu, 23 Sep 2010 23:34:56 +0000 (19:34 -0400)]
Avoid sharing subpath list structure when flattening nested AppendRels.
In some situations the original coding led to corrupting the child AppendRel's
subpaths list, effectively adding other members of the parent's list to it.
This was usually masked because we never made any further use of the child's
list, but given the right combination of circumstances, we could do so. The
visible symptom would be a relation getting scanned twice, as in bug #5673
from David Schmitt.
Backpatch to 8.2, which is as far back as the risky coding appears. The
example submitted by David only fails in 8.4 and later, but I'm not convinced
that there aren't any even-more-obscure cases where 8.2 and 8.3 would fail.
Heikki Linnakangas [Thu, 23 Sep 2010 11:49:00 +0000 (14:49 +0300)]
Initialize tableoid field correctly when dumping foreign data wrappers and
servers. AFAICT it's harmless at the moment because nothing can depend on
either, but as soon as we introduce an object type with such dependencies,
tableoid needs to be set or pg_dump will fail to interpret the dependencies
correctly. In theory, I guess the uninitialized garbage in tableoid could
cause the object to be mistaken for some other object with same OID as well.
Tom Lane [Thu, 23 Sep 2010 03:48:14 +0000 (23:48 -0400)]
Re-allow input of Julian dates prior to 0001-01-01 AD.
This was unintentionally broken in 8.4 while tightening up checking of
ordinary non-Julian date inputs to forbid references to "year zero".
Per bug #5672 from Benjamin Gigot.
Tom Lane [Thu, 23 Sep 2010 02:32:19 +0000 (22:32 -0400)]
More fixes for libpq's .gitignore file.
The previous patches failed to cover a lot of symlinks that are only
added in platform-specific cases. Make the lists match what's in the
Makefile for each branch.
Tom Lane [Thu, 23 Sep 2010 00:22:35 +0000 (20:22 -0400)]
Do some copy-editing on the Git usage docs.
Tom Lane [Wed, 22 Sep 2010 23:51:46 +0000 (19:51 -0400)]
Fix remaining stray references to CVS.
These are just cosmetic and don't seem worth back-patching far.
I put them into 9.0 just because it was trivial to do so.
Tom Lane [Wed, 22 Sep 2010 22:08:53 +0000 (18:08 -0400)]
Add assorted other documentation build targets to documentation gitignore.
Tom Lane [Wed, 22 Sep 2010 21:21:58 +0000 (17:21 -0400)]
Some more gitignore cleanups: cover contrib and PL regression test outputs.
Also do some further work in the back branches, where quite a bit wasn't
covered by Magnus' original back-patch.
Magnus Hagander [Wed, 22 Sep 2010 19:49:07 +0000 (21:49 +0200)]
Add gitignore files for ecpg regression tests.
Backpatch to 8.2 as that's how far the structure looks the same.
Magnus Hagander [Wed, 22 Sep 2010 18:10:29 +0000 (20:10 +0200)]
Remove anonymous cvs instructions, and replace them with instructions
for git. Change other references from cvs to git as well.
Magnus Hagander [Wed, 22 Sep 2010 10:57:06 +0000 (12:57 +0200)]
Convert cvsignore to gitignore, and add .gitignore for build targets.
Tom Lane [Tue, 21 Sep 2010 20:40:50 +0000 (16:40 -0400)]
Fix a missed explanation of auto-analyze threshold, per Joe Miller.
Tom Lane [Tue, 21 Sep 2010 18:42:58 +0000 (14:42 -0400)]
Back-patch replacement of README.CVS with README.git.
In older branches, also git-ify the "make distdir" rule.
Robert Haas [Fri, 17 Sep 2010 18:50:22 +0000 (18:50 +0000)]
Move pg_db_role_setting docs to correct place in alphabetical order.
Marc G. Fournier [Fri, 17 Sep 2010 01:18:41 +0000 (01:18 +0000)]
tag v9.0.0 ... the big day approaches
Magnus Hagander [Thu, 16 Sep 2010 20:37:18 +0000 (20:37 +0000)]
Treat exit code 128 (ERROR_WAIT_NO_CHILDREN) as non-fatal on Win32,
since it can happen when a process fails to start when the system
is under high load.
Per several bug reports and many peoples investigation.
Back-patch to 8.4, which is as far back as the "deadman-switch"
for shared memory access exists.
Peter Eisentraut [Thu, 16 Sep 2010 19:09:39 +0000 (19:09 +0000)]
Translation updates for 9.0.0
Tom Lane [Thu, 16 Sep 2010 18:15:28 +0000 (18:15 +0000)]
Stamp 9.0 release notes with expected release date; also some last-minute
copy-editing.
Tom Lane [Thu, 16 Sep 2010 14:31:26 +0000 (14:31 +0000)]
Fix bad grammar.
Tom Lane [Thu, 16 Sep 2010 02:54:07 +0000 (02:54 +0000)]
Fix two new-in-9.0 bugs in hstore.
There was an incorrect Assert in hstoreValidOldFormat(), which would cause
immediate core dumps when attempting to work with pre-9.0 hstore data,
but of course only in an assert-enabled build.
Also, ghstore_decompress() incorrectly applied DatumGetHStoreP() to a datum
that wasn't actually an hstore, but rather a ghstore (ie, a gist signature
bitstring). That used to be harmless, but could now result in misbehavior
if the hstore format conversion code happened to trigger. In reality,
since ghstore is not marked toastable (and doesn't need to be), this
function is useless anyway; we can lobotomize it down to returning the
passed-in pointer.
Both bugs found by Andrew Gierth, though this isn't exactly his proposed
patch.
Tom Lane [Wed, 15 Sep 2010 17:46:02 +0000 (17:46 +0000)]
Add a compatibility note about plpgsql's treatment of SELECT INTO rec.fld
when fld is of composite type. Per discussion of bug #5644 from Valentine
Gogichashvili.
Tom Lane [Tue, 14 Sep 2010 23:15:37 +0000 (23:15 +0000)]
Fix join-removal logic for pseudoconstant and outerjoin-delayed quals.
In these cases a qual can get marked with the removable rel in its
required_relids, but this is just to schedule its evaluation correctly, not
because it really depends on the rel. We were assuming that, in effect,
we could throw away *all* quals so marked, which is nonsense. Tighten up
the logic to be a little more paranoid about which quals belong to the
outer join being considered for removal, and arrange for all quals that
don't belong to be updated so they will still get evaluated correctly.
Also fix another problem that happened to be exposed by this test case,
which was that make_join_rel() was failing to notice some cases where
a constant-false qual could be used to prove a join relation empty. If it's
a pushed-down constant false, then the relation is empty even if it's an
outer join, because the qual applies after the outer join expansion.
Per report from Nathan Grange. Back-patch into 9.0.
Heikki Linnakangas [Tue, 14 Sep 2010 08:05:54 +0000 (08:05 +0000)]
Don't warn about an in-progress online backup, when we're recovering from
an online backup instead of performing one. pg_ctl can detect that by
checking if recovery.conf exists.
Backup label file is renamed away early in recovery, so the window where
backup label exists during recovery is normally very small, but you can run
into it e.g if restore_command is set incorrectly and the startup process
never finds even the first WAL segment containing the checkpoint record to
start recovery from.
Fujii Masao with comments by me.
Robert Haas [Mon, 13 Sep 2010 17:03:23 +0000 (17:03 +0000)]
Elaborate on what gets stored in pg_authid.rolpasswd.
Also, add cross-reference from pg_shadow.passwd to pg_authid.rolpasswd and
fix a bit of markup I muffed in my previous commit.
Per discussion with Josh Kupershmidt.
Heikki Linnakangas [Mon, 13 Sep 2010 10:14:30 +0000 (10:14 +0000)]
Remove prototype for non-existent function from walreceiver.h. Tidy up by
separating prototypes for functions in walreceiver.c and walreceiverfuncs.c
with comments.
Heikki Linnakangas [Mon, 13 Sep 2010 09:00:35 +0000 (09:00 +0000)]
Process options from the startup packed in walsender. Only few options
make sense for walsender, but for example application_name and client_encoding
do. We still don't apply per-role settings from pg_db_role_setting, because
that would require connecting to a database to read the table.
Fujii Masao
Bruce Momjian [Mon, 13 Sep 2010 01:35:54 +0000 (01:35 +0000)]
Don't try aligning comments for new archive_command Win32 doc example;
it doesn't work.
Backpatch to 9.0.X.
Robert Haas [Mon, 13 Sep 2010 01:25:12 +0000 (01:25 +0000)]
Link from pg_shadow docs to pg_authid docs.
Per discussion with Josh Kupershmidt.
Bruce Momjian [Sun, 12 Sep 2010 13:47:19 +0000 (13:47 +0000)]
Re-add documentation for Win32 copy syntax for archive_command.
Backpatch to 9.0.X.
Tom Lane [Thu, 9 Sep 2010 17:19:46 +0000 (17:19 +0000)]
Remove obsolete claim that gzip is needed while installing PG's documentation.
It isn't, now that we ship the docs as loose files rather than a sub-tarball.
Also adjust the wording in a couple of places to make the lists of required
software read more consistently.
Bruce Momjian [Thu, 9 Sep 2010 00:48:29 +0000 (00:48 +0000)]
Doc fixes:
- remove excessive table cells
- moving function parameters into function tags rather than having
them being considered separate
- add return type column on XML2 contrib module functions list and
removing return types from function
- add table header to XML2 contrib parameter table
Thom Brown
Backpatch to 9.0.X.
Peter Eisentraut [Wed, 8 Sep 2010 20:35:53 +0000 (20:35 +0000)]
Add tip about building plpython 2 and 3. Fix link to Python docs.
Peter Eisentraut [Tue, 7 Sep 2010 18:54:08 +0000 (18:54 +0000)]
Clarify that surrogate pairs are not encoded in UTF-8 directly
Bruce Momjian [Tue, 7 Sep 2010 14:10:39 +0000 (14:10 +0000)]
Modify pg_upgrade to set/restore all environment variables related to
collation/encoding to match English when reading controldata. This now
matches the English variable setting used by pg_regress.c.
Backpatch to 9.0.X.
Tom Lane [Sat, 4 Sep 2010 17:46:03 +0000 (17:46 +0000)]
Pad the ps_status display with nulls, not blanks, on Darwin.
A long time ago, this didn't work nicely, but it seems to work on all recent
versions of OS X. The blank-pad method is less desirable since it results
in lots of extra space in ps' output. Per Alexey Klyukin.
Tom Lane [Thu, 2 Sep 2010 14:57:09 +0000 (14:57 +0000)]
Clean up description of ecpg's dtcvfmtasc function.
Per KOIZUMI Satoru.
Tom Lane [Thu, 2 Sep 2010 14:46:51 +0000 (14:46 +0000)]
Clean up some bad grammar and punctuation in description of ecpg's decimal
type. Per KOIZUMI Satoru.
Tom Lane [Thu, 2 Sep 2010 03:16:52 +0000 (03:16 +0000)]
Fix up flushing of composite-type typcache entries to be driven directly by
SI invalidation events, rather than indirectly through the relcache.
In the previous coding, we had to flush a composite-type typcache entry
whenever we discarded the corresponding relcache entry. This caused problems
at least when testing with RELCACHE_FORCE_RELEASE, as shown in recent report
from Jeff Davis, and might result in real-world problems given the kind of
unexpected relcache flush that that test mechanism is intended to model.
The new coding decouples relcache and typcache management, which is a good
thing anyway from a structural perspective. The cost is that we have to
search the typcache linearly to find entries that need to be flushed. There
are a couple of ways we could avoid that, but at the moment it's not clear
it's worth any extra trouble, because the typcache contains very few entries
in typical operation.
Back-patch to 8.2, the same as some other recent fixes in this general area.
The patch could be carried back to 8.0 with some additional work, but given
that it's only hypothetical whether we're fixing any problem observable in
the field, it doesn't seem worth the work now.
Tom Lane [Wed, 1 Sep 2010 18:22:35 +0000 (18:22 +0000)]
Clarify documentation of handling of null arguments for aggregates.
Per discussion.
Tom Lane [Wed, 1 Sep 2010 15:14:48 +0000 (15:14 +0000)]
Improve release notes' description of Teodor's fixes for polygon overlaps
and contains operators.
Alvaro Herrera [Tue, 31 Aug 2010 05:57:56 +0000 (05:57 +0000)]
Add missing markup for translatability
Tom Lane [Mon, 30 Aug 2010 17:30:49 +0000 (17:30 +0000)]
Cosmetic fixes for KnownAssignedXidsGetOldestXmin, per Fujii Masao.
Simon Riggs [Mon, 30 Aug 2010 15:38:17 +0000 (15:38 +0000)]
Fix misleading DEBUG2 issued during RemoveOldXlogFiles()
Simon Riggs [Mon, 30 Aug 2010 15:21:18 +0000 (15:21 +0000)]
Truncate subtrans after each restartpoint.
Issue reported by Harald Kolb, patch by Fujii Masao, review by me.
Simon Riggs [Mon, 30 Aug 2010 15:20:31 +0000 (15:20 +0000)]
Teach GetOldestXmin() about KnownAssignedXids during recovery.
Very minor issue, though this is required for a later patch.
Reported by Heikki Linnakangas.
Heikki Linnakangas [Mon, 30 Aug 2010 06:33:26 +0000 (06:33 +0000)]
Fix typo in comment.
Tom Lane [Sun, 29 Aug 2010 19:33:21 +0000 (19:33 +0000)]
Reduce PANIC to ERROR in some occasionally-reported btree failure cases.
This patch changes _bt_split() and _bt_pagedel() to throw a plain ERROR,
rather than PANIC, for several cases that are reported from the field
from time to time:
* right sibling's left-link doesn't match;
* PageAddItem failure during _bt_split();
* parent page's next child isn't right sibling during _bt_pagedel().
In addition the error messages for these cases have been made a bit
more verbose, with additional values included.
The original motivation for PANIC here was to capture core dumps for
subsequent analysis. But with so many users whose platforms don't capture
core dumps by default, or who are unprepared to analyze them anyway, it's hard
to justify a forced database restart when we can fairly easily detect the
problems before we've reached the critical sections where PANIC would be
necessary. It is not currently known whether the reports of these messages
indicate well-hidden bugs in Postgres, or are a result of storage-level
malfeasance; the latter possibility suggests that we ought to try to be more
robust even if there is a bug here that's ultimately found.
Backpatch to 8.2. The code before that is sufficiently different that
it doesn't seem worth the trouble to back-port further.
Tom Lane [Sun, 29 Aug 2010 15:19:12 +0000 (15:19 +0000)]
Remove obsolete remark that PQprepare() is more flexible than PREPARE.
Spotted by Dmitriy Igrishin. Back-patch to 8.2, which is when the PREPARE
statement was improved to allow parameter types to be omitted.
Marc G. Fournier [Fri, 27 Aug 2010 03:04:41 +0000 (03:04 +0000)]
tag rc1 ... final stretch ...
Tom Lane [Thu, 26 Aug 2010 22:00:32 +0000 (22:00 +0000)]
Document the existence of the socket lock file under unix_socket_directory,
which is perhaps not a terribly good spot for it but there doesn't seem to be
a better place. Also add a source-code comment pointing out a couple reasons
for having a separate lock file. Per suggestion from Greg Smith.
Tom Lane [Thu, 26 Aug 2010 21:08:43 +0000 (21:08 +0000)]
Explain automatic creation (or lack of it) of indexes for the various types
of constraints.
Kevin Grittner
Tom Lane [Thu, 26 Aug 2010 19:58:50 +0000 (19:58 +0000)]
Update time zone data files to tzdata release 2010l: DST law changes in
Egypt and Palestine. Added new names for two Micronesian timezones:
Pacific/Chuuk is now preferred over Pacific/Truk (and the preferred
abbreviation is CHUT not TRUT) and Pacific/Pohnpei is preferred over
Pacific/Ponape. Historical corrections for Finland.
Alvaro Herrera [Thu, 26 Aug 2010 19:49:41 +0000 (19:49 +0000)]
Improve wording for privilege description on certain failure messages; the
original misleadingly suggests that only access is meant, causing confusion.
Per recent trouble report by Robert McGehee on pgsql-admin.
Alvaro Herrera [Thu, 26 Aug 2010 19:24:40 +0000 (19:24 +0000)]
Remove duplicate translatable phrase
Peter Eisentraut [Thu, 26 Aug 2010 19:23:10 +0000 (19:23 +0000)]
Translation updates for 9.0rc1
Tom Lane [Thu, 26 Aug 2010 18:54:44 +0000 (18:54 +0000)]
Fix ExecMakeTableFunctionResult to verify that all rows returned by a SRF
returning "record" actually do have the same rowtype. This is needed because
the parser can't realistically enforce that they will all have the same typmod,
as seen in a recent example from David Wheeler.
Back-patch to 8.0, which is as far back as we have the notion of RECORD
subtypes being distinguished by typmod. Wheeler's example depends on
8.4-and-up features, but I suspect there may be ways to provoke similar
failures before 8.4.
Tom Lane [Thu, 26 Aug 2010 18:34:44 +0000 (18:34 +0000)]
Don't auto-create the subdirectories holding built documentation in a VPATH
build tree. If we actually build the docs in the VPATH tree, those dirs
will get created then; but if they're present and empty, they capture the
vpathsearch searches in "make install", preventing installation of prebuilt
docs that might exist in the source tree. Per bug #5595 from Dmtiriy Igrishin.
Fix based on idea from Peter Eisentraut.
Bruce Momjian [Wed, 25 Aug 2010 23:56:03 +0000 (23:56 +0000)]
Remove docs for "Incrementally Updated Backups" because it was of
questionable reliability; information moved to a wiki:
http://wiki.postgresql.org/wiki/Incrementally_Updated_Backups
Backpatch to 9.0.
Tom Lane [Wed, 25 Aug 2010 21:43:01 +0000 (21:43 +0000)]
Document filtering dictionaries in textsearch.sgml.
While at it, copy-edit the description of prefix-match marker support in
synonym dictionaries, and clarify the description of the default unaccent
dictionary a bit more.
Tom Lane [Wed, 25 Aug 2010 20:10:59 +0000 (20:10 +0000)]
Improve hint message for ENOMEM failure from shmget().
It turns out that some platforms return ENOMEM for a request that violates
SHMALL, whereas we were assuming that ENOSPC would always be used for that.
Apparently the latter is a Linuxism while ENOMEM is the BSD tradition.
Extend the ENOMEM hint to suggest that raising SHMALL might be needed.
Per gripe from A.M.
Backpatch to 9.0, but not further, because this doesn't seem important
enough to warrant creating extra translation work in the stable branches.
(If it were, we'd have figured this out years ago.)
Bruce Momjian [Wed, 25 Aug 2010 19:41:51 +0000 (19:41 +0000)]
Update release notes, per comments from Simon Riggs.
Peter Eisentraut [Wed, 25 Aug 2010 19:37:52 +0000 (19:37 +0000)]
Catch null pointer returns from PyCObject_AsVoidPtr and PyCObject_FromVoidPtr
This is reproducibly possible in Python 2.7 if the user turned
PendingDeprecationWarning into an error, but it's theoretically also possible
in earlier versions in case of exceptional conditions.
backpatched to 8.0
Peter Eisentraut [Wed, 25 Aug 2010 18:18:38 +0000 (18:18 +0000)]
Add missing description of reloftype field
Tom Lane [Wed, 25 Aug 2010 02:12:11 +0000 (02:12 +0000)]
Docs review for unaccent: fix grammar, markup, etc.
Tom Lane [Wed, 25 Aug 2010 00:48:06 +0000 (00:48 +0000)]
Update 9.0 release notes for changes since beta4.
Note: as usual, bug fixes that were also applied in back branches are not
considered material to include in a new major release's notes.
Tom Lane [Tue, 24 Aug 2010 23:45:37 +0000 (23:45 +0000)]
Further editing of release notes.
Bruce Momjian [Tue, 24 Aug 2010 15:22:19 +0000 (15:22 +0000)]
Fix awkward wording in Incrementally Updated Backups docs.
Backpatch to 9.0.X.
Bruce Momjian [Tue, 24 Aug 2010 14:46:35 +0000 (14:46 +0000)]
Clarifications for 9.0 release notes
Josh Berkus
Bruce Momjian [Tue, 24 Aug 2010 13:32:32 +0000 (13:32 +0000)]
Update autovacuum_freeze_max_age documentation to mention that the
default is low because of pg_clog file removal.
Backpatch to 9.0.X.
Tom Lane [Mon, 23 Aug 2010 17:20:08 +0000 (17:20 +0000)]
Marginal code cleanup for streaming replication.
There is no reason that proc.c should have to get involved in this dirty hack
for letting the postmaster know which children are walsenders. Revert that
file to the way it was, and confine the kluge to pmsignal.c and postmaster.c.
Tom Lane [Mon, 23 Aug 2010 02:56:29 +0000 (02:56 +0000)]
Make pg_archivecleanup log messages more consistent.
Erik Rijkers
Tom Lane [Mon, 23 Aug 2010 02:43:35 +0000 (02:43 +0000)]
Make an editorial pass over the 9.0 release notes.
This is mostly about grammar, style, and presentation, though I did find
a few small factual errors.
Bruce Momjian [Sun, 22 Aug 2010 02:37:38 +0000 (02:37 +0000)]
Document that autovacuum_freeze_max_age is used for pg_clog recycling.
We already mentioned xid wraparound.
Tom Lane [Sat, 21 Aug 2010 16:55:58 +0000 (16:55 +0000)]
Use a non-locale-dependent definition of isspace() in array_in/array_out.
array_in discards unquoted leading and trailing whitespace in array values,
while array_out is careful to quote array elements that contain whitespace.
This is problematic when the definition of "whitespace" varies between
locales: array_in could drop characters that were meant to be part of the
value. To avoid that, lock down "whitespace" to mean only the traditional
six ASCII space characters.
This change also works around a bug in OS X and some older BSD systems, in
which isspace() could return true for character fragments in UTF8 locales.
(There may be other places in PG where that bug could cause problems, but
this is the only one complained of so far; see recent report from Steven
Schlansker.)
Back-patch to 9.0, but not further. Given the lack of previous reports
of trouble, changing this behavior in stable branches seems to offer
more risk of breaking applications than reward of avoiding problems.
Tom Lane [Sat, 21 Aug 2010 13:59:50 +0000 (13:59 +0000)]
Improve parallel restore's ability to cope with selective restore (-L option).
The original coding tended to break down in the face of modified restore
orders, as shown in bug #5626 from Albert Ullrich, because it would flip over
into parallel-restore operation too soon. That causes problems because we
don't have sufficient dependency information in dump archives to allow safe
parallel processing of SECTION_PRE_DATA items. Even if we did, it's probably
undesirable to allow that to override the commanded restore order.
To fix the problem of omitted items causing unexpected changes in restore
order, tweak SortTocFromFile so that omitted items end up at the head of
the list not the tail. This ensures that they'll be examined and their
dependencies will be marked satisfied before we get to any interesting
items.
In HEAD and 9.0, we can easily change restore_toc_entries_parallel so that
all SECTION_PRE_DATA items are guaranteed to be processed in the initial
serial-restore loop, and hence in commanded order. Only DATA and POST_DATA
items are candidates for parallel processing. For them there might be
variations from the commanded order because of parallelism, but we should
do it in a safe order thanks to dependencies.
In 8.4 it's much harder to make such a guarantee. I settled for not
letting the initial loop break out into parallel processing mode if
it sees a DATA/POST_DATA item that's not to be restored; this at least
prevents a non-restorable item from causing premature exit from the loop.
This means that 8.4 will be more likely to fail given a badly-ordered -L
list than 9.x, but we don't really promise any such thing will work anyway.
Tom Lane [Thu, 19 Aug 2010 22:55:10 +0000 (22:55 +0000)]
Bring some sanity to the trace_recovery_messages code and docs.
Per gripe from Fujii Masao, though this is not exactly his proposed patch.
Categorize as DEVELOPER_OPTIONS and set context PGC_SIGHUP, as per Fujii,
but set the default to LOG because higher values aren't really sensible
(see the code for trace_recovery()). Fix the documentation to agree with
the code and to try to explain what the variable actually does. Get rid
of no-op calls trace_recovery(LOG), which accomplish nothing except to
demonstrate that this option confuses even its author.
Tom Lane [Thu, 19 Aug 2010 18:58:04 +0000 (18:58 +0000)]
Allow USING and INTO clauses of plpgsql's EXECUTE to appear in either order.
Aside from being more forgiving, this prevents a rather surprising misbehavior
when the "wrong" order was used: the old code didn't throw a syntax error,
but absorbed the INTO clause into the last USING expression, which then did
strange things downstream.
Intentionally not changing the documentation; we'll continue to advertise
only the "standard" clause order.
Backpatch to 8.4, where the USING clause was added to EXECUTE.
Tom Lane [Thu, 19 Aug 2010 18:10:56 +0000 (18:10 +0000)]
Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar" is simple.
It's not clear if this situation can occur in plpgsql other than via the
EXECUTE USING case Heikki illustrated, which I will shortly close off.
However, ignoring the intoClause if it's there is surely wrong, so let's
patch it for safety.
Backpatch to 8.3, which is as far back as this code has a PlannedStmt
to deal with. There might be another way to make an equivalent test
before that, but since this is just preventing hypothetical bugs,
I'm not going to obsess about it.
Tom Lane [Thu, 19 Aug 2010 17:31:50 +0000 (17:31 +0000)]
Be a bit less cavalier with both the code and the comment for UNKNOWN fix.
Heikki Linnakangas [Thu, 19 Aug 2010 16:54:48 +0000 (16:54 +0000)]
Revert patch to coerce 'unknown' type parameters in the backend. As Tom
pointed out, it would need a 2nd pass after the whole query is processed to
correctly check that an unknown Param is coerced to the same target type
everywhere. Adding the 2nd pass would add a lot more code, which doesn't
seem worth the risk given that there isn't much of a use case for passing
unknown Params in the first place. The code would work without that check,
but it might be confusing and the behavior would be different from the
varparams case.
Instead, just coerce all unknown params in a PL/pgSQL USING clause to text.
That's simple, and is usually what users expect.
Revert the patch in CVS HEAD and master, and backpatch the new solution to
8.4. Unlike the previous solution, this applies easily to 8.4 too.
Tom Lane [Thu, 19 Aug 2010 16:16:27 +0000 (16:16 +0000)]
Allocate local buffers in a context of their own, rather than dumping them
into TopMemoryContext. This makes no functional difference, but makes it
easier to see what the space is being used for in MemoryContextStats dumps.
Per a recent example in which I was surprised by the size of TopMemoryContext.
Tom Lane [Thu, 19 Aug 2010 15:46:24 +0000 (15:46 +0000)]
Fix possible corruption of AfterTriggerEventLists in subtransaction rollback.
afterTriggerInvokeEvents failed to adjust events->tailfree when truncating
the last chunk of an event list. This could result in the data being
"de-truncated" by afterTriggerRestoreEventList during a subsequent
subtransaction abort. Even that wouldn't kill us, because the re-added data
would just be events marked DONE --- unless the data had been partially
overwritten by new events. Then we might crash, or in any case misbehave
(perhaps fire triggers twice, or fire triggers with the wrong event data).
Per bug #5622 from Thue Janus Kristensen.
Back-patch to 8.4 where the current trigger list representation was introduced.
Tom Lane [Wed, 18 Aug 2010 21:52:32 +0000 (21:52 +0000)]
Reset the per-output-tuple exprcontext each time through the main loop in
ExecModifyTable(). This avoids memory leakage when trigger functions leave
junk behind in that context (as they more or less must). Problem and solution
identified by Dean Rasheed.
I'm a bit concerned about the longevity of this solution --- once a plan can
have multiple ModifyTable nodes, we are very possibly going to have to do
something different. But it should hold up for 9.0.
Tom Lane [Wed, 18 Aug 2010 18:35:30 +0000 (18:35 +0000)]
Fix failure of "ALTER TABLE t ADD COLUMN c serial" when done by non-owner.
The implicitly created sequence was created as owned by the current user,
who could be different from the table owner, eg if current user is a
superuser or some member of the table's owning role. This caused sanity
checks in the SEQUENCE OWNED BY code to spit up. Although possibly we
don't need those sanity checks, the safest fix seems to be to make sure
the implicit sequence is assigned the same owner role as the table has.
(We still do all permissions checks as the current user, however.)
Per report from Josh Berkus.
Back-patch to 9.0. The bug goes back to the invention of SEQUENCE OWNED BY
in 8.2, but the fix requires an API change for DefineRelation(), which seems
to have potential for breaking third-party code if done in a minor release.
Given the lack of prior complaints, it's probably not worth fixing in the
stable branches.
Tom Lane [Wed, 18 Aug 2010 15:22:00 +0000 (15:22 +0000)]
Add missing handling of PlannedStmt.transientPlan in copyfuncs/outfuncs.
_outPlannedStmt is only debug support, so the omission there was not very
serious, but the omission in _copyPlannedStmt is a real bug. The consequence
would be that a copied plan tree would never be marked as a transient plan,
so that we would forget we ought to replan it after some not-yet-ready index
becomes ready for use. This might explain some past complaints about indexes
created with CREATE INDEX CONCURRENTLY not being used right away. Problem
spotted by Yeb Havinga.
Back-patch to 8.3, where the field was added.
Heikki Linnakangas [Wed, 18 Aug 2010 12:20:22 +0000 (12:20 +0000)]
Coerce 'unknown' type parameters to the right type in the fixed-params
parse_analyze() function. That case occurs e.g with PL/pgSQL
EXECUTE ... USING 'stringconstant'.
The coercion with a CoerceViaIO node. The result is similar to the coercion
via input function performed for unknown constants in coerce_type(),
except that this happens at runtime.
Backpatch to 9.0. The issue is present in 8.4 as well, but the coerce param
hook infrastructure this patch relies on was introduced in 9.0. Given the
lack of user reports and harmlessness of the bug, it's not worth attempting
a different fix just for 8.4.
Michael Meskes [Tue, 17 Aug 2010 11:06:26 +0000 (11:06 +0000)]
Applied Zoltan's patch to fix a few memleaks in ecpg's pgtypeslib.
Peter Eisentraut [Tue, 17 Aug 2010 04:47:03 +0000 (04:47 +0000)]
Revert: looks like Binary Large OBject[sic] wasn't a misspelling
Peter Eisentraut [Tue, 17 Aug 2010 04:37:19 +0000 (04:37 +0000)]
Spell and markup checking
Tom Lane [Mon, 16 Aug 2010 17:32:53 +0000 (17:32 +0000)]
Arrange to fsync the contents of lockfiles (both postpid and the
socket lockfile) when writing them. The lack of an fsync here may well
explain two different reports we've seen of corrupted lockfile contents,
which doesn't particularly bother the running server but can prevent a
new server from starting if the old one crashes. Per suggestion from
Alvaro.
Back-patch to all supported versions.