OSDN Git Service
Bruce Momjian [Fri, 13 Dec 2002 22:17:57 +0000 (22:17 +0000)]
Increment libpq major number for 7.3.1 and minor for 7.4.
Tom Lane [Fri, 13 Dec 2002 20:35:57 +0000 (20:35 +0000)]
Admit defeat on the prospect of keeping straight exactly which platforms
produce which output in the geometry test, even with the problem narrowed
down to only whether they print minus zero or not. Instead, use
pg_regress' locale-variant mechanism to automatically consider the test
to pass if it matches either supplied comparison file. geometry_1.out
replaces the former geometry-positive-zeros.out.
Bruce Momjian [Fri, 13 Dec 2002 20:29:07 +0000 (20:29 +0000)]
Protect from null param on ecpg disconnect, verified by Roland Karch
Tom Lane [Fri, 13 Dec 2002 20:16:11 +0000 (20:16 +0000)]
Add a basic regression test for IS DISTINCT FROM, which has spent way too
much time in a broken state for lack of anyone noticing.
Tom Lane [Fri, 13 Dec 2002 19:46:01 +0000 (19:46 +0000)]
Phase 3 of read-only-plans project: ExecInitExpr now builds expression
execution state trees, and ExecEvalExpr takes an expression state tree
not an expression plan tree. The plan tree is now read-only as far as
the executor is concerned. Next step is to begin actually exploiting
this property.
Tom Lane [Fri, 13 Dec 2002 17:29:25 +0000 (17:29 +0000)]
Adjust costsize calculations to avoid introducing unnecessary roundoff
error. This seems to explain the differing choice of plan that's been
causing geometry regress test to fail for the last few days.
Bruce Momjian [Fri, 13 Dec 2002 05:51:29 +0000 (05:51 +0000)]
Remove strerror output for openssl SYSCALL error check.
Bruce Momjian [Fri, 13 Dec 2002 05:50:18 +0000 (05:50 +0000)]
This patch fixes minor bugs in dictionary generator in contrib/tsearch
(contrib/tsearch/makedict/makedict.pl)
[ Backpatched to 7.3.]
Teodor Sigaev
Bruce Momjian [Fri, 13 Dec 2002 05:49:10 +0000 (05:49 +0000)]
This patch fixes a few typos in the documentation for the '~/.pgpass'
libpq feature.
Neil Conway
Bruce Momjian [Fri, 13 Dec 2002 05:36:24 +0000 (05:36 +0000)]
Here's the patch I mentioned on HACKERS to fix up ALTER command tab
completion. Note that it's based on 7.3 tarball, not CVS HEAD, or 7.3rel
branch. Damn, looking at CVS, this will patch into 7.3rel (just tested,
it does) probably collide with Rod Taylor's patch adding ALTER TRIGGER
stuff. O.K, second patch attached against HEAD - not tested, hand
merged.
Ross Reedstrom
Bruce Momjian [Thu, 12 Dec 2002 22:49:27 +0000 (22:49 +0000)]
> There is an ugly little problem with the DB wrapper class.
>
> In pg.py the attributes of DB are defined as being the same as
> the attributes of the corresponding pgobject "db", using the following
...
> The problem is that the attributes of db (which are read only)
> are not static (they are actually function calls to PostgreSQL),
> especially "status" and "error", but those attributes are copied
> and this is done only once when initializing the DB object.
>
> So, in effect, only the attribute "db.error" of a DB instance
> will be updated, but not the attribute "error". Same with "status".
> Don't copy the (read only) attributes of the pgobject to the
> DB object, but only the methods, and all of them, like this:
>
> --------------- change in pg.py ------------------
> # Create convience methods, in a way that is still overridable.
> for e in self.db.__methods__:
> setattr(self, e, getattr(self.db, e))
> ----------------------------------------------------
>
> Furthermore, make an addition to the documentation of the
> DB wrapper class (i.e. in pygresql-pg-db.html):
> After the sentence "All pgobject methods are included in this class also."
> add the following sentence "The pgobject read-only attributes can be
> accessed py adding the prefix 'db.' to them."
Christoph Zwerschke
Bruce Momjian [Thu, 12 Dec 2002 22:42:39 +0000 (22:42 +0000)]
Check SSL_get_error() value SSL_ERROR_SYSCALL to see if SSL_read()
returned -1, per SSL_get_error() documentation.
Nathan Mueller
Bruce Momjian [Thu, 12 Dec 2002 21:50:01 +0000 (21:50 +0000)]
While porting my TPC-C implementation from Oracle, I discovered the
attached problem with the EXEC SQL COMMIT RELEASE statement.
Roland Karch
Tom Lane [Thu, 12 Dec 2002 21:03:24 +0000 (21:03 +0000)]
Don't produce bogus COPY command when there are no undropped columns
in a table.
Bruce Momjian [Thu, 12 Dec 2002 21:02:25 +0000 (21:02 +0000)]
TODO marked as done:
* Add schema, cast, and conversion backslash commands to psql
I had to create a new publically available function,
pg_conversion_is_visible, as it seemed to be missing from the catalogs.
This required me to do no small amount of hacking around in namespace.c
I have updated the \? help and sgml docs.
\dc - list conversions [PATTERN]
\dC - list casts
\dn list schemas
I didn't support patterns with casts as there's nothing obvious to match
against.
Catalog version incremented --- initdb required.
Christopher Kings-Lynne
Bruce Momjian [Thu, 12 Dec 2002 21:02:21 +0000 (21:02 +0000)]
Done:
> * -Add schema, cast, and conversion backslash commands to psql (Christopher)
Tom Lane [Thu, 12 Dec 2002 21:02:00 +0000 (21:02 +0000)]
Don't force rebuild of all of backend/parser when we only need
keywords.o.
Tom Lane [Thu, 12 Dec 2002 20:35:16 +0000 (20:35 +0000)]
Preliminary code review for domain CHECK constraints patch: add documentation,
make VALUE a non-reserved word again, use less invasive method of passing
ConstraintTestValue into transformExpr, fix problems with nested constraint
testing, do correct thing with NULL result from a constraint expression,
remove memory leak. Domain checks still need much more work if we are going
to allow ALTER DOMAIN, however.
Tom Lane [Thu, 12 Dec 2002 19:16:55 +0000 (19:16 +0000)]
Guard against overrunning CTZName buffer when TZ is bogus.
Tom Lane [Thu, 12 Dec 2002 15:49:42 +0000 (15:49 +0000)]
Phase 2 of read-only-plans project: restructure expression-tree nodes
so that all executable expression nodes inherit from a common supertype
Expr. This is somewhat of an exercise in code purity rather than any
real functional advance, but getting rid of the extra Oper or Func node
formerly used in each operator or function call should provide at least
a little space and speed improvement.
initdb forced by changes in stored-rules representation.
Bruce Momjian [Thu, 12 Dec 2002 00:19:22 +0000 (00:19 +0000)]
Add for protocol changes:
> o Compression?
Bruce Momjian [Wed, 11 Dec 2002 23:07:06 +0000 (23:07 +0000)]
Move psql \? Formatting above Large Object/Copy.
Bruce Momjian [Wed, 11 Dec 2002 23:03:45 +0000 (23:03 +0000)]
psql \? rearrangement, suggested by Tom.
Bruce Momjian [Wed, 11 Dec 2002 22:45:13 +0000 (22:45 +0000)]
Reorder psql \? help into groupings, idea from Harald Armin Massa.
Bruce Momjian [Wed, 11 Dec 2002 22:27:26 +0000 (22:27 +0000)]
Mark SCO Openserver 5.0.4. supported by 7.3.1 as per chat report from user.
template/sco updated.
Bruce Momjian [Wed, 11 Dec 2002 22:17:11 +0000 (22:17 +0000)]
Fix line count error reporting in config files, like pg_hba.conf, per
report from Oliver Elphick.
Backpatch to 7.3.
Dave Cramer [Wed, 11 Dec 2002 21:02:58 +0000 (21:02 +0000)]
patch for getTables to fix problems with backends before 7.3 by Kris Jurka
Dave Cramer [Wed, 11 Dec 2002 12:29:13 +0000 (12:29 +0000)]
Mike Beachy's build patch to allow ant builds without make
Dave Cramer [Wed, 11 Dec 2002 11:42:14 +0000 (11:42 +0000)]
Aaron's patch for Pooled Connections
Bruce Momjian [Wed, 11 Dec 2002 04:09:51 +0000 (04:09 +0000)]
Back out psql help change. Not done yet.
Bruce Momjian [Wed, 11 Dec 2002 04:07:39 +0000 (04:07 +0000)]
Bump version for 7.3 and 7.4.
Bruce Momjian [Tue, 10 Dec 2002 22:27:45 +0000 (22:27 +0000)]
Add:
>
> * Wire Protocol Changes
> o Show transaction status in psql
> o Allow binding of query parameters, support for prepared queries
> o Add optional textual message to NOTIFY
> o Remove hard-coded limits on user/db/password names
> o Remove unused elements of startup packet (unused, tty, passlength)
> o Fix COPY/fastpath protocol?
> o Replication support?
> o Error codes
> o Dynamic character set handling
> o Special passing of binary values in platform-neutral format (bytea?)
> o ecpg improvements?
> o Add decoded type, length, precision
Tom Lane [Tue, 10 Dec 2002 18:23:12 +0000 (18:23 +0000)]
Reverse out unintended resultmap change.
Tom Lane [Tue, 10 Dec 2002 16:12:53 +0000 (16:12 +0000)]
If typecmds is going to have its own header file, said header file
should include what it needs.
D'Arcy J.M. Cain [Tue, 10 Dec 2002 11:43:44 +0000 (11:43 +0000)]
Add an unnecessary assignment to remove a bogus warning. I checked the
logic carefully and I am sure that the test against n happens after it
is assigned to.
Bruce Momjian [Tue, 10 Dec 2002 01:57:46 +0000 (01:57 +0000)]
More minor improvements to the SGML docs, namely
doc/src/sgml/runtime.sgml
Neil Conway
Bruce Momjian [Tue, 10 Dec 2002 01:57:16 +0000 (01:57 +0000)]
Following patch avoids removing oids in the temporary table from the
temporary table.
Kenji Sugita
Bruce Momjian [Mon, 9 Dec 2002 21:26:09 +0000 (21:26 +0000)]
I've simplified the Darwin/Mac OS X startup script I submitted earlier
in the year. This version has only the two files required by the Darwin
startup bundle design. Plus the sh script now uses Darwin-standard
functions to start up PostgreSQL, and it checks for the presence of a
variable in /etc/hostconfig, as do other Darwin startup scripts.
I suggest that a new directory be created,
contrib/start-scripts/darwin, and that these two files be put into it.
Folks who want to use the script can read the comments inside it to
figure out how to use it.
David Wheeler
Bruce Momjian [Mon, 9 Dec 2002 21:03:30 +0000 (21:03 +0000)]
This patch updates doc/src/sgml/runtime.sgml to refer to "MacOS X", not
"OS/X".
Neil Conway
Tom Lane [Mon, 9 Dec 2002 20:31:05 +0000 (20:31 +0000)]
Some quick fixes for ALTER DOMAIN patch. It still needs a lot of work,
but at least it doesn't generate gcc warnings.
Peter Eisentraut [Mon, 9 Dec 2002 19:47:21 +0000 (19:47 +0000)]
Fix Latin9/Unicode conversion by selecting the right table.
Tom Lane [Mon, 9 Dec 2002 18:21:43 +0000 (18:21 +0000)]
Update obsolete comment.
Bruce Momjian [Mon, 9 Dec 2002 18:09:44 +0000 (18:09 +0000)]
Add:
> * Add ROLLUP, CUBE, GROUPING SETS options to GROUP BY
Tom Lane [Fri, 6 Dec 2002 19:28:03 +0000 (19:28 +0000)]
Explain's code for showing quals of SubqueryScan nodes has been broken
all along; not noticed till now. It's a scan not an upper qual ...
Bruce Momjian [Fri, 6 Dec 2002 16:40:13 +0000 (16:40 +0000)]
In the examples, I missed changing a few 'column' and 'table' mentions
to domain when copying alter table docs.
--
Rod Taylor <rbt@rbt.ca>
Bruce Momjian [Fri, 6 Dec 2002 05:20:28 +0000 (05:20 +0000)]
Attached are two small patches to expose md5 as a user function -- including
documentation and regression test mods. It seemed small and unobtrusive enough
to not require a specific proposal on the hackers list -- but if not, let me
know and I'll make a pitch. Otherwise, if there are no objections please apply.
Joe Conway
Bruce Momjian [Fri, 6 Dec 2002 05:18:57 +0000 (05:18 +0000)]
Mention of DEFAULT_STATISTICS_TARGET default.
Jeff Davis
Bruce Momjian [Fri, 6 Dec 2002 05:17:42 +0000 (05:17 +0000)]
This patch improves the documentation for SERIAL columns a little bit.
Neil Conway
Bruce Momjian [Fri, 6 Dec 2002 05:17:03 +0000 (05:17 +0000)]
RANDOM_PAGE_COST clarification of docs.
Joseph Shraibman
Bruce Momjian [Fri, 6 Dec 2002 05:15:02 +0000 (05:15 +0000)]
Thank you very much, you catch it :). This bug had a long life, because it
exists if and only if locale of postmaster
was a different from C (or ru_RU.KOI8-R).
Please, apply patch for current CVS & 7.3.1
Magnus Naeslund(f) wrote:
> Ok, I nailed the bug, but i'm not sure what the correct fix is.
> Attached tsearch_morph.diff that remedies this problem by avoiding it.
> Also there's a debug aid patch if someone would like to know how i
> finally found it out :)
>
> There problem in the lemmatize() function is that GETDICT(...) returned
> a value not handled (BYLOCALE).
> The value (-1) and later used as an index into the dicts[] array.
> After that everything went berserk stack went crazy somehow so trapping
> the fault sent me to the wrong place, and every time i read the value it
> was positive ;)
>
> So now i just return the initial word passed to the lemmatize function,
> because i don't know what to do with it.
Magnus Naeslund
Bruce Momjian [Fri, 6 Dec 2002 05:07:16 +0000 (05:07 +0000)]
Mark ALTER DOMAIN as supported, fix typo in header.
Bruce Momjian [Fri, 6 Dec 2002 05:00:34 +0000 (05:00 +0000)]
Re-addd Rod's ALTER DOMAIN patch.
Bruce Momjian [Fri, 6 Dec 2002 04:40:58 +0000 (04:40 +0000)]
Add file.
Bruce Momjian [Fri, 6 Dec 2002 04:40:36 +0000 (04:40 +0000)]
Add SGML file.
Bruce Momjian [Fri, 6 Dec 2002 04:37:05 +0000 (04:37 +0000)]
Back out V6 code, caused postmaster startup failure.
Bruce Momjian [Fri, 6 Dec 2002 04:18:11 +0000 (04:18 +0000)]
Add missing v6utils file.
Bruce Momjian [Fri, 6 Dec 2002 03:49:19 +0000 (03:49 +0000)]
Updated IPv6 patch to fix netmask.
Bruce Momjian [Fri, 6 Dec 2002 03:46:37 +0000 (03:46 +0000)]
We have just finished porting the old KAME IPv6 patch over to
postgresql version 7.3, but yea... this patch adds full IPv6
support to postgres. I've tested it out on 7.2.3 and has
been running perfectly stable.
CREDITS:
The KAME Project (Initial patch)
Nigel Kukard <nkukard@lbsd.net>
Johan Jordaan <johanj@lando.co.za>
Bruce Momjian [Fri, 6 Dec 2002 03:44:14 +0000 (03:44 +0000)]
Some time ago John Gray <jgray@azuli.co.uk> and myself worked out and
tested a patch to contrib/xml where the existing code was causing
postgres to crash when it encountered & entities in the XML. I've
enclosed a patch that John came up with to correct this problem. It
patches against 7.3 and will apply on 7.2x if the elog WARNING calls
are changed to elog NOTICE.
Michael Richards
Bruce Momjian [Fri, 6 Dec 2002 03:43:35 +0000 (03:43 +0000)]
Back out ALTER DOMAIN patch until missing file appears.
Bruce Momjian [Fri, 6 Dec 2002 03:28:34 +0000 (03:28 +0000)]
ALTER DOMAIN .. SET / DROP NOT NULL
ALTER DOMAIN .. SET / DROP DEFAULT
ALTER DOMAIN .. ADD / DROP CONSTRAINT
New files:
- doc/src/sgml/ref/alter_domain.sgml
Rod Taylor
Bruce Momjian [Fri, 6 Dec 2002 03:19:28 +0000 (03:19 +0000)]
PyGreSQL inserttable patch
=====================
I suggested an improvement of the inserttable in the PyGreSQL interface
already in January, but seemingly it was never implemented. I was told this
is the right place to get patches in for PyGreSQL, so I'm reposting my patch
here.
I consider the inserttable methode essential in populating the database
because of its benefits in performance compared to insert, so I think this
patch is quite essential. The attachment is an improved version of the
corresponding pg_inserttable function in pgmodule.c, which fixes the
following problems:
* The function raised exceptions because PyList_GetItem was used beyond the
size of the list. This was checked by comparing the result with NULL, but
the exception was not cleaned up, which could result in mysterious errors in
the following Python code. Instead of clearing the exception using
PyErr_Clear or something like that, I avoided throwing the exception at all
by at first requesting the size of the list. Using this opportunity, I also
checked the uniformity of the size of the rows passed in the lists/tuples.
The function also accepts (and silently ignores) empty lists and sublists.
* Python "None" values are now accepted and properly converted to PostgreSQL
NULL values
* The function now generates an error message in case of a line buffer
overflow
* It copes with tabulators, newlines and backslashes in strings now
* Rewrote the buffer filling code which should now run faster by avoiding
unnecessary string copy operations forth and back
Christoph Zwerschke
Bruce Momjian [Fri, 6 Dec 2002 03:15:07 +0000 (03:15 +0000)]
With a recent commit truncate is transaction safe in 7.4.
Rod Taylor
Bruce Momjian [Thu, 5 Dec 2002 23:21:07 +0000 (23:21 +0000)]
As far as I figured from the source code this function only deals with
cleaning up locale names and nothing else. Since all the locale names
are in plain ASCII I think it will be safe to use ASCII-only lower-case
conversion.
Nicolai Tufar
Tom Lane [Thu, 5 Dec 2002 22:48:03 +0000 (22:48 +0000)]
localbuf.c must be able to do blind writes.
Tom Lane [Thu, 5 Dec 2002 21:46:37 +0000 (21:46 +0000)]
Avoid pulling up sublinks from a subselect's targetlist. Works around
problems that occur if sublink is referenced via a join alias variable.
Perhaps this can be improved later, but a simple and safe fix is needed
for 7.3.1.
Bruce Momjian [Thu, 5 Dec 2002 21:03:51 +0000 (21:03 +0000)]
It looks like the problem was introduced when the "SET autocommit" and
"SET search_path" commands were added to the beginning of the script.
The attatched patch should fix the problem. It probably should be
applied against the 7.3 and 7.4 branches.
Steven Singer
Bruce Momjian [Thu, 5 Dec 2002 20:30:36 +0000 (20:30 +0000)]
Add:
> * Add SQL99 WITH clause to SELECT (Tom, Fernando)
> * Add SQL99 WITH RECURSIVE to SELECT (Tom, Fernando)
443a444
> * Fernando Nasser <fnasser@redhat.com>
Bruce Momjian [Thu, 5 Dec 2002 18:52:43 +0000 (18:52 +0000)]
Clearify variables names so it is clear which variable is the
client-supplied password and which is from pg_shadow.
Bruce Momjian [Thu, 5 Dec 2002 18:39:43 +0000 (18:39 +0000)]
Allow 'password' encryption even when pg_shadow has MD5 passwords, per
report from Terry Yapt and Hiroshi.
Backpatch to 7.3.
Tom Lane [Thu, 5 Dec 2002 15:50:39 +0000 (15:50 +0000)]
Phase 1 of read-only-plans project: cause executor state nodes to point
to plan nodes, not vice-versa. All executor state nodes now inherit from
struct PlanState. Copying of plan trees has been simplified by not
storing a list of SubPlans in Plan nodes (eliminating duplicate links).
The executor still needs such a list, but it can build it during
ExecutorStart since it has to scan the plan tree anyway.
No initdb forced since no stored-on-disk structures changed, but you
will need a full recompile because of node-numbering changes.
Bruce Momjian [Thu, 5 Dec 2002 05:47:44 +0000 (05:47 +0000)]
Improvements from Neil Conway.
Bruce Momjian [Thu, 5 Dec 2002 04:38:30 +0000 (04:38 +0000)]
Document get/set bit/byte functions.
Bruce Momjian [Thu, 5 Dec 2002 04:04:51 +0000 (04:04 +0000)]
More cleanup of userid to be AclId rather than Oid.
Dave Cramer [Thu, 5 Dec 2002 01:11:43 +0000 (01:11 +0000)]
changed sort of column names to sort by attnum, not attname
Bruce Momjian [Wed, 4 Dec 2002 21:43:07 +0000 (21:43 +0000)]
Update docs mention of query string for debug_ commands, from Joseph
Shraibman.
Tom Lane [Wed, 4 Dec 2002 20:00:37 +0000 (20:00 +0000)]
Repair oversight in recent change of dependency extraction code: when
recursing to handle a join alias var, the context had better be set to
be appropriate to the join var's query level. Per report from Hristo Neshev.
Bruce Momjian [Wed, 4 Dec 2002 18:23:47 +0000 (18:23 +0000)]
Add:
> * Add ALTER SEQUENCE to modify min/max/increment/cache/cycle values
Bruce Momjian [Wed, 4 Dec 2002 18:14:11 +0000 (18:14 +0000)]
Stamp minor version numbers for 7.4 release.
D'Arcy J.M. Cain [Wed, 4 Dec 2002 12:23:42 +0000 (12:23 +0000)]
Remove typprtlen from getdescr() as it is not available in 7.3. Return -1 for
that field so that existing programs don't break.
Bruce Momjian [Wed, 4 Dec 2002 05:18:38 +0000 (05:18 +0000)]
Make usesysid consistently int4, not oid.
Catalog patch from Alvaro Herrera for same.
catversion updated. initdb required.
Bruce Momjian [Tue, 3 Dec 2002 22:10:47 +0000 (22:10 +0000)]
Done:
> * -Add OpenBSD's getpeereid() call for local socket authentication
Bruce Momjian [Tue, 3 Dec 2002 22:09:20 +0000 (22:09 +0000)]
Deal with cases where getpeereid _and_ another creditial method is
supported.
Bruce Momjian [Tue, 3 Dec 2002 21:50:44 +0000 (21:50 +0000)]
Add OpenBSD local indent credentials, from William Ahern.
Bruce Momjian [Tue, 3 Dec 2002 17:38:34 +0000 (17:38 +0000)]
Updated:
< * Add sql3 recursive unions
> * Add SQL99 WITH clause to SELECT
> * Add SQL99 WITH RECURSIVE to SELECT
Tom Lane [Tue, 3 Dec 2002 07:12:18 +0000 (07:12 +0000)]
Fix off-by-one bug in usage check.
Bruce Momjian [Mon, 2 Dec 2002 05:42:36 +0000 (05:42 +0000)]
Add for D'Arcy:
> * Python
> o Allow users to register their own types with _pg
> o Allow SELECT to return a dictionary of dictionaries
> o Allow COPY BINARY FROM
Tom Lane [Mon, 2 Dec 2002 05:20:47 +0000 (05:20 +0000)]
Repair core dump when trying to delete an entry from an already-NULL
datconfig or useconfig field. Per report from Dustin Sallings.
Tom Lane [Mon, 2 Dec 2002 00:29:01 +0000 (00:29 +0000)]
Fix script name in README.
Tom Lane [Mon, 2 Dec 2002 00:28:29 +0000 (00:28 +0000)]
Fix dependency generation for multicolumn foreign keys. From Adam Buraczewski.
Bruce Momjian [Sun, 1 Dec 2002 21:28:01 +0000 (21:28 +0000)]
Done in 7.3, so removed:
< o Allow psql \copy to specify column names
199d197
< o Add SET REAL_FORMAT and SET DOUBLE_PRECISION_FORMAT using printf args
Bruce Momjian [Sun, 1 Dec 2002 21:20:45 +0000 (21:20 +0000)]
Done:
> * -Inline simple SQL functions to avoid overhead (Tom)
Tom Lane [Sun, 1 Dec 2002 21:05:14 +0000 (21:05 +0000)]
Teach planner to expand sufficiently simple SQL-language functions
('SELECT expression') inline, like macros, during the constant-folding
phase of planning. The actual expansion is not difficult, but checking
that we're not changing the semantics of the call turns out to be more
subtle than one might think; in particular must pay attention to
permissions issues, strictness, and volatility.
Tom Lane [Sun, 1 Dec 2002 20:27:32 +0000 (20:27 +0000)]
Fix ExecMakeTableFunctionResult() to work with generic expressions as
well as function calls. This is needed for cases where the planner has
constant-folded or inlined the original function call. Possibly we should
back-patch this change into 7.3 branch as well.
Tom Lane [Sun, 1 Dec 2002 18:44:00 +0000 (18:44 +0000)]
Fix pg_dump failure against 7.1 or older servers, per
report from Philip Warner.
Tom Lane [Sun, 1 Dec 2002 18:14:22 +0000 (18:14 +0000)]
Run COPY OUT in a temporary memory context that's reset once per row,
and eliminate its manual pfree() calls. This solves the encoding-conversion
bug recently reported, and should be faster and more robust than the
original coding anyway. For example, we are no longer at risk if
datatype output routines leak memory or choose to return a constant string.
Tom Lane [Sat, 30 Nov 2002 21:25:08 +0000 (21:25 +0000)]
Code review for IS DISTINCT FROM patch. Fix incorrect constant-folding
logic, dissuade planner from thinking that 'x IS DISTINCT FROM 42' may
be optimized into 'x = 42' (!!), cause dependency on = operator to be
recorded correctly, minor other improvements.
Tom Lane [Sat, 30 Nov 2002 18:28:49 +0000 (18:28 +0000)]
Missed one place that can be simplified after recent Param/Const cleanup.
Tom Lane [Sat, 30 Nov 2002 05:21:03 +0000 (05:21 +0000)]
Be more realistic about plans involving Materialize nodes: take their
cost into account while planning.
Tom Lane [Sat, 30 Nov 2002 00:22:39 +0000 (00:22 +0000)]
Make install and clean targets behave more normally.