OSDN Git Service
Philip Quinn [Tue, 11 Jul 2017 16:44:49 +0000 (16:44 +0000)]
Merge "Hide the Keyguard bottom area overlay when dozing." into oc-dr1-dev
TreeHugger Robot [Tue, 11 Jul 2017 16:28:44 +0000 (16:28 +0000)]
Merge "Fix zen panel theming" into oc-dr1-dev
TreeHugger Robot [Tue, 11 Jul 2017 16:24:50 +0000 (16:24 +0000)]
Merge "Try to work on test flakyness." into oc-dr1-dev
Christine Franks [Tue, 11 Jul 2017 14:37:06 +0000 (14:37 +0000)]
Merge "Support demo mode and demo users" into oc-dr1-dev
Jason Monk [Tue, 11 Jul 2017 14:13:31 +0000 (10:13 -0400)]
Fix zen panel theming
The theme of the panel might be different than sysui now, so it
needs to use the right context.
Test: visual
Change-Id: Ic647421113f6721e63e69afc2b9c5d6c5b0e86f2
Fixes:
63530105
Jason Monk [Tue, 11 Jul 2017 14:05:03 +0000 (10:05 -0400)]
Try to work on test flakyness.
- Add bt permission
- mock more BT stuff
- Disable test that is causing crash on main thread
Test: runtest systemui
Change-Id: I5cddb71941cce4f9b595c65ef69919186addb6df
Fixes:
63568935
TreeHugger Robot [Tue, 11 Jul 2017 13:25:01 +0000 (13:25 +0000)]
Merge "Lock pattern should be red when error" into oc-dr1-dev
Bill Yi [Tue, 11 Jul 2017 04:00:23 +0000 (04:00 +0000)]
Merge "Import translations. DO NOT MERGE" into oc-dev
am:
88e9aa19e2 -s ours
Change-Id: Id4a8d9d891b06a789132f9d9915306f336f52902
TreeHugger Robot [Tue, 11 Jul 2017 03:57:08 +0000 (03:57 +0000)]
Merge "Import translations. DO NOT MERGE" into oc-dr1-dev
Bill Yi [Tue, 11 Jul 2017 03:52:59 +0000 (03:52 +0000)]
Import translations. DO NOT MERGE am:
48cf1d9768 -s ours
am:
829d7186d5 -s ours
Change-Id: I16754fc3b6c9df4b415d8c74ffe390787e932f8c
TreeHugger Robot [Tue, 11 Jul 2017 03:50:19 +0000 (03:50 +0000)]
Merge "Import translations. DO NOT MERGE" into oc-dev
Bill Yi [Tue, 11 Jul 2017 03:43:57 +0000 (03:43 +0000)]
Import translations. DO NOT MERGE
am:
48cf1d9768 -s ours
Change-Id: If7328a10566daf60ac6da033923b1acbb307865f
TreeHugger Robot [Tue, 11 Jul 2017 01:48:08 +0000 (01:48 +0000)]
Merge "Move eUICC permissions to com.android namespace." into oc-dr1-dev
Christine Franks [Sat, 24 Jun 2017 01:12:46 +0000 (18:12 -0700)]
Support demo mode and demo users
Bug:
62712426
Test: run cts -m CtsDevicePolicyManagerTestCases -t \
com.android.cts.devicepolicy.DeviceOwnerTest#testCreateAndManageEphemeralUser
and
run cts -m CtsDevicePolicyManagerTestCases -t \
com.android.cts.devicepolicy.DeviceOwnerTest# \
testCreateAndManageEphemeralUserFailsWithoutSplitSystemUser
and
runtest -c com.android.server.devicepolicy.DevicePolicyManagerTest \
frameworks-services
Change-Id: I77a71a994fe0f4f1f8c5df7c4ccf493aafa8fefe
TreeHugger Robot [Tue, 11 Jul 2017 00:46:11 +0000 (00:46 +0000)]
Merge "Catch exception in descriptor parser causes device connection to be skipped." into oc-dr1-dev
Lucas Dupin [Mon, 10 Jul 2017 23:33:02 +0000 (16:33 -0700)]
Lock pattern should be red when error
Test: visual
Change-Id: I133ac629ca7ee6ae7e049711d024e6f776b10331
Fixes:
63450674
Bill Yi [Mon, 10 Jul 2017 21:56:13 +0000 (14:56 -0700)]
Import translations. DO NOT MERGE
Change-Id: I6f7c93454c795da3db06572b1cddf9691ec4ff8e
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
TreeHugger Robot [Mon, 10 Jul 2017 21:21:54 +0000 (21:21 +0000)]
Merge "Eliminate a race condition that could lead to calling PBT#finalizeBackup() twice" into oc-dr1-dev
Bill Yi [Mon, 10 Jul 2017 21:17:29 +0000 (14:17 -0700)]
Import translations. DO NOT MERGE
Change-Id: I0d78e510a92213c8cd7bf2ba96e756418b79aba8
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
Bill Yi [Mon, 10 Jul 2017 21:08:01 +0000 (14:08 -0700)]
Import translations. DO NOT MERGE
Change-Id: Ic838cd08ba00fe8aaf462f7de5908e63bcea79f5
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
Paul McLean [Mon, 10 Jul 2017 20:51:57 +0000 (14:51 -0600)]
Catch exception in descriptor parser causes device connection to be skipped.
Bug:
63538159
Test: Manual - force an exception and verify the the device is still available.
Change-Id: I4f4c59d4d0f73b664fac8bc74a64414d0e9d9a24
Chen Xu [Mon, 10 Jul 2017 20:51:52 +0000 (20:51 +0000)]
Merge "fix cellular captive portal reevaluation url" into oc-dr1-dev
TreeHugger Robot [Mon, 10 Jul 2017 20:36:07 +0000 (20:36 +0000)]
Merge "Fix RTL mobile data type indicators" into oc-dr1-dev
TreeHugger Robot [Mon, 10 Jul 2017 20:17:56 +0000 (20:17 +0000)]
Merge "Add screensaver settings to backup list" into oc-dr1-dev
fionaxu [Mon, 10 Jul 2017 16:34:07 +0000 (09:34 -0700)]
fix cellular captive portal reevaluation url
we apply redirection link as the url everywhere for cellular captive portal.
this url should only be used when load the portal page at the first place (when users
click on the notification) and shouldn't be used as the re-evaluation url
as it wont return the expected response code.
instead we should use special URL (generate_204) from connectivity
service which will return 204 if redirection is gone.
Test: manual test with cold and hot TMO SIM
Bug:
63351490
Bug:
62532802
Change-Id: I56bb03a58447c5c46758e692ff357d540ea4cd7b
Jason Monk [Mon, 10 Jul 2017 15:14:19 +0000 (11:14 -0400)]
Add screensaver settings to backup list
Test: manual
Change-Id: Icf47312e20b4ec44d02dc31ce575e89083a8be7d
Fixes:
35700553
Evan Laird [Mon, 10 Jul 2017 17:00:39 +0000 (13:00 -0400)]
Fix RTL mobile data type indicators
Data type indicators were drawing too big for their containers and
causing the data type overlays not to obey RTL. Also tweaked some sizes
to fix RTL.
Change-Id: I1aee7397976e77d2b834b163bf7fa7cf2a008968
Fixes:
62538496
Test: visual (RTL mode)
Winson Chung [Mon, 10 Jul 2017 17:12:35 +0000 (17:12 +0000)]
Merge "Fix issue with PiP touch drift." into oc-dr1-dev
Julia Reynolds [Mon, 10 Jul 2017 16:55:01 +0000 (16:55 +0000)]
Merge "Limit the number of notis an app can enqueue" into oc-dr1-dev
Lucas Dupin [Mon, 10 Jul 2017 16:49:33 +0000 (16:49 +0000)]
Merge "Add theme style flag to WallpaperColors" into oc-dr1-dev
TreeHugger Robot [Mon, 10 Jul 2017 15:57:32 +0000 (15:57 +0000)]
Merge "Rate limit notification sounds/vibrations" into oc-dr1-dev
Bryce Lee [Mon, 10 Jul 2017 14:21:37 +0000 (14:21 +0000)]
Merge "Add app bounds to Configuration#compareTo." into oc-dr1-dev
Julia Reynolds [Wed, 5 Jul 2017 12:47:03 +0000 (08:47 -0400)]
Limit the number of notis an app can enqueue
In addition to the number they can post. Also decrease
the number of posts per second to 5, but allow finished
progress notifications through.
Fixes:
63173849
Fixes:
63167456
Test: runtests systemui-notification & simultaneously
downloading 5 files.
Change-Id: I0c8ea35b3d9d38b000ea5fe383515e1d5a26bac7
Julia Reynolds [Mon, 19 Jun 2017 12:16:04 +0000 (08:16 -0400)]
Rate limit notification sounds/vibrations
1 alert per second.
Bug:
36662487
Test: runtest systemui-notification
Change-Id: I2046ae17b9e89ac0a83e182b91422fd242bc7557
Michal Karpinski [Fri, 7 Jul 2017 14:30:50 +0000 (15:30 +0100)]
Eliminate a race condition that could lead to calling PBT#finalizeBackup() twice
Calling finalizeBackup() the second time will most probably lead to underholding
the wakelock and system crash.
Bug:
63156509
Test: manual
Change-Id: Ic995ba4a65d749b80bf1f1d226d35a279a0d1b25
Philip Quinn [Sat, 8 Jul 2017 19:59:24 +0000 (12:59 -0700)]
Hide the Keyguard bottom area overlay when dozing.
Fixes:
63152136
Test: enter/leave AOD; observe absence/presence of overlay view
Change-Id: I4ef103e769f5d67308ededa427b1016f1a28cf8d
TreeHugger Robot [Sat, 8 Jul 2017 03:06:37 +0000 (03:06 +0000)]
Merge "Change initial value of mStaleScanResults to true." into oc-dr1-dev
Sundeep Ghuman [Wed, 5 Jul 2017 21:19:30 +0000 (14:19 -0700)]
Change initial value of mStaleScanResults to true.
In ag/
2409026 we introduced a stale scan result bit to prevent callbacks
from sticky broadcasts from occuring until we have fetched the latest
set of scan results. However, this initial value was set to false hence
there is a race condition in which the currently connected network can
still be shown without any other networks, as the scan results have not
yet been processed.
By changing the initial value to true, we address this race condition.
Bug: b/
62493360
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java
Change-Id: I5f2108e17d2c549e2176ccf64e640fbd4808b5f1
TreeHugger Robot [Sat, 8 Jul 2017 00:21:44 +0000 (00:21 +0000)]
Merge "Moving color extraction classes" into oc-dr1-dev
Winson Chung [Fri, 7 Jul 2017 21:49:49 +0000 (14:49 -0700)]
Fix issue with PiP touch drift.
- Fix issue with cumulative truncation of positions causing a large x/y
error causing drift. Instead of using the rounded stack position,
keep track of the cumulative delta and apply that on each move.
Bug:
62541932
Test: Pip activity, move around with finger and ensure no drift
Change-Id: Ic7737a6b19672ee8a1d98fd57f84a1d89f4a17e9
Etan Cohen [Fri, 7 Jul 2017 23:13:34 +0000 (23:13 +0000)]
Merge "[AWARE] Fix close guard method name" into oc-dr1-dev
Derek Tan [Fri, 7 Jul 2017 23:12:44 +0000 (23:12 +0000)]
Merge "Prevent any app except LPA to create logical channel to AID of ISD-R." into oc-dr1-dev
Wale Ogunwale [Fri, 7 Jul 2017 23:09:55 +0000 (23:09 +0000)]
Merge "Don't remove starting window for visible app." into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 21:43:46 +0000 (21:43 +0000)]
Merge "Add logging for unusually long read times" into oc-dr1-dev
Lucas Dupin [Thu, 29 Jun 2017 19:20:29 +0000 (12:20 -0700)]
Add theme style flag to WallpaperColors
Theme colors should always be the same in sysui and launcher.
We're now sharing a hint HINT_SUPPORTS_DARK_THEME, to make sure
we're never out of sync.
Test: runtest -x tests/Internal/src/android/app/WallpaperColorsTest.java
Fixes:
63140091
Change-Id: Ibd196f540d77269df377804b0f4d4d0d20820067
TreeHugger Robot [Fri, 7 Jul 2017 19:37:19 +0000 (19:37 +0000)]
Merge "Fix RTL drawing for QS tiles in edit mode" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 19:34:49 +0000 (19:34 +0000)]
Merge "Update brightness icon to rounded one" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 19:31:54 +0000 (19:31 +0000)]
Merge "Make BatterySaverTile controlled by pluggIn state" into oc-dr1-dev
Julia Reynolds [Fri, 7 Jul 2017 19:24:37 +0000 (19:24 +0000)]
Merge "Allow setup apps to colorize notifications." into oc-dr1-dev
Andrew Solovay [Fri, 7 Jul 2017 19:09:39 +0000 (19:09 +0000)]
Merge "docs: Described why ProgressDialog is now deprecated." into oc-dev
am:
1cdf4244f4
Change-Id: I1c25c17f1f73e4006e3b0fa9479d5b0563c6be98
TreeHugger Robot [Fri, 7 Jul 2017 19:07:32 +0000 (19:07 +0000)]
Merge "AOD: Block when fingerprint is already authenticated but waiting for goingToSleep to complete" into oc-dr1-dev
Andrew Solovay [Fri, 7 Jul 2017 19:02:48 +0000 (19:02 +0000)]
Merge "docs: Described why ProgressDialog is now deprecated." into oc-dev
TreeHugger Robot [Fri, 7 Jul 2017 17:55:54 +0000 (17:55 +0000)]
Merge "Fix announcement of global actions menu" into oc-dr1-dev
Lucas Dupin [Thu, 6 Jul 2017 21:35:30 +0000 (14:35 -0700)]
Moving color extraction classes
Fixes:
62220212
Test: make
Test: runtest -x tests/Internal/src/com/android/internal/colorextraction/ColorExtractorTest.java
Test: runtest -x tests/Internal/src/com/android/internal/colorextraction/types/TonalTest.java
Test: runtest systemui
Change-Id: I7c4cf5c40a88555e81fbad9bec2b32c55c927468
Merged-In: I7c4cf5c40a88555e81fbad9bec2b32c55c927468
Evan Laird [Tue, 27 Jun 2017 17:33:40 +0000 (13:33 -0400)]
Update brightness icon to rounded one
This is part of the icon updates for DR. Should be there.
Test: visual
Bug:
62668861
Change-Id: I11c8ddd99de90c319143292cd32441d14eb7fc1d
(cherry picked from commit
801705bbea9637bf709e4579ef708f90bb92e311)
TreeHugger Robot [Fri, 7 Jul 2017 17:40:13 +0000 (17:40 +0000)]
Merge "AOD: Fix possible NPE in DozeSensors" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 17:28:10 +0000 (17:28 +0000)]
Merge "AOD: Finish pulse when notification is removed" into oc-dr1-dev
Evan Laird [Fri, 7 Jul 2017 17:24:56 +0000 (13:24 -0400)]
Fix RTL drawing for QS tiles in edit mode
When in RTL mode, sometimes the tile displaying the mobile signal was
not properly set (was drawing as LTR). Setting it explicitly during
QSIconViewImpl#updateTile() fixes the issue.
Test: visual
Bug:
63160044
Change-Id: If00b149ca0372fc3d51fc2ee53a43e3b74e78791
Lucas Dupin [Fri, 7 Jul 2017 17:23:22 +0000 (17:23 +0000)]
Merge "WallpaperColors caching and synchronization" into oc-dr1-dev
Julia Reynolds [Fri, 30 Jun 2017 17:34:01 +0000 (13:34 -0400)]
Allow setup apps to colorize notifications.
Fixes:
63147379
Test: runtest systemui-notification, core tests
Change-Id: I2077a9fd563826d978d0dc01be89dd0bbc09eebf
Adrian Roos [Fri, 7 Jul 2017 17:02:34 +0000 (19:02 +0200)]
AOD: Block when fingerprint is already authenticated but waiting for goingToSleep to complete
Improves an issue where immediately triggering fingerprint after
the devices goes to sleep results in a lot of flickering.
There's still flicker however if the fingerprint authenticates after we've requested the AOD
display state, but before it has actually been applied.
Bug:
62887179
Test: Go to Home. Lock screen. Immediately unlock via fingerprint. Verify that the AOD screen does not even show.
Change-Id: Ib6425eee803a8c7e02f9621a571e562e825af57f
TreeHugger Robot [Fri, 7 Jul 2017 17:00:12 +0000 (17:00 +0000)]
Merge "Fix clipping of large global actions items" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 16:42:03 +0000 (16:42 +0000)]
Merge "AOD: Do not animate notification icons while dozing" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 16:10:13 +0000 (16:10 +0000)]
Merge "AOD: Keep doze brightness when unlocking with fingerprint" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 15:52:21 +0000 (15:52 +0000)]
Merge "Import translations. DO NOT MERGE" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 15:40:25 +0000 (15:40 +0000)]
Merge "Import translations. DO NOT MERGE" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 15:39:04 +0000 (15:39 +0000)]
Merge "Import translations. DO NOT MERGE" into oc-dr1-dev
Jason Monk [Fri, 7 Jul 2017 15:35:13 +0000 (11:35 -0400)]
Fix announcement of global actions menu
Make sure it has focus when it opens so that it can announce.
Test: manual
Change-Id: Ie1795faf5c9b79eb20f538b9dc6f4cb1f04babfb
Fixes:
62433101
Adrian Roos [Fri, 7 Jul 2017 15:10:11 +0000 (17:10 +0200)]
AOD: Finish pulse when notification is removed
Change-Id: I346e7ef77cc3c9bb2c72bd028953f0e5ff757502
Fixes:
38174509
Test: receive notification while phone off (with or without AOD). Swipe away notification. Verify that it goes back to the base state immediately
Jason Monk [Fri, 7 Jul 2017 14:36:03 +0000 (10:36 -0400)]
Fix clipping of large global actions items
Test: visual
Change-Id: I9f652642055d190e2368dab89fe56518fb15eb19
Fixes:
63150552
Adrian Roos [Fri, 7 Jul 2017 13:58:57 +0000 (15:58 +0200)]
AOD: Keep doze brightness when unlocking with fingerprint
Updates the logic that was already in place to prevent lighting up
the display before the unlock transition starts:
- treat AOD as pulsing in FingerprintUnlockController
- now that doze can use more than one brightness level, use the current
Bug:
62885451
Test: Unlock with fingerprint from AOD. Observe that the unlock transition does not prematurely change the brightness level
Change-Id: I266bd5e4c0a1d5b4c347a65c0e7936247e333cfc
Wale Ogunwale [Thu, 6 Jul 2017 22:30:55 +0000 (15:30 -0700)]
Don't remove starting window for visible app.
Activity manager agressively removes starting windows to avoid leaks.
See ag/696830 and ag/
1213075 for some history. However, it is possible
for window manager to process the request of removing the starting window
coming from activity manager while the app token for the starting window
is still visible from the window manager side because we are delaying
hiding it due to an animation in progress.
We now only process the request to remove starting window from the
activity manager side if the app is hidden on the window manager side.
Change-Id: Ia33076f0e7405f9430e9d4e9d4026ae6fd1b133e
Fixes:
62443388
Test: go/wm-smoke
Test: Swipe Gmail away in Recents, launch Chome, press home button, launch Gmail, and press the home button.
Jason Monk [Fri, 7 Jul 2017 12:36:11 +0000 (12:36 +0000)]
Merge "Fix translation direction in QS animation" into oc-dr1-dev
Adrian Roos [Fri, 7 Jul 2017 11:22:51 +0000 (11:22 +0000)]
Merge "Keeping notifications around that show guts" into oc-dr1-dev
Adrian Roos [Fri, 7 Jul 2017 10:20:21 +0000 (12:20 +0200)]
AOD: Fix possible NPE in DozeSensors
Fixes an NPE that can happen if the ProximitySensor callback
unregisters the proximity sensor.
Change-Id: I8df1cf98e5334b3ff35c19b30bb7e01d0ebcfd6a
Fixes:
63357752
Test: Squint at the code *really hard*
Adrian Roos [Fri, 7 Jul 2017 10:03:05 +0000 (10:03 +0000)]
Merge "AOD: Add logging" into oc-dr1-dev
Bill Yi [Fri, 7 Jul 2017 09:16:14 +0000 (02:16 -0700)]
Import translations. DO NOT MERGE
Change-Id: I0f7d8a0b363893098604e0b912974ca56b67100c
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
TreeHugger Robot [Fri, 7 Jul 2017 06:13:55 +0000 (06:13 +0000)]
Merge "Add more logging to the Tethering SharedLog" into oc-dr1-dev
Bill Yi [Fri, 7 Jul 2017 05:45:34 +0000 (22:45 -0700)]
Import translations. DO NOT MERGE
Change-Id: I00e4f252a805a1085523991237cfd84b4b397865
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
TreeHugger Robot [Fri, 7 Jul 2017 03:34:24 +0000 (03:34 +0000)]
Merge "Fix keyguard visibilities after reinflate" into oc-dr1-dev
Bill Yi [Fri, 7 Jul 2017 03:30:32 +0000 (20:30 -0700)]
Import translations. DO NOT MERGE
Change-Id: I5949b2f491bc3cf64d2b205ed5af758316ee9ac4
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
Robert Carr [Fri, 7 Jul 2017 03:22:50 +0000 (03:22 +0000)]
Merge "SurfaceView: Avoid initializing Surface from an invalid SurfaceControl." into oc-dev
am:
401b8907d0
Change-Id: Ib7a916fb484fb3a7924315169d162f4fdddd8a06
TreeHugger Robot [Fri, 7 Jul 2017 03:10:12 +0000 (03:10 +0000)]
Merge "SurfaceView: Avoid initializing Surface from an invalid SurfaceControl." into oc-dev
Bryce Lee [Fri, 7 Jul 2017 02:38:38 +0000 (02:38 +0000)]
Merge "Revert "Use configuration delta to determine if still in orientation change."" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 01:38:01 +0000 (01:38 +0000)]
Merge "Fix Configuration#updateFrom() when assetsSeq doesn't change" into oc-dr1-dev
TreeHugger Robot [Fri, 7 Jul 2017 01:29:54 +0000 (01:29 +0000)]
Merge "Color of the ring around the lock icon" into oc-dr1-dev
Bryce Lee [Fri, 7 Jul 2017 00:51:26 +0000 (17:51 -0700)]
Revert "Use configuration delta to determine if still in orientation change."
This reverts commit
2a0284b1a69b57cc239357c9a5fbb514cf2fc8b2.
Reason for revert: b/
63380251
Bug:
62846907
Fixes:
63380251
Change-Id: I18eb9e478cb2b99980a2e9bff22ba9b32b817f2f
TreeHugger Robot [Fri, 7 Jul 2017 00:12:08 +0000 (00:12 +0000)]
Merge "Hide all color hints references" into oc-dr1-dev
TreeHugger Robot [Thu, 6 Jul 2017 23:50:32 +0000 (23:50 +0000)]
Merge "Make dun APNs as read-only by default." into oc-dr1-dev
TreeHugger Robot [Thu, 6 Jul 2017 23:46:42 +0000 (23:46 +0000)]
Merge "Add a MetricsEvent entry for BT forget device confirm dialog" into oc-dr1-dev
Robert Carr [Thu, 6 Jul 2017 22:28:34 +0000 (15:28 -0700)]
SurfaceView: Avoid initializing Surface from an invalid
SurfaceControl.
In a recent CL we introduced a call to Surface#createFrom, in order to
recreate the Surface object from the underlying SurfaceControl, as a
workaround to emulate when it was parcelled over binder in the past.
However this is causing BufferQueue abandoned errors when stopping and
resuming some applications. To understand them, we need to revisit the
SurfaceView destruction process when handling onStop.
First mWindowStopped will be set to true (SurfaceView#windowStopped),
and we should then enter updateSurface. Our requested visibility will
now be false and so we emit the Surface destroyed callbacks. Notice in
the finally block in mUpdateSurface, we will release mSurface, but we
will NOT null mSurfaceControl. Inline documentation explains why.
In the case that the activity is not actually being destroyed, it's
possible that we may not get a dispatchDetachedFromWindow. This means
that we will not null mSurfaceControl. Now if the activity is
un-stopped and we re-enter updateSurface we encounter a problem
state. "creating" will be set to false since mSurfaceControl != null,
however mSurfaceControl will not point to a valid surface.
Prior to the introduction of the #createFrom call, this unwanted state
didn't cause any problems. Because mSurface was released back in the
finally block as we were stopping we now fall out of the
mSurface.isValid() block in updateSurface. As we reach the finally
block again, we would now set mSurfaceControl=null since the app was
no longer stopped. Later when we reach updateSurface again (which
tends to happen quite often) it will now be null and we will correctly
set creating=true, create a valid SurfaceControl, and move along
happily. However following, the introduction of this
Surface#createFrom call we will now reinitialize the Surface from an
invalid underlying SurfaceControl. This means we will enter the
mSurface.isValid block, but will proceed to emit an invalid Surface to
the client in the callbacks.
We avoid this state by making creating=true even if
SurfaceControl=non-null when the calculated visibility changes from
invisible to visible.
Bug:
63251745
Test: Manual of app from bug and apps from previous related bugs. go/wm-smoke. Additional manual testing of many SV apps.
Change-Id: Icc32a34cac239d65267da705cc23feb23e1ceb67
TreeHugger Robot [Thu, 6 Jul 2017 22:39:48 +0000 (22:39 +0000)]
Merge changes from topic 'nci-2.0-part2' into oc-dr1-dev
* changes:
NCI2.0 update LF_T3T_PARAMETERS of 18 byte.
AID suffix registration.
TreeHugger Robot [Thu, 6 Jul 2017 22:38:16 +0000 (22:38 +0000)]
Merge "DO NOT MERGE Ensure minimized state is false when dock is gone on exists change" into oc-dr1-dev
Daniel Nishi [Thu, 6 Jul 2017 21:58:41 +0000 (21:58 +0000)]
Merge "Add a Setting for whether or not we have been disabled by policy." into oc-dr1-dev
Adam Lesinski [Thu, 6 Jul 2017 19:06:13 +0000 (12:06 -0700)]
Fix Configuration#updateFrom() when assetsSeq doesn't change
Compare the value of assetsSeq when updating Configuration from
a delta.
Bug:
63352177
Test: manual
Change-Id: I9e1205cd64c4a1e0192b7049c82d36d53fb4af36
(cherry picked from commit
2123c415bf4cc67ad2c50e9613c7748956cd0c46)
TreeHugger Robot [Thu, 6 Jul 2017 21:49:37 +0000 (21:49 +0000)]
Merge "Only play up effect if its been over 100 ms" into oc-dr1-dev
TreeHugger Robot [Thu, 6 Jul 2017 21:38:06 +0000 (21:38 +0000)]
Merge "Fix crash when no StatusBarView" into oc-dr1-dev
TreeHugger Robot [Thu, 6 Jul 2017 21:29:57 +0000 (21:29 +0000)]
Merge "Fix leak in ScrimView" into oc-dr1-dev
TreeHugger Robot [Thu, 6 Jul 2017 21:25:39 +0000 (21:25 +0000)]
Merge "Fix nav accessibility order" into oc-dr1-dev
Anthony Chen [Thu, 6 Jul 2017 21:14:47 +0000 (21:14 +0000)]
Merge "Fix bug where RemoteViews addView is backwards." into oc-dr1-dev