OSDN Git Service
Tom Lane [Tue, 9 Dec 2003 01:56:20 +0000 (01:56 +0000)]
query_tree_mutator should copy RangeTblEntry nodes even when it's not
planning to modify them itself. Otherwise we end up with shared RTE
substructure, which breaks inheritance_planner because the rte->inh
flag needs to be independent in each copied subquery. Per bug report
from Chris Piker.
Tom Lane [Mon, 8 Dec 2003 21:54:00 +0000 (21:54 +0000)]
Minor autovacuum fixes from Matthew O'Connor.
Tom Lane [Mon, 8 Dec 2003 21:51:31 +0000 (21:51 +0000)]
Add fflush() before sleeping, per Matthew O'Connor.
Tom Lane [Mon, 8 Dec 2003 18:19:58 +0000 (18:19 +0000)]
Whole-row references were broken for subqueries and functions, because
attr_needed/attr_widths optimization failed to allow for Vars with attno
zero in this case. Per report from Tatsuo Ishii.
Tom Lane [Mon, 8 Dec 2003 16:39:05 +0000 (16:39 +0000)]
Work around naming conflict between zlib and OpenSSL by tweaking inclusion
order. Remove some unnecessary #includes (that duplicate c.h).
Bruce Momjian [Mon, 8 Dec 2003 13:04:14 +0000 (13:04 +0000)]
Done:
< * COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT | LANGUAGE ]
> * -COMMENT ON [ CAST | CONVERSION | OPERATOR CLASS | LARGE OBJECT | LANGUAGE ]
263c263
< * Allow pg_dump to dump CREATE CONVERSION (Christopher)
> * -Allow pg_dump to dump CREATE CONVERSION (Christopher)
Tom Lane [Sun, 7 Dec 2003 19:55:58 +0000 (19:55 +0000)]
Replace unportable and overflow-prone use of 'long long' with safer
'double' arithmetic, per recent discussion.
Tom Lane [Sun, 7 Dec 2003 19:43:02 +0000 (19:43 +0000)]
Remove test on c.relkind from check_constraints view; unnecessary and
prevents view from showing constraints on domains. This addresses the
other half of Claus Colloseus' bug report.
Peter Eisentraut [Sun, 7 Dec 2003 10:21:58 +0000 (10:21 +0000)]
Fix typmod interpretation for bit types. (It was erroneously assumed that
for bit(x), the typmod stores x+4, like for the character types.)
Tom Lane [Sun, 7 Dec 2003 05:44:50 +0000 (05:44 +0000)]
One more pass at reducing the cost of pg_dump's new implementation:
reduce the number of times TopoSort() has to be executed by trying to
extract multiple dependency loops from each pass, instead of only one.
This saves about another factor of ten on the regression database.
This could be considered as another exercise in grokking Fred Brooks'
maxim: Representation *is* the essence of programming.
Joe Conway [Sun, 7 Dec 2003 04:14:10 +0000 (04:14 +0000)]
Repair indexed bytea like operations, and related selectivity
functionality. Per bug report by Alvar Freude:
http://archives.postgresql.org/pgsql-bugs/2003-12/msg00022.php
Tom Lane [Sun, 7 Dec 2003 03:14:01 +0000 (03:14 +0000)]
Speed up findObjectByCatalogId() to get rid of the other salient
bottleneck in the new pg_dump code.
Bruce Momjian [Sun, 7 Dec 2003 00:54:05 +0000 (00:54 +0000)]
Done:
> * -Use dependency information to dump data in proper order
Joe Conway [Sat, 6 Dec 2003 23:10:23 +0000 (23:10 +0000)]
Documentation update for previously committed changes: read-only GUC variables
and pg_settings view.
Tom Lane [Sat, 6 Dec 2003 22:55:11 +0000 (22:55 +0000)]
Replace not-very-bright implementation of topological sort with a better
one (use a priority heap to keep track of items ready to output, instead
of searching the input array each time). This brings the runtime of
pg_dump back to about what it was in 7.4.
Tom Lane [Sat, 6 Dec 2003 03:00:16 +0000 (03:00 +0000)]
Massive overhaul of pg_dump: make use of dependency information from
pg_depend to determine a safe dump order. Defaults and check constraints
can be emitted either as part of a table or domain definition, or
separately if that's needed to break a dependency loop. Lots of old
half-baked code for controlling dump order removed.
Tom Lane [Fri, 5 Dec 2003 15:50:31 +0000 (15:50 +0000)]
Guard against bug in Solaris' bsearch(), per Michael Wildpaner.
Teodor Sigaev [Fri, 5 Dec 2003 15:37:51 +0000 (15:37 +0000)]
One more fix confusion
Teodor Sigaev [Fri, 5 Dec 2003 14:27:42 +0000 (14:27 +0000)]
Avoid confusion start_parse_str function with tsearch V1
Peter Eisentraut [Thu, 4 Dec 2003 21:24:56 +0000 (21:24 +0000)]
Markup improvements
Teodor Sigaev [Thu, 4 Dec 2003 12:21:11 +0000 (12:21 +0000)]
Avoid conflict strndup with glibc
Joe Conway [Wed, 3 Dec 2003 18:53:52 +0000 (18:53 +0000)]
catversion change needed by previous read-onlu GUC variables commit.
Joe Conway [Wed, 3 Dec 2003 18:52:00 +0000 (18:52 +0000)]
Added new group of read-only GUC variables to allow simple access
to certain compile-time options (FUNC_MAX_ARGS, INDEX_MAX_KEYS,
NAMEDATALEN, BLCKSZ, HAVE_INT64_TIMESTAMP). Also added "category",
"short_desc", and "extra_desc" to the pg_settings view. Per recent
discussion here:
http://archives.postgresql.org/pgsql-patches/2003-11/msg00363.php
Tom Lane [Wed, 3 Dec 2003 17:45:10 +0000 (17:45 +0000)]
Planner failed to be smart about binary-compatible expressions in pathkeys
and hash bucket-size estimation. Issue has been there awhile but is more
critical in 7.4 because it affects varchar columns. Per report from
Greg Stark.
Teodor Sigaev [Wed, 3 Dec 2003 16:07:48 +0000 (16:07 +0000)]
Fix for word with several infinitives
Michael Meskes [Wed, 3 Dec 2003 08:49:17 +0000 (08:49 +0000)]
Added patch by Dave Cramer for array handling in ecpglib.
Joe Conway [Tue, 2 Dec 2003 19:26:47 +0000 (19:26 +0000)]
Add a warning to AtEOXact_SPI() to catch cases where the current
transaction has been committed without SPI_finish() being called
first. Per recent discussion here:
http://archives.postgresql.org/pgsql-patches/2003-11/msg00286.php
Tom Lane [Tue, 2 Dec 2003 16:14:12 +0000 (16:14 +0000)]
Update release notes for 7.3.5.
Peter Eisentraut [Tue, 2 Dec 2003 10:24:37 +0000 (10:24 +0000)]
Fix some small errors.
Tom Lane [Tue, 2 Dec 2003 00:26:59 +0000 (00:26 +0000)]
Code and docs review for numeric-factorial patch.
Bruce Momjian [Mon, 1 Dec 2003 23:19:33 +0000 (23:19 +0000)]
I've run across a pretty serious problem with pg_autovacuum.
pg_autovacuum looses track of any table that's ever been truncated
(possibly other situations too). When i truncate a table it gets a
new relfilenode in pg_class. This is a problem because pg_autovacuum
assumes pg_class.relfilenode will join to pg_stats_all_tables.relid.
pg_stats_all_tables.relid is actallly the oid from pg_class, not the
relfilenode. These two values start out equal so pg_autovacuum works
initially, but it fails later on because of this incorrect assumption.
This patch fixes that problem. Applied to HEAD and 7.4.X.
Brian Hirt
Bruce Momjian [Mon, 1 Dec 2003 23:15:47 +0000 (23:15 +0000)]
Fix initdb use of mkdir_p().
Andrew Dunstan
Bruce Momjian [Mon, 1 Dec 2003 23:13:07 +0000 (23:13 +0000)]
I noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is
not initialized if a log file is not specified on the command line. This
causes an immediate segfault on systems that fill allocated memory with some
value other than zero (my FreeBSD machine uses 0xD0).
Several crashes later I discovered that args->user, password, host, and port
are also used without being initialized.
This doesn't appear to be fixed in CVS and I came up empty on a mailing list
search -- hope it hasn't been reported already.
Craig Boston
Bruce Momjian [Mon, 1 Dec 2003 23:12:16 +0000 (23:12 +0000)]
The attached patch enables contrib/cube to build cleanly under Cygwin
(again). Please consider this patch for the 7.4.1 branch (if there will
be one) too.
Jason Tishler
Bruce Momjian [Mon, 1 Dec 2003 23:09:02 +0000 (23:09 +0000)]
This patch refactors execTuples.c in two ways.
Neil Conway
Bruce Momjian [Mon, 1 Dec 2003 22:36:40 +0000 (22:36 +0000)]
Hi, this doco patch is a quick one to add explicit mention of the need
for the AT clause in threaded ECPG applications.
Philip Yarra
Bruce Momjian [Mon, 1 Dec 2003 22:34:48 +0000 (22:34 +0000)]
This makes help like this:
\lo_export LOBOID FILE
\lo_import FILE [COMMENT]
\lo_list
\lo_unlink LOBOID large object operations
Instead of not saying anything about what arguments are required.
Christopher Kings-Lynne
Bruce Momjian [Mon, 1 Dec 2003 22:23:06 +0000 (22:23 +0000)]
Win32 patch for Makefile.shlib
Claudio Natoli
Bruce Momjian [Mon, 1 Dec 2003 22:22:44 +0000 (22:22 +0000)]
Update for patches applied:
< * Change factorial to return a numeric
> * -Change factorial to return a numeric (Gavin)
258c258
< * Allow psql \du to show groups, and add \dg for groups
> * -Allow psql \du to show groups, and add \dg for groups
Bruce Momjian [Mon, 1 Dec 2003 22:21:54 +0000 (22:21 +0000)]
attached is a patch that adds display of the groups a user belongs to to
\du and a \dg command to psql. It's against 7.4beta5.
Markus Bertheau <twanger@bluetwanger.de>
Tom Lane [Mon, 1 Dec 2003 22:15:38 +0000 (22:15 +0000)]
Avoid assuming that type key_t is 32 bits, since it reportedly isn't
on 64-bit Solaris. Use a non-system-dependent datatype for UsedShmemSegID,
namely unsigned long (which we were already assuming could hold a shmem
key anyway, cf RecordSharedMemoryInLockFile).
Bruce Momjian [Mon, 1 Dec 2003 22:14:40 +0000 (22:14 +0000)]
This patch reduces some unsightly #ifdefs, and fixes two typos in
comments in the psql code. This doesn't make any functional change, so
feel free to save it for 7.5
Neil Conway
Bruce Momjian [Mon, 1 Dec 2003 22:11:06 +0000 (22:11 +0000)]
This patch finishes off the work that I did with making view
definitions use pretty printing.
It does:
* Pretty index predicates
* Pretty rule definitions
* Uppercases PRIMARY KEY and UNIQUE to be consistent with CHECK and
FOREIGN KEY
* View rules are improved to match table rules:
Christopher Kings-Lynne
Bruce Momjian [Mon, 1 Dec 2003 22:08:02 +0000 (22:08 +0000)]
This patch adds a new GUC var, "default_with_oids", which follows the
proposal for eventually deprecating OIDs on user tables that I posted
earlier to pgsql-hackers. pg_dump now always specifies WITH OIDS or
WITHOUT OIDS when dumping a table. The documentation has been updated.
Neil Conway
Bruce Momjian [Mon, 1 Dec 2003 21:59:25 +0000 (21:59 +0000)]
Try to reduce confusion about what is a lock method identifier, a lock
method control structure, or a table of control structures.
. Use type LOCKMASK where an int is not a counter.
. Get rid of INVALID_TABLEID, use INVALID_LOCKMETHOD instead.
. Use INVALID_LOCKMETHOD instead of (LOCKMETHOD) NULL, because
LOCKMETHOD is not a pointer.
. Define and use macro LockMethodIsValid.
. Rename LOCKMETHOD to LOCKMETHODID.
. Remove global variable LongTermTableId in lmgr.c, because it is
never used.
. Make LockTableId static in lmgr.c, because it is used nowhere else.
Why not remove it and use DEFAULT_LOCKMETHOD?
. Rename the lock method control structure from LOCKMETHODTABLE to
LockMethodData. Introduce a pointer type named LockMethod.
. Remove elog(FATAL) after InitLockTable() call in
CreateSharedMemoryAndSemaphores(), because if something goes wrong,
there is elog(FATAL) in LockMethodTableInit(), and if this doesn't
help, an elog(ERROR) in InitLockTable() is promoted to FATAL.
. Make InitLockTable() void, because its only caller does not use its
return value any more.
. Rename variables in lock.c to avoid statements like
LockMethodTable[NumLockMethods] = lockMethodTable;
lockMethodTable = LockMethodTable[lockmethod];
. Change LOCKMETHODID type to uint16 to fit into struct LOCKTAG.
. Remove static variables BITS_OFF and BITS_ON from lock.c, because
I agree to this doubt:
* XXX is a fetch from a static array really faster than a shift?
. Define and use macros LOCKBIT_ON/OFF.
Manfred Koizar
Bruce Momjian [Mon, 1 Dec 2003 21:53:15 +0000 (21:53 +0000)]
Remove mention of factorial as casting example. New example needed.
Bruce Momjian [Mon, 1 Dec 2003 21:52:38 +0000 (21:52 +0000)]
Attached is a patch implementing factorial(), returning numeric. Points
to note:
1) arttype is numeric. I thought this was the best way of allowing
arbitarily large factorials, even though factorial(2^63) is a large
number. Happy to change to integers if this is overkill.
2) since we're accepting numeric arguments, the patch tests for floats.
If a numeric is passed with non-zero decimal portion, an error is raised
since (from memory) they are undefined.
Gavin Sherry
Tom Lane [Mon, 1 Dec 2003 20:34:53 +0000 (20:34 +0000)]
Minor wordsmithing in datetime docs to try to address gripes raised by
cnliou.
Tom Lane [Mon, 1 Dec 2003 18:50:19 +0000 (18:50 +0000)]
netmask() and hostmask() functions should return maximum-length masklen,
per gripe from Joe Sunday.
Tom Lane [Mon, 1 Dec 2003 17:58:27 +0000 (17:58 +0000)]
Fix typos noted by Halley Pacheco de Oliveira.
Tom Lane [Mon, 1 Dec 2003 16:53:19 +0000 (16:53 +0000)]
Force zero_damaged_pages to be effectively ON during recovery from WAL,
since there is no need to worry about damaged pages when we are going to
overwrite them anyway from the WAL. Per recent discussion.
Bruce Momjian [Mon, 1 Dec 2003 03:55:21 +0000 (03:55 +0000)]
Seems there are three GUC variables that are defined as "Shows ..."
while you can actually set them with SET.
This applied patch changes the wording from "Show" to "Set".
Joe Conway [Sun, 30 Nov 2003 20:55:09 +0000 (20:55 +0000)]
Make PQescapeBytea and byteaout consistent with each other, and
octal escape all octets outside the range 0x20 to 0x7e. This fixes
the problem pointed out by Sergey Yatskevich here:
http://archives.postgresql.org/pgsql-bugs/2003-11/msg00140.php
Bruce Momjian [Sun, 30 Nov 2003 06:09:54 +0000 (06:09 +0000)]
Bump all version numbers and version stamps mentioned in RELEASE_CHANGES.
Bruce Momjian [Sun, 30 Nov 2003 06:01:15 +0000 (06:01 +0000)]
Reorder win32/bcc makefile mentions of thread.c for sanity.
Bruce Momjian [Sun, 30 Nov 2003 05:54:33 +0000 (05:54 +0000)]
Add thread.c to Borland CC build.
Bruce Momjian [Sun, 30 Nov 2003 05:45:22 +0000 (05:45 +0000)]
Remove INTO recommendation for plpgsql language.
Bruce Momjian [Sun, 30 Nov 2003 05:29:26 +0000 (05:29 +0000)]
Add:
> * Have pg_ctl look at PGHOST in case it is a socket directory
Bruce Momjian [Sun, 30 Nov 2003 04:56:47 +0000 (04:56 +0000)]
Fix URL.
Bruce Momjian [Sun, 30 Nov 2003 04:54:07 +0000 (04:54 +0000)]
*** empty log message ***
Bruce Momjian [Sun, 30 Nov 2003 04:47:37 +0000 (04:47 +0000)]
There is an unused variable in an example function in the PL/PgSQL
documentation; this patch removes it.
Neil Conway
Bruce Momjian [Sun, 30 Nov 2003 04:44:38 +0000 (04:44 +0000)]
Add:
> * Make LENGTH() of CHAR() not count trailing spaces
>
Bruce Momjian [Sun, 30 Nov 2003 04:35:53 +0000 (04:35 +0000)]
Remove win32-only mention for pgadmin.
Bruce Momjian [Sun, 30 Nov 2003 04:34:14 +0000 (04:34 +0000)]
*** empty log message ***
Bruce Momjian [Sun, 30 Nov 2003 04:07:04 +0000 (04:07 +0000)]
Update wording:
< * Allow clients to query WITH HOLD cursors and prepared statements
> * Allow clients to query a list of WITH HOLD cursors and prepared statements
Bruce Momjian [Sun, 30 Nov 2003 03:41:10 +0000 (03:41 +0000)]
Updates:
< manuals (Rory)
> manuals
496c496
< * Jan is Jan Wieck <JanWieck@Yahoo.com> of PeerDirect Corp.
> * Jan is Jan Wieck <JanWieck@Yahoo.com> of Afilias, Inc.
PostgreSQL Daemon [Sat, 29 Nov 2003 22:41:33 +0000 (22:41 +0000)]
make sure the $Id tags are converted to $PostgreSQL as well ...
Tom Lane [Sat, 29 Nov 2003 21:40:43 +0000 (21:40 +0000)]
Put out a more useful version indication in the welcome banner for a
standalone backend --- the CVS revision number of postgres.c is not real
useful to anyone.
PostgreSQL Daemon [Sat, 29 Nov 2003 19:52:15 +0000 (19:52 +0000)]
$Header: -> $PostgreSQL Changes ...
PostgreSQL Daemon [Fri, 28 Nov 2003 20:32:09 +0000 (20:32 +0000)]
testing $PostgreSQL$ tag
Bruce Momjian [Fri, 28 Nov 2003 20:22:18 +0000 (20:22 +0000)]
Attached is a patch to correct white space issues in FAQ_MSWIN.
Daniel Convissor
Bruce Momjian [Fri, 28 Nov 2003 20:20:33 +0000 (20:20 +0000)]
Update Russian FAQ, both branches.
Viktor Vislobokov
Bruce Momjian [Fri, 28 Nov 2003 20:09:30 +0000 (20:09 +0000)]
Update most recent version to 7.4.
Teodor Sigaev [Fri, 28 Nov 2003 12:09:02 +0000 (12:09 +0000)]
Fix free instead of pfree
Joe Conway [Fri, 28 Nov 2003 05:03:02 +0000 (05:03 +0000)]
Fix regression in dblink_disconnect() reported by Eduardo Stern:
persistent_conn was left dangling after a disconnect in the
unnamed connection case, causing a subsequent disconnect to
crash the backend.
Peter Eisentraut [Thu, 27 Nov 2003 19:44:56 +0000 (19:44 +0000)]
Remove possibility to specify an installation root after --with-krbx and
--with-openssl options. This creates too much risk to pick up the wrong
directory accidentally (for example when there are lib64 directories), and
does not really help much with contemporary installation layouts.
Peter Eisentraut [Thu, 27 Nov 2003 18:14:02 +0000 (18:14 +0000)]
Make sure vpath_build is set correctly even if config.status --no-create
was specified.
Peter Eisentraut [Thu, 27 Nov 2003 18:12:50 +0000 (18:12 +0000)]
Conditionalize variable that is only used conditionally, to avoid warning.
Teodor Sigaev [Thu, 27 Nov 2003 16:04:40 +0000 (16:04 +0000)]
Fixes about word with several infiniteve
Tom Lane [Wed, 26 Nov 2003 20:50:11 +0000 (20:50 +0000)]
Second try at fixing no-room-to-move-down PANIC in compact_fsm_storage.
Ward's report that it can still happen in RC2 forces me to realize that
this is not a can't-happen condition after all, and that the compaction
code had better cope rather than panicking.
Joe Conway [Wed, 26 Nov 2003 20:43:25 +0000 (20:43 +0000)]
Added missing SPI_finish() calls to get_tuple_of_interest(). Fixes bug
reported by Andrea Grassi.
Peter Eisentraut [Wed, 26 Nov 2003 15:56:48 +0000 (15:56 +0000)]
Add NetBSD Sparc as supported.
Peter Eisentraut [Wed, 26 Nov 2003 15:55:01 +0000 (15:55 +0000)]
Cast field-length variables used in printf to int, because sometimes
they might be of a wider type.
Teodor Sigaev [Wed, 26 Nov 2003 14:06:16 +0000 (14:06 +0000)]
Utility for convert myspell dictionaries to ispell, full README will be later
Tatsuo Ishii [Wed, 26 Nov 2003 06:53:18 +0000 (06:53 +0000)]
Patches from Yutaka Tanida. Create primary key indexes after data
insertion to reduce initialization time.
Tom Lane [Tue, 25 Nov 2003 23:59:12 +0000 (23:59 +0000)]
Repair subselect.c's occasional assignment of the wrong vartypmod to
Vars created to fill subplan args lists. This is an ancient error, going
back at least to 7.0, but is more easily triggered in 7.4 than before
because we no longer compare varlevelsup when deciding whether a Param
slot can be re-used. Fixes bug reported by Klint Gore.
Tom Lane [Tue, 25 Nov 2003 21:00:54 +0000 (21:00 +0000)]
Get rid of hashkeys field of Hash plan node, since it's redundant with
the hashclauses field of the parent HashJoin. This avoids problems with
duplicated links to SubPlans in hash clauses, as per report from
Andrew Holm-Hansen.
Peter Eisentraut [Tue, 25 Nov 2003 19:27:18 +0000 (19:27 +0000)]
Fix language.
Peter Eisentraut [Tue, 25 Nov 2003 19:19:21 +0000 (19:19 +0000)]
New translation
Peter Eisentraut [Tue, 25 Nov 2003 19:18:26 +0000 (19:18 +0000)]
More adjustment of error messages
Peter Eisentraut [Tue, 25 Nov 2003 19:09:02 +0000 (19:09 +0000)]
Install all the headers files that the ones that are already installed
depend on.
Teodor Sigaev [Tue, 25 Nov 2003 13:33:15 +0000 (13:33 +0000)]
Ignore too long lexeme
Peter Eisentraut [Mon, 24 Nov 2003 19:08:02 +0000 (19:08 +0000)]
Upgrade to DocBook V4.2 SGML.
Tom Lane [Mon, 24 Nov 2003 17:25:14 +0000 (17:25 +0000)]
Avoid using string literal with embedded newline.
Peter Eisentraut [Mon, 24 Nov 2003 16:56:00 +0000 (16:56 +0000)]
Fix markup.
Tom Lane [Mon, 24 Nov 2003 16:54:07 +0000 (16:54 +0000)]
Overdue code review for ALTER SEQUENCE patch. Don't generate illegal Node
tree for CYCLE option; don't assume zeros are invalid values for sequence
fields other than increment_by; don't reset cache_value when not told to;
simplify code for testing whether to apply defaults.
Peter Eisentraut [Mon, 24 Nov 2003 14:52:58 +0000 (14:52 +0000)]
Use --with-docdir to choose installation location of documentation; put
back --infodir, which several automatic build environments expect to exist.
Add --without-docdir to prevent installation of documentation, which is
helpful for things like RPM that have their own method of installing
documentation.
Tom Lane [Mon, 24 Nov 2003 14:49:51 +0000 (14:49 +0000)]
Repair missed renamings of show_statement_stats and show_executor_stats.
Peter Eisentraut [Mon, 24 Nov 2003 13:16:22 +0000 (13:16 +0000)]
Rename USE_THREADS to ENABLE_THREAD_SAFETY to avoid name clash with Perl.
Fixes compilation failure with --enable-thread-safety --with-perl and Perl
5.6.1.
Peter Eisentraut [Sun, 23 Nov 2003 22:17:59 +0000 (22:17 +0000)]
Make the messages and the options parsing a bit more standard.