OSDN Git Service

android-x86/system-bt.git
5 years ago[automerger skipped] Merge "DO NOT MERGE - Merge pie-platform-release (PPRL.181205...
Xin Li [Thu, 13 Dec 2018 21:27:59 +0000 (13:27 -0800)]
[automerger skipped] Merge "DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master"
am: cb7dcad70d  -s ours

Change-Id: I3937cd25882e43468acb0d0192a5ccd34aa59091

5 years ago[automerger skipped] DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001)...
Xin Li [Thu, 13 Dec 2018 19:25:51 +0000 (11:25 -0800)]
[automerger skipped] DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master
am: 1083b621e4  -s ours

Change-Id: I050265331bd4a18405f7d6f93b03125a1fc659ae

5 years agoFix performance-for-range-copy warnings
Chih-Hung Hsieh [Thu, 13 Dec 2018 18:48:26 +0000 (10:48 -0800)]
Fix performance-for-range-copy warnings
am: 01a40403d7

Change-Id: Ife0d8af7af4a5ac26dfe7d735bbc65460d1beb70

5 years agoMerge "DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master"
Treehugger Robot [Thu, 13 Dec 2018 05:45:20 +0000 (05:45 +0000)]
Merge "DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master"

5 years agoFix performance-for-range-copy warnings
Chih-Hung Hsieh [Wed, 12 Dec 2018 22:30:52 +0000 (14:30 -0800)]
Fix performance-for-range-copy warnings

Bug: 30413223
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance*
Change-Id: I7d5537c24c39d5c42ac17c8a67646e4b9321d6bb

5 years agoTurn stack/gatt/conneciton_manager.cc into text file
Jakub Pawlowski [Wed, 12 Dec 2018 08:30:59 +0000 (00:30 -0800)]
Turn stack/gatt/conneciton_manager.cc into text file
am: fef2539cd2

Change-Id: I95b2a8c2136819491f4aafc38e6fb0a782e898ec

5 years agoTurn stack/gatt/conneciton_manager.cc into text file
Jakub Pawlowski [Tue, 11 Dec 2018 20:53:58 +0000 (21:53 +0100)]
Turn stack/gatt/conneciton_manager.cc into text file

Change-Id: I031bfaa1745de55aeb0a0dbde3a7a67be0f9c982

5 years agoMerge changes I7f8b5cfd,I68d65028
Myles Watson [Wed, 12 Dec 2018 05:14:36 +0000 (21:14 -0800)]
Merge changes I7f8b5cfd,I68d65028
am: 1b29fe6e18

Change-Id: I00f505eb8b71e21e6a2bc778e41ee9a0f8e35fc3

5 years agoMerge changes I7f8b5cfd,I68d65028
Treehugger Robot [Wed, 12 Dec 2018 05:05:27 +0000 (05:05 +0000)]
Merge changes I7f8b5cfd,I68d65028

* changes:
  test_vendor: Add PacketBuilder classes
  test_vendor: Add PacketView for copyless parsing

5 years agoDO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master
Xin Li [Tue, 11 Dec 2018 22:45:08 +0000 (14:45 -0800)]
DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master

Bug: 120502534
Change-Id: Icdcf2220fd28f92b182da73bee207151e80db295

5 years agoMerge "DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into stage-aosp...
TreeHugger Robot [Tue, 11 Dec 2018 21:49:24 +0000 (21:49 +0000)]
Merge "DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into stage-aosp-master" into stage-aosp-master

5 years agoMerge "OWNERS -eisenbach, +zachoverflow"
Zach Johnson [Tue, 11 Dec 2018 08:26:18 +0000 (00:26 -0800)]
Merge "OWNERS -eisenbach, +zachoverflow"
am: 55c7b8ba5d

Change-Id: Ib3b6c7398a8a749ab6e19d202cde14250d3024dd

5 years agoMerge "OWNERS -eisenbach, +zachoverflow"
Zach Johnson [Tue, 11 Dec 2018 04:21:52 +0000 (04:21 +0000)]
Merge "OWNERS -eisenbach, +zachoverflow"

5 years agoDO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into stage-aosp-master
Xin Li [Mon, 10 Dec 2018 22:22:38 +0000 (14:22 -0800)]
DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into stage-aosp-master

Bug: 120502534
Change-Id: I71b31fb1bf8a4c2b2f471b54b5a74bc2191c9693

5 years agoFix GATT not working due to address mismatch
Jakub Pawlowski [Tue, 11 Dec 2018 00:20:46 +0000 (16:20 -0800)]
Fix GATT not working due to address mismatch
am: f4b2f61690

Change-Id: Id435aecebda5a8cb5195353616bbfeb8ec9a87ec

5 years agotest_vendor: Add PacketBuilder classes
Myles Watson [Wed, 14 Nov 2018 00:56:38 +0000 (16:56 -0800)]
test_vendor: Add PacketBuilder classes

Templated PacketBuilder class for inserting fixed width
types with the correct endianness.

Test: rootcanal-packets_test_host --gtest_filter=*PacketBuilderEndian*
Change-Id: I7f8b5cfd225ebae35f310b44fc0782b940a23007

5 years agotest_vendor: Add PacketView for copyless parsing
Myles Watson [Wed, 7 Nov 2018 20:10:46 +0000 (12:10 -0800)]
test_vendor: Add PacketView for copyless parsing

A View is holds bounds and a shared pointer.
A PacketView is a forward list of View, templated for endianness.
A BaseIterator iterates over PacketViews.
An Iterator is a BaseIterator with extract, which is templated for endianness.

Test: rootcanal-packets_test_host
Change-Id: I68d6502861be61f411c0f5f2da33ead3d2392694

5 years agoOWNERS -eisenbach, +zachoverflow
Andre Eisenbach [Tue, 4 Sep 2018 17:17:20 +0000 (10:17 -0700)]
OWNERS -eisenbach, +zachoverflow

5 years agoFix GATT not working due to address mismatch
Jakub Pawlowski [Thu, 6 Dec 2018 18:32:37 +0000 (19:32 +0100)]
Fix GATT not working due to address mismatch

If the initial connection is established when using RPA, device can
later decide to use it's Identity Address for reconnections, if it
doesn't care about privacy.
When we receive such Identity Address, we must translate it into pseudo
address before passing it further down the stack.

Test: Connect to device using RPA, try to reconnect when it advertise
      it's Public address
Change-Id: Icb8eed25e1aad7003f1a3e0fed684168a8344544

5 years agoConfig: Reduce LOG(WARNING) to VLOG(1) when config key is not found
Jack He [Mon, 10 Dec 2018 00:15:32 +0000 (16:15 -0800)]
Config: Reduce LOG(WARNING) to VLOG(1) when config key is not found
am: fe8658175f

Change-Id: I87fd172353352e4ad79fcf801ebdcfcf7eefebbb

5 years agoConfig: Reduce LOG(WARNING) to VLOG(1) when config key is not found
Jack He [Fri, 7 Dec 2018 21:58:12 +0000 (13:58 -0800)]
Config: Reduce LOG(WARNING) to VLOG(1) when config key is not found

Fixes: 120495903
Test: make
Change-Id: I724b8883ea400ed3c79fe31b75f1e2aa65b45b4d

5 years agoMerge "Preserve x18 while calling aptX encoder libraries."
Peter Collingbourne [Fri, 7 Dec 2018 00:54:19 +0000 (16:54 -0800)]
Merge "Preserve x18 while calling aptX encoder libraries."
am: b1db2b8792

Change-Id: Ie19afe9335e95128fa4f0411e2c6e1f9758a9791

5 years agoMerge "Preserve x18 while calling aptX encoder libraries."
Peter Collingbourne [Fri, 7 Dec 2018 00:47:06 +0000 (00:47 +0000)]
Merge "Preserve x18 while calling aptX encoder libraries."

5 years agoPreserve x18 while calling aptX encoder libraries.
Peter Collingbourne [Mon, 19 Nov 2018 20:58:18 +0000 (12:58 -0800)]
Preserve x18 while calling aptX encoder libraries.

Shadow call stack (SCS) is a security mitigation that uses a
separate stack (the SCS) for return addresses. In versions of
Android newer than P, the compiler normally cooperates with the
system to ensure that the SCS address is always stored in register
x18. This requires that everything in a process that uses SCS is
built with -ffixed-x18. However, two libraries (libaptX_encoder.so
and libaptXHD_encoder.so) are supplied in binary format and were
not compiled with -ffixed-x18. We are working with the vendor to get
these libraries rebuilt with -ffixed-x18, but until then, we need to
prevent this library from clobbering x18 so that we can turn on SCS
in the Bluetooth process.

Bug: 112907825
Bug: 120621517
Change-Id: Id27829ed5696903c42b4aeb75c3b3880c97a3a36

5 years agoMerge "Hearing Aid: Add clear conn_id and close ctrl UIPC when BT turn off"
weichinweng [Thu, 6 Dec 2018 03:07:23 +0000 (19:07 -0800)]
Merge "Hearing Aid: Add clear conn_id and close ctrl UIPC when BT turn off"
am: b946c2690a

Change-Id: Ied576f7bc2ba217facb6a2d16ccd4e2734b57a3f

5 years agoMerge "Hearing Aid: Add clear conn_id and close ctrl UIPC when BT turn off"
Treehugger Robot [Thu, 6 Dec 2018 02:43:24 +0000 (02:43 +0000)]
Merge "Hearing Aid: Add clear conn_id and close ctrl UIPC when BT turn off"

5 years agoMerge "Enable bounds sanitization in Bluetooth."
Ivan Lozano [Wed, 5 Dec 2018 23:58:50 +0000 (15:58 -0800)]
Merge "Enable bounds sanitization in Bluetooth."
am: ec74937aa0

Change-Id: Ie1a58ea6002a2ce5ba36d9a5ca870a6db1fc4614

5 years agoMerge "Enable bounds sanitization in Bluetooth."
Ivan Lozano [Wed, 5 Dec 2018 23:38:16 +0000 (23:38 +0000)]
Merge "Enable bounds sanitization in Bluetooth."

5 years agoMerge "Group BR-EDR related SDP variables under transport"
Srinu Jella [Wed, 5 Dec 2018 22:30:51 +0000 (14:30 -0800)]
Merge "Group BR-EDR related SDP variables under transport"
am: 1068f028e1

Change-Id: Idb6f348ffea7350cbc6ae8e9fbf24938d8f6a2c9

5 years agoMerge "Group BR-EDR related SDP variables under transport"
Treehugger Robot [Wed, 5 Dec 2018 22:04:09 +0000 (22:04 +0000)]
Merge "Group BR-EDR related SDP variables under transport"

5 years agoMetrics: Fix a typo in log
Jack He [Wed, 5 Dec 2018 02:15:51 +0000 (18:15 -0800)]
Metrics: Fix a typo in log
am: 015dd9392f

Change-Id: Ib15c2fad51eb1569dfa9589fc39bb7595ed2c5bc

5 years agoMetrics: Fix a typo in log
Jack He [Tue, 4 Dec 2018 22:30:28 +0000 (14:30 -0800)]
Metrics: Fix a typo in log

Test: make
Change-Id: I92a49c62ebf13d8da7f13b39c426d0eb14a83db6

5 years agoMerge PQ1A.181205.006 from Pi-QPR1-Release into ToT for Pi-Platform release.\n\nBUG...
Bill Rassieur [Tue, 4 Dec 2018 17:00:02 +0000 (17:00 +0000)]
Merge PQ1A.181205.006 from Pi-QPR1-Release into ToT for Pi-Platform release.\n\nBUG: 120448245

Change-Id: I39b32c98eac813e96ba19087a27c97d0da02ab5e

5 years agoGroup BR-EDR related SDP variables under transport
Srinu Jella [Thu, 11 Feb 2016 14:17:39 +0000 (19:47 +0530)]
Group BR-EDR related SDP variables under transport

Use Case: Random RNR initiated after HOGP Keyboard disconnection

steps:
1. keep madcatz in advertisement mode and scan, pair from DUT.
2. keep dailog Keyboard in advertisement mode and scan, pair from DUT.
3. Take Keyboard out of range to initiate disconnection from remote
or initiate disconnection from remote.

Failure: DUT trying to do RNR to random device.

Root Cause: when the disconnection happened for LE device, it sets
the wait_disc to true, that is causing random RNR to go for BR-EDR
device.

Fix: Group all BR-EDR related SDP variables under transport check
so that if some other operation on LE will not corrupt these BR-EDR
variables to mislead.

Test: code compilation.
Bug: 69031582
Change-Id: Ic9003f2b85bbaaa30b201b8a639a9d9b52055ac5

5 years agoSplit Timer into OnceTimer and RepeatingTimer
Jakub Pawlowski [Tue, 4 Dec 2018 10:42:23 +0000 (02:42 -0800)]
Split Timer into OnceTimer and RepeatingTimer
am: 5cf0304979

Change-Id: Ie3d704b95231953a8cb602cc0b279a94a6f8081a

5 years agoSplit Timer into OnceTimer and RepeatingTimer
Jakub Pawlowski [Mon, 3 Dec 2018 15:50:40 +0000 (16:50 +0100)]
Split Timer into OnceTimer and RepeatingTimer

Follow the naming convention in libbase, where Callback was split into
OnceCallback, and RepeatingCallback, to make it obvious how many times
callback is expected to be called.

Test: unit tests were split from TimerTest into OnceTimerTest and
RepeatingTimerTest
Bug: 110303473
Change-Id: Ibbb9bb74a2e6e1a0f0f74c6ec44f63c5a4a1537f

5 years agoHearing Aid: Add clear conn_id and close ctrl UIPC when BT turn off
weichinweng [Tue, 27 Nov 2018 05:47:25 +0000 (13:47 +0800)]
Hearing Aid: Add clear conn_id and close ctrl UIPC when BT turn off

* On some condition, BT will stay on BLE_ON state when BT turn off. For
the case, Hearing Aid should be correctly disconnected and ctrl UIPC
close until next BT turn on.
* This CL add clear BtaGATTQueue and Close GATTC to make sure Queue
clean and HA enter disconnected state. And don't restart ctrl UIPC if
HearingAid is shutdown.

Bug: 118803637
Test: make, BT off/on when play A2DP and an app registered.
Change-Id: I1c52307637ee6b34222de9308dcfe1392ad170e8

5 years agoTest: Save SSR dump after test
Jack He [Sat, 1 Dec 2018 00:17:05 +0000 (16:17 -0800)]
Test: Save SSR dump after test
am: 268b88c948

Change-Id: I34ae79fdf0fcdb246d8be40970b785d9dee92e9b

5 years agoTest: Save SSR dump after test
Jack He [Fri, 30 Nov 2018 00:51:22 +0000 (16:51 -0800)]
Test: Save SSR dump after test

* Save SSR dump from /data/vendor/ssrdump after test invocation

Bug: 120098494
Test: atest :postsubmit
Change-Id: Iafc1666c8cc9fbc7f69b909be630b3d0c1445fe4

5 years agoMerge "Metrics: Add Bluetooth address obfuscator"
Jack He [Fri, 30 Nov 2018 08:37:43 +0000 (00:37 -0800)]
Merge "Metrics: Add Bluetooth address obfuscator"
am: 17d56d8962

Change-Id: I02e0c1a734e55ead434c7e0b3a1696a03eaa027d

5 years agoMerge "Assert if alarm callback is null"
Stanley Tng [Fri, 30 Nov 2018 08:19:30 +0000 (00:19 -0800)]
Merge "Assert if alarm callback is null"
am: dec5621902

Change-Id: I4241a172b6245bd7fdb4837c494882b8ea03416f

5 years agoMerge "Metrics: Add Bluetooth address obfuscator"
Treehugger Robot [Fri, 30 Nov 2018 07:59:20 +0000 (07:59 +0000)]
Merge "Metrics: Add Bluetooth address obfuscator"

5 years agoMerge "Assert if alarm callback is null"
Treehugger Robot [Fri, 30 Nov 2018 01:58:17 +0000 (01:58 +0000)]
Merge "Assert if alarm callback is null"

5 years agoMetrics: Add Bluetooth address obfuscator
Jack He [Fri, 16 Nov 2018 10:59:43 +0000 (02:59 -0800)]
Metrics: Add Bluetooth address obfuscator

* Add an address obfuscator that takes a 256-bit randomly generated
  salt and hashes a Bluetooth MAC address using HMAC-SHA256 algorithm
* The salt is generated per Android device during the first time
  Fluoride native layer is initialized after a connectivity reset
* The output of the above operation is an unique identifier for a
  Bluetooth device on the same Android device, but yet remains
  anonymous across different Android devices.
* Add a logging method loghex(std::array) that allows dumping integral
  arrays into a hex string
* Add more error logging to btif_config_get_bin() so that we know why it
  fails in the future
* Change mutex in btif_config to recursive_mutex to avoid deadlock when
  calling btif_config API functions with API function

Bug: 112969790
Test: mm -j40, bluetooth_test_common
Change-Id: I11f01cc82fe805c97fd7c86ad83b3d324ee5af53

5 years agoAssert if alarm callback is null
Stanley Tng [Mon, 26 Nov 2018 22:44:38 +0000 (14:44 -0800)]
Assert if alarm callback is null

Crash the system when callback is null. This will help to identify and debug the problem. Previously, we got a CFI crash which is hard to isolate.

Test: Run with Hearing Aids but did not simulate the error condition
Bug: 119533256
Change-Id: I9bc2af7c3c405bea3a57c5feb9b213614484507f

5 years agoMerge pi-qpr1-release PQ1A.181105.017.A1 to pi-platform-release
Bill Yi [Thu, 29 Nov 2018 02:35:03 +0000 (18:35 -0800)]
Merge pi-qpr1-release PQ1A.181105.017.A1 to pi-platform-release

Change-Id: I2a349df7ad02b6b57044fe77d92b329e1a5afda0

5 years agoAllow Resolvable Private Address into LE White List
Jakub Pawlowski [Wed, 28 Nov 2018 21:31:27 +0000 (13:31 -0800)]
Allow Resolvable Private Address into LE White List
am: eb976adf47

Change-Id: I701e05e417ae2c30491660faaf9de97c3c07beb7

5 years agoCentralize call to gatt_update_app_use_link_flag for GATT_Connect
Jakub Pawlowski [Wed, 28 Nov 2018 19:55:18 +0000 (11:55 -0800)]
Centralize call to gatt_update_app_use_link_flag for GATT_Connect
am: 8c2f8384a8

Change-Id: Icb9fd21e6af43dc4d31afba64bd58655a8f6ff5a

5 years agoAllow Resolvable Private Address into LE White List
Jakub Pawlowski [Thu, 15 Nov 2018 22:22:21 +0000 (23:22 +0100)]
Allow Resolvable Private Address into LE White List

When doing background connection, we don't want to put RPA into the
white list, as it might expire in 15 minutes.
For direct connect procedure, RPA is ok - the request times out after 30
seconds.

This patch moves address type check from the White List to the background
connection procedure. It is prepearation for handling direct connect
with white list.

Bug: 112827989
Test: sl4a GattConnectTest
Change-Id: I907ad44d1d255c9212ed58112bb8b99464e46f43

5 years agoCentralize call to gatt_update_app_use_link_flag for GATT_Connect
Jakub Pawlowski [Tue, 13 Nov 2018 17:31:08 +0000 (18:31 +0100)]
Centralize call to gatt_update_app_use_link_flag for GATT_Connect

Currently both code paths, doing direct and background connection, call
gatt_update_app_use_link_flag. Move this call to common code.

Bug: 112827989
Test: sl4a GattConnectTest
Change-Id: I5d55f6467ffca78ff785ecdad02dd049ea5481bf

5 years agoMerge "Prevent potential deadlock in Hearing Aids"
Stanley Tng [Wed, 21 Nov 2018 21:03:03 +0000 (13:03 -0800)]
Merge "Prevent potential deadlock in Hearing Aids"
am: 2fb03d8470

Change-Id: Id16264dd2cd55ab730323ed0d95adde1cb88431a

5 years agoMerge "HFP: Send caller ID in +CLIP command (3/4)"
Benson Li [Wed, 21 Nov 2018 20:57:56 +0000 (12:57 -0800)]
Merge "HFP: Send caller ID in +CLIP command (3/4)"
am: 0bcf573d91

Change-Id: Ib4d00ef1e727613a4363226115137f700464fe82

5 years agoMerge "Prevent potential deadlock in Hearing Aids"
Treehugger Robot [Wed, 21 Nov 2018 20:52:18 +0000 (20:52 +0000)]
Merge "Prevent potential deadlock in Hearing Aids"

5 years agoMerge "HFP: Send caller ID in +CLIP command (3/4)"
Treehugger Robot [Wed, 21 Nov 2018 20:21:19 +0000 (20:21 +0000)]
Merge "HFP: Send caller ID in +CLIP command (3/4)"

5 years agoMerge "btsock_signaled: provide debugging info for crash"
Hansong Zhang [Wed, 21 Nov 2018 20:14:21 +0000 (12:14 -0800)]
Merge "btsock_signaled: provide debugging info for crash"
am: f8da780d60

Change-Id: Ic7773644aba72a0310c15ae786b14d8fb11e9faf

5 years agoMerge "btsock_signaled: provide debugging info for crash"
Treehugger Robot [Wed, 21 Nov 2018 19:51:32 +0000 (19:51 +0000)]
Merge "btsock_signaled: provide debugging info for crash"

5 years agoMerge "btif_av: remove dead code"
Hansong Zhang [Wed, 21 Nov 2018 19:26:32 +0000 (11:26 -0800)]
Merge "btif_av: remove dead code"
am: 84f70f1152

Change-Id: I7ffedcf6dd730ff452ff68f1c7ce87ea71832305

5 years agoMerge "btif_av: remove dead code"
Treehugger Robot [Wed, 21 Nov 2018 19:04:36 +0000 (19:04 +0000)]
Merge "btif_av: remove dead code"

5 years agobtif_av: remove dead code
Hansong Zhang [Wed, 21 Nov 2018 00:04:18 +0000 (16:04 -0800)]
btif_av: remove dead code

Test: manual
Change-Id: I8b172ec2235ae5847f073f8d50ad71761bc37d02

5 years agoPrevent potential deadlock in Hearing Aids
Stanley Tng [Fri, 16 Nov 2018 19:34:28 +0000 (11:34 -0800)]
Prevent potential deadlock in Hearing Aids

Prevent a potential deadlock when calling the main thread but the main
thread is not running.

Bug: 117619792
Test: Manual test to make sure no regression
Change-Id: I6e001533144827b17b88547671765f790ed771bd

5 years agoMerge "Remove unused BTM_BleSetAdvParams"
Jakub Pawlowski [Tue, 20 Nov 2018 21:27:48 +0000 (13:27 -0800)]
Merge "Remove unused BTM_BleSetAdvParams"
am: 3b12d664e9

Change-Id: Ib265a9a6022765110c2e2c0cd338255863c2cbf5

5 years agoMerge "Remove unused BTM_BleSetAdvParams"
Treehugger Robot [Tue, 20 Nov 2018 21:13:35 +0000 (21:13 +0000)]
Merge "Remove unused BTM_BleSetAdvParams"

5 years agoLinux tests build fix
Jakub Pawlowski [Tue, 20 Nov 2018 21:09:37 +0000 (13:09 -0800)]
Linux tests build fix
am: 83db4992e3

Change-Id: Ieafc3eb4d4b4834f1475cdae8b5f72d637b49828

5 years agoRemove unused BTM_BleSetAdvParams
Jakub Pawlowski [Tue, 20 Nov 2018 11:14:10 +0000 (12:14 +0100)]
Remove unused BTM_BleSetAdvParams

Test: compilation
Change-Id: I5797a16b3fd92c5ffa1ad1fd048699a591fd1e4c

5 years agoLinux tests build fix
Jakub Pawlowski [Tue, 20 Nov 2018 18:27:11 +0000 (19:27 +0100)]
Linux tests build fix

Test: compile on Linux using ninja
Change-Id: I180679a7a6f12abe83db0480d9007ebdfdf1d451

5 years agoFix an error in pure virtual function in earlier CL
Stanley Tng [Fri, 16 Nov 2018 16:19:51 +0000 (08:19 -0800)]
Fix an error in pure virtual function in earlier CL
am: e72c597aa7

Change-Id: Ia8c01a258eb3fa2614751055dbef2b0807b20eb5

5 years agoFix an error in pure virtual function in earlier CL
Stanley Tng [Wed, 7 Nov 2018 20:50:37 +0000 (12:50 -0800)]
Fix an error in pure virtual function in earlier CL

The earlier CL "Fix Spurious Hearing Aid Start and Stop Cmds" is missing
this "=0" to make the virtual function pure. This CL fixes this
oversight.

Test: Compile
Bug: 117619792

Change-Id: Id9e72b8d93f9671c08a613ecb43b4121662770a0

5 years agobtsock_signaled: provide debugging info for crash
Hansong Zhang [Thu, 15 Nov 2018 23:37:12 +0000 (15:37 -0800)]
btsock_signaled: provide debugging info for crash

Test: manual
Bug: 68108403
Change-Id: I89cfc15787f51594535e1e0c00e7a18a317a5d81

5 years agoDump gatt::connection_manager state into bugreport
Jakub Pawlowski [Thu, 15 Nov 2018 07:20:01 +0000 (23:20 -0800)]
Dump gatt::connection_manager state into bugreport
am: 8ae68be3b8

Change-Id: Id19a8a93a055fda21dbb62888fa4db3f442bb4a9

5 years agoUse map instead of list for keeping apps interested in connection
Jakub Pawlowski [Thu, 15 Nov 2018 07:19:49 +0000 (23:19 -0800)]
Use map instead of list for keeping apps interested in connection
am: c436612cdc

Change-Id: Icd78c19959b2a88a5b1ad6164a09ee35fc77f2ec

5 years agoDump gatt::connection_manager state into bugreport
Jakub Pawlowski [Tue, 13 Nov 2018 14:41:42 +0000 (15:41 +0100)]
Dump gatt::connection_manager state into bugreport

Knowing what's in the white list is useful for debugging.

Bug: 112827989
Test: adb bugreport, verify content.
Change-Id: I195d1ee2fe277f0f0ef534c73f7a964c5f5e61b6

5 years agoUse map instead of list for keeping apps interested in connection
Jakub Pawlowski [Sat, 10 Nov 2018 15:45:35 +0000 (16:45 +0100)]
Use map instead of list for keeping apps interested in connection

Bug: 112827989
Test: BleGattConnectionManager
Change-Id: I7b7ea608f5e27a9f17141ccec0c5d5c06bb22e60

5 years agoFirst tests for connection management
Jakub Pawlowski [Tue, 13 Nov 2018 13:13:10 +0000 (05:13 -0800)]
First tests for connection management
am: e85bc52264

Change-Id: I1127e88d0b2c83eb00e1105af25cfe54ca21d203

5 years agointroduce gatt::connection_manager::get_apps_connecting_to
Jakub Pawlowski [Mon, 12 Nov 2018 23:36:23 +0000 (15:36 -0800)]
introduce gatt::connection_manager::get_apps_connecting_to
am: d1d3088e93

Change-Id: Idde98ec3cb082150cd57d7749be5d53c11745379

5 years agoNaming cleanup in stack/gatt/connection_manager.*
Jakub Pawlowski [Sat, 10 Nov 2018 13:37:14 +0000 (05:37 -0800)]
Naming cleanup in stack/gatt/connection_manager.*
am: d28727edd4

Change-Id: I73a6d1da304af64c986eba804011e6d9f0d6d4cc

5 years agoFirst tests for connection management
Jakub Pawlowski [Fri, 9 Nov 2018 13:41:01 +0000 (14:41 +0100)]
First tests for connection management

Test: added in this CL
Change-Id: Id3937530e1b0a16c056ae48face78b18c6ec32f0

5 years agointroduce gatt::connection_manager::get_apps_connecting_to
Jakub Pawlowski [Fri, 9 Nov 2018 17:40:04 +0000 (18:40 +0100)]
introduce gatt::connection_manager::get_apps_connecting_to

This is to clean up the interface, and don't expose internal control
structures.

Test: compilation
Change-Id: Id2afc5efb4c14be0b787cfabbe21fc1961381cb7

5 years agogatt_utils_white_list -> connection_manager
Jakub Pawlowski [Fri, 9 Nov 2018 23:01:02 +0000 (15:01 -0800)]
gatt_utils_white_list -> connection_manager
am: ddba8a6243

Change-Id: I8000a7a5121c61270a7ea6cb24b48cec5ee1f09d

5 years agoNaming cleanup in stack/gatt/connection_manager.*
Jakub Pawlowski [Fri, 9 Nov 2018 11:42:32 +0000 (12:42 +0100)]
Naming cleanup in stack/gatt/connection_manager.*

Test: compilation
Change-Id: Ic73632cb258515856b9ae5616ec47881b4b28c61

5 years agogatt_utils_white_list -> connection_manager
Jakub Pawlowski [Fri, 9 Nov 2018 10:53:11 +0000 (11:53 +0100)]
gatt_utils_white_list -> connection_manager

Test: compilation
Change-Id: Ib6741ddd8332ff70efd47a8ede0176d887743ff4

5 years agoMerge "AVRCP: Change notification variable when the interim response is sent"
Ajay Panicker [Fri, 9 Nov 2018 03:06:59 +0000 (19:06 -0800)]
Merge "AVRCP: Change notification variable when the interim response is sent"
am: 62cd940292

Change-Id: I11061ce6fb36be8cac793ad93cd0d502eed9734d

5 years agoMerge "AVRCP: Change notification variable when the interim response is sent"
Treehugger Robot [Fri, 9 Nov 2018 02:57:12 +0000 (02:57 +0000)]
Merge "AVRCP: Change notification variable when the interim response is sent"

5 years agoEnable bounds sanitization in Bluetooth.
Ivan Lozano [Fri, 28 Sep 2018 18:23:51 +0000 (11:23 -0700)]
Enable bounds sanitization in Bluetooth.

This enables UBSan bounds sanitization in our bluetooth modules.
This adds run-time bounds checks where the compiler can statically
determine the array bounds.

Bug: 116517182
Test: Pairing devices, playing audio, sharing files.
Change-Id: I9a3ac98aaa6092ac0ad8d1ba080a76b3203bdb26

5 years agoAVRCP: Change notification variable when the interim response is sent
Ajay Panicker [Tue, 26 Jun 2018 21:52:56 +0000 (14:52 -0700)]
AVRCP: Change notification variable when the interim response is sent

This avoids the possibility of having a changed notification be sent
before an interim response is sent when the AVRCP service has to wait
for a response from the media layer for information regarding the
notification.

Also fix the PlayPosition test for AVRCP as it was testing for play
state correctness.

Bug: 109588762
Test: Run host test net_test_avrcp
Change-Id: Icb7bb1068191ecf2a2e390854084b6b9b47537fa
(cherry picked from commit 2d87908fe8825245dcc2e1dbde027331f1e2371d)

5 years agoMinor style fixes in gatt_main.cc
Jakub Pawlowski [Thu, 8 Nov 2018 23:25:56 +0000 (15:25 -0800)]
Minor style fixes in gatt_main.cc
am: b5629de6ed

Change-Id: I26d6290ccfe93ab38329dfb84560b8722804d57f

5 years agoMinor style fixes in gatt_main.cc
Jakub Pawlowski [Thu, 8 Nov 2018 18:54:49 +0000 (19:54 +0100)]
Minor style fixes in gatt_main.cc

Test: compilation
Change-Id: I446b9e83603e7224abe1eddd030b4502cc7dceb5

5 years agoMerge "Add code coverage report support to Bluetooth"
Ajay Panicker [Thu, 8 Nov 2018 22:18:37 +0000 (14:18 -0800)]
Merge "Add code coverage report support to Bluetooth"
am: d533096b1b

Change-Id: I4980643d5443389bb04e14fd93fdf3941a7d3b19

5 years agoMerge "Add code coverage report support to Bluetooth"
Treehugger Robot [Thu, 8 Nov 2018 22:02:48 +0000 (22:02 +0000)]
Merge "Add code coverage report support to Bluetooth"

5 years agoMerge "HFP: Don't use mSBC for HF devices not supporting related feature"
weichinweng [Thu, 8 Nov 2018 08:50:27 +0000 (00:50 -0800)]
Merge "HFP: Don't use mSBC for HF devices not supporting related feature"
am: c5931e67b4

Change-Id: Ic9969ea693f9912f12917186c921cdccdba085ab

5 years agoHFP: Send caller ID in +CLIP command (3/4)
Benson Li [Tue, 17 Jul 2018 10:05:16 +0000 (18:05 +0800)]
HFP: Send caller ID in +CLIP command (3/4)

* Append caller display name in ag_reslut data if there is name in
  CALL_STATE_INCOMING state
* Process all clip data and store the formatted string to ag_result
  data

Bug: 111378831
Test: runtest bluetooth, runtest -x BluetoothPhoneServiceTest.java
Change-Id: Ief48ed9cb5e0b32274624a90799ab9922dbd656e

5 years agoMerge "HFP: Don't use mSBC for HF devices not supporting related feature"
Treehugger Robot [Thu, 8 Nov 2018 08:43:27 +0000 (08:43 +0000)]
Merge "HFP: Don't use mSBC for HF devices not supporting related feature"

5 years agoFix Spurious Hearing Aid Start and Stop Cmds
Stanley Tng [Wed, 7 Nov 2018 23:47:05 +0000 (15:47 -0800)]
Fix Spurious Hearing Aid Start and Stop Cmds
am: ff3ed00c79

Change-Id: I14199a18d6d89385c23188e265703f5dc4d12189

5 years agoFix Spurious Hearing Aid Start and Stop Cmds
Stanley Tng [Sun, 14 Oct 2018 04:17:00 +0000 (21:17 -0700)]
Fix Spurious Hearing Aid Start and Stop Cmds

Prevent the spurious Start and Stop Commands that are send to the
Hearing Aids when there is audio suspend and resume, and also connection
and disconnections.
Also, make sure that the callback for the Audio Suspend and Resume are
done in the main thread; previously, it was running in the wrong socket
thread.
Lastly, make sure that the Connection Update callback are processed
correctly; previously, we are not checking that the right connection
interval are set and taking the callbacks done by service discovery.

Test: Manual testing with Hearing Aids
Bug: 117619792
Change-Id: I33a175947b0118f0234ec6338c20ac6e7963a598
Merged-In: I33a175947b0118f0234ec6338c20ac6e7963a598
(cherry picked from commit cac96c646fac463a9c894ad702bd4428863c9400)

5 years agoAdd code coverage report support to Bluetooth
Ajay Panicker [Thu, 20 Sep 2018 21:39:00 +0000 (14:39 -0700)]
Add code coverage report support to Bluetooth

Allow the generation of code coverage reports for any code that has
native tests.

In order to add coverage support to code do the following steps.

1. Add "clang_file_coverage" as a default to the source library(s) you
   want statistics for.
2. Add "clang_coverage_bin" as a default to the host supported test.
3. Add the test name and the files you want covered to "gen_coverage.py"
    - The files covered can either be a directory or files.
    - Avoid using / at the beginning of a covered file/dir as this
      breaks how the coverage generator resolves filenames.

Bug: 114751344
Test: run ./gen_coverage.py and test arguments manually
Change-Id: I9dd04f6ee2fd642531e301e3bfd52713f862cd4b

5 years agoCleanup LE White List HCI interface
Jakub Pawlowski [Fri, 2 Nov 2018 13:16:26 +0000 (06:16 -0700)]
Cleanup LE White List HCI interface
am: 553e88bd1f

Change-Id: I08c7e027598302105e585971de127aed5ee6bd86

5 years agoCleanup LE White List HCI interface
Jakub Pawlowski [Tue, 30 Oct 2018 21:49:30 +0000 (22:49 +0100)]
Cleanup LE White List HCI interface

Replace global functions with callbacks, to reduce interface size.

Test: add/remove at least two devices in whitelist, verify HCI snoop log
Bug: 112827989
Change-Id: Id05c9f4970bbb795309a3a233f83559bcc1c56e2

5 years agoMerge "HFP: support pause character "Comma" in acceptable dial digit string"
jonerlin [Thu, 1 Nov 2018 06:21:56 +0000 (23:21 -0700)]
Merge "HFP: support pause character "Comma" in acceptable dial digit string"
am: 33c4b665b2

Change-Id: I28a7fe3aff8da888aa26b89047babd7d6047ec35

5 years agoMerge "HFP: support pause character "Comma" in acceptable dial digit string"
Treehugger Robot [Thu, 1 Nov 2018 06:07:45 +0000 (06:07 +0000)]
Merge "HFP: support pause character "Comma" in acceptable dial digit string"

5 years agoHCI: accept OnceCallback instad of Callback
Jakub Pawlowski [Wed, 31 Oct 2018 00:05:29 +0000 (17:05 -0700)]
HCI: accept OnceCallback instad of Callback
am: c74471dcac

Change-Id: Ic0d01c5864fe714d89887bdb9e9efd5700ec80bb

5 years agoHFP: Don't use mSBC for HF devices not supporting related feature
weichinweng [Wed, 17 Oct 2018 07:28:56 +0000 (15:28 +0800)]
HFP: Don't use mSBC for HF devices not supporting related feature

* Some misbehaving HF devices indicate their support some mSBC related
feature but some feature is not support. It will cause some unexpected
behavior.
* This CL adds a workround for checking if HF device indicate which one
is not support on Transparent Synchronous Data, WBS and Codec
Negotiation, Fluoride will assume CVSD codec by default.

Bug: 116082185
Test: make, connect SCO and check voice on carkit and headset.
Change-Id: Ic2209e514999958061bc7db7ab18d6e5b3976758